- 11 Dec, 2020 40 commits
-
-
arthursonzogni authored
This patch makes two attributes of DidCommitNavigationParams: - sandbox_flags - origin to be simulated more correctly. Both arguments are meant to disapear soon and be replaced by the ones computed from the browser process. In the meantime, we only check what the browser and the renderer computed match, as close as possible. This patch is required for: https://chromium-review.googlesource.com/c/chromium/src/+/2579743/ Otherwise, the NavigationSimulator won't simulate them correctly and there will be a mismatch. Bug: 1041376 Change-Id: I87ee6ac583b1e8212a2e566934bf94f4e3b72a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584873Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#836096}
-
Christian Dullweber authored
The current approach of getting a FragmentManager for PageInfo does not work with WebLayer. Instead we use PageInfoControllerDelegate obtain a FragmentManager from Chrome and WebLayer. Contains BrowserFragmentImpl changes from https://crrev.com/c/2575753. Bug: 1077766 Change-Id: I0f8d3ecfaaed68e99140e39836cbc1539ef8225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577206Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#836095}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607666365-bbaa45b634e1691b87709d169151bc6605a0f202.profdata to chrome-linux-master-1607687924-a60f129d913249bc70405ac39567e1c7a8e8f34e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I52ac75bbba94db5d3831d02c24368c069d75ca79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836094}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59248a61..4abdaef9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38f6c4276cedda70274e7874a899b26e253c5bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836093}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c75473c2cf88..a77bc1f1e690 2020-12-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d94a77b304f4 to 0a64a9747555 (3 revisions) 2020-12-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2db43e77 to 0c234289 (451 revisions) 2020-12-11 syoussefi@chromium.org Add a scissored MSRTT test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I0095535ec623ec07e4f1a2ecbd1a3cab4162740d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586897Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, the touch targets of the autofill card and address editor text fields were 45dp tall, which is smaller than necessary for accessibility. This patch adds a minimum height of 48dp to the text fields in the card and address editors, while the bottom margin is reduced from 8dp to 5dp to compensate for the 3dp increase in text field height. After this patch, the touch targets of the autofill card and address editor text fields are at least 48dp tall. Bug: 977272 Change-Id: If356cb5cf64f7b912fbdb924dfc35ecef84eef48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580147Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836091}
-
arthursonzogni authored
(Final attempt) This has been enabled/disabled many times. I recently found the reason blink was reporting a different sandbox than the one computed by the browser process. It was caused by the 'reuse' of the LocalDomWindow for some same-origin navigation from the initial empty document. Blink was applying sandbox twice by mistake. Test: https://chromium-review.googlesource.com/c/chromium/src/+/2578957 Fix: https://chromium-review.googlesource.com/c/chromium/src/+/2578902 Bug: 1041376 Change-Id: I5ec5339031cf9e744ca1f5bd739783b4cf53bc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584872Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#836090}
-
Wolfgang Beyer authored
This CL allows DevTools to look up the COEP status of service workers. Bug: 1122507 Change-Id: I7e1c84d874139479f86d0defd91363edf7d3b10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575023Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836089}
-
Ramin Halavati authored
This change has no effect until EnableEphemeralGuestProfilesOnDesktop flag is enabled. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I23caee7e825153faf7b6e3f8d11ce3f8b3640898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469566 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#836088}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607622801-7eee2da7088824da6e68b5fe6587fe40e650ba9e.profdata to chrome-win32-master-1607655596-75336cc70b08765a793f0c1f5daab74c560f984f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1db66b13a0424e6469bc8d7efe11aaa0827badae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586749Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a9d7eaa74ad..f2d81b7d4073 2020-12-11 lalitm@google.com perfetto_cmd: use new atoms for logging triggers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174150911 Tbr: perfetto-bugs@google.com Change-Id: Id0ae87fa90df1f879116308f1700225702c40677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586901Reviewed-by:
-
Nohemi Fernandez authored
Bug: 1157475 Change-Id: Ifa0d6e112be23a489e2a5cc73b483e52308396d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584028Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#836085}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2a9af6f630f..388379be2125 2020-12-11 alexrudenko@chromium.org Fix device name overflow in Devices list 2020-12-11 alcastano@google.com [Frontend] Show Issue next to corresponding line in Source Tab 2020-12-11 jacktfranklin@chromium.org Migrate string-utilities.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1150883 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c8a409b109b376015dabb5d0a8d3716f09c64ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586953Reviewed-by:
-
Yifan Luo authored
Add warnings for empty/invalid require-trusted-types-for keywords in CSP parser. Bug: 1149293 Change-Id: I97d2daddba8ebad7eb34ffcbe8467e1e7d7bb9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575305 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#836083}
-
Jakub Chyłkowski authored
Currently, the TraceConfig JSON object passed to the DevTools method to start tracing only supports configuration of the Chrome-internal trace event data source. This commit provides additional parameters in DevTools: - base64-encoded serialized protobuf message which takes precedence over other parameters, - backend selection. In order to handle new parameters, convert base::trace_event::TraceConfig to perfetto::TraceConfig before passing it and add support for the new perfettoConfig protocol param. Add test to handle Command to run new test: out/Default/content_browsertests --gtest_filter=DevToolsProtocolTest.TracingWithPerfettoConfig Bug: chromium:1141381, chromium:1141386 Change-Id: I35e436487b2526bb3bf17bac34b9741712fb5319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560581 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#836082}
-
Michael Ershov authored
Extract CertDbInitializer interface from the implementation to allow writing a mock for it. This is a refactoring with no intentional change to behavior. Bug: 1145946 Change-Id: If08abcdcd1257d574137d2d5d1264dc389e868f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581925 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2300e5aba7c..49ce67ac98da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com Change-Id: I2872b49d2665000070bdb3051d89001ae21b4c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586055Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836080}
-
David Roger authored
The logic to check whether an account is managed was duplicated many times in the code. This CL factors it in a helper function. This should be a pure refactoring, and should not change the behavior. Fixed: 1122496 Change-Id: I32e09af11ecc1169b2d704a5c4552e7f17f8ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570569Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#836079}
-
Gyuyoung Kim authored
This CL replaces the use of IsolatedWorldId::kEmbedderWorldIdLimit in //content via IsExceedEmbedderWorldIdLimit() to move IsolatedWorldId enum into blink/renderer. IsolatedWorldId enum is moved to DOMWrapperWorld class. Bug: 919392 Change-Id: I62b499c64e6c268705fb3bb0ea6c704c30a5ea1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585255Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#836078}
-
Sreeja Kamishetty authored
Following tests are consistently failing on linux chromeos-dbg LoginOfflineManagedTest.CorrectDomainCompletion LoginOfflineManagedTest.FullEmailDontMatchProvided LoginOfflineTest.AuthOffline More details build: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/21702/overview Suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/2450314 TBR=dkuzmin@google.com,antrim@chromium.org Bug: 1157777 Change-Id: I4586346e689b1281eb77b178b19a5f68151c878a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586840Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836077}
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I8837750441a5c451c9107137d78fd0e04b8ad8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581169 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836076}
-
Bence Béky authored
migrateNetworkPredictionPreferences has been part of PrivacyPreferencesManager ever since it was upstreamed on 2015-02-19 at https://codereview.chromium.org/935903002. This removal only affects users who had set this particular preference to non-default before 2015 and have not launched their Chrome since than. Remove now unused PRIVACY_NETWORK_PREDICTIONS. Bug: 526773 Change-Id: Iba72578c9e7bd77e95433098b29d727166326d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568665Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836075}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607644656-7adc1a9108854fa8e662531b0c0fa8127d30765c.profdata to chrome-win64-master-1607666365-c1cc1d25065c901589c113e3c731cdd417d0631b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6cb507da755c5f01279d7a6f0b889885182fce6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586874Reviewed-by:
-
Robbie Gibson authored
CRWWebViewScrollViewProxy initializes itself with a base UIScrollView so any properties set on it before a real web view scroll view is set are used (see the comment in CRWWebViewScrollViewProxy -init). Then, when another scroll view is added to the proxy, all properties are copied over from the stored scroll view to the newly added one. However, there are a few properties for which a WKWebView.scrollView (WKScrollView, a private class) and UIScrollView have different defaults. This means that the property copying phase overwrites the WKWebView.scrollView defaults with the UIScrollView defaults. A better solution might be to track which properties are set, and only copy over those properties in the copying phase, but that would be a much more involved solution. Bug: 1156224 Change-Id: Ie0ad8bad0439caf3fdb4ec37d03369c43d0a7100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580533Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#836073}
-
Wez authored
Migrate console logging from content hosted by a FrameImpl to use per-Frame fx_loggers, rather than the //base LOG() macros. Log messages are tagged with the |debug_name| specified when the Frame was created, if any. Implement a SetConsoleLogSink() API to allow callers to redirect logging on a per-Frame basis. Bug: 1088094, 1051533, 1139396 Change-Id: I7c4d6b55fa34ba6e8a343d5830c91594eedcca7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517534 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836072}
-
Rune Lillesveen authored
The spec says the behavior is currently undefined and implementations should not apply the property to generated content. It is still part of the computed styles, so add a test for that as well. Bug: 397265 Change-Id: I5391c54c2e3035c90cb5b8db38aa55a77c5ef0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584970Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#836071}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I7b45782b6f9fed91c68cf3e989be026cadfd9d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586344 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836070}
-
Thomas Tellier authored
Bug: 1003885 Change-Id: I5753343b5e52f26679f54077b09877474b54330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573436 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#836069}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/721ef456ee27..d2a9af6f630f 2020-12-11 wolfi@chromium.org Fix wide dropdown in DeviceModeToolbar 2020-12-11 jacktfranklin@chromium.org Migrate utilities to TypeScript files 2020-12-11 petermarshall@chromium.org [application] Avoid jumpy UI when clearing IndexedDB list 2020-12-11 changhaohan@chromium.org Remove auto-focus in Computed pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0bdb96ce6a50982839ca60e233131d6dc4d43c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586894Reviewed-by:
-
Alice Wang authored
This CL moves PersonalizedSigninPromoView to signin.ui target. Bug: 1156619 Change-Id: Ic0c0a1e23c05b88bb36f4daee3eba469c7fcb63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584505 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd549ceda1d4..d2300e5aba7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com Change-Id: I7b9c5f7496be447a7b9e9c23b10380bf11d822c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586054Reviewed-by:
-
David Dorwin authored
Although fuchsia.logger.LogSink is provided when using run-test-component, it still needs to be in the sandbox. Also make indentation consistent. Bug: 1132147 Test: The following no longer appears in the system log when running run_cast_runner_integration_tests with and without --use-run-test-component: `app#sys#fuchsia-pkg://fuchsia.com/cast_runner_integration_tests#meta/cast_runner_integration_tests.cmx` is not allowed to connect to `fuchsia.logger.LogSink` because this service is not present in the component's sandbox. Change-Id: I67d4205156f1a0bc7eb847159ea417ec776a7832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586098 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Leo Lai authored
we are obsoleting the unnecessary `TpmIsBeingOwned()`. BUG=b:172775884 BUG=b:172748724 TEST=build ok. Change-Id: Ie1dc4044060caadb24a9470dbb98d51bcfc383e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532157 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Benoit Lize authored
The provided task runner was always bound to the same thread on which the manager is created. Make this explicit rather than implicit. Bug: 1131857 Change-Id: I1e24d20edf9cd77c2ce904d13e2e66ef559cc183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527045 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836063}
-
Victor Hugo Vianna Silva authored
1) Before this CL, some ModelTypeControllers called IsWebSignout() in their GetPreconditionState() implementation to make sure the data type was stopped upon web sign-out. This is no longer needed following the StopSyncInPausedState launch (crbug.com/906995), so this CL removes such checks. If GetPreconditionState() makes no other checks, the controller also no longer needs to observe the SyncService. Note this isn't true for controllers that check for persistent auth errors, since that concept is more general than web sign-out. For those, only TODOs/includes are removed. 2) The CL also addresses one IsWebSignout() TODO in PersonalDataManager. Contrary to what the TODO implies, just removing the call isn't enough. IsSyncFeatureEnabled() returns true in the sync-paused state, so the check for TransportState::PAUSED must be moved up. 3) Finally, the CL updates the last TODO pointing to crbug.com/906995 to point to a newly filed bug. This concludes the post-launch cleanup for StopSyncInPausedState. Bug: 1140447 Change-Id: I996a8871050f8f18e1509a5560ca0ccfc849f217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505772Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
-
sandromaggi authored
Before this change, an empty value was causing a failure state only if no other values existed. The empty value was skipped for filling and later on (maybe) failed in the empty-check. If the field was filled by outside forces (e.g. cached by website) the skipped value would not cause a failure state. This behaviour was causing inconsistent results. After this change, an empty value will always cause a failure state immediately and not attempt the filling. Bug: b/175270472 Change-Id: I939e2069e237d960ebf3a826a799e5ab23ecc4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582323Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#836061}
-
Joel Hockey authored
Adds window properties for * kEscHoldToExitFullscreen - if true holding esc for 2s will exit fullscreen. * kEscHoldExitFullscreenToMinimized - if true window is minimized when it exits from fullscreen rather than being restored to normal. AppServiceAppWindowLauncherController sets these properties on: * Borealis to use esc, and minimize on exit * PluginVM to use esc, and restore on exit Bug: 1144780 Change-Id: Ibcbbb811f99b5650df6b16e0de85b2b5129a4a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581626Reviewed-by:
-
David Grogan authored
Updated TestExpectations in place and organized the flex section a bit. 7 tests weren't moved because I already ported those to check-layout versions in css/css-flexbox and they hadn't been deleted from vendor-imports yet. Removed two tests from css3/flexbox/mozilla because they were in the move. One test is still in that directory because it wasn't in vendor-imports. Change-Id: I15e815ea15e30eee4568c65aa92dd364c17a5e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585929 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#836059}
-
Michael Ershov authored
Some initialization steps may block (and trigger a crashing check). Move it to a worker thread to unload the UI thread and fix the crashing. Waiting for the initialization to finish will be implemented in the next CL. Bug: 1145946 Change-Id: I03ca8aee5e0ab3870670506828b821a7a69bddff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574938Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Carlos IL authored
Enable AutofillPreventMixedFormsFilling and InsecureFormSubmissionInterstitial in preparation for 100% launch. Bug: 1105210 Change-Id: Id6d4325ee8d0fb27f109b45d3654c56e5d653688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583141 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#836057}
-
