- 21 Aug, 2020 40 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3d23ea2b66d4b72c67e0846d350a681adb978e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367494Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800471}
-
Jiewei Qian authored
This CL adds a chrome feature AlwaysReinstallSystemWebApps. If enabled, it will always reinstall system apps instead of only doing so after a version upgrade or a locale change. This is useful for testing. Bug: 1095524 Change-Id: I0e806f5dd0e8c10d8d971b0db2004940ec9b86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366334 Commit-Queue: Jiewei Qian <qjw@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#800470}
-
Maksim Sisov authored
After https://chromium-review.googlesource.com/c/angle/angle/+/2210151 it's required to pass platform type for X11 so that correct backend is chosen so that X11/Linux doesn't become broken when compiled with use_x11 && use_ozone. Bug: 789065 Change-Id: Ia2e11a89fc358c9976d216f6729c49a28d4661aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366755Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800469}
-
Wei-Yin Chen (陳威尹) authored
TBR=adithyas@chromium.org Bug: 1120213 Change-Id: I97e4a5c755488cdc797e1a491c3c367c1edefae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368543Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800468}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If30c793062ea360ddc9fe5449b0cd1fe94ceb984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800467}
-
Kenichi Ishibashi authored
Similar to crrev.com/c/2352268, accessing browser context in weblayer seems to initialize BackgroundFetchContext, which depends on ServiceWorkerStorage::GetUserDataForAllRegistrationsByKeyPrefix(). Tests should wait for the completion of GetUserDataForAllRegistrationsByKeyPrefix() to avoid hitting DCHECK() in mojo generated bindings. Bug: 1115172 Change-Id: I5836e962cd35f07ab46e20b64352f8ef8eb9f353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368652Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800466}
-
Mei Liang authored
This CL makes the taller GTS group card contain mini thumbnails with the same aspect ratio as the big thumbnail. Bug: 1116475 Change-Id: I3d92e30259a17b4f7125ff14fcf317f683557709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359395 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now the feature is launched in the stable channel, and this experiment is not needed any more. The feature should be enabled by default. Bug: 1096677 Change-Id: I8dad4f56fdc8bbd85c4dd9f3a819d88d5a9f114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355154 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800464}
-
Stephen Sigwart authored
For time picker, and for date&time picker, the initial focus when opening a picker is always at the 'Hour' column cell. When opening the picker from 'Minute' or 'AM/PM' from the input box, the intent is likely to change the originated column value, and the expectation is likely to see the focus on the originated column value as well. The user might immediately start arrowing up or down to change the intended value, e.g. Minute, but the outcome is the Hour being changed. Matching the focused column cell seems more expected (vs. always focusing the 'Hour' column cell). Bug: 1053797 Change-Id: I0ca7467d40cfe46d3750e649e58c3924c3693660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358479 Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#800463}
-
Jit Yao Yap authored
This CL adds a network traffic annotation for the network request to download the app's icon. Bug: 1101208 Change-Id: I4a4e4236d0fc74fb36228626408927fbccd3b48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362820Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#800462}
-
Hirokazu Honda authored
Bug: 1045825 Test: None Change-Id: I97faf171a0636ea45d69a0fe638c888b34ecf9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361902Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800461}
-
Wei-Yin Chen (陳威尹) authored
TBR=dmazzoni@chromium.org Bug: 1120210 Change-Id: Ia4a1e44945adbcb64eae3247403734af0be115c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368752Reviewed-by:
-
Donn Denman authored
Adds a new In Product Help bubble that suggests that the user should enable access to page content in order to improve translations. This includes handling of the IPH, but not any triggering of the IPH or noting that the expected user response event has occurred. Following instructions here: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/translation_screenshots.md BUG=1120080 Change-Id: Ib929b40d9b0954bfba5ed80ba02d3913ec30f1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368472 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800459}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b583133590a5..13a12ff3de9a 2020-08-21 chrche@microsoft.com Fix background services recording button tooltip not updating If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1117410 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3b0f1a1a18fc40837d11bceb5edb88c4beef74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368101Reviewed-by:
-
Thomas Lukaszewicz authored
This CL restores the default close on deactivate behavior of the BubbleDialogDelegateView. This was enabled on extensions as a way for allowing a devtools window to gain activation whilst the bubble is showing and is not necessary for the Tab Search UI. Additionally, the Tab Search's bubble widget won't receive activation until after it has been shown. This means that the intended behavior of not dismissing the bubble until it has been shown will remain. Bug: 1099917 Change-Id: I2b154d7240ab02eca1d965df6d4b7d0b7134aa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363002Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#800457}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6bb943fc2f8..12ffc2536244 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com,xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106954,chromium:1118191 Tbr: mxcai@google.com,xialinyan@google.com Change-Id: Id52b92434bac210da552c8bb2063a5347704655a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800456}
-
David Stevens authored
An exo surface's damage is first scaled up by device_scale_factor when added to its render pass, and then eventually scaled down by 1/device_scale_factor when surfaces are aggregated. Due to rounding, these don't necessarily cancel out. However, if device_scale_factor < 1, then exo can report the enclosed rect of the scaled damage. Since 1/device_scale_factor < 1, the rescaled RectF at aggregation is <1px smaller than the original damage rect, which means the enclosing rect will be equal to the original damage. Bug: 1082082 Change-Id: If151fb5161b145990a685283e97b11bdbc6e1412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324691 Commit-Queue: David Stevens <stevensd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#800455}
-
Wei-Yin Chen (陳威尹) authored
TBR=bsazonov@chromium.org Bug: 1119548 Change-Id: I42e3b5f50644cc09d26f0281811442dc993d46b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368143Reviewed-by:
-
Yuly Novikov authored
conformance/textures/image_bitmap_from_video/tex-2d-alpha-alpha-unsigned_byte.html conformance/textures/misc/tex-video-using-tex-unit-non-zero.html conformance/textures/misc/texture-upload-size.html conformance/textures/video/tex-2d-alpha-alpha-unsigned_byte.html Started failing when HW video decoder was enabled in https://chromium-review.googlesource.com/c/chromium/src/+/2364962 TBR=bsheedy Bug: 1119939 Change-Id: Ib7519f318653a7623486907a72a1c574d1a71be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368421Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#800453}
-
Matthias Körber authored
Change-Id: I90f75fd591537eeb1c6b23892a4703289af2872f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367612Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#800452}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit bce04023. Reason for revert: crbug.com/1120212 Original change's description: > [COOP] reporting: reenable OriginTrial tests. > > Reenable two test: > -CoopReportingOriginTrialBrowserTest.AccessReportingWithToken > -CoopReportingOriginTrialBrowserTest.CoopStateWithToken > > They were disabled by: > https://chromium-review.googlesource.com/c/chromium/src/+/2365362 > > We think this might be fixed by: > https://chromium-review.googlesource.com/c/chromium/src/+/2366778 > > Feel free to immediately revert this patch if the two tests start to > fail. We will also monitor them today. > > Bug: 1119555 > Change-Id: Ibd6fc4af82fcc4cbd3dcf5fe2b1472d81cb9c8cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366894 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800081} TBR=clamy@chromium.org,arthursonzogni@chromium.org Change-Id: I6b733083ad41e0f1b99c39435c17c558987271bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119555, 1120212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368078Reviewed-by:
-
Elliott Sprehn authored
In the case that EntityMask is 0 we don't even need to iterate the characters and can just call Append(const StringView&) which will share the underlying StringImpl if the builder is empty. This optimizes the case where someone does something like: <script id=json type=json>{huge blob of text}</script> and then JSON.parse(document.getElementById('json').innerHTML) which would previously iterate the string doing nothing and then make a copy. While technically using .textContent would be the fast path devs don't seem to often do that. For example see this twitter thread: https://twitter.com/ElliottZ/status/1171817105336832000?s=20 and also many other places like SO posts: https://stackoverflow.com/questions/7581133/how-can-i-read-a-json-in-the-script-tag-from-javascript/7956249#7956249 as well as inside Airbnb's codebase (which I fixed to .textContent). I went further and optimized the case where we have a non-empty EntityMask, but don't replace anything. For example if you have a large paragraph of text and do getElementById('p').innerHTML in many cases there's nothing to replace. We can't avoid the O(n) scan of the string in that case, but we can at least avoid the copy. Change-Id: I4270b7d8f693fe8dcf8f95271f33202a209ea298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366612Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Elliott Sprehn <esprehn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800450}
-
Hirokazu Honda authored
Bug: 1045825 Test: Build video_encode_accelerator_perf_tests Change-Id: I55c9af739236ee154a04ebc9f858be28c00e37ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368653Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800449}
-
jongdeok.kim authored
In this CL, create a transform node instead of setting Layer::SetHasWillChangeTransformHint(). By doing so, each node can see if it's parents have will-change:transform compositing reason. Bug: 1114504 Change-Id: Ia5e9fe82126dc343e0cffbdbccff3b2d4cf4fcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355660 Commit-Queue: jongdeok.kim <jongdeok.kim@navercorp.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800448}
-
Maggie Cai authored
In the case of getting apps from app service, there is no need to defer the navigation. Update the code to move the icon loading code out of defer navigation and never defer navigation. BUG=853604 Change-Id: Idbc0dba4eb18eea16dfe907be7849877f0879395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367232Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800447}
-
Juliet Levesque authored
Add style to make dictionaries passed as NS_LOGS more readable on the debug page. Bug: 1093634 Change-Id: Iae95b101a1ad00af5e0267d1aa444f33fe670a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368496Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#800446}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77419b0f04e8..9869f187b5ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iba63033667499609e903edeb5947a6e983664212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368247Reviewed-by:
-
Ilya Sherman authored
This provider is preventing the AsyncInit task from ever completing, which is causing a major drop-off in Chrome OS metrics. Bug: b:165076656 Change-Id: I4d8a700b3b11a6cb9db4fddeebc75e5484a0d137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368142 Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#800444}
-
Lindsay Pasricha authored
now that we'rve rolled main this is redundant. Change-Id: I11c10b7cd646d1c1405846584b5182fcc3514886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368012Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#800443}
-
Harry Cutts authored
This is part of the work described in go/cros-wheel-tick-counts, fixing code which assumes linear scrolling from wheels. Later CLs in the series will populate and use the field. On Mac, see the (very helpful) comment "Of Mice and Men" in web_input_event_builders_mac.mm for details on the axes used. Bug: 1077644 Test: run unit tests Change-Id: I74f060fb3acbc141f2d04b16068030e0e0e62ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336911 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#800442}
-
tby authored
Right now we record type metrics like this: - user action received by ash - ash sends result id to chrome - chrome re-associates id with a ChromeSearchResult object - we log the type associated with the ChromeSearchResult object However the re-association step is subject to a race condition related to whether the search result objects have been cleared from the cache. This CL changes the process to be: - user action received by ash - ash sends an AppListNotifier::Result object to chrome, containing id and type - chrome logs type directly. Note: the result id string in AppListNotifier::Result is now unused on the chrome side, but we're planning to use it for other impressions-related work soon. Bug: 1076270 Change-Id: I699f293139ac7b89cbcfe92aa9c5af017b033a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365572 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#800441}
-
Juliet Levesque authored
Fix the dom-repeat element typo in the Contact Tab and fixed the spacing between list elements, as seen here: https://screenshot.googleplex.com/eb1d918c-0c7a-4890-8086-8ef893ef27f4. Bug: 1093634 Change-Id: Ifc586dd982e28d3ee2853359cb8cfa8e220ceb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368332Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c41b4fb5. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Id2aa467bea6308cec82a7da998e57d16826bcdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367518Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800439}
-
Rachel Carpenter authored
At the moment it navigates to a support.google.com link in a tab. This doesn't work offline, so utilising the help app which caches this article instead. Bug: b/157935237 Change-Id: Ibb5098b032bc959a826d52b1d05ebd7d14ab7cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362166 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#800438}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c060d8d65786..e689d3164f34 2020-08-20 jmadill@chromium.org Vulkan: Don't end RenderPass on DS feedback loops. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I47980b1185a1aa197903238d9de24d1e97586e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368275Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bedb605c8272..ea7fbfb9665b 2020-08-20 deadbeef@webrtc.org Implement network monitor for iOS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie315cf1d77b624d612a09d463d345f9cbf888d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368539Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This reverts commit a1325695. Reason for revert: Android ASAN bot compilation failure. crbug.com/1120202 Original change's description: > Reland "Add -noverify to build commands to improve runtime (local builds only)" > > This reverts commit 17e2a917. > > Reason for revert: Ensure buildtools.py is a no-op on bots. > > Original change's description: > > Revert "Add -noverify to build commands to improve runtime (local builds only)" > > > > This reverts commit 132e1deb. > > > > Reason for revert: Android ASAN bot compilation failures: https://ci.chromium.org/p/chromium/builders/ci/Android%20ASAN%20%28dbg%29/26489 > > > > Original change's description: > > > Add -noverify to build commands to improve runtime (local builds only) > > > > > > The flag is guarded by treat_warnings_as_errors=false so that it > > > will apply only to local developer builds. > > > > > > Results from //tools/android/build_speed/benchmark.py base_java_sig: > > > With change: > > > base_java_sig: 68.0s avg (68.8s, 67.2s) > > > base_java_sig: 68.4s avg (68.6s, 68.2s) > > > > > > Without change: > > > base_java_sig: 69.4s avg (69.3s, 69.5s) > > > base_java_sig: 69.7s avg (69.7s, 69.7s) > > > > > > time out/Debug/bin/run_base_junit_tests: > > > With Change: > > > real 0m22.741s > > > real 0m23.543s > > > > > > Without change: > > > real 0m23.176s > > > real 0m24.328s > > > > > > Bug: 1117222 > > > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299 > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#799285} > > > > TBR=wnwen@chromium.org,agrieve@chromium.org > > > > Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1117222 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493 > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799471} > > Bug: 1117222 > Change-Id: Ib43bfe72869def7da43b237360df0e155149a963 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363975 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800233} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I0d617bcfc7a311bfae743445fccaaab26364511e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368541Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ia9e729229f4f9943a068fcfcb014487f44d1ad6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367524Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800434}
-
Christopher Lam authored
This CL changes RulesRegistry::DeserializeAndAddRules() to bail out if the extension has been unloaded. This may have been the cause of some crashes where a ContentAction was being created for an unloaded extension. Bug: 1010336, 1115969 Change-Id: Ibbd01c1b5b0a8f4cc3c2668fbb4b804189ba0b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345939 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800433}
-
Maggie Cai authored
This reverts commit cb9cdc66. Reason for revert: This CL is likely the cause of build failure for Builder Linux Tests (dbg)(1) since https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91043. Revert to see if that fix the build Original change's description: > Give blink::CueTimeline a timer for precisely handling cue events > > Cue-related events (enter, exit, cuechange) are fired up to 250ms late, > and there is a similar latency in their display which is quite > noticeable. > > The underlying problem is that we only update cues alongside the > `timeupdate` event, which is fixed at 4 Hz. > > My solution is to add a separate timer to CueTimeline > (`CueTimeline::cue_event_timer_`) which is given a timeout for the > next cue event based on the current playback position and rate. This > allows for significantly more precise cue timing accuracy without a > significant performance penalty. > > Additionally, several web tests were written with the expectation that > the 'time marches on' algorithm is run before video playback begins > (ie, upon loading text track cues). This behavior is not in accordance > with the spec (as outlined in crbug/1050767), so this CL fixes those > expectations and adds a new test to prevent regressing. > > Bug: 576310, 1050767 > Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#800148} TBR=fs@opera.com,alancutter@chromium.org,mlamouri@chromium.org,cassew@google.com Change-Id: I0563b173344cef976c16b4f2851b45762a67843f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 576310 Bug: 1050767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368614Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800432}
-
