- 28 Aug, 2019 40 commits
-
-
Yasmin authored
Before: One device: Send to pixel 2XL Multiple device: Send to devices After: One device: https://screenshot.googleplex.com/h7ggmzB8TZz Multiple device: https://screenshot.googleplex.com/mduLZUSpqLb Bug: 996676 Change-Id: I775de0d561859b21f5b8ebf6721aa19fcea005c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768591Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691115}
-
Marc Treib authored
After crrev.com/c/1768775 it's unused, except for some tests. Some of these are updated to use GROUP_PASSWORD instead (the only remaining non-UI non-USS group, which will actually also be removed soon), and some, where that was not easily possible, are just removed. Bug: 853688 Change-Id: I361e27bfb85c22b781498ee4468b9f6dd57dbcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773138Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691114}
-
Jake Hughes authored
This is the first CL of an artefact investigating precise stack map support for garbage collection in Blink / V8 using experimental LLVM features. The bulk of this change is made up of two main components: - A parser for reading the .llvm_stackmap section (generated by LLVM) into a table for use by the GC. - A simple stack walking mechanism, which, once called, traverses the call stack bottom up frame by frame searching for a gc rootset in the root table. This also fleshes out a few helper API functions (see gc/gc_api.h) which can be used when calling into the gc library from user code. The idea for this gc/ directory is to be compiled as a library. It is then linked to user code which has be compiled with the relevent LLVM IR passes for generating stack maps at pre-defined safepoints. The code for which will be forthcoming in a separate CL. Bug: 978892 Change-Id: Ia2cb40881460b6a084babab9986df6c5303b41f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768770 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691113}
-
Rayan Kanso authored
TBR=timvolodine@chromium.org Bug: 998478 Change-Id: Ib7b24f28474773be6cfa6b0dc3e9f1c3a8497be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768343Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#691112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f0281d3e2a8..9a49709304f6 Created with: gclient setdep -r src-internal@9a49709304f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I176b35f629a978a81b544c46f092ad6920a02c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774050Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691111}
-
Marc Treib authored
Instead of a custom build step that mangled the sources for java compilation. In the past, the script mangled the protos to be compatible with the proto nano library, but this hasn't been necessary for a while (we've been using proto lite already). Now all it did was add two java_* options to the files. It's easier and harmless to just add these options into the files themselves. This was triggered by crrev.com/c/1773256 which wants to expose some of the sync protos to java (outside of tests). Bug: 998429 Change-Id: Ic4165d732b9a04d49938ce1fe06ca9d4bc735427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772165 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Oskar Sundbom authored
Tbr: pkasting@chromium.org Bug: 998403 Change-Id: Ie5de3f9336b6fcc5c5e49e21465f4a3a68402f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773141Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691109}
-
Rayan Kanso authored
All Android JNI calls to native will be routed via SharingServiceProxy which calls into SharingServiceProxyAndroid. SharingServiceProxyAndroid then either handles the request directly or forwards it to one of the sharing handlers. TBR=estevenson@chromium.org Bug: 996320, 997200 Change-Id: I0d30048938bf51439c19aa52b9d9e775dfc41fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768339 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691108}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a203388eab27..8e62744aa4a1 git log a203388eab27..8e62744aa4a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 primiano@google.com Move build flags to generated file, stop using cflags Created with: gclient setdep -r src/third_party/perfetto@8e62744aa4a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132678367 Change-Id: I138662254bc2ba815d838899b2450465ee9e579c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691107}
-
Jérôme Lebel authored
Adding a callback counter into FakeChromeIdentityService to be able to run the runloop until all callbacks are called. This helps to cleanup the SigninPromoViewMediatorTest to test image updates in the sign-in promo view. Therefore WarmStateConfigureSigninPromoViewWithImage is now useless. Related to: + crrev.com/c/1760793 + crrev.com/c/1718370 Change-Id: I6f625ba6715db207574a9bba3715edad2c2cfd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764151Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691106}
-
Andrei Chulkov authored
Change-Id: I6178d17add00beb32ac7067638c8119cb4ed236f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773216 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#691105}
-
Alex Chau authored
- Include fcm_token and encryption_info in all non-Ack SharingMessage, so we can send Ack without looking up sync preference. This allow Ack to be sent reliably and own't be affected by delay for above data propagating through sync - Store encryption_info in local preference, so we can embed it in SharingMessage without looking up GcmEncryptionProvider - Add method to fast lookup Device from SharingSyncPreference - Removed logic in SharingFCMSender that clean up GONE device, because this will race with device trying to registering at the same time, and results in device not in sync preference after registration. As we're migrating to DeviceInfo we won't be able to clean up other devices in the future as well. Bug: 988975 Change-Id: I2d0f7051fe1a31aa7a2db9e3494584b475aa7052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768702 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/886698bc3fdd..6f24d8a79388 git log 886698bc3fdd..6f24d8a79388 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src a3bc04b278ed..f27bd2aa2e3f (4 commits) Created with: gclient setdep -r src/third_party/angle@6f24d8a79388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I43f8f0a02ca610885cc827e2826c6827c9231e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774048Reviewed-by:
-
Peter Beverloo authored
The test relies on closing a notification to be faster than SW -> document communication, which until recently was true, but is not a guaranteed contract. Bug: 997824 Change-Id: I32141ed13acd85b7e74e9f14c5493b156c69870f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768341Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691102}
-
Tsuyoshi Horo authored
Bug: 998359 Change-Id: Id9c7290487bd8ae001c28a02a7a629c3727a30d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772210Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691101}
-
Oskar Sundbom authored
This reverts commit 887f778e. Reason for revert: Breaks MSan tests Original change's description: > Roll src/third_party/swiftshader a9da772f0587..04e148570dbb (8 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/a9da772f0587..04e148570dbb > > git log a9da772f0587..04e148570dbb --date=short --no-merges --format='%ad %ae %s' > 2019-08-28 capn@google.com Make round-robin task enqueue index thread safe > 2019-08-27 bclayton@google.com Device: Migrate Renderer to Yarn > 2019-08-27 bclayton@google.com Device: Don't use a global for the cluster count. > 2019-08-27 bclayton@google.com Some minor code tidying. > 2019-08-27 bclayton@google.com Pipeline: Use Yarn to make compute multi-threaded. > 2019-08-27 bclayton@google.com Vulkan: Build a yarn::Scheduler and pass it down to the vk::Queue. > 2019-08-27 bclayton@google.com vk::Queue: Lazily construct Renderers > 2019-08-27 bclayton@google.com Yarn: Don't zero-initialize data in Pool<T>::Item::construct() > > Created with: > gclient setdep -r src/third_party/swiftshader@04e148570dbb > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=swiftshader-team+autoroll@google.com > > Bug: chromium:b/139010488,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139142453,chromium:b/139010488,chromium:b/139142453 > Change-Id: Iceb60a95f44801f390732a1506641ace01c4e131 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774264 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#691066} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I58b3d9d5fb39b0db4e2fedac3a29ca1f1e5a3998 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:b/139010488, chromium:b/139142453, 998457 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773142Reviewed-by:
-
Yoshifumi Inoue authored
This patch markes following CSS properties layout dependent: - margin-block-start, margin-block-end - margin-inline-start, margin-inline-end - padding-block-start, padding-block-end - padding-inline-start, padding-inline-end for improving browser interoperatiblity. This patch is follow up of the CL[1] to fix following tests: - css/css-logical/parsing/margin-block-inline-computed.html - css/css-logical/parsing/padding-block-inline-computed.html [1] http://crrev.com/c/1760419 Import WPT tests Bug: 995612 Change-Id: If754cdcb7085ffa10cf965301f46f7aace33032d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774421Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691099}
-
Rune Lillesveen authored
No behavioral change. Change-Id: I054cd7f3743d0021f52241f2839297c0ae97bcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768340 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#691098}
-
Clemens Arbesser authored
This fixes a bug where the client would not correctly end a PR action for some invalid protos. Note: this is likely *not* b/140008909, but I can't yet confirm. This also fixes a bug where the client should fail the PR if a login choice was requested but no options are available (e.g., for websites which do not offer guest checkout). In practice, this is unlikely to happen, but the case should be handled regardless. Bug: 806868 Change-Id: I68174fa84e72fbfe209272cc62d6461970762fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771604 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691097}
-
Rouslan Solomakhin authored
https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/ecb3c4f4ce2c..681ca92480ec $ git log ecb3c4f4c..681ca9248 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 msmiljanic.gm Replace plain text Serbian dictionary with rule based dictionary. Created with: roll-dep src/third_party/hunspell_dictionaries R=gujen@chromium.org Bug: 997228 Change-Id: I2737accf1293ebcfa7b4903ce92ba5755835be60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769176 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691096}
-
Rayan Kanso authored
This reverts commit d0788ba8. Reason for revert: Breaking the build (crbug.com/998383) Bug: 998383 Original change's description: > Don't compile DownloadService in Android. > > Bug: 996380 > Change-Id: I57e49cad315fb038ef4b9dfb71293f49f64c749f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769728 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690903} TBR=bdea@chromium.org,drubery@chromium.org Change-Id: I441fa51291798df8d4243f197ecad0090c43638f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774279Reviewed-by:
-
David Jean authored
With 32 bits build gone, iOS can use the posix implementation of TimeExploded, which is faster. Bug: 985061 Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#691094}
-
Mike West authored
URLs like `https://whatever.com:0/` have an opaque origin, as they're rejected in the SchemeHostPort constructor (see [1] and [2]). This means that they fail the `IsOriginSecure()` check, and crash the renderer, which is a bit unfortunate, as they're going to fail to load regardless. This patch excludes URLs with opaque origins from the referrer check in order to avoid that crash. [1]: https://cs.chromium.org/chromium/src/url/scheme_host_port.h?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=83 [2]: https://cs.chromium.org/chromium/src/url/scheme_host_port.cc?rcl=90e84c7240870d52c224cb8c07b52545a2ef7cef&l=85 Bug: 960312 Change-Id: I39a41e3148554fda36e52d1f0c9934f52a2b8dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771906 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691093}
-
Dominik Röttsches authored
The promise resolution was already wrapped in calling it inside the right execution context, but the reject was not. Add the correct execution context and schedule rejecting the promise if font loading for a local() font fails when it is triggered by an implicit UA-triggered load. Spec reference: https://drafts.csswg.org/css-font-loading/#font-face-load in particular the last normative paragraph: "User agents can initiate font loads on their own, whenever they determine that a given font face is necessary to render something on the page. When this happens, they must act as if they had called the corresponding FontFace’s load() method described here." Thanks to Roel Nieskens (pixelambacht@) for the helpful bug report and reproduction test case. Bug: 996687 Change-Id: Icb5d75675b8a2e0b3f100808645a1e2e550cfcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771607 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691092}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7096a4a9fc5b..0f0281d3e2a8 Created with: gclient setdep -r src-internal@0f0281d3e2a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iba6155c369448cc52caf79f5fde91da4010e5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772455Reviewed-by:
-
Mohamed Amir Yosef authored
This patch adds logging for the dropped invalidations in Sync browser tests. This will help investigate some flaky tests. Invalidation are dropped if they are received before an FCMNetworkHandler is actually assigned and listening for FCM messages. Change-Id: I10409bfdda7b0616da6e45a6ecd5f00b3cd5bef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771904 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Jessica Tallon authored
A crash can sometimes happen when there the base and extent are equal and there are no valid nodes going rightward. This fixes it so in this situation it should have the selection on the same leftward node. Bug: 989162 Bug: 987702 Change-Id: I10a05125367f561ed5b4ba2b3d533907caf8b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760303Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#691089}
-
Keishi Hattori authored
ScheduledAction::Execute is only ever called by DOMTimer::Fired which is called as a task. So the stack is simple and we should be able to add AllowedStackScope and allow cooperative scheduling. Bug: 804661 Change-Id: Ida6d3605810469d0e95b6e72ded3f1aed05ad341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743236 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691088}
-
Mugdha Lakhani authored
Move the logic of calculating delay for the next background sync event to the chrome layer. This CL moves the logic to apply cross-registration limits for the same origin to BackgroundSyncController in the chrome layer. It also moves a unit test to this layer, and adds additional unit tests to BackgroundSyncController. Bug: 949499 Change-Id: I26bdd63d376c5b0821d62ccb7293833fbadaa444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751250 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Niels Möller authored
Intended to enable landing of https://webrtc-review.googlesource.com/c/src/+/53861 Bug: webrtc:8733 Change-Id: Ia0b946c51215fc7ce6f7f27541d1e788cda1a843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768587Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#691086}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 23bae0af. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8ef90c4180acc76fd2c8149a493c85682ab13985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774379Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691085}
-
Mike Reed authored
Update callsites. Change-Id: I2ebaf88c479c0a8c20953f77fae00cdb77835fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769212 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#691084}
-
Hirokazu Honda authored
This CL adds test cases for a conversion from Dmabuf frame to Dmabuf frame. The test cases are currently for ImageProcessor using VA-API, which will be introduced in crrev.com/c/1367389. The ImageProcessor only supports a conversion between Dmabuf frames. Bug: 898423, 917951 Test: image_processor_tests on atlas Change-Id: I69460be06c7c5a5cd5827b09f4a62d67e9148a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772926 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#691083}
-
Clemens Arbesser authored
There are still some parts of the code that are un-tested, particularly concerning additional actions and T&C links. Bug: b/140018932 Change-Id: Iea4a4f92dbb6f118c01e1fab1839721ebac76082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769447 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Ross McIlroy authored
It used to use runtimeStatsMetric but this seems broken, so move to runtimeStatsTotalMetric instead. Perf Sheriffs: This is expected to change all the metrics on v8.runtime_stats.top_25 due to the change in measurements. BUG=chromium:688342 Change-Id: I3e185fa9086e69151f4c5fa2db5fbf3d326d93fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771611Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#691081}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by reusing |ShapeResult| of before and after replaced range for improving performance, 10% to 15% faster but 3 times slower than legacy layout. (Profile data: http://bit.ly/33B9rfg) From this patch, |SetTextWithOffset()| does: 1. Get offset mapping to map DOM offsets to text content offsets for replaced range. 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted text. 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list in step 2. 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse |ShapeResult|. This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because new test case replaces this test and this test call |SetTextWithOffset()| with wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of |"before".replaceData(1, 4, "after")|. Bug: 707656 Change-Id: I078b19615d6f7e31362c1e6398aac88fb17b29c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729330 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#691080}
-
Andrei Polushin authored
The macro EXPECT_EQ_UNIQUE_ID() has been defined in a way that expects variables with exact names `expected' and `actual' defined in a dynamic scope, i.e. in the scope of C++ code that actually uses either EXPECT_EQ_UNIQUE_ID() or EXPECT_FORM_FIELD_DATA_EQUALS() macros. It seems the original intent was to use argument expressions passed to EXPECT_FORM_FIELD_DATA_EQUALS(), not necessarily bound to exact names. BUG=896689 Change-Id: I4f782afc1c8ab7c55b77ee111dcbbe64002a4d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757823 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#691079}
-
Juan Antonio Navarro Perez authored
Fix the code in results_processor that detects whether output options should be processed or not. Add a test in scripts_smoke_test to make sure the "run_benchmark list" command is kept working. And add more tests on the current behaviour for output option processing. These would have avoided crbug.com/997284. Bug: 996493 Change-Id: I1476a32eb3b48b7c1ebbaae60b47dba9b17ca23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771603 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691078}
-
chromium-autoroll authored
Not taking the new woff2 support right now, since Chromium already has woff2 support (which already depends on brotli) and Chromium needs to roll FreeType past this commit while evaluating what to do. https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9adc3b35f1a6..cbee985a2bc1 git log 9adc3b35f1a6..cbee985a2bc1 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 drott@chromium.org [woff2] Don't use `FT_UInt64' (#56815). 2019-08-27 wl@gnu.org [truetype] Prevent crash in `TT_Set_Named_Instance' (#56813). 2019-08-27 wl@gnu.org CHANGES: Updated. 2019-08-27 wl@gnu.org [woff2] Fix compiler warnings. 2019-08-27 wl@gnu.org [woff2] Formatting; some comments. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Check whether known tag is in array bounds. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] More formatting and documentation. 2019-08-27 ramakrishnan.nikhil@gmail.com * src/sfnt/sfwoff2.c: Improve trace comments. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Formatting. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Support `hmtx' reconstruction when `glyf' is untransformed. 2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Support `face->num_faces' for WOFF2 fonts. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Improve memory and error handling. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Avoid too many calls to `FT_REALLOC'. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Reconstruct `loca', `hmtx', and swap out stream. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Reconstruct transformed `glyf' table. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Copy un-transformed tables to sfnt stream. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Create stream for uncompressed buffer. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Handle TTCs and start reconstructing font. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Get known tags from function. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Minor. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Uncompress Brotli streams and `face_index' support. 2019-08-27 ramakrishnan.nikhil@gmail.com * builds/unix/configure.raw: Change argument name to `brotli'. 2019-08-27 ramakrishnan.nikhil@gmail.com Add Brotli dependency and required checks. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Write SFNT Offset table. 2019-08-27 ramakrishnan.nikhil@gmail.com * src/sfnt/sfwoff2.c: #undef macros. 2019-08-27 ramakrishnan.nikhil@gmail.com [woff2] Read table and collection directory. 2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Include `woff2tags.c' for building. 2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Add WOFF2 constants. 2019-08-27 ramakrishnan.nikhil@gmail.com [sfnt] Read WOFF 2 header. 2019-08-27 ramakrishnan.nikhil@gmail.com Add structures for WOFF2. Created with: gclient setdep -r src/third_party/freetype/src@cbee985a2bc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 998083 TBR=bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ia8406de15aeb9b5593c9e1f8ae579fe2baf8bf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773439 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Jessica Tallon authored
Bug: 978136 Change-Id: Id7026f3132f38398f1a0e9fc8cf2413a30095979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771402Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#691076}
-
