- 27 May, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590594916-1a49bd7be838713a54921f61c31eff74f9ded2d9.profdata to chrome-win32-master-1590609462-f9ab96859e162a96cc1f1ba3f4ac827a4c53be85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id2b5c07f685621b8f582dc5a271b5b1945e29b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9990e869..64cadfcf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68d94f74ecf752c051f3b3c6b6ab97d823ce1ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772427}
-
Mounir Lamouri authored
It's Android only. Trunk currently allows the user to expand into the cutout area. With this change, it will instead allow the user to reduce out of the cutout area. Bug: 1077400 Change-Id: I99c15f671c0b085dcaf770e594cd06e722192a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218453 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772426}
-
Dominic Mazzoni authored
This change introduces the first draft of a possible Chrome-specific COM API for accessibility that's async-only and could potentially lead to better performance and more easily allow Windows assistive technology to avoid injecting in-process. This new interface is behind a feature flag with no intention of launching as-is - if this proves to be successful we should either standardize this as part of an existing API like IAccessible2, or else create a new public spec for it. For now, the goal is to make something available for experimenting and building a proof-of-concept. Bug: 1083834 AX-Relnotes: None Change-Id: I32fb830217f55e1b1b214b1044362d9c2c42f5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206224Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772425}
-
Lukasz Anforowicz authored
Bug: 1015882 Change-Id: I4cd7d39808c4e2ac6df1d159fe91da8803f5209d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216598Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#772424}
-
Thomas Lukaszewicz authored
Currently FocusRing calls Install() on a view and returns an unique_ptr that is owned by the client and not the view to which it is added. This ends up with client classes holding a unique_ptr to the FocusRing without any need for independent ownership. This patch updates the view to own the FocusRing with classes holding non-owning pointers to the FocusRing if required. AX-Relnotes: n/a. Bug: 1044687 Change-Id: Ib3c8a0f47df20249a750dca476ab2f73a992b53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209402Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#772423}
-
Connie Wan authored
See attached bug and inline comments for details. The throbber is used to visually indicate that a background tab has been created, to ensure the user is aware of the activity. It is not meant to exactly represent the loading state of the background tabs. Bug: 1085560 Change-Id: Id51096620a487eb549fe1395f3199f59fe49a806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212812Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#772422}
-
Gabriel Charette authored
These will help confirm/eliminate whether these rare problems are at fault when diagnosing message pump hangs in Slow Reports. R=etienneb@chromium.org Bug: 1074019 Change-Id: I7432ec471a9b605f36feda392207e9f5d40edfea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216032 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772421}
-
Tommy Li authored
OmniboxPopupModel::TriggerSelectionAction will definitely crash in the no-default-match edge case, which can definitely happen with certain enterprise policies. Additionally, it's possible that UI callers will pass in an invalid |selection|, as they are an external class that could potentially be stale. In practice, it doesn't SEEM possible for this to occur with Views, but I'm not sure. Philosophically, I think crashing when the UI code gets out of date isn't a good thing, and this code should be a bit more tolerant. Bug: 1085407, 1078183, 1052522 Change-Id: Ibe5a2b09340679d3bfb86c234bc799f0823fdaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216605Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772420}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ad5d5733e00..369a09ac8618 2020-05-27 bsheedy@chromium.org Reland "[Telemetry] Add LocalFirstBinaryManager" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1054583 Tbr: rmhasan@google.com Change-Id: Ife5755f369855fce406ee4597c7a8340a9c63404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218737Reviewed-by:
-
David Black authored
Crash was caused by overlapping animate-out animations. Bug: b:157521638, b:151979172, b:145136105 Change-Id: I71787905346a29a3d238d172a5660e252d3c4f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216617 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#772418}
-
Leonard Grey authored
TBR=guidou@chromium.org Bug: 984879 Change-Id: I5d68c9e97a185075daabb8dbd6791163dd1ad127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218794Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772417}
-
Frank Liberato authored
Previously, DXVA decoding copied to RGB to avoid an Intel driver crash. This CL allows it to copy to NV12 instead, which permits overlays. This also enables an existing zero-copy workaround in D3D11VideoDecoder, to avoid array textures when decoding. Bug: 971952 Change-Id: I7bca63102cf886b29439c42660499fc9887d5b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217037Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#772416}
-
Elly Fong-Jones authored
This change adds setters for: * Accessible role & title on Widget * Initially focused view on Dialog At first glance these might appear unrelated, but in fact bubbles use the presence or absence of an initially focused view to decide what role they should have. Bug: 1011446, 1075649 Change-Id: I1ad2b8b333c46c9252cc8d5667a21d6b9b7a0d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218688 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772415}
-
Timothy Gu authored
Prior to this CL, Chrome on desktop Linux often inconsistently used contour fonts (e.g., DejaVu Sans and Noto Sans Symbols2) for some emojis, even when a dedicated emoji font (e.g., Noto Color Emoji) is available and used for all other emojis. In order to force the color emoji font to be used always, hacks [1] have been mentioned in online forums that prepend the color emoji font to the list of system fonts in fonts.conf, which can have highly deletorious effects on other applications (like normal numerals becoming their emoji versions). The ISO locale code "und-Zsye" [2] is one of the ways of informing fontconfig (as of version 2.12.5) that color emoji fonts should be preferred, along with the special font family "emoji" [3]. fontconfig also has default configurations that automatically map the locale and the "emoji" family to any available color emoji font. By explicitly setting the locale to "und-Zsye", this CL provides the desired out-of-the-box experience to desktop Linux users. While we could also specify the "emoji" font family either instead of or in addition to the locale, doing so requires more plumbing in the code and may be done in the future. [1]: https://github.com/googlefonts/noto-emoji/issues/36 [2]: https://unicode.org/reports/tr51/#Emoji_Script [3]: https://bugs.freedesktop.org/show_bug.cgi?id=94551 Bug: 767754 Change-Id: Ie8019cc0540a177c816c8131ca7c6a504952aa09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207627 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#772414}
-
Manas Verma authored
This CL maintains the reference to the C++ instance, and handles the null response case better. Bug: 949269 Change-Id: I3bb453286d8a1f8c8f087787235a664570e2c259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200045Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#772413}
-
Sam Sebree authored
This change adds new color values to support high contrast for scrollbars. Color values for scrollbars are now selected using GetControlColor() in order totake advantage of existing code paths for selecting unique colors based on dark mode or high contrast color schemes. Bug: 1081921 Change-Id: I141aacbe4830544594626cc777f0183394e8c3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207981Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772412}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/65dd291c8da7..0ee4ee85ddf2 2020-05-27 handellm@webrtc.org RtpSender: remove lock recursions. 2020-05-27 handellm@webrtc.org PacketBuffer: remove lock recursions. 2020-05-27 ivoc@webrtc.org Add UMA histogram for native audio buffer size in ms 2020-05-27 tommi@webrtc.org Remove locks and dependency on ProcessThread+Module from NackModule2. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9226f524010d5d8575770251de18dd7684153349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218734Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590594916-60e361b5828c3c2c59992f70098f83fe3dce39a9.profdata to chrome-mac-master-1590609462-0a980a885be44e446b55c280ee660f43e0ab11a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifd152d28bb5274f3f845449e8b41ef4ccaedff6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218953Reviewed-by:
-
Frank Liberato authored
This CL causes D3D11VideoDecoder to listen to the video decoder's config for whether it prefers one Texture2D with multiple array slices, or multiple Texture2Ds with one array slice eacy to hold decoded output. Previously, we would always do the former. Also, this CL adds a workaround to force multi-texture / one slice mode for some Intel drivers which require it. Bug: 971952 Change-Id: I4f12ead43aec2d35f463cc46d9a3bfc61500dc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191157Reviewed-by:
-
Erik Staab authored
TBR=sky@chromium.org Change-Id: I228a7ec684eafc907147a7e761fdb501a567e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218052Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772408}
-
Joe Mason authored
* boundaryForce now updates node velocities to pull them back across the boundary instead of teleporting them, which causes jitter as other forces continue to act after the teleport. * Rescale targetYPositionStrength to a max of 1 so that boundaryForce can match its strength without increasing oscillations. * Add a linkStrengthScalingFactor so that some link strengths can be rescaled along with targetYPositionStrength. * Add a 20-pixel border to the bottom edge of the graph so that the boundary force doesn't cram process nodes against the edge of the screen. Bug: 1086231 Change-Id: Idb4fe5acc05c4a8c0a7cfa7b5143c4f2d4f78f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215403 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772407}
-
Charlie Hu authored
Most image policies can report multiple violations for a single cause(same image not following the rule) during layout, e.g. An unoptimized-lossless-image's bpp(byte per pixel) value can change multiple times if the image is being scaled in an animation. To avoid unnecessary duplicated reports being generated. This CL adds Hash method for DocumentPolicyViolationReport to uniquely identify each report and avoid the duplication by remembering these hash values in LocalDOMWindow and filter out reports that are in record. Some existing web tests rely on the fact that multiple copies of same report generated in same document. This CL also worked around that to either help make reports generated unique or isolate test cases to different documents(iframes). Bug: 924684, 926199 Change-Id: I230e32801c77980573b5ed55064d46f94aed3060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078837 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#772406}
-
Sammie Quon authored
I forget why i put the extra check in the first place, I think did it in case the displays are stacked vertically and dragging i thought maybe dragging from the bottom to top display would trigger a maximize. But we pass the display as well, so that is not a problem. Removing the extra check allows for touch dragging on bezel. Test: manual Fixed: 1081985 Change-Id: I5a58eb7874b109f7403a9fe383f27e5bf9fa87e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218506Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#772405}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1443c9df589b..7135239769de 2020-05-27 johnstiles@google.com Line-wrap comments to fit the 100-character limit. 2020-05-27 michaelludwig@google.com Store float value for SkSL settings 2020-05-27 bungeman@google.com [infra] Add iOS 13.4 2020-05-27 johnstiles@google.com Remove misleading comments that implied big-endian support in Skia. 2020-05-27 ethannicholas@google.com Revert "Revert "SkSL function inlining"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ie902897b6560e2880235c7cc2daf4b1ad9ba1e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218855Reviewed-by:
-
Steven Bennetts authored
This allows users to view and toggle the Metered property for WiFi and Cellular networks. (See issue for more details). Bug: 971704 Change-Id: I6ad441b4781d65875d4d6a44184e9287a789f230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216854 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#772403}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=pmonette@chromium.org Bug: 1026641 Change-Id: I828d0534b9b7fb7c988994a07e3e762500e934b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215915 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#772402}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/800891e5ad60..9129f940933f 2020-05-27 caseq@chromium.org Allow extensions while inspecting NTP in OTR mode 2020-05-27 duongn@microsoft.com [wasmparser] Update to 0.16.1 2020-05-27 janscheffler@chromium.org Enable TypeScript in DOMModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066386,chromium:1079233,chromium:1085228 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I591f7f5448aa3e88b9ca6592e090d2645408677f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218573Reviewed-by:
-
Matt Wolenetz authored
Updates FrameProcessor to: 1. Understand if it is currently handling a codec for which nonkeyframes are supported (specifically, only AAC with xHE-AAC profile in this CL.) 2. Enforce parse failure if a supported audio nonkeyframe sequence does not increase in PTS monotonically (as a major simplification to related buffering logic, and coherent with the supported underlying codec's restriction on decode order matching presentation order.) 3. Disallows an audio nonkeyframe from becoming a possible audio preroll buffer in HandlePartialAppendWindowTrimming. Updates SourceBufferStream and SourceBufferRange to: * Trust the upstream FrameProcessor to enforce (1) and (2), above. In particular, SourceBufferRange::GetBuffersInRange() and SourceBufferStream::TrimSpliceOverlap() no longer require all audio frames to be keyframes. This simplifies tracking whether or not each buffered frame is allowed to be a nonkeyframe (e.g. if it's AAC:xHE-AAC), since changeType uses the same SourceBufferStream and SourceBufferRanges across the bytestream or codec type changes. * Trivially make TrimSpliceOverlap a no-op if the beginning of the new buffers is a nonkeyframe. Otherwise, it would be infeasible to determine if the new buffers are coherently decodable when fed to the decoder after a possibly end-overlapped, previously buffered, frame. Includes (and tests) a further simplification: if an audio keyframe is fully outside the append window and the next continuous frame processed is a nonkeyframe, that previous audio keyframe is not used as preroll; it's dropped instead, and a keyframe at least partially within the append window is required to continue buffering. If this is an oversimplification, later CLs can attempt to more precisely handle this case. TEST=Includes new FrameProcessorTests. Manually tested with a private stream on Android P+ that seeking in a mixed keyframe/nonkeyframe MP4 xHE-AAC stream no longer caused decoder to emit logs about silence. BUG=1079034,1081952 Change-Id: I41010079041a14dca90e23660350d4cf2469bf2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186205 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772400}
-
Ben Joyce authored
Bug: 1060721 Change-Id: I6fe5e9189fae6944859fbb3a99aa5c65c2d4f558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218753Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#772399}
-
Hongbo Song authored
2. Stop observing FSD when the local_root_ or the client of local_root_ is null. Once |LayerTreeView::Disconnect()| is called to shutdown the compositor, the delegate_ will be null. We should not observe FSD after that. Change-Id: Ia0d0e27f6d7db0d2c452b8951191424884f5585a Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218230 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
-
Samuel Huang authored
SuperSize requires GN flag generate_linker_map = true, but previously the flag is available only for Android or Linux. This CL makes the flag usable for ChromeOS builds as well, to enable SuperSize usage. Bug: 1084580 Change-Id: Ibfd13e7433a6b4cc6af43a8fddcb7510ea757e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218699 Commit-Queue: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
It's an eyesore that we're instantiating and describing this data on non-renderer process nodes. Bug: 1080647 Change-Id: I00ac8f6fc8732b66ffb42516c7d140113c7aa84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218556Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772396}
-
Xianzhu Wang authored
We already have the following logic which renders the original special handling of compositing of the root layer redundant: - We'll composite a LayoutView with the same rules as normal scrollers in PaintLayerScrollableArea::ComputeNeedsCompositedScrollingInternal(); - Any compositing in a frame will trigger compositing of the LayoutView and the PaintLayerCompositor. Change-Id: I15ad83095185defadb1c780a9444acfa1828bb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216858Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772395}
-
David Van Cleve authored
This CL adds metrics timing Trust Token operations, bucketed by operation type and success or failure. They record: - the duration of each Begin (outbound) operation part, and of each Finalize (inbound) part - the "server time" between the end of a Begin and the start of the corresponding Finalize; in order to bucket this by success or failure, it uses the success or failure of the subsequent Finalize part - the total duration of each operation (the time elapsed between the beginning of Begin and the end of Finalize), for operations that make it all the way to the end of Finalize R=csharrison Fixed: 1078541 Change-Id: I1e3541007616b971941aa7deef8a094f76ce3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216599Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772394}
-
Andrew Grieve authored
* Use "Short Name" as fallback for "Name" * Download files concurrently * Generate .info files concurrently * Increase thread count for CIPD * Improve logging around missing licenses (and adds a missing one) * Remove less-used (never-used?) flags * Make --update-all be the default * Always overwrite all files (crbug/1078529) * Don't clobber non-committed local modifications to BUILD.gn * Show gradle output (so it's clear things are happening) The script now runs in < 10 seconds (for a no-op) on my machine. Bug: 1078529 Change-Id: I4eefb7e1442d647854ffa6bbedbf371382fa3cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218561 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772393}
-
Sinan Sahin authored
There is a NullPointerException in OfflineIndicatorControllerV2 that seem to be caused by a posted ConnectivityDetector#performConnectivityCheck(). While we can't repro the crash, this CL adds a call to from the Handler. It also removes any posted runnables in OfflineIndicatorControllerV2#destroy() that may otherwise cause similar issues. Bug: 1085567 Change-Id: I548dbe4b0c54d382cd9e5684f5e252565f9fc337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216388 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#772392}
-
Mike Frysinger authored
The style guide says to put spaces after colons in JSDoc types: https://google.github.io/styleguide/jsguide.html#jsdoc-whitespace Bug: 469920 Change-Id: I579fd028bd5b55419ae82adcb9de633967a6f911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209535Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#772391}
-
Olivier Li authored
The new behavior (back-end dispatches to the ThreadPool) has been the default on stable since 81.0.4028.0. This CL includes some cleanup of base::Thread specific mechanisms now that a base::Thread is never explicitly instantiated. Bug: 661143 Change-Id: I65bf7af5682025dddf99ea431e2e02f2b525b8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201876 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772390}
-
Yuly Novikov authored
TBR=kbr Bug: 1060024 Change-Id: Ifaa67a559d54df54749d387b73a89f258dfa35e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218693Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772389}
-
