- 24 Nov, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change adds operator-> and operator* to base::StrongAlias. These dereference operators are customary for wrapper types like StrongAlias, allow for more convenience and allow passing StrongAlias to generic APIs like base::invoke. Bug: 954080 Change-Id: I2e2e8da600f20fa9947c615cb2e016a50160d8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553428Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830532}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6396316ea2ff5e778e2c247ee653b23bacd80f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830531}
-
Simon Zünd authored
This CL adds a new "TrustTokenOperationResult" mojo structure that is emitted in a new NetworkServiceClient event. The structure is used to convey the exact operation status as well as additional operation-dependent data to DevTools to allow better Trust Token debugging. Follow up CLs will pipe the event all the way through to the DevTools network handler and instrument the redemption and signing operations. R=davidvc@chromium.org Bug: chromium:1126824 Change-Id: I04dd881a74221b3f96a9eea74e39b2d50c9ee20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513593 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#830530}
-
Friedrich Horschig authored
Right now, the all passwords show saving exceptions as chips but it should ignore them entirely. In addition, it should not show the option if only saving exceptions are stored. Bug: 1150851 Change-Id: I4a7a707ab1e1dade7655af6e722c802785ad12ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550818 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830529}
-
Mikhail Khokhlov authored
This CL enables collecting Chrome events through perfetto system tracing in the power.mobile benchmark. Bug: 1151840 Change-Id: Iac07d6f9705d264867738e741ad743c7949f29a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553426Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#830528}
-
Oriol Brufau authored
A Shadow DOM V0 insertion point can't participate in the flat tree, so attempting to convert a Position with such an anchor node into a PositionInFlatTree used to produce a DCHECK failure. This patch makes ToPositionInFlatTree use a position with the parent node, if the given one is a V0 insertion point. Bug: 1151536 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint1 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint2 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint3 Change-Id: I2d823294ed092ceb7dca4cd708fd75eca5a55f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551131 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830527}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19526a69c763..d840c8fb5dc4 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d375f99a..acfa5a01 (830370:830473) 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 45755197..d375f99a (830233:830370) 2020-11-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ef9a6dff..45755197 (830132:830233) 2020-11-23 mbonadei@webrtc.org Fix perf results upload. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icde44d3fa88816bfb9f622d208d46e564f0246d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557527Reviewed-by:
-
Yuzu Saijo authored
This CL makes normal load deferring (i.e. pausing, frozen background etc) and bfcache load deferring different. This is to avoid bfcache specific calls all the time, such as eviction. Also this allows to set memory limit / time limit for network requests only for bfcache, without changing normal deferring behavior. Bug: 1137682 Change-Id: I6b9f082ad0c4ebb959730106381673e1aae8bb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549023 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#830525}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b413197a6d7..35df41dad885 2020-11-24 ynovikov@chromium.org Skip more tests on Linux AMD RX 5500 XT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1004356,chromium:1097750 Tbr: jmadill@google.com Change-Id: I3899eea2e3062389480213e240ca4e02ad488ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557518Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes "reconfiguring_encooder.html" to ignore linux_layout_tests_layout_ng_disabled bot because required web codec is not installed on the bot. TBR=eugene@chromium.org Bug: 591099 Change-Id: I8e40737e62b7600e2c7b67fbbc4c0ee76dc4d065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557282Reviewed-by:
-
Bartek Nowierski authored
BackupRefPtr has better security features and its performance is in the same ballpark, so we decided to go that route instead. Bug: 1073933 Change-Id: I1481e8a8ab143b9b7b17e37a6a6156bcd7fc72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557121Reviewed-by:
-
David Roger authored
This is a tentative fix, as I could not repro the issue. It is theoritically possible that the call to TriggerCookieJarUpdate() does nothing. The scenario would look like this: - Reconcilor starts - Reconcilor does a ListAccounts - At this point DiceInterceptedSessionStartupHelper calls TriggerCookieJarUpdate, but this is a no-op because a ListAccount is already running. - Reconcilor finishes running and adds the account, but OnAccountsInCookieUpdated is never called (because bug 1051864) - this results in a timeout of DiceInterceptedSessionStartupHelper The CL also adds an histogram to track reconcilor errors, as they would explain the timeout as well. Bug: 1151313 Change-Id: I5082ffa377c3c3c4e605d75ae79545811593ac3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550814Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#830521}
-
Sigurd Schneider authored
If multiple CDP clients were attached, only the first would get a valid ClientSecurityState. Bug: chromium:1128885 Change-Id: I6a54a1943b81dd1011288716d12e291b1ef315e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554545 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830520}
-
Nico Weber authored
We don't seem to use it, and it makes it easier to implement these scripts without subprocess calls using just plistlib once on Py3. Bug: 1147069 Change-Id: Iac7464b7767b2c221f3a63bf79708aa211147249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554781Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830519}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I634d9bd6f351f2961255b318774bbdbbeac41c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557517Reviewed-by:
-
Yoshifumi Inoue authored
Introduce Synthetic Vertical Oblique by Font::DrawBlob This patch implements limited version of "font-style oblique <angle>" when <angle> is negative, text-orientation is upright, and writing mode is vertical, e.g. "font-style: oblique -15deg", for simulating "tts:fontShear"[1] in vertical writing mode, e.g. video caption for Japanese title. This patch does two things: 1. Draw font glyph with affine transform skew y-axis -15deg, aka synthetic oblique. 2. Select normal slant font when using synthetic vertical oblique[2]. Note: "Meriryo" has italic font and other Japanese fonts are slant by font manager. [1] https://www.w3.org/TR/2018/REC-ttml2-20181108/#style-attribute-fontShear [2] http://crbug.com/918475: Chrome does not distinguish `italic` and `oblique` Bug: 1112923 Change-Id: I5c14bb705fcdd01893be7cc0734bfc2440cb381d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537733 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#830517}
-
Reid Kleckner authored
The closing paren and opening square bracket apparently must be joined for these links to be recognized as markdown links. R=hans@chromium.org Change-Id: I7a3e42c6c6e0ade18a1305e0ae6ed8e48e50bb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555540 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#830516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/260eb0f662b4..b35dd76cd5f6 2020-11-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I3526605f02c4399d5daf47e0b21e6e8d8f01d376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557457Reviewed-by:
-
Austin Tankiang authored
This test was failing as it was timing out when waiting for the file handler extension's background page to close. Override the page's idle time to ensure it closes before the test times out. Bug: 1150689 Change-Id: Iff3970c65149f322ebfe014d773abc646a8cc503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557280 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830514}
-
Yuki Yamada authored
I've disabled some tests for all the platforms, but they had problems only with specific platforms. This is a follow-up for these CLs: https://crrev.com/c/2556621 https://crrev.com/c/2557065 https://crrev.com/c/2557279 TBR=dpapad@chromium.org,bugsnash@chromium.org,rohitrao@chromium.org No-Try: true Bug: 1152287, 1152318, 1152289 Change-Id: If24633596f23ae8f53447b02b2232dd44eed9761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557284Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830513}
-
Sean Harrison authored
Add description text to the customized behaviors section for content settings in chrome://settings/content. Bug: 1113642 Change-Id: Idb8dd03d152f8c2bdccc27dffca1bdc8e233aca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555037Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#830512}
-
Shik Chen authored
This CL fixes the following error by remove the 'for' attribute: Avoid 'for' attribute on <label>. Place the input within the <label>, or use aria-labelledby for <select>. The <input> are already associate with <label> correctly as a direct child. ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label Bug: b/172879638, b/172340545 Test: Pass presubmit checks and manually check with Chromevox Change-Id: Idcf38a2de244b9a3052a0831be28b72c522ca0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554272 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#830511}
-
Taeho Nam authored
Change-Id: I1a73ce66491885f38bb481c9c7f2b565def536ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551892Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#830510}
-
Yuzu Saijo authored
This CL mechanically replaces a parameter of SetDefersLoading, bool, with enum. Bug: 1137682 Change-Id: I5af8193acf926867f56980686d0a58c4d238f1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537457Reviewed-by:
-
Rainhard Findling authored
* Show the number of compromised and weak passwords that were found by the password check in the password check child of safety check (SC). Translation Screenshots: IDS_SETTINGS_SAFETY_CHECK_PASSWORDS_SAFE: https://storage.cloud.google.com/chromium-translation-screenshots/9337b5cfa3bcef4342156a73d83cf37043f783e9 IDS_SETTINGS_SAFETY_CHECK_COMPROMISED_PASSWORDS: https://storage.cloud.google.com/chromium-translation-screenshots/48000c9b3b776cd72ef4b37861123533cef88cb7 IDS_SETTINGS_SAFETY_CHECK_WEAK_PASSWORDS: https://storage.cloud.google.com/chromium-translation-screenshots/8d987688c08641fee35f117eddeaa63f9769a515 IDS_SETTINGS_SAFETY_CHECK_STRING_TUPLE_WITH_COMMA: https://storage.cloud.google.com/chromium-translation-screenshots/6139bb64c11e0f921e8d5951367952b62ecb3fcc Bug: 1015841 Change-Id: Id40473d34164dfaafdea2e0db6f0f256a1b73522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547582Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#830508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60b0ce5c4a44..8fb8d59ba581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukiy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149681 Tbr: yukiy@google.com Change-Id: Iedfce050b40a48db7721b9f13d4215ef86ee1ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557147Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830507}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606175959-25d181192b782b01bd229877ae9d4ba54da15043.profdata to chrome-mac-master-1606196878-31a6a989939947bbb9b6b52f3528a70f37f5b2e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ida2dea1c67437937f7e0eef4f7e6821d81d3eea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556501Reviewed-by:
-
Colin Blundell authored
This CL does the initial bringup of ad tagging and blocking functionality in WebLayer. To do so, we do the following: - Bring up an implementation of SubresourceFilterClient and attach it to WebContents instances - Instantiate subresource filter navigation throttles on navigation - Instantiates and configures SubresourceFilterAgent instances in the renderer The organization and code added is modeled after that in //chrome. We have left TODOs for significant pieces of functionality to be added in followups (e.g., showing of the infobar on Android). One thing to note is that ad tagging/blocking only triggers on Android in WebLayer, as it requires having a safe browsing database instance and WebLayer does not have one on platforms other than Android. This CL also adds browsertests of this initial functionality: - that the subresource filter activation state is computed on page loads - that ads are blocked on activated pages if they are flagged by the ruleset This CL is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2526087, which was reverted as one of the added tests exhibited flake on Windows: occasionally the result of a check of whether a resource was loaded reflected the state of a prior navigation to the test URL. That flake has two likely sources: (1) The test is not waiting for the right event to be signalled (i.e., the document is not fully loaded) (2) The repeated navigations to the same URL are resulting in some sort of optimization (e.g., in //content) that is interfering with the expected flow of the test (1) seems unlikely, as //weblayer's NavigateAndWaitForCompletion() waits until WebContentsObserver notifications have been received that both the navigation to the given URL has completed *and* that loading has stopped. This CL provides a speculative fix for (2) by adding intervening navigations to a different URL. If the flake still exhibits itself, we will have gained more insight for further debugging it. Bug: 1116095 Change-Id: I4e5fd3f9debfaccc219f865c896010429f1f299e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554539Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#830505}
-
Morten Stenshorne authored
CL:2421371 does something similar for floats. Bug: 1079031, 829028 Change-Id: Ifee794cb4fb6751a511f075b32fbe0b9c50d18c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554568Reviewed-by:
-
Yuki Yamada authored
All/MediaAppIntegrationTest.HandleRawFiles/_WebAppInfoInstall randomly failing on builder "linux-chromeos-chrome" TBR=bugsnash@chromium.org No-Try: true Bug: 1152318 Change-Id: I2ca7b0f4b50a83be8a0fe5a504ab94cf024c0f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557065Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606175959-14a3411953113a2fe64aa457a295c32153a3500e.profdata to chrome-linux-master-1606196878-64b7b1e8929e5613baadbfb35b6857cd242016c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1205440d0ecc5eb6f147bd87957bf8a1b9928b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557341Reviewed-by:
-
Mason Freed authored
The conversation [1] about the recent changes to setInnerHTML have led to the conclusion [2] that perhaps we shouldn't add a new XSS sink method at all. That would "fix" the declarative Shadow DOM problem, but would create a new sink that all security libraries would need to know about and handle. Seems like not a good trade. In the meantime, a polyfill can stand in for setInnerHTML: Element.prototype.setInnerHTML = function(content) { const fragment = (new DOMParser()).parseFromString(`<pre>${content}</pre>`, 'text/html', {includeShadowRoots: true}); this.replaceChildren(...fragment.body.firstChild.childNodes); }; [1] https://github.com/whatwg/dom/issues/912 [2] https://github.com/whatwg/dom/issues/912#issuecomment-732476002 Bug: 1042130 Change-Id: Ibaf15a3edf86be9a720225dea2ba2741f2882b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555589 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830501}
-
Yutaka Hirano authored
Bug: 1152249 Change-Id: Id21f5ec3531f3b3b03f163fe3d1f8d848ca3b8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556887 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I794e7484ccea4d900c1fd6ee77aa2281271f9ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554982 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#830499}
-
Jinsuk Kim authored
A single factory instance for TabDelegate objects is enough for a ChromeActivity. This CL prevents multiple instantiations of the factory. This fixes a bug that logs MobileNTPOpenedInNewTab more often than expected due to numerous UMA reporter objects. Bug: 1014382 Change-Id: I7c28f6cd500bc58a835c16d7e5dbb6f9e90d82b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554274 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830498}
-
Alice Wang authored
This CL migrates usage of signin.SigninPreferencesManager to the same class in signin.services target and remove the old class signin.SigninPreferencesManager. Bug: 1150862 Change-Id: I97f08bf0723ed8baf3d4757f1f01754c3eeb31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553550Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830497}
-
Risan authored
In the Android CLs, we allow this to happen and we prohibited the creation of the Android directories. So apps can access the MyFiles through Storage frameworks, but no default directories to be created. BUG=b:162793388 BUG=b:169537013 TEST=Manual test in Photos app, CtsAppSecurityHostTestCases, CtsProviderTestCases, part of CtsMediaTestCases Change-Id: I98ab33d6d68adfb1638bcdf07557817df257c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536424Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830496}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ieab892a421c52a3dcc4e00bfd6a34b24eddeb963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830495}
-
Yoshifumi Inoue authored
This patch extends expiry of WebCore.Editing.Commands* histogram and updates owner of WebCore.Editing.* histograms This is reland of the CL[1] with changing owner to yosin@ and kojii@ from editing-dev@ which is not valid for owner. [1] http://crrev.com/c/2550325 Bug: 1149518 TBR: schenney@chromium.org Change-Id: I46cc7e1db43c294a3dd7c0bc266266073535ec2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556891Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I3b8b1179ee7a7cc44a8649514a13134ae2065ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546388Reviewed-by:
-
