- 03 Jun, 2020 40 commits
-
-
Gabriel Charette authored
base::PostTask with no traits implicitly posted to base::ThreadPool. This isn't necessary here. The correct semantics would have been to post to ThreadTaskRunnerHandle::Get(). But even that seems unnecessary as RunLoop::Quit() can be invoked directly in this context. Assuming the test doesn't need to let pending tasks run before quitting the loop. This change is blocking https://chromium-review.googlesource.com/c/chromium/src/+/2225541 Bug: 968047, 1026641 Change-Id: I6caea1ee7c7f3089ebc8a7786a4755eb784cac80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228118Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#774668}
-
Marc Treib authored
An "unsynced deletion" is a password deletion that has been applied locally, but not committed to the server yet. Clear Browsing Data is interested in the existence of unsynced deletions, so it can track when a deletion has actually been committed. Bug: 1086433 Change-Id: Ieec2b5b57b2ffa49caa8f697662953892ec61f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214953Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#774667}
-
Luke Zielinski authored
In PR https://github.com/web-platform-tests/wpt/pull/23922 a command was added to the docs/ directory, and docs/ was added to tools/wpt/paths. This means that running wpt now requires docs/command.json to exist. The WPT Waterfall (go/wpt-waterfall) is currently broken by this. Change-Id: Ie5514a6257f1d87f7a3da1fa758e655dd2312841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229063 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#774666}
-
Robert Ogden authored
This class manages all the subresources on a prefetch page and how they are loaded. This is only a plumbing and ownership change, no behaviorial changes. Bug: 1082505 Change-Id: I7f09cf32235c089591bed8f2608224a29bcf2a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224822Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#774665}
-
Reilly Grant authored
This is an alternate to crrev.com/c/2216317 to fix test flake in geolocation-api/watchPosition-page-visibility.html now that page visibility changes are asynchronous. The original mock required a call to setGeolocationPosition() for every call by Blink to queryNextPosition(). This is a difficult invariant to maintain because Blink will always call queryNextPosition() after calling the success callback. Most tests avoided the error by marking the test passing during the watch position callback and so the error generated by the next "tick" was ignored. The page visibility test is sensitive to this issue because the call to queryNextPosition() after state 2 races with the change in visibility. If it wins then there is no position available and the test fails. This version of the mock allows queryNextPosition() and setGeolocationPosition() to be called in any order, matching up the request from Blink to the position update when it is available. In this case if queryNextPosition() is called before the visibility state change then it will wait for the position to be updated after the page is hidden. This position update will still be ignored by Blink because it has, at that point, already closed the Mojo connection to the geolocation service. Bug: 1083585, 866140 Change-Id: Ida2469738b19d0862c7af3870360c755c71f7e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219148Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774664}
-
Alison Maher authored
This change updates the name of the forced-colors media query within the UA stylesheets to ua-forced-colors. This is done to make it clear that it is a UA-specific hack for forced-colors. This is based on feedback from https://chromium-review.googlesource.com/c/chromium/src/+/2211124. Bug: 970285 Change-Id: Ic99620f7886a82cfbb87d929bf7f985f474714c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227098Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774663}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9221f239a587..91a2d1d02653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fdoray@google.com,tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fdoray@google.com,tnagel@google.com Change-Id: Ibceae0ae54255e9893767caf79ff94e8d75038dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228910Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774662}
-
Andreea Costinas authored
This CL replaces the deprecated SetSystemTrafficCredentials dbus method with SetAuthenticationDetails wich allows setting additional information like kerberos availability. BUG=chromium:1042641 TEST=updated unit tests Change-Id: I3267d473a1a4350c07b004480d27d7c4e78fdad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199259 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774661}
-
Xianzhu Wang authored
A layer with backdrop effects (special blending modes including kDstIn for masks, and backdrop filters) should draw contents even if it draws nothing, because the "nothing" drawing may still take effect on the backdrop. Change-Id: If25525a259777cf848c2af5b424d0308537be1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226065 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774660}
-
Jia Li authored
Expiry extended from M85 to M89 Bug: 1089755 Change-Id: Ife721af437bc68d57776664864660b684833ecd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224619Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Mason Freed authored
Previously, Chromium had intermittent behavior with respect to the "disabled" attribute: - <link id=foo rel="stylesheet" disabled> would not show up in document.styleSheets. - foo.disabled=false; foo.disabled=true; would cause it to appear (and remain) in document.styleSheets. - <link rel="alternate stylesheet"> cannot be enabled, except by disabling and re-enabling it. - When disabled, link.ownerNode was not null The above issues are being resolved with this CL. See the spec discussion and PR here: https://github.com/whatwg/html/issues/3840 https://github.com/whatwg/html/pull/4519 And the ChromeStatus and I2S here: https://chromestatus.com/feature/5110851973414912 https://groups.google.com/a/chromium.org/d/msg/blink-dev/3izM5vVo98U/iDLjz_TwAgAJ= WPT tests are located here: https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned&q=htmllinkelement-disabled and they show that Firefox already implements the new behavior, while WebKit does not. With this CL, all 7 tests are now green. Bug: 695984, 1087043 Change-Id: Ic6d2c8e901a72885b9f4806c616adb95e019cf09 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216701Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bindings is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in PerformanceMark's constructor. Bug: 839389 Change-Id: I1796093b38c00dd876031b44e53d6d983d6d75ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227930 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#774657}
-
Daniel McArdle authored
Bug: 1052476 Change-Id: I43ec9308e2079f09ca164b7575241ef9f82ef25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202336Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#774656}
-
Kyle Horimoto authored
Also add missing mojom::Setting enum values and register them within the section. Bug: 1083518 Change-Id: I0e7b0372e0d9dcf5e9bf0ebdaa064f250dd724f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227791Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Amruth Raj authored
When a WebCoalescedInputEvent is getting built from individual input events by the renderer, it looks for events that can be coalesced together. If there is a kRelativeMotionEvent in the queue, existing logic is to skip it and coalesce the next events. In case of a pointer lock, kRelativeMotionEvent is sent during a cursor recenter. Events before kRelativeMotionEvent and events after kRelativeMotionEvent differ by a big margin and should not be coalesced together. This patch correctly stops coalescing when a kRelativeMotionEvent is seen thereby avoiding incorrect bigdeltas from being sent to the DOM. Bug: 1066544 Change-Id: I1a38391e41f4d0bc11ec67c88e3df1d321bc15bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226479Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774654}
-
Devlin Cronin authored
If the NTP was overridden from its default state with Google as the search provider, show a branded dialog and custom message to the user. This requires a bit of code acrobatics in order to determine what the previous NTP and search engine will be. In particular, we need to: 1) Determine if the default search is Google 2) Determine if the default NTP is the "secondary" NTP 1) is relatively straightforward; 2) is more complicated. The NTP can be overridden by several different sources (extensions, policies, or a different default search provider). In order to accommodate this, introduce BrowserURLHandler::GetPossibleRewrites(), which iterates over all rewriters and accumulates the list of rewrites that would happen. This, in conjunction with also checking for multiple NTP overriding extensions, allows us to check if the default NTP would be used if the overriding extension were removed. Add tests for various pieces: - BrowserURLHandler::GetPossibleRewrites() - ExtensionWebUI::GetNumberOfExtensionsOverridingURL() - The dialog params generated when a non-default search is selected - The dialog params generated when multiple NTP-overriding extensions are installed - UI browser tests for both the generic and the default-specific dialogs. Bug: 1079364 Change-Id: I6d37eb8fa85cd824155a9907253a57f1d8cfd51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202156 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#774653}
-
Victor Hugo Vianna Silva authored
This CL moves the code in PasswordsSection responsible for retrieving saved passwords and deduplicating copies into a new Polymer behavior. Future CLs will introduce the "passwords on device" WebUI page, which will also use this behavior. A similar behavior will also be introduced for exceptions. As a minor note: hasSavedPasswords_ is not factored out since the new page is only interested on whether each of its subsections is empty or not. Bug: 1049141 Change-Id: Id919aa18ae4bcd57c4f9c71fefff259485752bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225906Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#774652}
-
Francois Doray authored
Before this CL, changing the wake up interval in WakeUpBudgetPool did not have an immediate effect. With this CL, decreasing the wake up interval immediately reschedules the next wake up. This change is required to support the intensive wake up experiment, which will change the wake up interval from 1 second to 1 minute after 5 minutes in background. Bug: 1075553 Change-Id: I4ca1589a1ca810a4109cffc694db8ae1d89293dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220840 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774651}
-
Nicolás Peña Moreno authored
This CL is a tentative fix for some flaky tests. An assert_equals to 0 is sometimes failing, presumably because the test itself may cause some inputs to occur. Hence, we only check that eventCounts is 0 when the |looseCount| variable is set to false. Bug: 1074048 Change-Id: I989ccdb7cb469ff24132bf17a3da9a43264ae6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225293 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#774650}
-
Mila Green authored
Bug: 1072061 Change-Id: I6b903e5e4c47ee1368faf57a2388b92b39c2a2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208605 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#774649}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I42f7767a241a2116b0f589fddb042f199931002d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774648}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591142315-92a136d405d944eb0ad6a14d1cc0d834f3d533a1.profdata to chrome-win64-master-1591184865-5178b7a96ecfc255ba5ba33ed0277fd9a93edec8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fdd4eabfab7d7d27e9d504794e5ef2e3535a7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228913Reviewed-by:
-
Stepan Khapugin authored
Fix a UIWindowScene leak in multiwindow. Improve memory management of overlays. Bug: 1090263 Change-Id: Ia5e06566635b182fa33c4976c933cebcf0b5f11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228654 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774646}
-
Stephen McGruer authored
This also changes to use full email addresses instead of usernames, which is (coincidentally) a concern raised by Pinpoint team in issue 1045089. This change is being deliberately TBR'd (after review!) to confirm that TBR-ing an @google.com account works. TBR=kyleju@google.com Bug: None Change-Id: I472c8fcdfba0aae9d2ff75d34a59e287905b50f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226769Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#774645}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4d88908b1bb..fb2bd34e2d92 2020-06-03 fmayer@google.com Do not use id as row number. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4a18c1e94b379cbc0a0fc4be31dca398777f030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229141Reviewed-by:
-
Andrew Grieve authored
Noticed this was the only resource in the sw720dp config. Turns out that it's not even necessary anymore since sw600dp/window_background.xml == sw720dp-v19/window_background.xml And we don't support pre-v19. Saves 3.7kb Change-Id: I591bf7f1a91c1984ad5896db85a6c09f168b314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225944Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#774643}
-
Gavin Williams authored
- Show the 3 default print preview destinations Save to PDF, Save to Google Drive, and See More... - Add the existing icons to inside the dropdown using |destinationIcon| Bug: 1059607 Change-Id: Icef448773ac3f350c0fd3bf5eb8b63c8d567cb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194789 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#774642}
-
Sylvain Defresne authored
The incognito BrowserState should only be destroyed when there are no tab open in any window. When multi-window is enabled, this mean that all the WebStateList of all Browsers are empty. Additionally, before destroying the incognito BrowserState, the objects whose lifetime is tied to the incognito BrowserState must first be destroyed (like Browser, ...), so iterate over all the SceneController to inform them to destroy those items before the BrowserState is destroyed. Bug: 1069749 Change-Id: Ibcba14081e3bccc9737f57104a77a11e68eeea46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225772 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a46f5c6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5a6b0e46ab7b851b7137034c46382fee8b8c246b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228574Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774640}
-
Yi Gu authored
The TODOs are now assigned to the linked bugs. Bug: None Change-Id: I92ee6368f1d9b730c9cc31d204d716c0c2c30f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225291 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774639}
-
Peter Kasting authored
* Remove DownloadShelfNeedsLayout(). The BrowserView implementation of this turned out to be equivalent to checking if the download shelf GetVisible() returns true. BrowserViewLayout can do this directly. The test implementation of this was easy to replace with setting the visibility directly. * Remove the SetViewVisibility() call in LayoutDownloadShelf(). The download shelf updates its own visibility (correctly), so this was a no-op. * Remove the Layout() call in LayoutDownloadShelf(). If the View size has changed, SetBoundsRect() will Layout() automatically. If not, layout is unnecessary. * Better use of unique_ptr to convey ownership in unittest code. Bug: none Change-Id: Ia79970b1fd386a080623ff80c57eb29bc50c2d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227435 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774638}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b4a80ad22de..463d729cd6db 2020-06-03 paraboul@gmail.com Fix an "use-after-move" in SkFontMgr_custom_embedded. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I97aae6fb02303207bf4d8d0cec97933749198a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229139Reviewed-by:
-
Tim van der Lippe authored
The flag is being removed. Before we can remove the usages in devtools-frontend itself, we first have to remove the references to them in Chromium. R=yangguo@chromium.org Bug: 1087379 Change-Id: I09650358aba4bc2ec30fe91fe49e7e287d4b205b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224216 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774636}
-
Peter Wen authored
Rename the one offending non-java target with a java target name pattern by removing _java and _junit. Bug: 1090812 Change-Id: I8a00951fd9564e9b2842af78e4f5485f9df5aa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229001 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774635}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/78a3c915a1d7..232ba0d848d1 2020-06-03 47594367+rg3igalia@users.noreply.github.com Add SPIR-V capabilities needed for spec constants (#2199) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Iabda92ca97d27d9bd714896735d46e76b7718f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228916Reviewed-by:
-
sandromaggi authored
This re-introduced the ShortWaitForElement for the Use*Action, if the |form_field_element| is specified. This is not a hard restriction, if |skip_autofill| is true, the element does not need to be specified. If it's not, the |RequiredFieldsFallbackHandler| will be called immediately without waiting. Bug: none Change-Id: I269ac0735a060357a6679e66fdf41f7a315f402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228720Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#774633}
-
Travis Skare authored
Matches c/b/ui/views/qrcode_generator Change-Id: I4e2a0600908b849893decdd0b0d72162d55ce5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227853 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774632}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb005807e661..c042e00faa0e 2020-06-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-03 tvanderlippe@chromium.org Typecheck sdk/SourceMap.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ca9cc397fe3c26ae4cc7e823b26f884fcf93fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228915Reviewed-by:
-
François Doray authored
This reverts commit bc99f5b2. Reason for revert: https://crbug.com/1090820 Original change's description: > [COOP access reporting] Preliminary WPT tests. > > Add some basic WPT tests about the COOP access reporting feature. > No web browsers actually implement this. As a result, chrome do not > pass them yet. > The tests aren't complete yet, they will evolve along the specification > and the implementations. > > Bug: 922191 > Change-Id: I9aa03e727252086eb64c0110afc9b5885b66802d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225757 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774599} TBR=clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org Change-Id: Iffd419fd7bc0e2f4b9c77260c2f9a40ba44b0cdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922191, 1090820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229003Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774630}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/adbf9153d909..d586b079f20d 2020-06-03 cwallez@chromium.org Fix compilation failure with libstdc++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I22d51ed0ad374080d4be449bebc580c41e97c478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228912Reviewed-by:
-
