- 20 Apr, 2019 11 commits
-
-
Tim Song authored
The top notification may be clipped even though there is sufficient space to render the message center taller. BUG=954395 Change-Id: I5aade1b772d80640a2094bcb42365a75f75db837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574956 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#652710}
-
Eric Karl authored
Ensures that Android WebView works with SurfaceSynchronization enabled. For WebView, SurfaceSynchronization is nearly a no-op, as only one surface is ever in use. This change only does two real things: - Ensures that WebView uses RenderFrameMetadata rather than CompositorFrameMetadata where appropriate. - Ensures that SurfaceIds are correctly sent to the renderer for WebView, allowing for rendering to occur. Also removes previous disabling of WebView in tests. Bug: 881469 Change-Id: If01ebc3be54eb90ca3aa196a464de693ad69bed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570136Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#652709}
-
Hiroshige Hayashizaki authored
This CL adds the following methods that are used in upgrade-insecure-requests processing to FetchClientSettingsObject, and use them in FrameLoader::UpgradeInsecureRequest(): - GetInsecureRequestsPolicy() - GetUpgradeInsecureNavigationsSet() - GetMixedAutoUpgradeOptOut() Before this CL, upgrade-insecure-requests works based on ExecutionContext's SecurityContext, and thus uses the insideSettings' CSP list during off-the-main-thread worker script fetch. After this CL, upgrade-insecure-requests works via FetchClientSettingsObject and thus uses the outside settings object's CSP list correctly in off-the-main-thread worker script fetch. This CL doesn't cause behavior changes in dedicated workers because dedicated workers inherits the parent's CSP list. This CL probably affect behaviors in off-the-main-thread fetch for shared and service workers, but these are not covered by tests. Anyway OTMT for shared and service workers is still under development and will be tested and fixed in the future. Bug: 878274 Change-Id: I412845c9c7a866d22b97c501936d640fab99b71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570669 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#652708}
-
David Benjamin authored
Bug: none Change-Id: I9c4a35aa6797230840f3436cbf66f35904dbf5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576010 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652707}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f777fd10f59a..5cc5a8e61949 git log f777fd10f59a..5cc5a8e61949 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate scalar-span to es6 module 2019-04-19 benjhayden@chromium.org Migrate raised-button to es6 module. Created with: gclient setdep -r src/third_party/catapult@5cc5a8e61949 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011 TBR=charliea@chromium.org Change-Id: Idee0eb527cd3f1e3af0a5dd12fce64fafd0b3d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652706}
-
Bret Sepulveda authored
Attempting to deflake Windows 10 bot. The test virtual/bidi-caret-affinity/editing/selection/modify_move/move-by-word-visually-crash-test-2.html is passing on some platforms and crashing on others. This patch adds Pass to the test's expectation. TBR=xiaochengh@chromium.org Bug: 894651, 954586 Change-Id: Ic0b0068269016cbd3de611f2059cf5364ff918e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576159Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#652705}
-
Marcin Wiącek authored
Before: file contains many similar methods and variable definitions. After: there are created tables for integer and boolean values indexed by @IntDef, which are handled by two methods. It makes code and APK shorter. Change-Id: I549b288f53a7644601179b1477e8a05d2e9b2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565311 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652704}
-
Wez authored
Exiting the Runner when it is not hosting any components saves memory but increases the time taken to launch new components, since the web.Context must be re-created from scratch each time. Fuchsia's Components v2 APIs will allow the system to teardown Runners to save resources when required, but for now just run until the system kills the Runner process/job. Bug: 952560 Change-Id: I5fdd220fbb1e0587d584f14a5447948e1d1d99bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566766 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652703}
-
Harry Cutts authored
This was messing up the formatting on the rest of the line. Change-Id: I37263e8c7d2917b8b3bf620209282bfb576eb022 Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576014 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#652702}
-
Kevin Marshall authored
Allows the Agent to provide the Runner with the touch support policy for Cast applications. Bug: 953796 Change-Id: I3bd383e3df196c8217e5a0eb7da37fee6f6d83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572246Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652701}
-
Chris Lu authored
When calling CallJavaScriptFunction, the timeout being creating is expecting a value in seconds, but the constant is in milliseconds. Bug: 919685 Change-Id: Iae35a9fdbccaabf1c2c53ec650b75042bfb0cf87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575998Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652700}
-
- 19 Apr, 2019 29 commits
-
-
Bret Sepulveda authored
The test virtual/nobinary-for-devtools/http/tests/devtools/elements/highlight/highlight-display-locked.js does not exist, which is causing lint for the TestExpectations file to fail. This patch deletes that line. TBR=rakina@chromium.org Bug: 934458 Change-Id: I40ed3ddb425e462d89b0bf2647cc1c54dd928118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576219Reviewed-by:
-
Regan Hsu authored
This CL removes code Autofill section from OS-settings entirely, since it is not used by the OS. Bug: 950007 Change-Id: Ia59926a8861b329c5ab678e296bd91a6fda8a0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574295Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652698}
-
Reilly Grant authored
This change finishes wiring up the CONTENT_SETTINGS_TYPES_SERIAL_GUARD permission which can be used to entirely block the chooser UI shown by navigator.serial.requestPort(). As with the USB guard permission this needs special casing in the page info and site settings UIs because it can't be set to "allow," only "ask" or "block." Bug: 908836 Change-Id: I085c9e60e8a3cd6fa85ca0b18a58f359ef35e7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538681Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652697}
-
rajendrant authored
Bug: 936999 Change-Id: Ib67c739cfc862c942489fe9213abb7db410b100c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576119Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#652696}
-
Chris Blume authored
GLSurface's ctor does not have special logic, but isn't marked '= default'. It could gain std::is_trivially_constructible if it was marked as such. This CL replaces the empty ctor function body with '= default'. TBR=ericrk@chromium.org Change-Id: I2003ecb142ca8d5d61173fb6fc2cd754db9cf8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576023Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#652695}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5609aa373c8e..0ab4b3dfabf6 git log 5609aa373c8e..0ab4b3dfabf6 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 dhanyaganesh@chromium.org Revert "pre-cq-default-configs: disable betty-arcnext" 2019-04-19 jclinton@chromium.org Revert "ManifestCheckout: enable FetchAll for all scenarios" 2019-04-19 dhanyaganesh@chromium.org builder_status_lib: fix a confusing build message 2019-04-19 zamorzaev@chromium.org lib: Use a subdirectory of /tmp 2019-04-19 nednguyen@google.com [cbuildbot]: only run CPEExport stage in the release builder 2019-04-19 saklein@chromium.org controller/artifacts: Updated todos to reference bugs. 2019-04-19 jrosenth@chromium.org chromeos-config: make gale, whirlwind important 2019-04-19 haddowk@chromium.org chromeos_config: make moblab-generic-vm important again. Created with: gclient setdep -r src/third_party/chromite@0ab4b3dfabf6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iee12f0b87fa0e06562d8a2df5ef8c25494fc0ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576065Reviewed-by:
-
David Bienvenu authored
When Chrome is launched with a URL on the command line, and Chrome is already running, it looks for a browser window to load the URL in. This CL makes it ignore browser windows that are not on the current desktop, on Windows 10 (or higher). Bug: 757853 Change-Id: Ib251619cbcef18809b886b96e21034507ea14654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538834 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652693}
-
Alex Newcomer authored
The check can only be hit if item_count() is 1, but the to/from indices are not equal. If item_count() is 1, we shouldn't be doing a move anyways, so return early. This crash is likely occurring because a sync is coming in to delete the second item in a 2-item folder during the drag reorder. Bug: 937431 Change-Id: I2521f2e89ace9ca8c9218bfd050c04cc6bb89d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575776 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652692}
-
David Black authored
Previously, if a text query were initiated via deeplink and the UI was visible but not in main/embedded UI mode, the interaction would not be visible to the user. Bug: b:113278359 Change-Id: I1f65e0955df688cc08f1b511d09d6bf99a9a55a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566725 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#652691}
-
Bret Sepulveda authored
external/wpt/payment-request/payment-request-canmakepayment-method.https.html is timeout-flaky on Windows. TBR=robertma@chromium.org Bug: 954628, 954586 Change-Id: I5061ee3afd90cfe4b82f7d84f4e48bbac23e5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574454Reviewed-by:
-
Klaus Weidner authored
This change is needed to match the API change in https://chromium-review.googlesource.com/c/chromium/src/+/1570217 but was missing in that CL. TBR=bajones@chromium.org Change-Id: Ic49436558c3cde7e42b9b8a4bd26c416f0b80f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574457 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#652689}
-
John Budorick authored
This should make resource_sizes output files in a format and structure amenable to process_perf_results. Bug: 807273,861983 Change-Id: I5d359b35ad4ba836cd1282f804daf996fbbec7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574455 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652688}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Id7fcc09482854f18a722bc0e8e951fb96846b4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574447 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#652687}
-
Eric Roman authored
Change-Id: I7d9ca04bc1c82a0a7341bd76dd265653cb0fba55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575162Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652686}
-
David Benjamin authored
We can just tell //base to act case-insensitively. Change-Id: I5d4a9ecfa09cd7fada0b0af792d0f414de888904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575172 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Misha Efimov authored
Bug: 954372 Change-Id: Id148ead661409576491fec9b37226e975098ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575115Reviewed-by:
-
Dana Fried authored
This is distinct from opening a bookmark from bookmarks bar, manager, app/wrench menu, etc. Bug: 951909 Change-Id: I8ba878a126d21696e74f821535929a59db3c120e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574424 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
[Display Locking]: Highlight highest locked ancestor instead of highlighting nodes in locked subtree Previously DevTools might call getBoundingClientRect on nodes in a locked subtree from within paint, which might trigger style/layout because we skipped the locked subtree in those phases (so they might be still dirty), leading to crashes. For nodes in a locked subtree, when we want to highlight it, we should instead highlight the highest locked ancestor instead, because it will always have up-to-date style & layout values. The tooltip for the overlay will indicate that we're highlighting the locked ancestor in that case. See https://bugs.chromium.org/p/chromium/issues/detail?id=934458#c12 for a screenshot of the UI. Bug: 934458 Change-Id: I20d85104cbeed36af6ac98b157ab6da31ed73dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528123Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652682}
-
Johannes Henkel authored
This is the minimal change. I'll simplify the code in a separate change, and remove the test suites in a separate change. The update to dom-getBoxModel-expected.txt is because the flag won't have an effect any more. Bug: 954618 Change-Id: Ib017e78c56fa19178b2d914bfcad96f9a2187596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575999Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc0161223605..f777fd10f59a git log cc0161223605..f777fd10f59a --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate SessionIdRequest, SessionStateRequest, SheriffsRequest to es6 modules 2019-04-19 benjhayden@chromium.org Migrate expand-button to es6 module Created with: gclient setdep -r src/third_party/catapult@f777fd10f59a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011 TBR=charliea@chromium.org Change-Id: I33a86be494cc73fb8c3a1fb8c9d341106ad4dd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576058Reviewed-by:
-
Aran Gilman authored
This is a clean-up CL in preparation for adding an image-specific filter. Bug: 954318 Change-Id: I002e09c2ebd384c0f0d667dcb00eebc7550aee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574629 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652679}
-
Xiyuan Xia authored
- FocusActivationStore uses ActivateWindow(nullptr) for deactivating to avoid an arbitrary window covering the active window before Restore(). - RootWindowController puts the moved windows under existing ones on display change. Bug: 945754 Change-Id: I3cacfd3427b8c98c9ce9dd2da05977120c1c1d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574824Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652678}
-
Jacob Dufault authored
- DeviceDisabledScreenView - EnableDebuggingScreenView - EncryptionMigrationScreenView - FingerprintSetupScreenView - KioskAutoluanchScreenView Also eliminate unnecessary Delegate classes on the views. Bug: 928555 Change-Id: Ifd45f381f2fb9aaae60dbe3ec6ea1287424980bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572521 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652677}
-
Shakti Sahu authored
For completed videos 1 - We should show the play icon for completed videos 2 - We should not show the circle/square animation for completed videos 3 - Paused state should show a download icon rather than play button Bug: 951839 Change-Id: I3cd1aa07777f212824fe7a110ae834fdfe4d118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575400 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652676}
-
Mitsuru Oshima authored
This measures the presentation time of following actions: * gesture-drag to show the launcher from shelf to fullscreen state. * gesture-drag to hide the fullscreen launcher. I also moved the perf test utility classes into separate file so that they can be used in other tests. Bug: 948324 Change-Id: Iac4d5ca7a39ab44c0404ab927df12608cb7529de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565235Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652675}
-
Johannes Henkel authored
We're removing the --disable-internal-devtools-binary-protocol flag so these virtual tests are no longer useful. See also: https://chromium-review.googlesource.com/c/chromium/src/+/1575999 Bug: 954618 Change-Id: Ia084f42b19ea11c92de9c3dc37d43249ca67d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576002Reviewed-by:
-
Donn Denman authored
Adds a test to exercise the UI when a dictionary definition is returned by the server. BUG=936695 Change-Id: I1b18ab395a402948377d541e828e14f51f170fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573862 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652673}
-
Jeremy Roman authored
All valid inputs are ASCII, and ASCII case conversion is currently done on both the key and value after the Unicode case conversion. While here, use StringView to just access into the ASCII-lowered buffer without copying out substrings for each key and value, since they're only read. Bug: 627682 Change-Id: Ibe11bd111205c286efb12273e006837f57254e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575125Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652672}
-
Yuwei Huang authored
This CL provides an FtlDeviceIdProvider implementation for the iOS client, which generates the device ID from identifierForVendor: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor?language=objc Bug: 954594 Change-Id: Ieb5c373d66d17751294754c1674e86b8c7cb4ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575116 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652671}
-
