GitLab

https://quiche.googlesource.com/quiche.git/+log/639a4bf5ff46..5efb965c1b4d

$ git log 639a4bf5f..5efb965c1 --date=short --no-merges --format='%ad %ae %s'
2020-03-17 dschinazi Do not use iterators in ParsedQuicVersionIsValid
2020-03-17 dschinazi Improve QUIC TLS error logging
2020-03-17 bnc Add test for default return value of QuicSpdySession::server_push_enabled().
2020-03-16 bnc gfe-relnote: Switch from closing the connection to QUIC_BUG in two ShouldCreateIncomingStream() overrides when called with locally initiated stream ID.  Protected by gfe2_reloadable_flag_quic_create_incoming_stream_bug.
2020-03-16 wub gfe-relnote: In QuicBandwidth::FromBytesAndTimeDelta,do multiplication before division to make rounding error less likely.  Not protected.
2020-03-16 dschinazi Have ParsedQuicVersionIsValid also validate transport versions
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe.
2020-03-16 dschinazi Prevent crash when trying to serialize packet with missing encryption key
2020-03-16 bnc gfe-relnote: Disable server push.  Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-03-16 quiche-dev gfe-relnote: reset has_non_app_limited_sample in QuicConnectionStats to false once handshake is complete. Logging only change, not protected.
2020-03-16 dschinazi Fix QuicVersion MSVC compilation for Envoy
2020-03-16 wub gfe-relnote: (n/a) Add 2 connection options for BBRv2 to disable 1) adding ack height in queueing threshold, and 2) avoiding unnecessary PROBE_RTTs. Not protected, just more switches for already existing behaviors.
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout.
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged.
2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_no_window_update_if_disconnected.
2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_neuter_unencrypted_control_frames.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

add/delete flags

R=zhongyi@chromium.org

Change-Id: I990459757848577d6f839306a8fec48d389fb6b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106555Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751141}

Screenshots attached on crbug.

Bug: 1062306
Change-Id: I9a086a09e3d6b1a738bfa6f8bff5b0a075f930b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106492Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751140}

This is now superseded by documentation in ash/shelf/README.md

Change-Id: I86bac092939cb87d7a9659a2b5775d45fa5f57b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106803Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751139}

This reverts commit d8c37dee.

Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1062423

Original change's description:
> Add CertProvisioningWorker class
> 
> CertProvisioningWorker class implements core logic for building
> a CSR with DM server and importing corresponding certificate.
> 
> Bug: 1045895
> Test: CertProvisioningWorkerTest.*
> Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582
> Commit-Queue: Michael Ershov <miersh@google.com>
> Reviewed-by: Pavol Marko <pmarko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750986}

TBR=achuith@chromium.org,pmarko@chromium.org,miersh@google.com

Change-Id: I06d5c2889f05563980a20b42ff00c635da5677db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107394Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751138}

This CL makes FrameTracker within ExtensionMessagePort observe worker
shutdown, and remove FrameTracker's entry to that worker. Without this
CL, FrameTracker would hold onto stale workers that was shut down and
trying to send IPC to it (ExtensionMessagePort::SendToIPCTarget) would
cause browser crash, because of nullptr RenderProcessHost.

This CL adds a test for the regression fix.

Bug: 1033783
Test: Repro in the bug does not crash anymore.
Change-Id: I6906f84077834980568f4227121ae449b6e6ce0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106743
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751137}

There is no need for this functionality to reside within a Polymer
behavior, and it is already being used a simple class in all call
sites.

This is in preparation of migrating c/b/r/settings/people_page/
to Polymer3.

Bug: 1026426
Change-Id: I9dfbb7bbd2d496f4dcdb6c79df9291d238cae487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106916
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751136}

Bug: none
Change-Id: Iaf328b22a6fba65a1d9a6deb837f379cd9405b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088187
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751135}

Follow-up to crrev.com/c/2107309

Bug: 1062289
Change-Id: Ibc8de590610fc36c6e7c4a9263c1ce0be9e79949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107707
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751134}

This CL removes code that is related to an un-necessary main frame
no-damage notification.

Bug: 1048164
Change-Id: I84e33cc0d3a8bb5ed1d1cf7aed95f3fd7f621932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096761
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751133}

NearestTextIndexToPoint should not be called on anything
other than leaf nodes, as it checks against each
character in the inner text of the node, causing hangs
if called far up the tree.

To remedy this, a new API was created:
"NearestLeafToPoint"
This gets the nearest node to a given point, utilizing
HitTestSync to scope the search.

Bug: 1057680
Change-Id: I1c167bc28c6666ba79a02dc802d6ba089cd7425c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080788
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751132}

This matches behavior on macOS.

BUG=1050905

Change-Id: I29ce0f7e7f02377a25ad0fb9b15f7a6373410fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106478Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751131}

This CL disables command-menu.js so that this CL can land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2101972

Bug: 174309
Change-Id: I896f2aaba9b9d52f821a627537e690a1947173c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107812Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#751130}

This partially reverts commit 8af6f946.

Relands PIXEL_FORMAT_UYVY and resets the optimal pixel format in
AVFoundation to UYVY.

This fixes the link bug in which camera capture with resolution lower
than 720p appears to have a dropped framerate on Mac.

Verified fix by visiting
https://webrtc.github.io/samples/src/content/devices/input-output/ and
selecting an attached usb camera.

Bug: 1035077,1027325
Change-Id: I7c3810c3382b4f4f8290210eec3ca5f8c9c4343a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068819Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751129}

This change implements updating the Password Check UI after each
credential was checked. It makes sure to account for duplicates with
regard to canonicalization of usernames and passwords and updates the
progress accordingly.

Bug: 1061500
Change-Id: I46d13e7e007f31596b6c67f9f3e56535cbc5e8a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106580
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751128}

Due to product decisions, this field should not be included.

Bug: 1062298
Change-Id: I46986aec184f61b9af18a6debabd356cbebb9719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107713Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751127}

While migrating ExecutionContext to LocalDOMWindow, several helpers
were introduced on Document (From(), DynamicFrom(),
ToExecutionContext()). This CL removes usage of these types from this
directory.

From() and DynamicFrom() are replaced with the standard
downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced
with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(),
or Document::GetExecutionContext(), whichever is most direct from the
callsite.

Also, ExecutionContextLifecycleObserver has a temporary constructor
that takes a Document*. Switch users of that constructor to the
standard ExecutionContext* constructor.

Bug: 1029822
Change-Id: Id806fd4ba2b0565c9a4865e2293115c7249e1fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101537Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751126}

This reverts commit f8d430ce.

Reason for revert: This fix didn't eliminate the crash.

Original change's description:
> Skip popup Tabstrip update when opening tabs from background
> 
> Currently, we use AnchoredPopupWindow#onRectChanged to force update
> popup strip layout when new tabs are added. This could lead to a race
> condition where RecyclerView tries to recycle a view that has been
> temporarily detached due to the re-layouting process. This is only
> reproducible when there is recycling happening, and when tab is added
> from background.
> 
> This CL bypasses this crash by disabling the force update for adding
> tabs from background. Note that it is already a known issue that strip
> is not properly updated when tab is added from background, so this
> CL doesn't introduce any UI difference before/after.
> 
> Bug: 1045944, 1050401
> Change-Id: I4d7ba97f53d41042867bea9562ce2e76aade118b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048988
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741526}

TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1045944, 1050401
Change-Id: I52434502ea7661361fcac3077869f45e485955be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075224Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751125}

https://chromium.googlesource.com/openscreen.git/+log/1aa882626c3d..e43a73b009bd

git log 1aa882626c3d..e43a73b009bd --date=short --first-parent --format='%ad %ae %s'
2020-03-17 thakis@chromium.org Fix two -Wunreachable-code warnings.

Created with:
  gclient setdep -r src/third_party/openscreen/src@e43a73b009bd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:346399
Tbr: jophba@chromium.org
Change-Id: I8628d27e3bf5b60aabefc58d00f117c16bce017e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107784Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751124}

This CL replaces base::Bind() with BindOnce or BindRepeating in the
chrome/renderer/net folder. Two occurrences are in parameters for
AddInterface(), which receives a repeating callback and it makes sense
to have repeating callbacks there. The other one is for a timer where
BindOnce suffices.

Bug: 1007641
Change-Id: Id2d3df19c699b881c492a1a3402bb60dcaa7dd3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107803
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751123}

In preparation for moving compositing into blink move UpdateVisualState
into WidgetBase. This callback will eventually be called directly from
the LayerTreeView inside blink.

Change-Id: I32b6bdc74b778d6a5b60a20f44f6e51036020079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103507Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751122}

This CL moves the command-line switch from
CaptureStreamRenderProcessHostTest to its parent, RenderProcessHostTest.
Some RenderProcessHostTests use audio and are still flaking.

Bug: 986021
Change-Id: Ic1327890183433ef9dd737d7c8d649560e5a981f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107540
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751121}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80517cb9ee4c..29781ded1b6f

git log 80517cb9ee4c..29781ded1b6f --date=short --first-parent --format='%ad %ae %s'
2020-03-17 szuend@chromium.org Make live location update handlers async and properly await {uiLocation}
2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.cssWorkspaceBinding

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@29781ded1b6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016,chromium:1058320
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I1f00a99108fb71ebafa16a2f41422559d79d4778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751120}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f9434816..f1850bf0

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If6705d67c2abf1b3f6e46ad14ec2588fa12fb4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106320Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751119}

Bug: 1059865
Change-Id: Ic5c31a97233624fdf5848b6cf571fa0e7d120aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097183
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751118}

Bug: 1061979
Test: None
Change-Id: I2503f40a7f2ee20f2746b2d63dc19b0232bb1ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106701
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751117}

Bug: 1062343
Change-Id: I87307c13437f573a0f984034073691ea4d82eb26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107810
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751116}

Updates the expires_after attribute for 44 histograms that show
frequent access in the past 90 days.  These are the 90% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-09-13.

TBR=chrome-metrics-team@google.com

Change-Id: Ibc156c1e8be51e13a027853fe7bf645cc36b1305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106017
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#751115}

Using wpt-import in Chromium dc6d8e5e.
With Chromium commits locally applied on WPT:
acbe6d96 "Add timeouts for EventWatchers on CSS animation tests"
6a942cea "[WPT/upgrade-insecure-requests] Merge multiple subtests into one file
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1048 and retry the command."
1bb259bc "[WPT/referrer-policy] Merge multiple subtests into one file
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 8469 and retry the command."
168319dc "[WPT/mixed-content] Merge multiple subtests into one file
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1397 and retry the command."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I2638141fcbd0e96b2e654e5113ed365ed55e398a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106321Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751114}

This adds a runtime flag and a DCHECK for gating Font Access
functionality. The runtime flag's state is set from the Chromium
feature flag's state.

Bug: 535764
Change-Id: Ie756de078cd5063e978c5e3faf9248885f5b3efa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103859
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751113}

ActivityTabProvider nulls out the active tab when it's non-interactive,
and we receive the onObservingDifferentTab event before entering the
tab switcher. This caused us to prematurely set the current tab to null,
removing the ability for ToolbarPhone to accurately retrieve state about,
e.g. whether the location bar is currently showing. In the linked bug,
this manifested by drawing the location bar during the tab switcher entry
animation when the location bar wasn't currently being shown.

Bug: 1060335
Change-Id: Ib101e4be786f5cad0d2602cb73f7df4620f80af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100112Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751112}

As part of the privacy settings redesign a new Cookies settings page has
been created.

This CL adjusts the ordering and description of each exception list
presented on the new page. It also adds the search box to the Cookies
page so that exceptions may be filtered.

All changes only occur on the new Cookies page, which is only accessible
when the privacySettingsRedesign flag is on.

Bug: 1061136
Change-Id: I4e2202e9cc1789fd7275847b44ecf95a4c7f949d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102658
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751111}

https://webrtc.googlesource.com/src.git/+log/469205e1adaf..570330361a17

git log 469205e1adaf..570330361a17 --date=short --first-parent --format='%ad %ae %s'
2020-03-17 kron@webrtc.org Add fallback histograms for VideoDecoderSoftwareFallbackWrapper
2020-03-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4e516821..f71e417d (750566:750950)
2020-03-17 peah@webrtc.org APM: Localize/abstract the usage of AudioFrame

Created with:
  gclient setdep -r src/third_party/webrtc@570330361a17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1061376
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Iab55faa34568c9986e4085950cd9f49564bd924f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751110}

Roll src/third_party/dawn/ 971a6233c..b988e0398 (3 commits)

https://dawn.googlesource.com/dawn.git/+log/971a6233c2a4..b988e0398277

$ git log 971a6233c..b988e0398 --date=short --no-merges --format='%ad %ae %s'
2020-03-17 rharrison Add in a default case to unblock shaderc rolls
2020-03-17 natlee LoseForTesting can only be called once
2020-03-17 brandon1.jones Residency 4: Add Facilities For Budgeting Device Memory

Roll src/third_party/shaderc/src/ a7657e4fa..95185d920 (2 commits)

https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/a7657e4fa2fe..95185d920a0b

$ git log a7657e4fa..95185d920 --date=short --no-merges --format='%ad %ae %s'
2020-03-17 rharrison Rolling 4 dependencies (#1002)
2020-03-16 rharrison Add reflection support for storage textures (#1001)

Created with:
  roll-dep src/third_party/dawn src/th

Change-Id: I4f3ab6227a65d3b6977993feb11cc93803154682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107570
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751109}

Used by background tab loading policy to load a PageNode.

Bug: 1059341
Change-Id: Ifa11aab18abea4521016a5d9d5c14aff4b8ad88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106016
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751108}

* Added StreamModel::Update() to accept data from storage or
  the network.
* Added StoreObserver to StreamModel for observing changes
  that should be made to persistent storage. Currently this
  only includes DataOperations, but might include more data
  later (for network fetches).

Bug: 1044139
Change-Id: I8179f6f0d5b2c4dbd2347d0d8667a41bc97d09e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106554
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751107}

Added AXObject::IsDetached to check that the ax_object_cache_ is still
valid in AXObject::IsARIAControlledByTextboxWithActiveDescendant to
fix a crash due to nullptr dereferencing on the ax_object_cache_.

The crash happens in the following scenario, when there is a listbox
options dropdown where Javascript dynamically remove/add the dropdown
option nodes. When Windows Narrator's focus is set on the text content
of the option, and we call Javascript function hide(), a crash could
occur in some cases due to the following (I was unable to repro this
with NVDA):
 1. Javascript remove() nodes will trigger AXObject::Detach(), which
    sets ax_object_cache_ to nullptr.
 2. Meanwhile, Windows Narrator's focus remains on the listbox option,
    and triggers AXNodeObject::OnNativeFocusAction(), which calls
    AXObject::IsARIAControlledByTextboxWithActiveDescendant() and
    retrieves nullptr for ax_object_cache_ and we call FocusedObject()
    on the nullptr cache and causes an exception.

<button onclick="hide()">hide dropdown</button>
<div role="listbox">
  <div role="option" tabindex="1" id="0">option 1</div>
  <div role="option" tabindex="1" id="1">option 2</div>
  <div role="option" tabindex="1" id="2">option 3</div>
</div>

<script>
  function hide() {
    document.querySelector('div[role="listbox"]').remove();
  }
</script>

For scenario similar to the example above, I had difficulty to have
browsertests/unittests to exercise this scenario.

Bug: 1021740
Change-Id: Ib86db0df64c230d341add63faf28a582792fa8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107429
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751106}

Previously PaintTimingDetector depended the painter not to paint
opacity:0 contents to avoid detect timing of them, which didn't work
for composited layers and CompositeAfterPaint where we always paint
opacity:0.

Bug: 957674
Change-Id: Ie5530f5a4c00d5e350b6dc2d1922f58e3953e7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106341
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751105}

OnBeforeTunnelRequest and OnTunnelHeadersReceived both drop their
H1 qualifiers and are now called during H2 and QUIC CONNECT proxy
tunnel setup.

Bug: 926427
Change-Id: Ia512f01bc592bfa5ca196d6c2aa0b8b5dcac479b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099294
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751104}

With this CL, the title during the successful IDLE state changes to
"Checked Passwords" (not added since it exists for the same context).

Also, the IDLE state shows "Check again" only if a check happened before
and defaults to "Check Passwords" if there hasn't been a check yet.
Without an initial check, we also show a different message and banner
and hide icon and subtitle.

Screenshots are in the linked bug.

Bug: 1062216
Change-Id: I484504fdb37e0043b553813ff51008085d58488f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106087
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751103}

AddInterface() uses base::BindRepeating, so the input object must be a
base::BindRepeating, and it seems that it can be called multiple times
based on the comment here:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/common/sandbox_status_extension_android.mojom;l=11

Similarly, CreateFunctionTemplate() receives a repeating callback, and
it is reasonable to allow getAndroidSandboxStatus to be called multiple
times.

Bug: 1007641
Change-Id: I3103b1e4ca8f5d6064c4b2c74d19cb9aad01fed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107705
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751102}