- 05 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6ed96d1c23b..f0c5950706c6 git log f6ed96d1c23b..f0c5950706c6 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9e9493f29dbf..c55fbc4064aa (16 commits) 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 126720bd2e57..a095711c5d77 (4 commits) 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2f96e324..7c474dc8 (439 commits) Created with: gclient setdep -r src/third_party/skia@f0c5950706c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ia3f1b67fc635583ce6a21608103534d4f3f233ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747159}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I6c2d3a4ce305ef0ab5bf0dc36bfff27093c9717f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087584Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#747158}
-
Maksim Sisov authored
The buildbot could not run weston as it could not find some libraries. The problem turned out to be that linker wasn't looking in the out/release directory for libraries because that directory isn't in LD_LIBRARY_PATH. TBR=thomasanderson@chromium.org Bug: 1029241 Change-Id: Iaf9d0004bf4834dcf208ce7f588308801af0861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087407Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#747157}
-
Jose Lopes authored
This callback is called from a while loop. It's run in: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179 which is called from: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=297 Another example. It's run in: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_mpeg1audio.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=196 which is called from: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: Id10660797cf181121e0c34c581edd300fa3e23e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080268Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#747156}
-
Colin Blundell authored
The only client of ExternalNavigationParams.getTab() is now ExternalNavigationDelegateImpl, and the only client that sets the Tab of the params is InterceptNavigationDelegateImpl. The latter sets the Tab of the params to its own ivar, which is the same object that it has passed to the ExternalNavigationDelegateImpl instance that it constructs via TabDelegateFactory.createExternalNavigationHandler(). Thus, ExternalNavigationDelegateImpl can simply use its own |mTab| ivar in place of ExternalNavigationParams.getTab(), as they refer to the same object. This CL also makes a minor change to the structure of ExternalNavigationDelegateImplTest.java to adjust for the production change. This change aids in the componentiation of ExternalNavigationHandler for sharing with WebLayer. Bug: 1031465 Change-Id: I0b79258555c63171ab61459187ad6303822a467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087671 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747155}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie37277969698e1bd2539e43f93fa4481e8f41b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747154}
-
Maksim Sisov authored
This change removes hard requirement on a wl_seat and allows to run Ozone/Wayland without that. This is required by 1) tests that will be run with headless weston 2) systems that run without any perihperial peripheral devices. TBR=spang@chromium.org Bug: 1029241 Change-Id: I9970052b3d6d593591eb93738d0b83218abd1353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088852Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#747153}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I4382d96bec21c7267c749b1bf9d6fb07b3218f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088954Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60abb5cb5d28..dcb8686f7685 Created with: gclient setdep -r src-internal@dcb8686f7685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia02c83006b3dc70f6012d7f1f522c4d2a740a6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747151}
-
Anqing Zhao authored
Before supporting a new json format for uploads.log file, it's worthy to extract the cleanup codes for CSV format to an independent method. It can improve the readability. Bug: 1040078 Change-Id: I661bf875f799a6d56875b890c22f1fb1730c8d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057763 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#747150}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 432677d1. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib30a3724aefd9d2ab85b58ed8b306b8fb99cf6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088692Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747149}
-
Eugene But authored
User Actions are added to Breadscrumbs (log attached to steps to reproduce). Logging the actions earler will include them into Breadcrumbs if presentation code crashes (like what happens in crbug.com/1050786). Bug: 1046231 Change-Id: I6cde3c11320d41135bbeffc9d4943d5b9645a293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087874 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747148}
-
Dana Fried authored
This is a continuation of the pattern of AnimatingLayoutManager::GetDefaultFlexRule(). Bug: 1048061 Change-Id: I0aaff55bea6c674b07b42abd4584092058b01df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040731 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#747147}
-
Nicholas Verne authored
These tests are an promised add on to https://chromium-review.googlesource.com/c/chromium/src/+/2084213 Bug: 1057899 Change-Id: I92f6f7a308df197a02e0b935c6d0627509b60761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087879 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#747146}
-
Alice Wang authored
This CL cleans the AccountManagerFacade.getGoogleAccounts usage in RequestGenerator. We should use this method when the error thrown is meaningful. Bug: 1057040 Change-Id: Ib6dbd625d20c6da4a231a25055333100e93bc844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080231Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747145}
-
Rainhard Findling authored
* Aligns the safety check UI with the latest strings in the mocks. * Adds links to the dynamic UI strings of safety check. Bug: 1015841 Change-Id: I32c94c9b454c089aac5bfb1751e314e9911bb228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085371Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747144}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Ic735aaff5e8692b406a2d41a9063c8422cc91143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088338Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#747143}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I484604e2a494dc32712b0b16ea1c011f58a403ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088359Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747142}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/35da12b1c3de..6cc841a97e38 git log 35da12b1c3de..6cc841a97e38 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6cc841a97e38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib1411c25fc1e113126829ba285af16432ae758a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747141}
-
Camillo Bruni authored
This might save some debug time if the out/Dir is configured in a non-compatible way. This applies particularly for the defaults out/Debug and out/Release when -t is not provided. Change-Id: I0f01811c87050f0bbff67208cd0016d9e0e7190e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087673 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#747140}
-
David Staessens authored
This CL fixes a member variable not being properly initialized in the video decoder tests before first using it. In practice this shouldn't have caused any bugs. TEST=./video_decode_accelerator_tests on hana BUG=None Change-Id: I9ff4cf8e8415322a78ccd66d699e86a47e191f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087854Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#747139}
-
David Staessens authored
This CL removes a dependency from the video decoder test environment build target that was mostly unused. Only video.h/cc are used, which are moved to the test helpers target so they can also be reused by the upcoming the video encoder tests. TEST=Built video_decode_accelerator_tests target BUG=None Change-Id: I2aa6590ceaca9af423a3ff0ba5bda0a4fae8b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087492Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#747138}
-
dpapad authored
This will enable migrating an HTML file to Polymer3, even before all of its dependencies have been migrated. Bug: 1026426 Change-Id: I455858a1f1866a9cab83556239ec075cac7f9ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088504Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747137}
-
Keita Suzuki authored
This commit adds an option in run_blink_websocketserver.py and run_web_test.py to support running websocket test server (pywebsocket) on python versions other than sys.executable. This enables blinkpy to run on python 2, while the websocket server runs on python 3. Change-Id: I4ff4e3ce8c50b075c70acba74caa0ccb8bd65023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044263 Commit-Queue: Keita Suzuki <suzukikeita@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#747136}
-
Austin Tankiang authored
Bug: 1049067 Change-Id: I40e6ddb338061f7f58563af48ef5203c133ba07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086384Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#747135}
-
Kenichi Ishibashi authored
This is a preparation for moving SpecialStoragePolicy out of ServiceWorkerStorage. We are planning to take an approach similar to crrev.com/c/1945940. ServiceWorkerRegistry will own SpecialStoragePolicy and observe policy changes. We will need to observe policy changes on the IO thread so we will add a method to ServiceWorkerRegistry which runs on the IO thread. For now, all methods in ServiceWorkerRegistry run on the core thread. This CL adds DCHECKs to annotate the fact explicitly. Bug: 1055677 Change-Id: I767296f045a6d3d454c25cdaf18587073a111209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087320Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747134}
-
Kent Tamura authored
Rename HTMLSelectElement::Popup() to PopupForTesting() because it is used only by testing code. This CL has no behavior changes. Bug: 1052232 Change-Id: I0c84297de59937b496c52dc974dabd9cd5508229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087325 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747133}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4044.25-1582542147-benchmark-82.0.4065.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I69e7af73ff639f240e3af15d504cbc9863d3c086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747132}
-
Chris Letnick authored
Mojo is designed to be asynchronous and for the user to not have to wait for and check connection states. Merge-With: eureka-internal/370252 Merge-With: eureka-internal/370569 Merge-With: eureka-internal/371453 Merge-With: nest-camera-internal/54520 Bug: internal 150158878 Test: Verified on device. Change-Id: Ibb4fd27f7bfbffa0b9c9c695c6593f5bdbd599c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086689 Commit-Queue: Chris Letnick <cletnick@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Chris Letnick <cletnick@google.com> Cr-Commit-Position: refs/heads/master@{#747131}
-
Jason Lin authored
Crostini terminal needs to know when a11y spoken feedback is on so that it can also turn on its a11y features. However, the SWA (system web app) terminal cannot access the "accessibilityFeatures" extension API because it does not support SWA. To fix this problem, we add a new function and an event to terminalPrivate API to allow the terminal to get and subscribe to a11y status. Bug: 1019034 Change-Id: Ief4a5edceed470eac8d5b85d72f4ae581ce2dcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086357 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#747130}
-
Luciano Pacheco authored
Force some tests to run without FilesNg because they depend on the breadcrumb and the new breadcrumb isn't 100% ready: - tabindex* - breadcrumbsNavigate - breadcrumbsLeafNoFocus - showMyFiles Other tests disabled for FilesNg were due to name conflicting when using EnableFilesNg() and without it, both getting the suffix _FilesNg, forced DisableFilesNg() to make it explicit and have no suffix. Bug: 992818 Change-Id: I3737dfdb5bcd46f5fd6952fc38346880950c86e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087880Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747129}
-
Keishi Hattori authored
Bug: 1058341 Change-Id: I6e94a95be6e09d33da4424a9e228b69386e43783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087240Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca204ee2e1ed..60abb5cb5d28 Created with: gclient setdep -r src-internal@60abb5cb5d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idbd88d3f11e43b3fdee29bbdacdecf433407ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747127}
-
Luciano Pacheco authored
Add test helper function that checks if the Files app is running with the flag on/off. Change context_menu.js test to not rely on the breadcrumb for navigation, to be it's compatible with/without FilesNg. Change tests checking to sorting icon to use different query selector depending if is running with/without FilesNg. Change grid_view.js to dismiss Drive welcome banner to be able to display all entries. Bug: 1035691, 992819, 992821, 992822, 992818 Change-Id: Ia7d54e8446a0bb1aaef241525d225ff479533b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087245 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747126}
-
Noel Gordon authored
The splitter button has no keyboard interaction so no need for it to receive tab focus. Tab focus from directorytree => to breadcrumb, is the behavior we want. Bug: 1002790, 992819 Change-Id: If41272a1edd903be36b858aed211083f2c6ebdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087204Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747125}
-
Chong Gu authored
Bug: 1058458 Change-Id: Ia1c62fefd1accf999031155a60e7a3493285a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088181Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#747124}
-
Luciano Pacheco authored
Bug: 1035691,992819,992821,992818 Change-Id: Ie560caf9f760e0baae734f7d9bcccdb9b73382df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087244 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747123}
-
Miguel Casas authored
This CL replaces the DRM specific XR30 with AR30 where appropriate, and adds the necessary entries to support AR30 with SCANOUT usage. This format started being supported with the recent Mesa uprev. Test: forcing BGRA_1010102 as DisplaySnapshot::PrimaryFormat, and allowing for only an opaque FB (ToT wants both opaque and normal) the primary plane of the device is indeed XR30 as per /sys/kernel/debug/dri/0/state). and gl_unittests --gtest_also_run_disabled_tests and ozone_gl_unittests --gtest_also_run_disabled_tests AR30 test cases passing. Bug: 949260 Change-Id: I852433d30a5243f682b7bb9b9e8bbb0184b1d4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068825 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747122}
-
Luciano Pacheco authored
This makes the tabindex integration tests failure message more obvious. The test is based on the id of elements receiving focus. Bug: 1035691, 992818 Change-Id: I72ebbeb35927cbfa07c246b6bdf4d0b20f4bc427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088971 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#747121}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/43c76d116441..2e60acad147c git log 43c76d116441..2e60acad147c --date=short --first-parent --format='%ad %ae %s' 2020-03-05 fmeawad@google.com [dashboard] Fix focus selection after onBlur Created with: gclient setdep -r src/third_party/catapult@2e60acad147c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058488 Tbr: wenbinzhang@google.com Change-Id: Ice93f5eb6182c5f15a6c4600a5ee845c9ea42628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747120}
-