GitLab

This CL also includes a few fixes for loading a WebUILoginView instance by itself without associated helper classes also being initialized.

There are three child CLs associated with this one:
- [1] contains fixes on the HTML side.
- [2] makes the lock screen show up correctly in the task manager.
- [3] preloads and reuses the WebUIScreenLocker instance (derived from WebUILoginView).

1: https://codereview.chromium.org/2555453003/
2: https://codereview.chromium.org/2550263002/
3: https://codereview.chromium.org/2553863002/

There is additional context at go/cros-lock-screen-optimization.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2512473004
Cr-Commit-Position: refs/heads/master@{#437942}

Most code that calls the UserGestureIndicator knows which thread it is
executing in. Calling isMainThread involves doing a thread id syscall which
can be quite slow, and there are places in the loading code that do this
in a tight loop (e.g. preloading resources).

This patch adds an optional argument to the indicator's static methods which
optionally allow callers to get the gesture state in a thread-safe way.

BUG=348655

Review-Url: https://codereview.chromium.org/2555013004
Cr-Commit-Position: refs/heads/master@{#437941}

This is the case for CronetSample.apk

BUG=none

Review-Url: https://codereview.chromium.org/2566293002
Cr-Commit-Position: refs/heads/master@{#437940}

AutoplayUmaHelperTest currently uses GMock for mock
AutoplayUmaHelper in order to check if events are correctly
received. However this will make the test flaky since
MockAutoplyUmaHelper is garbage-collected but GMock expect it to
be destroyed when the test finishes.

This CL marks MockAutoplayUmaHelper as AllowLeak which fixes the
issue.

BUG=672831

Review-Url: https://codereview.chromium.org/2562683004
Cr-Commit-Position: refs/heads/master@{#437939}

With no cursor in readonly editor, highlight disappears very fast and
it's impossible to say where it was.

BUG=670417

Review-Url: https://codereview.chromium.org/2574443003
Cr-Commit-Position: refs/heads/master@{#437938}

Split out from:
https://codereview.chromium.org/2559573002/

There is a downstream caller for one method, so will
land this first to allow a quicker patch time.

TBR=yusufo@chromium.org
BUG=671149

Review-Url: https://codereview.chromium.org/2565183005
Cr-Commit-Position: refs/heads/master@{#437937}

Stability and performance numbers from the current 50% GPU process enable rate
look good. Move on to the third experiment configuration in the associated bug,
to test performance impact of enabling the profiler for both GPU and browser
processes vs. enabling for neither process.

This CL deviates from the roll out percentages in the bug by performing the
experiment on 10% of launches rather than 50%. The experiment will be enabled
over the holiday period, so the lower percentage will provide enough data while
minimizing data volume differences for the browser process.

BUG=650869

Review-Url: https://codereview.chromium.org/2571483003
Cr-Commit-Position: refs/heads/master@{#437936}

The CNNIC whitelist was temporary, and only contained EE certs.

Remove the whitelist, fully distrusting CNNIC.

BUG=673083

Review-Url: https://codereview.chromium.org/2565743004
Cr-Commit-Position: refs/heads/master@{#437935}

BUG=none

Review-Url: https://codereview.chromium.org/2568993002
Cr-Commit-Position: refs/heads/master@{#437934}

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167

Review-Url: https://codereview.chromium.org/2561343002
Cr-Commit-Position: refs/heads/master@{#437933}

BUG=672852
TEST=No more content_unittests, events_unittests, and extensions_unittests failures on linux_chromium_tsan_rel_ng
Confirmed @ https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/377

Review-Url: https://codereview.chromium.org/2565893002
Cr-Commit-Position: refs/heads/master@{#437932}

Adds an optional header to DateDividedAdapter and adds a new layout
with a clear browsing data button and privacy disclaimers as a header
in the history ui.

BUG=654071

Review-Url: https://codereview.chromium.org/2562123003
Cr-Commit-Position: refs/heads/master@{#437931}

BUG=671459,671653

Review-Url: https://codereview.chromium.org/2569753002
Cr-Commit-Position: refs/heads/master@{#437930}

The intent can be saved by android and re-used for launching a child
service in edge cases. However the command line arguments are different
for each launch of the child process. The command line args are already
passed through an additional bundle through the aidl interface. So just
fallback to the aidl bundle and remove command line args from the intent
bundle.

Note this may and probably does decrease parallelism in child service
start up, thus causing a perf regression.

BUG=664341

Review-Url: https://codereview.chromium.org/2560403002
Cr-Commit-Position: refs/heads/master@{#437929}

We have no way of telling what changes beyond the first column break, so if we
cannot guarantee that the column height *is* and *was* non-uniform, we need to
re-lay out children that may stretch into the unknown.

Review-Url: https://codereview.chromium.org/2562273003
Cr-Commit-Position: refs/heads/master@{#437928}

SVGElement::calculateTransform would not compensate for effective zoom
on 'transform' for SVG <text> elements.
Refactor the code a bit so that the different parameter configurations
are selected first, and then use the same code for both <text> and non-
<text>. This makes sure that effective zoom is factored into the
computed transform for <text> as well.

BUG=665387,369942

Review-Url: https://codereview.chromium.org/2565403002
Cr-Commit-Position: refs/heads/master@{#437927}

Security state decoration is set to active when the WebsiteSettingsBubble is opened

BUG=588377

Review-Url: https://codereview.chromium.org/2538323003
Cr-Commit-Position: refs/heads/master@{#437926}

- $descendants for div's can be very expensive. For example, in Gmail, there is a focusable div that wraps almost the entire contents of the page. We end up generating Output for everything under the div and lag significantly when focus lands here.
Fix this by only taking the text content of divs as one large string.  $descendants had all output including rich formatting.
- live region output on alerts causes double output (and similar lag). For example, pressing '?' in Gmail triggers hundreds of runs inside of LiveRegion.
Fix this by ignoring live regions set on alert nodes.

TEST=navigate in Gmail.
BUG=672955
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563173002
Cr-Commit-Position: refs/heads/master@{#437925}

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=673207

Review-Url: https://codereview.chromium.org/2564343003
Cr-Commit-Position: refs/heads/master@{#437924}

MUST_SUPPRESS_TAP_ENDS state is added to TapSuppressionController. When
a tap end event causes to drop the stashed tap down, the controller goes
to the new state. This state shows that all following tap ends should
get suppressed till the end of the current touch sequence.

BUG=656434
TEST=TapSuppressionControllerTest.*SufficientlyLateTapUp

Review-Url: https://codereview.chromium.org/2542453003
Cr-Commit-Position: refs/heads/master@{#437923}

The test is flaky, and we picked up bad baselines in
https://crrev.com/f46247289db27ff645f76261186189a96115dde8

Reverting to the previous, correct results.

BUG=669643
TBR=liyuqian@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2573543002
Cr-Commit-Position: refs/heads/master@{#437922}

There's no reason to have it package-private, and this prevents sharing with
tests in other packages (e.g. org.chromium.net.urlconnection).

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2568213002
Cr-Commit-Position: refs/heads/master@{#437921}

see https://skia-review.googlesource.com/c/5844/

BUG=
NOTRY=True

Review-Url: https://codereview.chromium.org/2573623002
Cr-Commit-Position: refs/heads/master@{#437920}

Make it clear this is only used for LocalFrames.

Review-Url: https://codereview.chromium.org/2566893003
Cr-Commit-Position: refs/heads/master@{#437919}

If you try and run some tests by themselves they may fail because
the certificate files have not been extracted from the APK
assets.  Make sure the files are extracted before use.
Without this change some tests only pass because prior tests
have already extracted the files.  Tests should not be dependent
on other tests.

BUG=629299
R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2573483003
Cr-Commit-Position: refs/heads/master@{#437918}

exception_processor_unittest.mm:
error: null passed to a callee that requires a non-null argument

Review-Url: https://codereview.chromium.org/2565093002
Cr-Commit-Position: refs/heads/master@{#437917}

Revert of Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors (patchset #5 id:80001 of https://codereview.chromium.org/2567643003/ )

Reason for revert:
Turns out this issue is trivial to reproduce locally (I probably should have tried that first...) so diagnostic data from crash dumps isn't needed.

Original issue's description:
> Send crash dumps for odd ERR_CERT_DATE_INVALID cert errors
>
> Safe Browsing Extended Reporting reports show a number of certificate
> errors from Windows users where the certificate error is
> ERR_CERT_DATE_INVALID but the certificate chain appears to have
> perfectly valid dates.
>
> To get some diagnostic data from Canary, this CL calls
> DumpWithoutCrashing() when we observe such a chain. This CL is intended
> to be reverted after obtaining a few days of data from Canary.
>
> BUG=672906
>
> Committed: https://crrev.com/822fd5f5b3ab71603d34a376928bf05323abfd0b
> Cr-Commit-Position: refs/heads/master@{#437726}

TBR=rsleevi@chromium.org,wfh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672906

Review-Url: https://codereview.chromium.org/2572553002
Cr-Commit-Position: refs/heads/master@{#437916}

Some files include guards had not been fixed when the files were
upstreamed. Fix that.

BUG=None

Review-Url: https://codereview.chromium.org/2562403003
Cr-Commit-Position: refs/heads/master@{#437915}

Moved from package-private to public, but @hide.
Having it be package-private disallows having tests in another package.

BUG=629299
R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2564063002
Cr-Commit-Position: refs/heads/master@{#437914}

Wrapper tracing's been disabled, and the underlying bug will be fixed
before it's enabled again.

BUG=671791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2558043009
Cr-Commit-Position: refs/heads/master@{#437913}

This CL lands server change 141401937 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2566193002
Cr-Commit-Position: refs/heads/master@{#437912}

This test has been failing on the WebKit Linux bots today.

TBR=keishi@chromium.org

BUG=673463

Review-Url: https://codereview.chromium.org/2568273002 .
Cr-Commit-Position: refs/heads/master@{#437911}

Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled (patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )

Reason for revert:
This is believed to have increased the rate of failure for SupervisedUserContentProviderTest#testWithSupervisedUser on linux_android_rel_ng.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20%28with%20patch%29&builder=tryserver.chromium.android%3Alinux_android_rel_ng for dramatic increase in failure rate after this CL landed.

Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810

Original issue's description:
> Supervised Users: Create ResourceThrottle only if filtering is enabled
>
> Before this CL, we were creating a SupervisedUserResourceThrottle for
> each top-level navigation. If the current user isn't supervised, this is
> pointless. One side-effect was that we were recording
> ManagerUsers.Filter* histograms for all navigations, including for
> non-supervised users.
>
> This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> to true iff the user is supervised. This allows us to not create the
> resource throttle for regular users.
>
> BUG=671472
>
> Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> Cr-Commit-Position: refs/heads/master@{#437868}

TBR=bauerb@chromium.org,treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=671472

Review-Url: https://codereview.chromium.org/2568953002
Cr-Commit-Position: refs/heads/master@{#437910}

Otherwise it will not be running on ClusterFuzz.

TBR=geofflang@chromium.org, inferno@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2570493002
Cr-Commit-Position: refs/heads/master@{#437909}

https://pdfium.googlesource.com/pdfium.git/+log/6814f49aa839..9468639bc3c4

$ git log 6814f49aa..9468639bc --date=short --no-merges --format='%ad %ae %s'
2016-12-12 dsinclair Update ICU

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2567033002
Cr-Commit-Position: refs/heads/master@{#437908}

ResourcePrefetchPredictorBrowserTest.LearningJavascriptAppendChild was
detected to be flaky by chromium-try-flakes.

TBR=lizeb@chromium.org

BUG=673028

Review-Url: https://codereview.chromium.org/2564213002 .
Cr-Commit-Position: refs/heads/master@{#437907}

ResourceProvider knows if a resource has requested hints about
overlay promotion.  This CL closes the loop, allowing
ResourceProvider to notify a GLStreamTextureImage that's bound to
the resource's texture about the promotion hint.

This is supported only on Android.  The purpose is to let
AndroidVideoDecodeAccelerator figure out if video frames should be
backed by SurfaceTexture or SurfaceView.

BUG=671357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2559523002
Cr-Commit-Position: refs/heads/master@{#437906}

Fetch a warmup URL if data reduction proxy (DRP) is enabled. The fetching
of the warm up URL is disabled by default, and enabled only via the
field trial.

BUG=672334

Review-Url: https://codereview.chromium.org/2503273002
Cr-Commit-Position: refs/heads/master@{#437905}

The method RenderWidget::GetInputMethodController() can return nullptr in
the following cases:
1- RenderWidget is swapped out.
2- There is no focused frame in the local root which accepts IME.
  2.1 There are no focused local frames.
  2.2 The focused local frame does not belong to the same local root as RenderWidget.
  2.3 The focused local frame cannot accept IME since WebWidget is not focused (e.g., switched tabs).

Therefore, to handle set composition IPC we should not assume controller can
never be nullptr. A valid repro case:
1- Create an OOPIF in a page.
2- Add input in OOPIF.
3- Write javascript code which would randomly take focus away from OOPIF.
4- Activate some IME and start typing.

Eventually, DCHECK fires because the IPC to set composition arrived after
the widget lost the focused frame.

BUG=578168

Review-Url: https://codereview.chromium.org/2558303003
Cr-Commit-Position: refs/heads/master@{#437904}

Mark org.chromium.chrome.browser.payments.PaymentRequestIncompleteContactDetailsTest#testEditIncompleteContactAndCancel as flaky

BUG=673299
TBR=grt@chromium.org

Review-Url: https://codereview.chromium.org/2567023002
Cr-Commit-Position: refs/heads/master@{#437903}