GitLab

Change-Id: I9ec22adf47f6f1e15d0a055844ac4cd9e518f0ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341133
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796124}

This property is no longer needed since switching to vector icons.

Bug: None
Change-Id: I01e92a838c2bba16516b77f10572e3a9f7875fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219350
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796123}

Also switch to loading *.mojom.js from /gen/ instead of
resources/chromium in preparation for launching official MojoJS support
in WPT. This would not change the test results on Chromium waterfall
(everything should continue to pass) or upstream WPT (tests currently
fail because MojoJS isn't enabled).

Move web_tests/usb to web_tests/wpt_internal/webusb so that these tests
are served the same was as web_tests/external/wpt/webusb, making the
resource URLs consistent and saving a special case in the helper
function.

Finally, remove unused .mojom.js files from WPT.

Bug: 1094512
Change-Id: I75f3d1a7acf494e2c881c527618a496e907a9596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276999
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796122}

First step in migrating to a more flexible histogram naming syntax using
tokens and variants and instead of suffixes.

Changed one UMA histogram to using token instead of suffixes, and made
corresponding changes and tests in the model and extract_histograms.py.

Change-Id: I57c20d3c172f5d3e2742b1f3459fd4f7cacf848e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333508Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com>
Cr-Commit-Position: refs/heads/master@{#796121}

This CL extends the following histograms, which are expected to be
important when diagnosing a regression:
  SoftwareReporter.Cleaner.TimeToCompleteDownload
  SoftwareReporter.Cleaner.TimeToCompleteDownload_DownloadFailure
  SoftwareReporter.Cleaner.TimeToCompleteDownload_DownloadSuccess
  SoftwareReporter.Cleaner.TimeToCompleteDownload_NetworkError
  SoftwareReporter.FoundUwSReadError
  SoftwareReporter.FoundUwSReadError_ESET
  SoftwareReporter.FoundUwSReadError_URZA
  SoftwareReporter.LastUploadResult
  SoftwareReporter.MajorVersion
  SoftwareReporter.MajorVersion_ESET
  SoftwareReporter.MajorVersion_URZA
  SoftwareReporter.MinorVersion
  SoftwareReporter.MinorVersion_ESET
  SoftwareReporter.MinorVersion_URZA
  SoftwareReporter.MemoryUsed
  SoftwareReporter.MemoryUsed_ESET
  SoftwareReporter.MemoryUsed_URZA
  SoftwareReporter.RunningTimeAccordingToChrome
  SoftwareReporter.RunningTimeAccordingToChrome_ESET
  SoftwareReporter.RunningTimeAccordingToChrome_URZA

And marks the following as obsolete:
  SoftwareReporter.Cleaner.HasCompleted
  SoftwareReporter.Cleaner.Version
  SoftwareReporter.PromptDialog.TimeUntilDone
  SoftwareReporter.PromptDialog.TimeUntilDone_Accepted
  SoftwareReporter.PromptDialog.TimeUntilDone_Canceled
  SoftwareReporter.PromptDialog.TimeUntilDone_DetailsButtonClicked
  SoftwareReporter.PromptDialog.TimeUntilDone_Dismissed
  SoftwareReporter.ReporterSequenceResult
  SoftwareReporter.ReporterSequenceResult_Periodic
  SoftwareReporter.ReporterSequenceResult_UserInitiated
  SoftwareReporter.RunningTime
  SoftwareReporter.RunningTimeRegistryError
  SoftwareReporter.RunningTimeRegistryError_ESET
  SoftwareReporter.RunningTimeRegistryError_URZA
  SoftwareReporter.RunningTime_ESET
  SoftwareReporter.RunningTime_URZA
  SoftwareReporter.Step
  SoftwareReporter.Step_ESET
  SoftwareReporter.Step_URZA
  SoftwareReporter.UploadFailureCount
  SoftwareReporter.UploadLongestFailureRun
  SoftwareReporter.UploadSuccessCount

Fixed: 1066069

Change-Id: I03b62a4466a1a5939563a75774d68e1e6b48664b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311036
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796120}

Bug: 1098881
Change-Id: Ic1a9a78731c9cf7c4c939578a966233f4e187a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343144Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796119}

Hopefully this is the last one. Base on the latest 2 jobs:
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/736?
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/735?
These are the only left failing tests.

Bug: 1111979
Change-Id: I410c0ae964a224aea9b39057cbe0ec11bf914110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343493Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796118}

crrev.com/790723 changed the unsandboxed audio process to use
the kNoSandbox sandbox type instead of the kAudio sandbox type
with sandboxing disabled.
While this behavior was correct, it causes crashes in some
MSAN builds due to lack of initialization of localtime functions,
which occurred when using the kAudio sandbox type.

This CL ensures that the audio process in Linux initializes
localtime functions when running unsandboxed.

Bug: 1109346
Change-Id: I97c1b7cc01906cb544305e47de8c59bf73a7c899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341134Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796117}

Tested at
https://oyiptong.github.io/opentype.js/font-inspector-bytes.html

With chrome://flags/#font-access enabled.

Fixed: 1112552
Change-Id: If7bba29a96fa305d78cc55879b8dee6e88bae4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340073
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#796116}

This change replaces ExecuteScript with WaitForLoadStop, to remove
flakiness due to timeouts while waiting for ExecuteScript to return.
This change also removes flaky tests from NoTrustedTypesViolation test
which was causing crash due to problem in specific WebUI pages itself.

Bug: 1113504, 1114062, 1114066, 1114074
Change-Id: I3f638792240660caf4b257a201784e7865563e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342308
Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#796115}

See bugs for reasoning.

Bug: 1112384, 1112395, 1112396
Change-Id: Ie6d9213e57e56041c249198400bf3c8d397b43ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339756
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796114}

TBR: enga@chromium.org
Bug: 953991, None
Change-Id: If04a4cf37717cb50adca4325f205a7c2ac5d57f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343222Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796113}

It was already skipped for WebView in Issue 984734, but the
suppression needs to be expanded to non-WebView now, too.

Bug: 1061298, 984734
Change-Id: I0272ea39c528caf449c210cae53552612a36696b
Tbr: bsheedy@chromium.org
Tbr: dalecurtis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343574Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796112}

Change-Id: Ibf442be9a9eb59d0c0558ab97763a4fd589d8826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343220Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796111}

Update fieldtrial_testing_config.json to enable it in variation
tests. This is for rolling it out in the stable.

Bug: 1096677
Change-Id: Ie37c3ab339a59b591dda2907d46314c2d4f490c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342229
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796110}

The logic here is incorrect.

All four states below are valid:
- Google tts exists, Espeak exists
- Google tts doesn't exist, Espeak exists
- Google tts exists, Espeak doesn't exist
- Google tts doesn't exist, Espeak doesn't exist

In cases where the extension doesn't exist, the expectation is that this function loads the extension. If neither extension exists, both should be loaded.

R=lazyboy@chromium.org

Bug: none
Test: manual. Observe that this function is called sometimes when one extension exists, and the other doesn't. Verify both are always loaded after this call.

Change-Id: Icd8138700876bd7414dce0d2b27fb672fb5d0846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343567Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796109}

Fails consistently on Lollipop Phone Tester with TIMEOUT:
see e.g. https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26466

Bug: 1063984
Tbr: yusufo@chromium.org
Change-Id: Icedf0752d949f6d3ca3a5c08667e2fe20a023e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343546
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796108}

https://quiche.googlesource.com/quiche.git/+log/1b6221e157c7..db0253c93b9

$ git log 1b6221e15..db0253c93 --date=short --no-merges --format='%ad %ae %s'
2020-08-07 dschinazi Fix QUIC merge
2020-08-07 renjietang Move flow control config validation logic from QuicSession to individual QuicStream.
2020-08-07 vasilvv Make QuicTransportClientSession implement QuicCryptoClientStream::ProofHandler.
2020-08-07 fayang Add connection option NSLC to always send connection close for idle timeout. Protected by gfe2_reloadable_flag_quic_no_silent_close_for_idle_timeout.
2020-08-07 fayang Add two QUIC_CODE_COUNT for trimming full time wait list and remove expired connections.
2020-08-06 fayang Add srtt to TimeWaitConnectionInfo. Also add GFE_CODE_COUNT recording information when a packet is processed in time wait list. Logging only, not protected.
2020-08-06 danzh N/a(test only) override OnConnectionClosed() in MockQuicCryptoStream.
2020-08-06 fayang In QUIC, add TimeWaitConnectionInfo to record necessary information of connections which are going to be added to time wait list. Refactor only, no functional change expected, not protected.
2020-08-06 fayang In QUIC, add error code QUIC_SILENT_IDLE_TIMEOUT. Used when server silently close connection due to no network activity. The connection close packets would be serialized and will be sent by time wait list upon receiving client packets. Protected by gfe2_reloadable_flag_quic_add_silent_idle_timeout.
2020-08-06 haoyuewang Disable sending min_ack_delay in transport parameters on the client side. It is a no-op for google service and not flag protected.
2020-08-05 danzh (n/a) remove final specifier from QuicBatchWriterBase::Flush() interface.
2020-08-05 renjietang Move lengthy inline functions from headers file to the .cc file.
2020-08-05 renjietang Move kDefaultMaxUncompressedHeaderSize to http_constants.
2020-08-04 nharper Use trampoline for TicketCrypterGoogle3::Decrypt
2020-08-04 quiche-dev Add build option to third_party/http2. No functional change.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=renjietang@chromium.org

Change-Id: I545eb1872c0e53351365bd8ab67ed2206194bffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342143
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796107}

In crrev/c/1622415 a test.only() test was added to the suite which
prevented other tests from running.  This change replaces all the
occurrences with a regular test() and fixes the tests which have broken
since this was introduced.

Fixed: 1114252
Change-Id: Ife3dd9f4ce3a0e61c3f702d053d0304f43435aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343319
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796106}

This reverts commit 67a9b3fb.

Reason for revert: This seems to cause SEGV in R's init sometimes.

Original change's description:
> arc: Expand 3 more .prop files at runtime
> 
> ARCVM boards will have {system_ext,odm,product}_build.prop files in
> /usr/share/arcvm/properties. This CL let Chrome process these files
> in addition to the existing ones (default.prop, build.prop, and
> vendor_build.prop).
> 
> When processing the files, this files also let Chrome replace
> ro.<partition>.product.cpu.abilist* so that all abilist properties
> have a single consistent value regardless of the <partition>.
> 
> BUG=b:162555733,b:162024174
> TEST=components_unittests
> 
> Change-Id: I98e1a5118657b91171b63c6bcbe9f71d9d1fe6da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333580
> Commit-Queue: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Yury Khmel <khmel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#794771}

TBR=yusukes@chromium.org,khmel@google.com,khmel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b:162555733
Bug: b:162024174
Change-Id: I05510404e9fa5a77d67596e5843af3b4cb7182ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343322Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Auto-Submit: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796105}

Field trials show that this feature greatly improves body reading
performance at the cost of slightly slower following matches.  This
makes sense since the body reading is contending with the later match
operations.

Overall the data suggests this is a net win.  While we don't have a
metric that measures the entire lifecycle of a FetchEvent handled via
cache_storage, we can approximate it by adding the values from these
two UMAs together by percentile slice:

ServiceWorker.LoadTiming.Subresource.ResponseReceivedToCompleted2.CacheStorage
ServiceWorkerCache.Cache.Browser.Match.RelatedFetchEvent

Using this metric we see a 20% or greater progression in median time
to match+read a Response across all platforms.  In addition android saw
a 20% progression at P95.

Bug: 1010624
Change-Id: Id0a68727fe8dd49966988805135a1b03d46dea1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343592Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796104}

TBR=govind@chromium.org

Change-Id: I2f29ab529916670a2be084e132310a8f79f4bf48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343303Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796103}

This reverts commit 9f54bb86.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1114308

Original change's description:
> [Media Router] Add AppAvailability Logs
> 
> This CL adds a mojo::Remote<mojom::Logger> in CastAppDiscoveryService to
> log unavailable (app_id, sink_id) pairs and socket not found errors.
> 
> Bug: 687380, b/154273698
> Change-Id: Ib50c74cd9a0e66c9c05b3f36fdf653e2565d8048
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332329
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Commit-Queue: Muyao Xu <muyaoxu@google.com>
> Cr-Commit-Position: refs/heads/master@{#795981}

TBR=takumif@chromium.org,muyaoxu@google.com

Change-Id: I28d8206ee3b243ff82d210d561869e7eb4dc04e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 687380
Bug: b/154273698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343764Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796102}

https://skia.googlesource.com/skia.git/+log/3e8fae719358..63a1a8309814

2020-08-07 bungeman@google.com More verbose CoreText structure checks
2020-08-07 herb@google.com move SkArenaAlloc reset to its own class
2020-08-07 mtklein@google.com check SkPictureData::getPaint()
2020-08-07 johnstiles@google.com Revert "Disable the coverage-as-alpha optimization flag for the Bicubic effect."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1113444
Tbr: herb@google.com
Change-Id: I2d7f1bed56990e8caab174603a3cb2b722a9ec1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343530Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796101}

- ClearAll() now clears metadata, including consistency token
- ClearAll() changes are now all applied from within a task. This
  might prevent subtle bugs.

Bug: 1044139
Change-Id: I79087516e914da4705f41b162f27cecafdd38443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341808Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796100}

Refactors the computation of the AfterSRPMetrics class into a separate
method so that it can be called by the PLM Observer when a navigation
fails to commit.

Bug: 1106957
Change-Id: Iaf9cc055f16733f491a1408d6fbe1f4f808a8bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343485
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796099}

Change-Id: I65c83fb0b39f64f106c867e68e19cd9d22c10fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342642
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796098}

In offline_item_utils.cc, if is_auto_resumable is false, we set
the offline item state to INTERRUPTED.

As a result, when push the UI, interrupted offline items should have
isAutoResumable set to false.

BUG=1098273

Change-Id: I59af7b4451d9c7b27505aab2785e2a6347916d55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343219Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796097}

Lacros needs to support two notification pathways:
* In-process, for the ash-chrome binary
* Out-of-process, for the lacros-chrome binary

However, both of these pathways have some shared behavior around
handling multiple profiles (for the pre-lacros ash case) and transient
notifications. This code lives in NotificationPlatformBridgeChromeOs
and we want to reuse it.

1. Introduce MessageCenterClientLacros. This is a stub for now. In
   a follow-up CL it will send notifications over mojo from lacros
   to ash.
2. Change NotificationPlatformBridgeChromeOs so it supports different
   |impl_| helpers for ash and lacros.
3. Refactor ChromeAshMessageCenterClient to inherit from
   NotificationPlatformBridge. This allows NPBChromeOs to have a
   generic |impl_| for both helpers, and avoids introducing a new
   abstract interface class.

See go/lacros-notifications for overall plan.

Bug: 1113889
Test: existing unit_tests and browser_tests
Change-Id: I159f410f3d84cc6e9bde0b3757015691f2289419
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343217Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796096}

https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..a4cba6578f09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I4f1d2194a229e438247b3b41d743f94f5a9de9de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343489Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796095}

https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..a4cba6578f09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5609083d3e87d9831848ca5c5911841401c1675c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343595Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796094}

Currently PaintInvalidator iterates all block fragments with one context
for each LayoutObject, so we should create ContainingBlockScope only once
for the first fragment only. Previously creating multiple
ContainingBlockScopes for one multi-block-fragment object broke stacking
of the scopes, causing memory corruption.

Add check in ~ContainingBlockScope for stacking error in the scopes.

This limitation will be removed with LayoutNGFragmentTraversal which
traverses block fragments in depth-first order.

Bug: 1113710
Change-Id: I07aa3626f1a1d34714459e256880a96897585d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339449Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796093}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: I02e35892e8d6b6b0425a273366ef8aa92a7a6a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343529Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796092}

Change Graphics.Smoothness.FrameSequenceLength.* to only report the length for the effective thread.

This change modifies all of the Graphics.Smoothness.FrameSequenceLength.* metrics to only report the length for the effective thread.

Bug: 1101497
Change-Id: I5397d8fcdc8bd82b0a142e35dec7803d2c2a5c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319786
Commit-Queue: Matthew Crabill <macrabil@microsoft.com>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796091}

Menu traversal handles up/down arrow keys as expected. But if the user
is holding down VKEY_COMMAND while pressing up/down arrows, menu
traversal does not occur. In this case, the ui::KeyboardCode received by
MenuController is actually VKEY_NEXT and VKEY_PRIOR which were
previously unhandled.

For an upcoming Chrome OS feature, a menu may be shown while holding
down VKEY_COMMAND, and we want to allow the user to continue to hold
down VKEY_COMMAND throughout their entire menu iteraction.

NOTE: Pressing down and up arrows while holding down VKEY_COMMAND moves
ChromeVox focus on Chrome OS. I confirmed that *prior* to this change,
ChromeVox did *not* appear to traverse menus but after this change it
does.

Bug: 1113035
Change-Id: I9df923d0972102542e69fa92c39eda711346b88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338918
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796090}

This CL adds the CaptureModeBarView which is the content
view of the CaptureModeBarWidget.

It also adds the CaptureModeSession which owns the widget
and remains alive as long as capture mode is active.

BUG=1112919
TEST=Manually, added new tests in capture_mode_unittests.cc

Change-Id: I36b5b5f2cb147c36aa66f5d889c55865345463a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339902
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796089}

To be technically accurate, we should not describe this option as
"anonymous"; it's actually properly described as "de-identified".
However, "de-identified" is a bit technical, so change to a more clear
string.

BUG=chromium:1112012
TEST=Deploy to DUT and verify dialog option is as expected

Change-Id: I41abf1ca9ec04bc6518a2c085d86f8c29db83a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340522Reviewed-by: Greg Levin <glevin@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796088}

Fix the code to use WebApp.Launcher.LaunchResult and
WebApp.Launcher.UpdateResult to match the ones in histograms.xml

Bug: none
Change-Id: Iece91aa20d3614ff2d711d7c765ec0837a63c23f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341845
Commit-Queue: Phillis Tang <phillis@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796087}

https://android.googlesource.com/platform/external/perfetto.git/+log/0c0349252934..a4cba6578f09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I9736cff2e080973864459305913ab08c496b860c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343590Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796086}

This is a reland of af2e1e93

Original change's description:
> [Screenshot] Enable image editor for canary builds.
> 
> Bug: 1024586
> Change-Id: I586d8dc0a05c0aab3776b42c9145d0f6a586c1f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032505
> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
> Reviewed-by: Kristi Park <kristipark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#793791}

Bug: 1024586
Change-Id: Iaa640531a8190fc0c1bebcc05990330283327e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342125Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796085}