- 12 Aug, 2020 40 commits
-
-
Aya ElAttar authored
- This CL is based on dpapapd@ comments on crrev.com/c/2098906 - Moved ChromeURLDisabledUI to a separate folder under webui/chromeos directory. Change-Id: I17a3ab761b91a05af00d6c6db5e9d857d7ba488b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349708Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797391}
-
Ilya Nikolaevskiy authored
Bug: chromium:1112391 Change-Id: Ic02acc66b236d6f376e8593c490066c61c7eff0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351830 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797390}
-
Chris Harrelson authored
When this flag is on, we will use GeometryMapper for overlap testing and squashing sparsity tests. This code will be rolled out via a Finch experiment in order to estimate its impact on performance. Bug: 1115577 Change-Id: I42d29d1e25d8d4df9ea1410af3203342c3242040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343675 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797389}
-
Swapnil authored
When the browser is shutdown, we start destroying the objects. In ExtensionInstallEventLogManger, we used to destroy |logger_| after the |extension_log_upload_| pointer. This could cause to a crash because we try add a LOGOUT event before the shutdown. And while adding the LOGOUT event, ExtensionInstallEventLogManager::Add method is invoked which posts a task to invoke InstallEventLogManagerBase::LogUpload::OnLogChange. Thus we should destroy the |extension_log_upload_| pointer after destroying the |logger_| pointer so that we add the LOGOUT event and prevent the crash. Similarly, this should be fixed for ARC++ reporting. Bug: 1114191 Change-Id: I6e88f5747b6a5b7a36e1dcee3083204833c9aeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346306Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#797388}
-
Brian Sheedy authored
Removes the special casing that was recently added to the GPU context loss pixel tests, as we have confirmed that the tests otherwise pass if not for the expected crash check. Bug: 1061298 Change-Id: I00ec5ec7034a68025b505a28f69c852ad304de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353049 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797387}
-
Bo Liu authored
RenderProcessHost::Shutdown does not go through fast shutdown, but does go through RenderProcessHostImpl::ProcessDied. This ends up being recorded as out of memory kill on Android. Add RenderProcessHost::ShutdownRequested, and plumb it to where ProcessedCrashCounts is recorded. Then record a count of how much this would affect the OOM metric if it's taken into account. Bug: 1115517 Change-Id: I43ac22e4dfcc2ff0c23423355817420b2a5aa5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351170Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797386}
-
Becca Hughes authored
Change-Id: I63b64b85cd4c9b42bef2a3f1518d79d573e9131f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352514Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797385}
-
Becca Hughes authored
BUG=1053599 Change-Id: I9dbe1a011579fb3e7f8cf9b99a85b97bda5bb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341935 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#797384}
-
Peter Kasting authored
No intended behavior change. Not a complete list, just changing a few places I was already touching. Bug: none Change-Id: I53b652722671366803a5e6b76fec7b1c41c3cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345509 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797383}
-
James Hawkins authored
Networking components have a lot of dependencies that need to be in place for testing, so use internet-config-dialog as the host instead of OS Settings. Note that ideally this would not be required for testing, but with Polymer2 going away soon, it's not worth building more infra to support this case. R=khorimoto@chromium.org Bug: none Test: none Change-Id: I06ca337eb0c18e362d91d8ddee81ffe2707dd0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352551Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#797382}
-
Xinghui Lu authored
Bug: 1097310 Change-Id: Iac117bddb711cbd493c05e8a86a40ca8d00f0130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353090Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797381}
-
Brian Sheedy authored
Switches the GPU experimental Linux NVIDIA builder to trigger tests on the new machines running GTX 1660 GPUs. Submitting with no-try since the only failures are crbug.com/1115172. No-Try: true Bug: 1042292, 1115314 Change-Id: I800f38e1bde84b156d8abfb05ae8816e66b36f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797380}
-
Shimi Zhang authored
Bug: None Change-Id: Iaa4911dc743216c9fde6d44b3677e6d0951b64a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350246 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797379}
-
K. Moon authored
Adds a "PdfPartialLoading" feature to control whether or not the PDF viewer tries to use partial loading. The default state is enabled, as this feature has shipped already, but we would like to experiment with disabling it to address certain problems related to partial loading. Bug: 1115149 Change-Id: Ie66fddf5b633269226bc01fca20ac7013f0c1e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349429 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797378}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7b09c4c3acf..a465e2e30890 2020-08-12 mtklein@google.com add SKPath::readFromMemory() fuzzer 2020-08-12 robertphillips@google.com Reenable the small path renderer on the DDL1 bots 2020-08-12 jvanverth@google.com Switch GN defs on Mac and iOS to use frameworks, take 3 2020-08-12 bungeman@google.com Avoid copy of SkImageInfo in HeapAllocator::allocPixelRef 2020-08-12 brianosman@google.com Reland "Add inline threshold to SkSL::Program::Settings" 2020-08-12 johnstiles@google.com Fix AutoDisableInline to avoid re-enabling inlining. 2020-08-12 robertphillips@google.com Allow small path renderer usage in DDL recordings 2020-08-12 johnstiles@google.com Revert "Guard dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." 2020-08-12 johnstiles@google.com Revert "Remove dumpInfo() entirely when GR_TEST_UTILS is off." 2020-08-12 johnstiles@google.com Revert "Guard gencode dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: I76ab27318eae7db9b358297e830c942029e3a71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797377}
-
wutao authored
Bug: b/163417826 Test: manual Change-Id: I970a36f4d98e5fccd435b8a9b5131da2e030f06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349984 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797376}
-
Mohamed Heikal authored
Internal checkouts can use a different protocol buffers and runtime, thus use variables to refer to them so they could be changed based on your checkout. TBR=# noop change to proto runtime target name Bug: 1114836 Change-Id: I564b5f7bfa65ff549c335766c26b2d1dd07241fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346861 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797375}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idbe07418af1f0d55096c919755c9adece4ff5c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352515Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#797374}
-
Cathy Li authored
This reverts commit d6d62019. Reason for revert: We want to keep control over the margins from the Chrome side. Original change's description: > [Feed V2] Update margins to render the external surface cards correctly. > > Bug: 1106425, b/161142289 > Change-Id: If3c89644289b6eb1d5b61f6680f03bf95e3b6888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303172 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789547} TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106425 Bug: b/161142289 Change-Id: I5b01fbb8167caaa027a9d7423c1272d66c35a56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347220Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#797373}
-
Omer Katz authored
Epoch based metrics will rely on "forced" tag (currently we wrongly account event that should be forced as non-forced) and a unique epoch id. Bug: 986235 Change-Id: I3156eecf7e4dcca12a9d2f11ea82b380ded46f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351918 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#797372}
-
Juliet Levesque authored
Change display of HTTP request/response dictionaries and contact data to have indentation maintained. Change-Id: I9134dab98f8e79fac3e6fd40c4dc0c14f63fab2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350242Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#797371}
-
Adam Rice authored
In February 2020 many web tests were timing out on the Fuchsia bots. The underlying issue appears to be fixed (see https://bugs.chromium.org/p/chromium/issues/detail?id=1055553#c58), so re-enable them. BUG=1057020,1056022 Change-Id: I45d74e7502ad6d8ff82b665ea4bc5d55bfd5e420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266592Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#797370}
-
Chris Sharp authored
Also fix the mappings to actually appear when viewing the doc as markdown. Change-Id: Ie68a1651a95b2876dcea1fe31a7aea54c872d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350250Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#797369}
-
Ken Rockot authored
In preparation for reusing most of this thing within the Storage Service process, this moves SandboxedVfs into //sql and abstracts out the few Blink-specific dependencies into a small delegate interface. Bug: 1052045 Change-Id: I947611c63060446692c7f78b4f555b9f90994842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351159 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#797368}
-
Tomasz Wiszkowski authored
Bug: 1085184 Change-Id: Idcaa9416a06fa8f08ab52aeb4c9ab89b4a4e94fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347406Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#797367}
-
Yusuke Sato authored
BUG=None TEST=None Change-Id: Iffca1cb97e79d336a3b41bdbefdf441f98cca6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350237Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797366}
-
Marc Treib authored
This CL adds the plumbing in ConsentAuditor[Impl] to record this new type of consent, and the corresponding sync proto messages. It's not used so far; that will follow in another CL. Bug: 1111252 Change-Id: Ib528273e88bfbd6546e6d1fc26c0884fef1e6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351923 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#797365}
-
Michael Crouse authored
This addresses attempting to clear a nonexistent blocklist on history clear. This also adds a nullptr check for the HintsAgent before determining if a hint is available. Bug: 1115360,1115362 Change-Id: I2513c966d5a81eedd260363c28e328e97e08cab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351372 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797364}
-
Stephen McGruer authored
This reverts commit af7117b8. Reason for revert: Tentative revert as suspect of https://crbug.com/1115630 . Will monitor + re-land if this doesn't fix the bot (with my apologies :)) Original change's description: > Remove refcount thrashes of value in setAttribute. > > This removes the refcount thrashes in Element::setAttribute() avoiding > nearly 13% of regression in blink_perf.bindings set-attribute.html story > when StringImpl is made threadsafe. > > Bug: 1083392 > Change-Id: Ia5fe7193c24ae8baa4f16a21a2a79f80e7dc0b5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797240} TBR=ajwong@chromium.org,jbroman@chromium.org Change-Id: I672f63ec54742db85ee1f699849eac24806d9af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353115Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797363}
-
Mark Pearson authored
Change-Id: I7e365794b24f3ca6879114371e6ce500d0ccd2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350142 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797362}
-
evliu authored
This CL updates the SODA component to be platform-specific. Bug: 1033227 Change-Id: I41bd61affc673b38d6029c83a3b7468121dc8c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348015Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#797361}
-
Yuwei Huang authored
The Chromoting team was the owner of //third_party/grpc, as we first introduced the gRPC dependency in Chromium. However, we have recently migrated our app from using gRPC to just using plain Protobuf requests over HTTP due to some network security concerns and the burden of maintaining the dependency in Chromium third_party. It appears that chromecast and libassistant is currently the only other users of //third_party/grpc. As previously discussed in the email and code review comments, this CL transfers the ownership of //third_party/grpc to chromecast and libassistant. Bug: 1103416 Change-Id: I07ae66ab05b7fc57d3b4fc3e6222585dacbad530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350189 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#797360}
-
Etienne Pierre-doray authored
Add JobHandle::IsComplete and pass worker_count as argument to max_concurrency_callback. To make better use of worker_lock, and accommodate worklist use case by exposing worker count: - worker_count is used in max_concurrency_callback in cases where the return value is inferred from it. In the worklist case, each active worker keep a local segment not visible globally, so worker_count is added to the global queue size. - IsComplete is used to make sure that no work is pending. In the worklist case, checking that we're done involves checking that the global queue is empty AND that worker_count == 0 (atomically), which is a lot easier when |worker_lock| is taken. This is used e.g. in marking to switch phase (we don't want to cancel or join) where we stop creating work. Bug: 1114823 Change-Id: I5efc5622aa70e731981a958a066ab56567c603ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304972Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797359}
-
James Long authored
Two features have been added to the filter list: * Entries in the class filter list now have the package displayed below them in a smaller, lighter font. * A "delist unchecked" button has been added to the filter list, allowing users to quickly delist multiple elements. Bug: 1102546 Change-Id: I0815c789b6a11b657685ade4b0a1dea193c74e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350800 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797358}
-
Elly Fong-Jones authored
Bug: 1046784 Change-Id: I7d9cb3b6cfdc44227d48764059cba366d3ab59ec Tbr: dgozman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346972 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797357}
-
Rohit Agarwal authored
This CL changes the CCT overflow menu as follows: 1. The top action icon buttons in the toolbar would be always fixed i.e non customisable to: a) Forward b) Page Info c) Refresh only d) Bookmarks 2. The menu items in the toolbar would be always fixed i.e non customisable to: a) Find in page b) Desktop site c) Translate d) Share (this would be hidden by default, unless specified.) This CL also adds instrumentation tests and refactors some code out from CustomTabActivityTest to CustomTabsTestUtils which was needed to avoid duplication in the CustomTabActivityIncognitoTest. Bug: 1104180 Change-Id: I6c3d44cd3a32b7437a67bac0c66f894e4d2d62ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338935 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797356}
-
Sam Fortiner authored
This feature is enabled by default for m85 builds and is on at 100% via finch for m84. There is no need for this feature flag any further in m86+ builds. Bug: 1058987 Change-Id: Ic210d55596cbacfaef928824b470e878a8132a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349968Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797355}
-
Xiaohan Wang authored
Use //media/OWNERS instead of videostack-eng. Change-Id: I78b14cc17159383df9af51ce3c1ffc02008d770c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352690Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797354}
-
Rune Lillesveen authored
We computed ::first-line style to figure out if we needed to paint invalidate for ::first-line. Instead just use the cached style, and if the ::first-line style is null and we need the image for ::first-line, other mechanisms should have marked necessary bits dirty for ::first-line in the first place. This fixes a crash when active style is not up-to-date when ImageChanged is called for a LayoutBlock with ::first-line. Bug: 1115377 Change-Id: I8039bc67ddafc142fdc7582526a8ef623bbd1e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352890Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797353}
-
Brandon Jones authored
The extensions attribute is a recent addition to the GPUDevice. Additionally, according to the WebGPU spec the name for the BC compressed texture extension should be "texture-compression-bc", while Blink had it exposed as "textureCompressionBC". Bug: 996713 Change-Id: I30e48a0ec4f8e3a3e492a96f2343f27b78d7d59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350123 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797352}
-