Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 03 Sep, 2020 32 commits
  3. 02 Sep, 2020 8 commits
    • Liquan (Max) Gu's avatar
      Revert "[PRImpl] PaymentRequestImpl retains the values it needs" · b7bb401a
      Liquan (Max) Gu authored 
      This reverts commit 00d4ff28.

Reason for revert: the waterfall fails to build.

Original change's description:
> [PRImpl] PaymentRequestImpl retains the values it needs
> 
> Context:
> CL[1] moved some PRImpl's parameters it needed into CPRImpl, and
> retrieved them from CPRImpl when PRImpl needs it. This is problematic,
> because PRImpl could outlive CPRImpl, and so doing it could cause
> NullPointerError (see the bug). This CL partially reverts CL[1] but
> keeps the changes of the constructor signature because this is more
> succinct than passing each one of the parameters. Since CPRImpl would
> take over the PRImpl logic going forwards, passing only CPRImpl would
> avoid the frequent change of the PRImpl constructor's signature.
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/2357630
> 
> Change:
> * Before: CPRImpl retains the values that PRImpl need; after: PRImpl
> keeps a reference of the value that itself needs
> * Added a few null check or assert for mComponentPaymentRequestImpl
> in case it's used after release.
> 
> Bug: 1122148
> 
> Change-Id: I00ac6e4ca3fccccd114132209465757f52fa0dc9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378538
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803902}

TBR=danyao@chromium.org,maxlg@chromium.org

Change-Id: Ia852083d85d574b8d37f6b8a11f0fd1fee1957c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391904Reviewed-by: default avatarLiquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803990}
      b7bb401a
    • Liquan (Max) Gu's avatar
      Revert "[PRImpl] Remove OnDoneCreatingPaymentApps() from PRImpl#initAndValidate()" · 4a073e10
      Liquan (Max) Gu authored 
      This reverts commit 1bdd8df6.

Reason for revert: the waterfall fails to build.

Original change's description:
> [PRImpl] Remove OnDoneCreatingPaymentApps() from PRImpl#initAndValidate()
> 
> Context:
> PaymentRequestImpl#initAndValidate() depends on
> OnDoneCreatingPaymentApps() which unnecessarily depends on a lot of
> PRImpl's members. It's error-prone and make it hard for PRSpec to
> implement the PaymentRequestParams interface. So I write this CL to
> remove initAndValidate()'s dependency on OnDoneCreatingPaymentApps().
> 
> Change:
> * initAndValidate() no longer depends on OnDoneCreatingPaymentApps()
> * When origin is unsafe: BEFORE PRImpl#initAndValidate()
> ended early but not close the mojo pipeline. AFTER: when origin is
> unsafe, PRImpl#initAndValidate() ends early and close the mojo
> pipeline.
> * When origin is unsafe: it's the blink PR (after) instead of PRImpl
> (before) rejects promise for the subsequent calls of show(), return
> false for canMakePayment(), hasEnrolledInstrument().
> * Update the documentation on payment_request.mojom, changed
> because the asynchronous nature of the Mojo IPC is an important design
> consideration. Making it explicit can make future change less
> error-prone.
> * CanMakePaymentQuery.java is changed because
> PaymentRequestImpl#mQueryForQuotachange's change makes the 'query'
> parameter not nullable.
> 
> Bug: 978471, 1102522
> 
> Change-Id: I367a7df795fb87ea0f79649d405f7fd6be65694e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372888
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803982}

TBR=kenrb@chromium.org,rouslan@chromium.org,dpranke@google.com,maxlg@chromium.org

Change-Id: I1706ac06e87251df193d80214c3bfc2c19a2825a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 978471
Bug: 1102522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391598Reviewed-by: default avatarLiquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803989}
      4a073e10
    • Liquan (Max) Gu's avatar
      Revert "[PRImpl] Not to assert getCertificateChain" · 91ca5fac
      Liquan (Max) Gu authored 
      This reverts commit a5cc0feb.

Reason for revert: the waterfall still fails to build.

Original change's description:
> [PRImpl] Not to assert getCertificateChain
> 
> Since  mCertificateChain is provided by CertificateChainHelper,
> PaymentRequestImpl should not assert its existence.
> 
> Bug: 1122148
> 
> Change-Id: I48b8ec4c6559bd3a95596d90fc2cf670ad167f87
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391725
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803986}

TBR=estade@chromium.org,maxlg@chromium.org

Change-Id: I2e52f57fd63dbab112a2d127414e333329ee7909
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1122148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391901Reviewed-by: default avatarLiquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803988}
      91ca5fac
    • Dana Fried's avatar
      [Build Sheriff] Disable flaky test on certain Mac builds. · e51dbf2b
      Dana Fried authored 
      Disables Blink test:
external/wpt/pointerevents/compat/pointerevent_mouse-pointer-preventdefault.html

No-Tree-Checks: true
TBR: liviutinta@chromium.org
Bug: 1124378
Change-Id: I295122b3f5136cc03eada8541b32ead3121c346b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391386
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: default avatarDana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803987}
      e51dbf2b
    • Liquan (Max) Gu's avatar
      [PRImpl] Not to assert getCertificateChain · a5cc0feb
      Liquan (Max) Gu authored 
      Since  mCertificateChain is provided by CertificateChainHelper,
PaymentRequestImpl should not assert its existence.

Bug: 1122148

Change-Id: I48b8ec4c6559bd3a95596d90fc2cf670ad167f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391725Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803986}
      a5cc0feb
    • Sean McAllister's avatar
      Refactor OS_LINUX preprocessor directive for LaCrOS effort. · ab857352
      Sean McAllister authored 
      Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/test/data/webui/settings

This CL was uploaded by git cl split.

R=dschuyler@chromium.org

Bug: 1110266
Change-Id: I3f47d833cdd11223ffad0240c2b815a80e4d0506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370287Reviewed-by: default avatardpapad <dpapad@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803985}
      ab857352
    • Brian Liu Xu's avatar
      Dismiss tooltips from web content when web content is occluded or hidden · 3be76f04
      Brian Liu Xu authored 
      Hides tooltips from web content when the Chrome_RenderWidgetHostHWND is
being reparented on Windows.

Normally, mouse input messages over the Chrome_RenderWidgetHostHWND are
forwarded to the host window, where they are processed as events and
used by the tooltip controller to manage tooltip visibility.

However, when the legacy Chrome_RenderWidgetHostHWND is hidden or
occluded, it is reparented to a global hidden window, and messages are
no longer forwarded to the host window. If a WM_MOUSELEAVE message did
not arrive before this happens, the tooltip controller would not handle
it, and any open tooltips would stay open. Thus, we must explicitly
close tooltips during this reparenting step.

Bug: 724538
Change-Id: I4e4273ed451ff97c49b146e6b0499db3951baf88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242951Reviewed-by: default avatarScott Violet <sky@chromium.org>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#803984}
      3be76f04
    • Dana Fried's avatar
      Ignore test that times out on MSAN · 115bb20e
      Dana Fried authored 
      See attached bug.

TBR: rouslan@chromium.org
Bug: 1115091
Change-Id: I54a433ed5ce6321df2d906fa55584ed51ca55365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391607Reviewed-by: default avatarDana Fried <dfried@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803983}
      115bb20e