- 19 Jan, 2021 40 commits
-
-
Sigurður Ásgeirsson authored
This reverts commit 5fce665c. Reason for revert: https://crbug.com/1168113 Original change's description: > PM: Enable service worker relationships in graph. > > Bug: 1143281 > Change-Id: Ibc54e560a2a2a5f38c6ef48c7352c40c1b82109c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636273 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844550} TBR=pmonette@chromium.org,siggi@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143281,1168113 Change-Id: Ie84eef7095d735bd4e8b4e0d7fb097b20419a0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637266Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844933}
-
Garrett Beaty authored
The cores for the android CQ builders were recently doubled because they were long poles and it significantly improved the build execution time. However, on the branches where the machines are builderless, there are not currently builderlss machines with the doubled core count. This will use the old value for the branches to get CQ runs unblocked. (cherry picked from commit cd2034ee10fc3062749172582f6d57df6710b7ab) Change-Id: I904056c92b8b7be8ccfdfacdc31d052b21c553df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638094 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4389@{#10} Cr-Original-Branched-From: 9251c5db-refs/heads/master@{#843830} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638443 Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844932}
-
chrome://flagDale Curtis authored
Per discussion with the ChromeOS product team, they'd like to remove these low usage codecs. We'll start by putting them behind a flag that users can disable if they need an escape hatch. sweyn@ will identify an appropriate locale to notify users that these are being deprecated. Bug: 1167327 Change-Id: Ib4f59dba02a4a431ce9a883257c50bc4f9459c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634063 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844931}
-
Patrick Noland authored
This removal also lets us remove setUrlFocusChangeInProgress. As a replacement, SearchActivity makes itself a url focus change listener and uses the new LocationBarCoordinator#setUrlFocusChangeInProgress method to call setUrlFocusChangeInProgress(false) in the scenarios where SALBL used to do so. Change-Id: I25259c2d28e99d6404590ac4e15d158254722ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597221 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844930}
-
Javier Ernesto Flores Robles authored
This CL applies the BVCContainer transforms directly to it instead of BVC applying them to its superview. Previous approach had a race condition where in some cases the BVC was already removed from it's container leaving the BVCContainer in the previous state. It also contains a few readability fixes in the involved methods. Bug: 1164978 Change-Id: I6e6cce85dca0478a062f04f7ba93aba14a051d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629968Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844929}
-
Mei Liang authored
TabContext listens to TabObserver#didFirstVisuallyNonEmptyPaint to invalidate the existing suggestion and fetch new suggestions. This CL ensures #didFirstVisuallyNonEmptyPaint is being notified only once before entering tab switcher. Bug: 1161272 Change-Id: Ic8a2410a68b116803c9f857bb7321a6a845c5ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626105Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844928}
-
Glenn Hartmann authored
These are all long-lived metrics that will be relevant for the foreseeable future. BUG=1160721,1160761,1160763,1160762,1160764 Change-Id: Ieead4c86ad04638c18065a3b476dd911afc85cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636275 Auto-Submit: Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844927}
-
Yuki Shiino authored
NULL is obsolete and doesn't work with the upcoming CheckedPtr, so rewrites NULL to nullptr. Change-Id: If1e2a15c95611157317aac48176d1cdbf3f23251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633487Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844926}
-
Patrick Noland authored
To enable this, onClick for the delete and mic buttons is now implemented by LBMediator This extraction lets us: * Implement updateMicButtonState in LBMediator * Remove LBLayout methods: getVoiceRecognitionHandler, onWindowVisibilityChanged, getWindowAndroid, and setVoiceRecognitionHandlerForTesting Since SearchActivityLocationBarLayout used LBL's VoiceRecognitionHandler, we need to refactor the methods that do this to take one as an argument. Doing so is straightforward. Finally, some WindowAndroid methods are made non-final to allow them to be mocked in unit tests. Bug: 1147581 Change-Id: I54a6ba9b36b7a9991793b0f9d52a163e0b362bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596424 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844925}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d1002c96edb..7bcb61f96b8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com,xidachen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063426,chromium:1138733,chromium:1150968,chromium:1151505,chromium:1155587,chromium:1162319,chromium:1164866,chromium:1166356,chromium:783819 Tbr: dbertoni@google.com,xidachen@google.com Change-Id: I3af28bc78f79cb18353f90c36ead8db058cbe8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844924}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I2fffe5a69d13fec291795466da84d143c6d56005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629708 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#844923}
-
Sven Zheng authored
Bug: 1166113 Change-Id: I77db7600afdf04d82cf824b8395f96500c31b824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634086 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844922}
-
Joey Arhar authored
In these spec PRs [1][2], the <link> element will no longer match :link, :visited, or :any-link, and it will no longer navigate the page when clicked. This patch also modifies the TestExpectations for one of the modified tests navigation.sub.html. There was one test case which was consistently timing out which I removed, which would stop the test from timing out. However, there are an additional two test cases which time out when run with run_web_tests.py but pass just fine with run_wpt_tests.py. In addition, the flags passed to run_web_tests.py on the trybots make it so that those two test cases which time out get written to a failure file instead of making the whole test runner time out, which would count as a failure in TestExpectations. Since the default flags for run_web_tests.py make it an actual timeout according to TestExpectations, I left the timeout expectation in there as well. Hopefully this test can just be run with run_wpt_tests.py in the future and we can get rid of this TestExpectation. [1] https://github.com/whatwg/html/pull/6269 [2] https://github.com/w3c/csswg-drafts/pull/5839 Bug: 611093 Change-Id: I7234eb6024450e28c1ca6ec1ede7fdfc8f2ece52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628037Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844921}
-
Dale Curtis authored
This allows the fuzzers to assign the right component as well as other integrations. R=tguilbert Bug: None Change-Id: I16e4b79d479ef1a704b31b3d1bf91e687a7c5ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638453 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#844920}
-
Peng Huang authored
Bug: 1157501 Change-Id: I6f2035076423e5077bea0c295ef9211ac439cf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634836 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844919}
-
Dale Curtis authored
Now that we allow RGB VideoFrames through WebCodecs, we need to add support in VideoResourceUpdater since BreakoutBox allows them to reach our normal compositing path. R=sandersd Bug: 1167206,1167412 Test: Updated unittests. Change-Id: Ie7a72128ab4bf65c72a5a8a41014700b9db7d677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634049 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844918}
-
Eugene But authored
Bug: None Change-Id: Iaecc6494caa63cacefb8cd454b0b4e22c716307e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633204 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#844917}
-
Scott Violet authored
Currently there is no way to detect when a WebMessageReplyProxy is closed so that the java side can do cleanup. This adds a callback to detect this. Additionally this adds isClosed() to immediately check if the channel has been closed. BUG=1166171 TEST=WebMessageTest.testOnWebMessageReplyProxyClosed Change-Id: Ia759fb38898cc798819988daa00555a59843207e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633644Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844916}
-
Victor Costan authored
The member is written, but never read. Change-Id: I401c9e2b3c443ad1e31730a2862a485bfb4fd570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634863 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844915}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/login/easy_unlock. This should unblock conversion of //chromeos/components/proximity_auth. Bug: 1148570 Change-Id: I4da7c25ef8e20d3700bc49348d109424b64975af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638359 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#844914}
-
yiyix authored
This reverts commit 14c3a923. Reason for revert: Caused 238.9% regression in rendering.desktop (crbug.com/1142298) Original change's description: > Remove locked_image logics > > The CanvasImageProvider in CanvasResourceProvider keeps a set of images > locked, up till a certain budget, since continuous lock/unlock with GPU > discardable caused a regression with cases of repeated draws with the > same image. Locked_image is added to solve this issue. > > However, it causes a big overhead to maintain the set of images or > to track these images externally. It also causes bugs on memory leakage > and other areas. So that the benefits it adds are diminished. > > In this cl, I am removing the locked_images logic from the code. > > Bug: 927834 > > Change-Id: I9425cc3dc9ff862b84d8a524d50841e05f44acae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422584 > Commit-Queue: Yi Xu <yiyix@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820146} TBR=fserb@chromium.org,khushalsagar@chromium.org,yiyix@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927834 Change-Id: Ia2c4d918d7fb0b3623fd91edbc0979e78520e6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623048Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#844913}
-
minch authored
Bug: 1168255 Change-Id: Ie849ada4a926d8953c1ac0b6cf4aef6083bb21e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638105Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#844912}
-
Xing Liu authored
Change incognito NTP string for reading list. Also uses \u2019 for incognito ntp strings. Bug: 1166785 Change-Id: I30d8d84e439b0f1ac09a7ca3dd03bb1a26564513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629462Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844911}
-
Vladimir Levin authored
This patch blumbs the document transition request from layer tree host to the compositor frame metadata. In the follow-up patches, this will be serialized and deserialized for viz's consumption. R=kylechar@chromium.org, vasilyt@chromium.org Bug: 1150461 Change-Id: Iacc17b578f38137c53b3da57a5cf8fc1f531cc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636274Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844910}
-
Caitlin Fischer authored
The server-side config shows that this study has ended. Bug: 1126640 Change-Id: If7139fb3de3a5978dcf86c0f74badae7b990d26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631434Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844909}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1122546 Change-Id: Ic158622c15bf3eff41d63aa735e5be5cd4a3b8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636945Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844908}
-
Rune Lillesveen authored
Moved two rules styling the media element, and not its controls, into html.css. Also add a html default @namespace to the media controls sheet to avoid any unintended effects outside of html. Bug: 1166678 Change-Id: Ib1ac69f12f52700fc408d81a4655f55c18b4da89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629927Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844907}
-
Mason Freed authored
This feature shipped in M86, with no issues reported. https://chromestatus.com/feature/6143552666992640 Bug: 1067384 Change-Id: Ic27c756b6df3e2470b4d55194c18609df5683f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633965 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844906}
-
Victor Costan authored
* Add sequence checks. * Replace base::PostTask*() calls with calling PostTask*() methods directly on TaskRunners. * Use PostTaskAndReplyWithResult() instead of equivalent implementation based on PostTaskAndReply(). Change-Id: I291e6d9dea744bd1eb7c020f86cacf0f1ab40ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633728 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844905}
-
Alex Ilin authored
This reverts commit b62892aa. Reason for revert: Removed the directory existence check that was failing. Directories are removed on a background thread and there is no reliable way of waiting until the remove is complete. Original change's description: > Revert "[profiles] Clean up guest ephemeral profile on startup" > > This reverts commit d660a480. > > Reason for revert: > Test fails: > https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview > > Original change's description: > > [profiles] Clean up guest ephemeral profile on startup > > > > This CL fixes a bug which leads to the guest ephemeral profile not being > > cleaned up on startup if it has been left over in the previous session. > > > > ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true` > > parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get > > the full list of registered profiles. > > > > Bug: 1167883 > > Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844749} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1167883 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844779} TBR=droger@chromium.org,xidachen@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1167883 Change-Id: I8f78c419804e91aaa6279660160a6310353415ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637479Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0489cc12af57..c3c15a1f6b71 2021-01-19 ehmaldonado@google.com owners_finder: Don't print comments for owners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I68d73e4ef28e7067ab130a393001b8ae9a87a9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844903}
-
kylechar authored
Both tests have passed the last 100/100 runs on the Windows 10 with Intel 630 GPU bots the expectations applied to. Fixed: 1087993 Change-Id: Iead74a995acb6d4a3119f7acbb78eaf35b3325f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488541 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844902}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611057528-899a688a15a64f3c7bd554cd5ab3f72fe33a7d09.profdata to chrome-win64-master-1611068186-b36b631e8b34e83450d9bdf5237d6c35b34952b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8cae7630581c70ddc0171c7644550ea2e5872239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637721 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844901}
-
Dave Tapuska authored
More debugging to if the MainFrameImpl is null. This is the last possible pointer that could be null, add a CHECK for it. BUG=1160652 Change-Id: I03509d30c2c6d30681915ec2c178b2e6badec993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636841Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#844900}
-
Xianzhu Wang authored
- When calculating the maximum animation to screen scale, for a nested or unknown-scale transform animation, use the parent's maximum animation scale instead of kInvalidScale which would fallback to page_scale * device_scale which ignored ancestor scales. - When adjusting raster scale for transform animation, use max(raster_contents_scale_, maximum_animation_scale). In normal cases, if the former is bigger than the latter, it means that raster_contents_scale_ calculated when the animation starts is more accurate than the maximum_animation_scale calculated by the cc/animation subsystem. - In case that a bigger scale than 1.5x of the previous calculated animation scale, force an raster scale. The case should be rare. Bug: 1165408 Change-Id: Ieccdb9e16fb6f151e74a881855ce3655e857c372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633800Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844899}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I1d7d54d8999d526fc65ec54dcec4f8d15a5f03ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626419 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#844898}
-
Caitlin Fischer authored
There do not appear to be server-side configs for these studies. LoadingPredictorUseLocalPredictions is enabled on TOT, but LoadingPredictorTableConfig is disabled. Bug: 1126640 Change-Id: I8634b015af89fec4c0fdc42070784527e6a7126b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632047Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844897}
-
Ramin Halavati authored
Adds "Profile.Guest.ForcedByPolicy" metric which records if Guest profiles are initiated by user request or forced by policy. Bug: 1125474, 1167473 Change-Id: I8c87096bd60d260c1542a1c869361f3f5ed2cb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632586 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844896}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I97cf624f147abdf852c852f7c0b3de5985e103f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637263 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844895}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1683f26e. With Chromium commits locally applied on WPT: fafb4f34 "[EventTiming] Exclude target from toJSON" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm cbiesinger@chromium.org: external/wpt/css/css-flexbox domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools mustaq@chromium.org: external/wpt/html/interaction/focus nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events rego@igalia.com: external/wpt/css/css-grid external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I9896ae1cecae7582b8ed3195266fe2d624a707a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637774Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844894}
-