- 02 Dec, 2019 40 commits
-
-
Tim Song authored
BUG=1021133 Change-Id: I7785f3184be08c33e333b6c918ba97762c25d986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940611Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720670}
-
Fredrik Söderquist authored
For interval updates performed "outside" of the regular flow in SMILTimeContainer, we would use the "previous" presentation - i.e the time just before the time we latest updated timing to. This could cause elements to resolve intervals in the past - for example when the latest update time was at the end of an interval it could discard the current interval and resolve an interval in the past, which could then be propagated to its dependents. When these elements were later updated by the main update loop they would again discard the current (in the past) interval and resolve a new one, notifying its dependents. Repeat. Instead always use the "latest update time" (the same is used by SMILTimeContainer::UpdateIntervals) as the argument to Updateinterval(), and only use the "previous" presentation time when checking if the active state may have changed in a relevant way and for rescheduling. Bug: 1021630, 1028839, 1029327 Change-Id: Ibe691ae336df51a36626fdd800e5ddc2303aee5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939788Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720669}
-
Yuly Novikov authored
In order to limit access to GPU resources by resource type. Moves Mac GPU trybots into a separate file. Bug: 1020753 Change-Id: Ic215312d129540f2674083b67f1261ab14af2d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918372Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#720668}
-
Ahmed Mehfooz authored
Bug: 1026073 Change-Id: I187064836c15c4014eae8f925a6e262df556670b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938257Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720667}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19f9f4148196..ca1b0fb895ca git log 19f9f4148196..ca1b0fb895ca --date=short --first-parent --format='%ad %ae %s' 2019-12-02 timvp@google.com VULKAN: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d Created with: gclient setdep -r src/third_party/angle@ca1b0fb895ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: If8ac23b98f79c86781840eac7712ec273a770d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720666}
-
Elly Fong-Jones authored
This is a reland of 1e92aab4 Original change's description: > cbui: disable PageInfoBubbleView focus tests on Mac > > These tests don't work on Mac - it's possible that they never did, or > they may have broken recently. Unfortunately the entire suite is > disabled (see issue 899286). This change marks these two tests > explicitly disabled pending a real fix. > > Bug: 1029882, 1028239 > Change-Id: I3a11ae61470850fd55ad95353c7eacd4ac516169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946394 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720629} Bug: 1029882, 1028239 Change-Id: I6077af8cd9431e069c766c71717a92de670ed210 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945895 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720665}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=mbarbella@chromium.org Bug: 891670 Change-Id: I2ef63eb8930f041ef6fb1c304e81d8ed938c9aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944849 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#720664}
-
Martin Kreichgauer authored
Refactor the settings-security-keys-pin-field JS interface to expose a single trySubmit() method that can be used to trigger PIN validation and submission. It previously had separate methods for validation and submission which caused unnecessary duplication in the credential management and fingerprint enrollment dialogs. With the new interface it is simpler to keep the two consistent. This also fixes a bug where it was possible to trigger multiple concurrent PIN submissions in the credential management dialog. The confirm button was disabled during PIN submission, but then re-enabled immediately once the PIN was accepted and credential enumeration was kicked off. If credential enumeration was sufficiently slow, a second PIN submission could be triggered, leading to a crash in the message handler code. No other functional changes. Fixed: 1027039 Change-Id: Ief6967bee17cc382912f158b7e7ec42b86014c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931378 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720663}
-
Ilia Samsonov authored
https://codereview.chromium.org/2857643002 forced all sanitizers builds to print address offsets only. This output is meant to run through tools/valgrind/asan/asan_symbolize.py yet test_env has different configuration to run through the asan_symbolize.py. The asan and tsan builds for this cl give meaningful output. Before, Stack trace: #0 0x55d1d54e8bc3 (/b/s/w/ir/out/Release/content_browsertests+0x1cf42bc2) #1 0x55d1ccb003ab (/b/s/w/ir/out/Release/content_browsertests+0x1455a3aa) #2 0x55d1ccb2b740 (/b/s/w/ir/out/Release/content_browsertests+0x1458573f) #3 0x55d1ccb29747 (/b/s/w/ir/out/Release/content_browsertests+0x14583746) #4 0x55d1c82f2530 (/b/s/w/ir/out/Release/content_browsertests+0xfd4c52f) #5 0x55d1d40a8d42 (/b/s/w/ir/out/Release/content_browsertests+0x1bb02d41) #6 0x55d1d4333e88 (/b/s/w/ir/out/Release/content_browsertests+0x1bd8de87) #7 0x55d1d16f3fc2 (/b/s/w/ir/out/Release/content_browsertests+0x1914dfc1) #8 0x55d1d2e62e79 (/b/s/w/ir/out/Release/content_browsertests+0x1a8bce78) #9 0x55d1d16f0f65 (/b/s/w/ir/out/Release/content_browsertests+0x1914af64) #10 0x55d1d16fb299 (/b/s/w/ir/out/Release/content_browsertests+0x19155298) #11 0x55d1d16eb211 (/b/s/w/ir/out/Release/content_browsertests+0x19145210) #12 0x55d1d1085a78 (/b/s/w/ir/out/Release/content_browsertests+0x18adfa77) #13 0x55d1d1084d99 (/b/s/w/ir/out/Release/content_browsertests+0x18aded98) #14 0x55d1dba2402c (/b/s/w/ir/out/Release/content_browsertests+0x2347e02b) After, Stack trace: #0 0x562f0d54eee3 in StackTrace ./../../base/debug/stack_trace.cc:206:12 #1 0x562f0d54eee3 in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #2 0x562f051de24b in StackTraceGetter::CurrentStackTrace(int, int) ./../../third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #3 0x562f051fdb40 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) ./../../third_party/googletest/src/googletest/src/gtest.cc:820:35 #4 0x562f051fc527 in testing::internal::AssertHelper::operator=(testing::Message const&) const ./../../third_party/googletest/src/googletest/src/gtest.cc:401:25 #5 0x562f0127b36b in content::PointerLockBrowserTest_PointerLockWheelEventRouting_Test::RunTestOnMainThread() ./../../content/browser/pointer_lock_browsertest.cc:518:5 #6 0x562f0c30fba6 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:656:5 #7 0x562f0c54407b in Run ./../../base/callback.h:132:12 #8 0x562f0c54407b in content::ShellBrowserMainParts::PreMainMessageLoopRun() ./../../content/shell/browser/shell_browser_main_parts.cc:168:26 #9 0x562f09b284d2 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:1031:13 #10 0x562f0b1a6839 in Run ./../../base/callback.h:98:12 #11 0x562f0b1a6839 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:29 #12 0x562f09b25475 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:940:25 #13 0x562f09b2f519 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:128:15 #14 0x562f09b1f61f in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #15 0x562f0959b1e8 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:527:10 #16 0x562f0959b1e8 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:960:10 #17 0x562f0959a50d in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #18 0x562f1327ce25 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:423:29 Bug: 877205 Change-Id: Ib83c3e72919f0d1664cd2e2d338cbd21982d1c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894762Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#720662}
-
Joe DeBlasio authored
This CL removes the dump without crashing that was triggered when download initiators were unknown. A subsequent CL will record a histogram here instead, but we've learned what we can from the traces. Bug: 1029003,1028179 Change-Id: I6117add43d77577555707e98eb7ed806ba5fe4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946927 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720661}
-
Arthur Wang authored
R=anushruth@chromium.org, bpastene@chromium.org, gbeaty@chromium.org Bug: 1015440 Change-Id: Ic5f7739fc9ee6efbc4f710f7301c82b3746ca945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910679 Commit-Queue: Arthur Wang <wuwang@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#720660}
-
Andrew Grieve authored
When enumerating classes, filter out those that do not have "Test" suffix. Spot checked 2 random shards of android-kitkat-arm-rel with and without this change. Both before shards took 41 seconds to list tests. Both after shards took 23 seconds. Change-Id: I35b5521095a9ccea857b8fed6d9d009a7d9c7c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946432 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720659}
-
Juan Antonio Navarro Perez authored
Make it easier add new files to update/verify by just havint to create a new "updater" function. Avoids all the code duplication in previous "verify"-ing functions. Bug: 1029042 Change-Id: Ia85209a38b588f7687aabdd04e2b68fb8e820037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944679 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720658}
-
shrekshao authored
Bug: 681341 Change-Id: I09ae60107987e2032a042a7074e39ad0fb5ae454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938249Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#720657}
-
Jasper Chapman-Black authored
The WebAssembly web worker parses .size and .sizediff files, the JS web worker parses .ndjson files. Previously, the web worker would be set on pageload according to the load_url parameter, so if you loaded a .size file and then uploaded a .ndjson to view, the viewer would crash. This CL refreshes the web worker on each file upload. Change-Id: I182ac524bfd7049ed178bd2c6784bb0282f0ee8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946858Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720656}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=dalecurtis@chromium.org Bug: 891670 Change-Id: I49b6558414f9fe68fa26c966df03172a2069493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944150 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720655}
-
Joe DeBlasio authored
This CL allows autofill on pages with valid TLS, but using legacy TLS certs or other non-fatal certificate errors. Bug: 1029906 Change-Id: I3676919fe7aa13c1aad82920f4cb74cb137af21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946984Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#720654}
-
Daniel Murphy authored
This reverts commit 1823d527. Reason for revert: Seems to have caused determinism failures Bug: 1029863 Original change's description: > Update V8 to version 8.0.419. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/adfb6ba3..684d2057 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ia2bb5ff51bfe4d6b2ebc77c171097d374c34df39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944383 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720481} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I094b8bbd5aa4db4563299c90847a317ef63a106a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux-blink-rel, luci.chromium.try:linux_optional_gpu_tests_rel, luci.chromium.try:mac_optional_gpu_tests_rel, luci.chromium.try:win_optional_gpu_tests_rel, luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946452Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720653}
-
Daniel Murphy authored
TBR=dominickn@chromium.org Bug: 1030009 Change-Id: I93453317cf22604a947e22ecca42e15099eab78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946449Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720652}
-
Etienne Pierre-Doray authored
This reverts commit e48149cf. Reason for revert: Step "compile" failing on 7 builder(s) Original change's description: > Roll src-internal 33ae3e65534f..a9771748c0c2 (2 commits) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..a9771748c0c2 > > > Created with: > gclient setdep -r src-internal@a9771748c0c2 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC jbudorick@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1017165 > Tbr: jbudorick@google.com > Change-Id: I43ccf9ae85647651302c034510f25fbb6bbd1565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946887 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#720642} TBR=jbudorick@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I3a4dbdf003fd3c39c57ca867f6281adcf16b79b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1017165, 1030005 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947096Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#720651}
-
Findit authored
This reverts commit 15204aaf. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720636 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1MjA0YWFmMDdlYWZmNTkzZDdhM2Q2ZDdlYjdhNjljOGI5MGE1NWEM Sample Failed Build: https://ci.chromium.org/b/8895149418482727520 Sample Failed Step: compile Original change's description: > refactor android locales in locales.gni > > This CL refactors build/config/locales.gni but makes no actual > changes to what locales are used. > > The primary change is to remove android_chrome_omitted_locales > and replace it with android_non_bundle_locales. > This list should be used directly instead of subtracting omitted > locales from locales. > > Additionally the list all_chrome_locales was added as the superset > of all supported locales. Platform specific lists are made by > subtracting from this list. > > No changes were made to the iOS and Mac locale lists names. > > Bug: 812837 > Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962 > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720636} Change-Id: I91d7824e9e0b292c3376556947cbe4aced6bd0be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 812837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947226 Cr-Commit-Position: refs/heads/master@{#720650}
-
Daniel Murphy authored
TBR=apotapchuk@chromium.org,xiyuan@chromium.org Bug: 1029965 Change-Id: Ib04027e8d35b6eb54ed95274e866139a7503630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946874Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720649}
-
Findit authored
This reverts commit 1e92aab4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720629 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFlOTJhYWI0YzVmZjI1YTZlOWM5MzExNzBlNDU2ODY3ZWQ1ZjI2MzcM Sample Failed Build: https://ci.chromium.org/b/8895150372258392000 Sample Failed Step: compile Original change's description: > cbui: disable PageInfoBubbleView focus tests on Mac > > These tests don't work on Mac - it's possible that they never did, or > they may have broken recently. Unfortunately the entire suite is > disabled (see issue 899286). This change marks these two tests > explicitly disabled pending a real fix. > > Bug: 1029882, 1028239 > Change-Id: I3a11ae61470850fd55ad95353c7eacd4ac516169 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946394 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720629} Change-Id: I3bb692bd8fc7fbfea575f0ff1119bbcb7f17d019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029882, 1028239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946868 Cr-Commit-Position: refs/heads/master@{#720648}
-
Findit authored
This reverts commit ca140dc0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 720640 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NhMTQwZGMwOTRmMTZiZGU3NGFkM2RlODUwNzY4YWRkYzgxYzE2ZGYM Sample Failed Build: https://ci.chromium.org/b/8895151056470093664 Sample Failed Step: compile Original change's description: > Replace uses of LogSymbolizedUnsymbolizedMinidumps > > Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with > CollectDebugData, which is functionally identical but the name is more > descriptive of what it actually does. > > TBR=crouleau@chromium.org > > Bug: 1025034 > Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720640} Change-Id: I79cbb55d5d3d10828d66251e57b388f9377eaa1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946023 Cr-Commit-Position: refs/heads/master@{#720647}
-
Megan Jablonski authored
Bug: 1026217, 1026760 Change-Id: I9bed765c6cb16ba52d0f28eef28434cae3540dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927169Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#720646}
-
Garrett Beaty authored
This will allow enforcing chump detection without preventing submits due to chromium_presubmit not being in a good state. Bug: 1024637 Change-Id: Ic80d65f6e6a9442c66e6d92a4b3626f3c5c02dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946857 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#720645}
-
Wenbin Zhang authored
In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the dimensions for: - mac-10_12_laptop_low_end-perf - Added synthetic product name 'MacBookAir7,2_x86-64-i5-5350U_Intel Broadwell HD Graphics 6000_8192_APPLE SSD SM0128G' - Updated OS from 'Mac-10.12' to 'Mac-10.12.6' Link for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=status&c=synthetic_product_name&d=asc&f=pool%3Achrome.tests.perf&f=gpu%3A8086%3A1626&f=os%3AMac-10.12&k=os&s=synthetic_product_name - mac-10_13_laptop_high_end-perf - Updated synthetic product name from 'synthetic_product_name': 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_1_475936.0' to 'synthetic_product_name': 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_APPLE SSD SM0512G' Link for the available bots based on the old/new dimensions: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=status&c=synthetic_product_name&d=asc&f=pool%3Achrome.tests.perf&f=os%3AMac-10.13.3&f=gpu%3A1002%3A6821-4.0.20-3.2.8&k=gpu&s=synthetic_product_name Bug: chromium:1019916 Change-Id: I67faf23b277f1fc4db5b5d960808aec8066b98bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941190Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#720644}
-
Ryan Sleevi authored
This enables the fetching of CRLSets on Chrome for Android. While Android is not yet using the CertVerifierBuiltin, which enables CRLSets during path building, it does support CRLSets for known MITM detection and disclosure. This ports the existing CRLSet tests (which hang off SSLUITest but are really browser tests) into platform-agnostic browser_tests, running on either android_browsertests or browsertests, respectively. Bug: 1025424 Change-Id: I89b066dfd539b287f35a20bea54d5cb5cb739501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930051Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720643}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..a9771748c0c2 Created with: gclient setdep -r src-internal@a9771748c0c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165 Tbr: jbudorick@google.com Change-Id: I43ccf9ae85647651302c034510f25fbb6bbd1565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720642}
-
Kevin Ellis authored
Bug: 421413 Change-Id: I810f8d8bce517e1de82e347d92bcc0204deedacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943445Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#720641}
-
Brian Sheedy authored
Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with CollectDebugData, which is functionally identical but the name is more descriptive of what it actually does. TBR=crouleau@chromium.org Bug: 1025034 Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720640}
-
Margaret Mary Kearney authored
The new version has information about progressive web apps. It also has details about migrating specific APIs. Change-Id: I8ee02283cd8fcc859bce221a53c408aac0596e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935235Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Auto-Submit: Meggin Kearney <mkearney@chromium.org> Commit-Queue: Anthony LaForge <laforge@chromium.org> Cr-Commit-Position: refs/heads/master@{#720639}
-
Nicolás Peña Moreno authored
Running with --test-path seems to no longer be supported. This CL updates the documentation to use story-filter. Change-Id: I9e202ef4a4b8474acbf1d8af4f81d44c1ffaf85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946429 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720638}
-
Gavin Williams authored
-The subtext variable/location on the CUPS printer page is intended to hold supplementary information for printers show on screen, but right now it is unused. Therefore, having aria-describedby="printerSubtext" gives no further context while unintentionally stopping the tooltip from being read by ChromeVox. So I will remove these references now then revisit these ARIA labels once we understand what the printer subtext will be. Fixed: 1014145 Change-Id: I481a018a5d7e75f4f8ac28e6c60262fefa9805a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930695Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#720637}
-
Trevor Perrier authored
This CL refactors build/config/locales.gni but makes no actual changes to what locales are used. The primary change is to remove android_chrome_omitted_locales and replace it with android_non_bundle_locales. This list should be used directly instead of subtracting omitted locales from locales. Additionally the list all_chrome_locales was added as the superset of all supported locales. Platform specific lists are made by subtracting from this list. No changes were made to the iOS and Mac locale lists names. Bug: 812837 Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#720636}
-
Changwan Ryu authored
Test: run_simpleperf_test.py:testStackAddressInterpreter covers this Bug: 1015236 Change-Id: Iedc680d8b484556044cfc1ae04576b5b4fb0907c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946932Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720635}
-
Chris Mumford authored
Binding repaint callback used for WebMediaStreamVideoRenderer to a "Repeating" callback because the repaint callbacks are called multiple more than once. Bug: 1007835 Change-Id: Ic6b9a64d9b35b2e3d08e97c4286edb078f6609a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912539 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720634}
-
John Rummell authored
On some bots getting the server command line is failing, so change DVLOGs to WARNINGS so that the actual error can be seen. Bug: 976083 Test: compiles Change-Id: I654d3857806b48015ecda97431d8e264a8924ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946929 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720633}
-
Chromium WPT Sync authored
Using wpt-import in Chromium beabaf9d. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I609b6d80f5204b077587551b2303c16786e8887a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946628Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720632}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I77752dd385065bd71b8d9ae522170d580b2010e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945892Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#720631}
-