Commits · 3f78e2ab228ce763403a6e92cc08e240b0305633 · eriksson monteiro / tangled

28 Oct, 2014 40 commits

grt authored Oct 27, 2014

BUG=412884
R=bengr@chromium.org

Review URL: https://codereview.chromium.org/674103003

Cr-Commit-Position: refs/heads/master@{#301554}

3f78e2ab

Add tests for RSA private key import using JWK when p and q are swapped. · c5b56441

eroman authored Oct 27, 2014

BUG=383995

Review URL: https://codereview.chromium.org/675453003

Cr-Commit-Position: refs/heads/master@{#301553}

c5b56441

[Telemetry] Add labels attribute to page as the new way to set label · b545bb93

nednguyen authored Oct 27, 2014

BUG=418375

Review URL: https://codereview.chromium.org/686623002

Cr-Commit-Position: refs/heads/master@{#301552}

b545bb93

Changes BookmarkBarView to only create buttons as needed · b8c86e2b

sky authored Oct 27, 2014

Previously it created a button per child of the bookmark bar node. Now
it creates only as many buttons as are needed, lazily creating more if
the size changes.

BUG=416641
TEST=covered by tests.
R=msw@chromium.org

Review URL: https://codereview.chromium.org/677533003

Cr-Commit-Position: refs/heads/master@{#301551}

b8c86e2b

Standardize usage of virtual/override/final specifiers. · ff08c7cc

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=msw@chromium.org

Review URL: https://codereview.chromium.org/680133002

Cr-Commit-Position: refs/heads/master@{#301550}

ff08c7cc

[telemetry] Disable measuring renderer CPU usage. · 65ee0192

dtu authored Oct 27, 2014

They're causing failures on the bots, and are incorrect anyway.

BUG=419786
TEST=None.

Review URL: https://codereview.chromium.org/671713004

Cr-Commit-Position: refs/heads/master@{#301549}

65ee0192

Null check content view core before using it. · 854fc333

hush authored Oct 27, 2014

This is because content view core object could be destroyed at the time when
a method is called on it.

BUG=427684

Review URL: https://codereview.chromium.org/677423003

Cr-Commit-Position: refs/heads/master@{#301548}

854fc333

Introduce the directory restriction of ServiceWorker scope in chromium side. · 8782077e

horo authored Oct 27, 2014

This restriction doesn't allow registration of the ServiceWorker scope outside the script directory.
As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468

BUG=423983

Review URL: https://codereview.chromium.org/677003002

Cr-Commit-Position: refs/heads/master@{#301547}

8782077e

Remove migation code for file manager path preference. · f9e1ec0a

kinaba authored Oct 27, 2014

BUG=313539

Review URL: https://codereview.chromium.org/677373002

Cr-Commit-Position: refs/heads/master@{#301546}

f9e1ec0a

[GCM] Adding last token fetching time handling · 5df10170

fgorski authored Oct 27, 2014

Adding SetLastTokenFetchingTime to GCMStore
Adding Get/SetLastTokenFetchingTime to GCMDriver
Propagating the last token fetching time up and down the GCM stack

BUG=374969

Review URL: https://codereview.chromium.org/681453004

Cr-Commit-Position: refs/heads/master@{#301545}

5df10170

Further restrict access on the alternate winstation and desktop · 4057b055

wfh authored Oct 27, 2014

BUG=427538

Review URL: https://codereview.chromium.org/683683002

Cr-Commit-Position: refs/heads/master@{#301544}

4057b055

Clear the bluetooth discoverable bit when OOBE is finished on Remora. · 27600066

zork authored Oct 27, 2014

BUG=427089

Review URL: https://codereview.chromium.org/681903002

Cr-Commit-Position: refs/heads/master@{#301543}

27600066

Hotword Audio Verification App: UI polishes. · d2185020

kcarattini authored Oct 27, 2014

Adds urls to the settings and 'learn more' links.
Adds CSS animation to the speech training pages.
Adds steps through speech training UI with clicks.

BUG=390086

Review URL: https://codereview.chromium.org/666073005

Cr-Commit-Position: refs/heads/master@{#301542}

d2185020

Standardize usage of virtual/override/final specifiers. · 28401c28

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=flackr@chromium.org

Review URL: https://codereview.chromium.org/645513008

Cr-Commit-Position: refs/heads/master@{#301541}

28401c28

Standardize usage of virtual/override/final specifiers. · 07d12f74

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=calamity@chromium.org

Review URL: https://codereview.chromium.org/681873002

Cr-Commit-Position: refs/heads/master@{#301540}

07d12f74

Standardize usage of virtual/override/final specifiers. · 440d8e1c

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dcaiafa@chromium.org

Review URL: https://codereview.chromium.org/660803004

Cr-Commit-Position: refs/heads/master@{#301539}

440d8e1c

Add unittest coverage for WriteToClipboard with a single URL · 36a8fb2d

hichris123 authored Oct 27, 2014

Added unittest coverage removed from CL 634523004

BUG=57376

Review URL: https://codereview.chromium.org/677423004

Cr-Commit-Position: refs/heads/master@{#301538}

36a8fb2d

Fix a bug in data_sender.js. · 1fdff9eb

sammc authored Oct 27, 2014

This fixes a bug where data sends that had been fully written to the
data pipe were not considered when deciding whether to cancel (or wait
for an in-progress cancel) during DataSender serialization.

Review URL: https://codereview.chromium.org/678223002

Cr-Commit-Position: refs/heads/master@{#301537}

1fdff9eb

Reject JWK key import when key_ops contains duplicate values. · ca92d1ea

eroman authored Oct 27, 2014

BUG=378074

Review URL: https://codereview.chromium.org/668313002

Cr-Commit-Position: refs/heads/master@{#301536}

ca92d1ea

Standardize usage of virtual/override/final specifiers. · f5963511

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/679283002

Cr-Commit-Position: refs/heads/master@{#301535}

f5963511

Standardize usage of virtual/override/final specifiers. · fa85b159

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/678073006

Cr-Commit-Position: refs/heads/master@{#301534}

fa85b159

mac: Fix bug where finder window extends past bottom of screen. · b5a19d4f

erikchen authored Oct 27, 2014

AppKit is responsible for determining the height of the NSSavePanel and
NSOpenPanel. It will never pick a height that causes the panel to be taller
than the screen, but it may pick a height that requires the panel to be
positioned near the top of its presenting window. Chrome's logic for
positioning panels did not take this into consideration, so it was possible to
position a panel that extended past the bottom of the screen.

This CL fixes this oversight.

BUG=423635

Review URL: https://codereview.chromium.org/665933005

Cr-Commit-Position: refs/heads/master@{#301533}

b5a19d4f

[fsp] Separate recursive and non-recursive watchers. · 60c10816

mtomasz authored Oct 27, 2014

With this patch, if one extension has a recursive watcher, and another non-
recursive one, then the providing extension will know about both of them.

In an upcoming patch ObservedEntry will be renamed to Watcher, since now
we can have two observed entries for the same path, which doesn't sound the
best.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/679573002

Cr-Commit-Position: refs/heads/master@{#301532}

60c10816

Make ChromeShell activity use AppCompat theme to match official Chrome. · 7cba8078
aurimas authored Oct 27, 2014
```
BUG=None

Review URL: https://codereview.chromium.org/684453004

Cr-Commit-Position: refs/heads/master@{#301531}
```
7cba8078

Standardize usage of virtual/override/final specifiers. · 47523f49

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/686563002

Cr-Commit-Position: refs/heads/master@{#301530}

47523f49

Don't dllexport anonymous class GestureConfigurationAura · 729385c6

Hans Wennborg authored Oct 27, 2014

BUG=82385
R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/684643003

Cr-Commit-Position: refs/heads/master@{#301529}

729385c6

Add an extensions keep-alive client. · d9fddbc5

sammc authored Oct 27, 2014

This adds the renderer side of adding keep-alives while API calls
implemented on mojo services are in progress.

BUG=389016

Review URL: https://codereview.chromium.org/669303002

Cr-Commit-Position: refs/heads/master@{#301528}

d9fddbc5

add pagination info to DistilledPageProto · 42a54f5f

kuan authored Oct 27, 2014

- this is part of the implementation of scoring mechanism for next/prev page
  links.
- pagination info will be passed to the scoring framework.
- standalone content extractor outputs the page links.
- modified tests to verify pagination info.

BUG=425952

Review URL: https://codereview.chromium.org/678543002

Cr-Commit-Position: refs/heads/master@{#301527}

42a54f5f

[android] Password generation UI for android. · b2237a9c

rouslan authored Oct 27, 2014

The feature is disabled through field trial infrastructure. Pass these
flags to try it out on a device:

--enable-password-generation
--local-heuristics-only-for-password-generation

BUG=412150

Review URL: https://codereview.chromium.org/606153002

Cr-Commit-Position: refs/heads/master@{#301526}

b2237a9c

Switch to EnhancedBookmarkModel from meta_accessor · 1dc2b410

ianwen authored Oct 27, 2014

Meta_accessor is deprecated and we should use EnhancedBookmarkModel in
EnhancedBookmarkBridge. We might want to delete metadata_accessor files
after this CL.

BUG=415817

Review URL: https://codereview.chromium.org/679833002

Cr-Commit-Position: refs/heads/master@{#301525}

1dc2b410

Standardize usage of virtual/override/final specifiers. · 71f12cb9

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/683563002

Cr-Commit-Position: refs/heads/master@{#301524}

71f12cb9

Standardize usage of virtual/override/final specifiers. · 7d4328f4

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/685543003

Cr-Commit-Position: refs/heads/master@{#301523}

7d4328f4

Standardize usage of virtual/override/final specifiers. · c71b15e5

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/676403006

Cr-Commit-Position: refs/heads/master@{#301522}

c71b15e5

[Password Generation] Always query password forms via Autofill · c57dd560

gcasto authored Oct 27, 2014

For other fields, we assume that if the author has specified autocomplete
attributes we should respect all their choices, including not trying to
determine field autocomplete values for fields that the author didn't specify.

This doesn't apply for password fields for two reasons. First, there is no way
for an author to specify generation for a particular field. Second, since
generation isn't a specced autocomplete value, the password field can reasonably
be set (e.g. "autocomplete=new-password") and also have generation enabled.

BUG=424793

Review URL: https://codereview.chromium.org/659793005

Cr-Commit-Position: refs/heads/master@{#301521}

c57dd560

telemetry: Remove obsolete benchmark aliases. · 0823191b

ernstm authored Oct 27, 2014

R=tonyg@chromium.org,dtu@chromium.org
BUG=426649

Review URL: https://codereview.chromium.org/684673002

Cr-Commit-Position: refs/heads/master@{#301520}

0823191b

cc: Full solid layers not at origin painted incorrectly · efe523e2

hendrikw authored Oct 27, 2014

Old code used a size, we now use a rect, and I didn't update the
quad clipping to use the origin offset.

We now correctly clip the quads, and I've updated the unit test
to use a visible rect that doesn't sit on (0,0), and will fail
without this change.

Though I wasn't able to reproduce it, it may also fix:
https://code.google.com/p/chromium/issues/detail?id=427467

BUG=18132446 (internal)

Review URL: https://codereview.chromium.org/678193002

Cr-Commit-Position: refs/heads/master@{#301519}

efe523e2

Standardize usage of virtual/override/final specifiers. · 34688b71

dcheng authored Oct 27, 2014

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/657923005

Cr-Commit-Position: refs/heads/master@{#301518}

34688b71

Roll src/third_party/WebKit bdffb34:33edc61 (svn 184473:184478) · bcfd1f3a

blink-deps-roller authored Oct 27, 2014

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bdffb34..33edc61

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/681913003

Cr-Commit-Position: refs/heads/master@{#301517}

bcfd1f3a

[webcrypto] Properly fail-fast when importing RSA key as JWK with bad usages. · 390613d6
eroman authored Oct 27, 2014
```
BUG=395904

Review URL: https://codereview.chromium.org/413523003

Cr-Commit-Position: refs/heads/master@{#301516}
```
390613d6

Remove stub ScrollEndEffectController · 9d751807

pkotwicz authored Oct 27, 2014

BUG=426561
TEST=None

Review URL: https://codereview.chromium.org/674303002

Cr-Commit-Position: refs/heads/master@{#301515}

9d751807