- 06 Feb, 2015 40 commits
-
-
dpranke authored
Now that we have fastbuild and Goma working, it should be safe to link the full binary again in a GN build on the bots. TBR=brettw@chromium.org, jam@chromium.org BUG=354261 Review URL: https://codereview.chromium.org/880373008 Cr-Commit-Position: refs/heads/master@{#315140}
-
rickyz authored
This can be disabled with the allow-sandbox-debugging flag. BUG=455964 Review URL: https://codereview.chromium.org/901683003 Cr-Commit-Position: refs/heads/master@{#315139}
-
spang authored
This is really silly, but gyp doesn't seem to track if a static_library contains C++ code and needs a C++ link step. So our copy of libxml breaks us by containing a little bit of (chromium-added) C++ code. This is really a correctness issue in the build system. BUG=445627 TEST=linux_ecs_ozone tryjob Review URL: https://codereview.chromium.org/872493004 Cr-Commit-Position: refs/heads/master@{#315138}
-
dfalcantara authored
The public hardly knew ye. Replaced by AppBannerInfoBars. BUG=453170 Review URL: https://codereview.chromium.org/903263002 Cr-Commit-Position: refs/heads/master@{#315137}
-
spang authored
Review URL: https://codereview.chromium.org/904033006 Cr-Commit-Position: refs/heads/master@{#315136}
-
zmo authored
BUG=429053 TEST=gpu_unittests R=piman@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/894373004 Cr-Commit-Position: refs/heads/master@{#315135}
-
viettrungluu authored
This reverts commit c2e11810. TBR=viettrungluu@chromium.org NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true BUG= Review URL: https://codereview.chromium.org/877993004 Cr-Commit-Position: refs/heads/master@{#315134}
-
mseaborn authored
This pulls in the following Native Client changes: 6c11549: (mseaborn@chromium.org) Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium 9fff96b: (teravest@chromium.org) NaCl: Remove use of NACL_BUILD_* in common.gypi. 76d6d4b: (mseaborn@chromium.org) PNaCl: Update Binutils revision in pnacl/COMPONENT_REVISIONS: use new IRT interface a3e1e94: (jfb@chromium.org) Delete Windows time code BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/905793003 Cr-Commit-Position: refs/heads/master@{#315133}
-
vigneshv authored
Re-landing the CL reverted here: https://codereview.chromium.org/866573004 Opus audio codec is supported by the android platform starting from Lollipop. This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus in Clank. This brings Opus feature parity with Desktop Chromium. BUG=318436 TBR=jschuh,rsleevi Review URL: https://codereview.chromium.org/898393002 Cr-Commit-Position: refs/heads/master@{#315132}
-
jinlong.zhai authored
--single-process mode may happen crash in file of webrtc_logging.cc where code is CHECK(!g_webrtc_logging_delegate). The orginal code is to expect there to be only one g_webrtc_logging_delegate instance in a single render process. g_webrtc_logging_delegate is created when a RenderThreadImpl is created. But in --single-process model all RenderThreadImpl are created in browser process and so g_webrtc_logging_delegate may be created many times in a single process. Then CHECK(!g_webrtc_logging_delegate) will fail. In this patch will change g_webrtc_logging_delegate from process-level to RenderThread-Level. Since every render process will only keep one RenderThread. BUG=455573 Review URL: https://codereview.chromium.org/889313003 Cr-Commit-Position: refs/heads/master@{#315131}
-
rdevlin.cronin authored
Add unittesting for ToolbarActionView to, at minimum, test the basic UI. Also remove the dependency of ToolbarActionView on Browser, and create a TestToolbarActionViewController. BUG=453841 TBR=sky@chromium.org (gn file change) Review URL: https://codereview.chromium.org/888043003 Cr-Commit-Position: refs/heads/master@{#315130}
-
weitaosu authored
Changes in this CL include: 1. Moved the daemon controller implemetation from |ElevatedDaemonController| to |DaemonControllerDelegateWin| 2. Removed all code related to COM activation in |DaemonControllerDelegateWin|. 3. Removed code related to SetOwnerWindow in |DaemonControllerDelegateWin|. 4. Removed code related to the pin confirmation dialog in |DaemonControllerDelegateWin| 5. Cleaned up the COM-styled code to make it adhere to the chromium coding styles. BUG=453172 Review URL: https://codereview.chromium.org/877343004 Cr-Commit-Position: refs/heads/master@{#315129}
-
viettrungluu authored
[Taken over from blundell's https://codereview.chromium.org/901843003/, PS3.] Adapt to de-clienting of Surface. Have nacl_listener pass a SimplePlatformSupport instance to mojo::embedder::Init to satisfy the DCHECK introduced in https://codereview.chromium.org/898623002/diff/40001/mojo/edk/embedder/embedder.cc. [Additional fix backported from https://codereview.chromium.org/898423002/.] Fix mojo::embedder::CreateChannel(): the evaluation order between the channel_info->channel_id and channel_info.release() is undefined. TBR=blundell@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/904103003 Cr-Commit-Position: refs/heads/master@{#315128}
-
maruel authored
$ git log 94aea8c60..bdad1183d --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2015-02-06 maruel Further limit parallelism on 32 bits user process. R=vadimsh@chromium.org BUG=419862 Review URL: https://codereview.chromium.org/903963004 Cr-Commit-Position: refs/heads/master@{#315127}
-
dbeam authored
R=kalman@chromium.org BUG=438301,438777 Review URL: https://codereview.chromium.org/862403006 Cr-Commit-Position: refs/heads/master@{#315126}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/d042358..2aafe6f CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/892803003 Cr-Commit-Position: refs/heads/master@{#315125}
-
bengr authored
The unittests were failing due to various bugs. These have been fixed. BUG=456240 Review URL: https://codereview.chromium.org/905823003 Cr-Commit-Position: refs/heads/master@{#315124}
-
dalecurtis authored
This allows clients to tell when fallback to fake device has occurred, which prevents silent no-audio failure situations. The new key, "device_type" can be seen on all controllers and streams created. BUG=455371 TEST=chrome://media-internals Review URL: https://codereview.chromium.org/890573003 Cr-Commit-Position: refs/heads/master@{#315123}
-
vitalybuka authored
Revert of Add Autofill to webview (patchset #5 id:160001 of https://codereview.chromium.org/866523002/) Reason for revert: BUG=456215 Original issue's description: > Add Autofill to webview > > The change in the chrome_autofill_client.cc is needed to enable the autofill popup on > Mac. > > BUG=447938 > TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username > with an incorrect password. After the password error appears, you should be able > to autofill that username. > > Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285 > Cr-Commit-Position: refs/heads/master@{#314889} TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,noms@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=447938 Review URL: https://codereview.chromium.org/887003007 Cr-Commit-Position: refs/heads/master@{#315122}
-
xdai authored
BUG=455084 Review URL: https://codereview.chromium.org/893963004 Cr-Commit-Position: refs/heads/master@{#315121}
-
jbudorick authored
BUG=428729 Review URL: https://codereview.chromium.org/905813002 Cr-Commit-Position: refs/heads/master@{#315120}
-
bengr authored
AwURLRequestContextGetter::SetKeyOnIO now calls into the DataReductionProxyAuthRequestHandler that is managed by DataReductionProxyIOData. BUG=453519 Review URL: https://codereview.chromium.org/881893004 Cr-Commit-Position: refs/heads/master@{#315119}
-
zmo authored
This is a pure code moving around CL. No logic change at all. So we add helper functions to pack/unpack strings to/from a bucket, so the code generator is now much simpler. This is to get the pack/unpack functions to be used by glGetUniformIndices. BUG=429053 TEST=gpu_unittests, webgl_conformance R=sievers@chromium.org Review URL: https://codereview.chromium.org/902943002 Cr-Commit-Position: refs/heads/master@{#315118}
-
rtenneti authored
cache sends a CHLO and another connection that doesn't wait to load server config from disk cache and sends INCHOATE_HELLO. This is not enabled. QuicStreamFactory tests with this flag enabled and disabled. Tested chrome and all unit tests with this flag enabled. R=rch@chromium.org Review URL: https://codereview.chromium.org/881133004 Cr-Commit-Position: refs/heads/master@{#315117}
-
rickyz authored
This unindents the lines about PID/network namespaces, since those now apply to both the setuid or unprivileged namespace sandbox. BUG=312380 Review URL: https://codereview.chromium.org/873283004 Cr-Commit-Position: refs/heads/master@{#315116}
-
rtenneti authored
Making the (deprecation-in-progress) congestion field write only. This is a bit of a hack because technically it's "required" for QUIC_VERSION_23 but as all the internal servers and all of chrome builds picking up this change consider the field optional despite the version, it should just Work (TM). I was hoping to stop sending the congestion fields for v24 clients but that is not safe until the internal server fleet doesn't consider it a required field for negotiated()=true. Bah. No longer reading the (deprecated) congestion fields for QUIC. Merge internal change: 85158634 https://codereview.chromium.org/898233003/ Improving junk packet handling for QUIC by ignoring packets with client port 0. Merge internal change: 85067984 https://codereview.chromium.org/885713009/ Removing deprecated flag FLAGS_quic_use_initial_rtt_for_stats. Merge internal change: 84999682 https://codereview.chromium.org/883393008/ Adding more error logging for failed QUIC writes. Merge internal change: 84989992 https://codereview.chromium.org/898243002/ Further cleanup to QuicAckNotifier and QuicAckNotifierManager. No functional change. Merge internal change: 84784925 https://codereview.chromium.org/880403006/ Remove an unneeded hash_set from QuicAckNotifierManager. No change in behavior. Merge internal change: 84637544 https://codereview.chromium.org/872403007/ Minor cleanup and optimization of QuicConnection::IsConnectionClose. Merge internal change: 84624803 https://codereview.chromium.org/903973002/ Rename QuicAckNotifier's AddSequenceNumber to OnSerializedPacket. No functional change. Merge internal change: 84624660 https://codereview.chromium.org/867293004/ R=rch@chromium.org Committed: https://crrev.com/ff331b65e0aef293ed6f1d0954b83ae17cc66d28 Cr-Commit-Position: refs/heads/master@{#315086} Review URL: https://codereview.chromium.org/903013002 Cr-Commit-Position: refs/heads/master@{#315115}
-
skare authored
BUG=456214 Review URL: https://codereview.chromium.org/885233004 Cr-Commit-Position: refs/heads/master@{#315114}
-
thestig authored
Revert of Linux: Enable multi-threading with the gold linker. (patchset #2 id:20001 of https://codereview.chromium.org/894463003/) Reason for revert: Several CrOS folks are reporting linker errors locally, even though the CrOS buildbots are green. Original issue's description: > Linux: Enable multi-threading with the gold linker. > > BUG=161942 > > Committed: https://crrev.com/226488abee2adbdb6e54e5bfca1c3b2f52f2da2d > Cr-Commit-Position: refs/heads/master@{#314991} TBR=thakis@chromium.org,tzik@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=161942 Review URL: https://codereview.chromium.org/909583002 Cr-Commit-Position: refs/heads/master@{#315113}
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/904063003 Cr-Commit-Position: refs/heads/master@{#315112}
-
dnicoara authored
Need to turn it off to reduce the power used by the display when idling. BUG=chrome-os-partner:35458 TEST=Wait for the displays to turn off and check with 'modetest -c' that the DPMS state is off Review URL: https://codereview.chromium.org/877213005 Cr-Commit-Position: refs/heads/master@{#315111}
-
atwilson authored
We want to restrict certain behavior (such as network reporting) to auto-launched kiosk apps. This change updates KioskAppManager to track whether a given app was auto-launched (which is different from whether a given app is *currently* set to auto-launch, because policies can change while an app is running). BUG=452968 Review URL: https://codereview.chromium.org/900553006 Cr-Commit-Position: refs/heads/master@{#315110}
-
Sadrul Habib Chowdhury authored
Instead of using the id of the worker-thread to keep track of the thread to run the image-loader callbacks on, use the task-runner of the thread instead. BUG=none R=mkwst@chromium.org Review URL: https://codereview.chromium.org/897733002 Cr-Commit-Position: refs/heads/master@{#315109}
-
mef authored
BUG=441466 Review URL: https://codereview.chromium.org/904033004 Cr-Commit-Position: refs/heads/master@{#315108}
-
rileya authored
BUG=456001 Review URL: https://codereview.chromium.org/887243003 Cr-Commit-Position: refs/heads/master@{#315107}
-
achaulk authored
If a quad is fully transparent then it shouldn't block overlays. For now we allow some SOLID_COLOR quads through Review URL: https://codereview.chromium.org/880023005 Cr-Commit-Position: refs/heads/master@{#315106}
-
kelvinp authored
Cause: The crash opt-in setting is sometimes controlled by domain policy, which will prevent the user from enabling it. However, this is not communicated to the user properly. Fix: - Shows a tooltip "This setting is controlled by your domain policy" if necessary. - Hides the check box if the domain doesn't allow usage stats collection as an empty disabled check box offers no value to the user. BUG=388864 Review URL: https://codereview.chromium.org/898163002 Cr-Commit-Position: refs/heads/master@{#315105}
-
dfalcantara authored
* Use AppBannerInfoBars instead of AppBannerViews for Android app promos. - Button doesn't install anything. - Layout is still incorrect. BUG=453170 Review URL: https://codereview.chromium.org/896243004 Cr-Commit-Position: refs/heads/master@{#315104}
-
pavely authored
Currently when user signs out GCMInvalidationBridge stays registered with GCMDriver preventing it from shutting down. GCMInvalidationBridge needs to unregister when user signs out. BUG=446349 R=jianli@chromium.org Review URL: https://codereview.chromium.org/899353002 Cr-Commit-Position: refs/heads/master@{#315103}
-
dougk authored
BUG=none Review URL: https://codereview.chromium.org/864663004 Cr-Commit-Position: refs/heads/master@{#315102}
-
Ken Rockot authored
This reverts commit 101f015e. Causing http://crbug.com/456224. While this original CL should be fine, it's not; we need to revert until we understand why. R=marshall@chromium.org BUG=456224 Review URL: https://codereview.chromium.org/892463005 Cr-Commit-Position: refs/heads/master@{#315101}
-