- 26 Aug, 2020 40 commits
-
-
Sean Gilhuly authored
SkiaRendererPixelTestWithOverdrawFeedback/2.TranslucentRectangles is now RendererPixelTestWithOverdrawFeedback.TranslucentRectangles/SkiaDawn after recent changes. The filter wasn't updated, but the test is now passing on the bots. Remove it from the filter file. Bug: 1061988 Change-Id: Icf043283ac95d0a32b68432a34a4793bafb6628a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377107Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#801780}
-
Henrik Boström authored
This reverts commit 864e565b. Reason for revert: Not the culprit of the bot failures Original change's description: > Revert "[Perfect Negotiation] Re-enable temporarily disabled WPTs." > > This reverts commit 154433da. > > Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 > > Original change's description: > > [Perfect Negotiation] Re-enable temporarily disabled WPTs. > > > > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has > > rolled into chromium, we can re-enable the disabled tests and update > > the expectations that more tests are passing. > > > > Follow-up CLs will make us pass even more tests. > > > > Bug: chromium:1060083 > > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707 > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801716} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1060083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872 > Reviewed-by: Amr Aboelkher <amraboelkher@google.com> > Commit-Queue: Amr Aboelkher <amraboelkher@google.com> > Cr-Commit-Position: refs/heads/master@{#801762} TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com # Skipping bots on reland because the revert was by mistake and there # are CL dependencies. NOTRY=True Bug: chromium:1060083 Change-Id: Ic542d9d2a6051de05073b59a21a2dee7ae81eafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376814Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801779}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc5e5f36. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 4e9cbb66 "Fixed test/reference mismatch for border." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I234b171fda432540cad21c18a24a0ee2f6b0faf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378005Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801778}
-
Bo Liu authored
Rename "virtual context lost" to just context lost and share the implementation for all GLContext subclasses: * MakeCurrent is no longer virtual and add virtual MakeCurrentImpl * MakeCurrent will mark context as lost if MakeCurrentImpl fails * Similar change for CheckStickyGraphicsResetStatus * Update all subclasses to override the impl methods. * Unit test mock needs to be updated to override the MakeCurrentImpl * Some unit tests directly call GLContextStub::MakeCurrent instead of the mock implementation, which now needs to be updated to MakeCurrentImpl Bug: 1115482 Change-Id: I50c6fa9364ca8fff7be589c9ac799c495c034f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363357Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801777}
-
Roman Sorokin authored
It's not actually registered before device is owned. Bug: none Change-Id: I124f4cecb7ea440e9b746827dc3b37fd0ccd48fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377805Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801776}
-
Rob Buis authored
Add a method to find the category for a given (String, form) pair as described in the spec [1] as well as unit tests. [1] https://mathml-refresh.github.io/mathml-core/#operator-dictionary Bug: 6606 Change-Id: I87aceb73720bf0e023d11767cde823ec4e04f185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375207Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#801775}
-
Benjamin Beaudry authored
This CL ensures that positioned nodes are inserted in the right fragmentainer and at the appropriate start offset. Bug: 1079031 Change-Id: I2ae47f4c210c64843d6e260b94165bdd25f79879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332300Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801774}
-
HyunJi Kim authored
Bug: 1010217 Change-Id: Icaffadcc037835b3c498a01b7a71d2ac77fc8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375010 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801773}
-
Morten Stenshorne authored
On the layout object side, all children of a fieldset are wrapped inside an anonymous fieldset contents block. We'll detect during layout which of the legend children (if any) will become the rendered legend. Unlike all other in-flow children of a fieldset element, whose containing block is the wrapper, the containing block of the rendered legend is the fieldset layout object itself (not the wrapper child), so if we change / remove the rendered legend, the wrapper won't be marked for layout. Bug: 1119400 Change-Id: I5b898af8c7b7e3687def6a2333d43a8ba6af09b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374526Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#801772}
-
Erik Chen authored
The ChromeOS platform team still relies on these histograms. This CL extends the expiry and updates the owners of the histogram. Bug: 1084030 Change-Id: Id28dc41480e7106b30a5c77f6a18243272b4e062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368540 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801771}
-
dizg authored
Bug: 1115247 Change-Id: I0b4c90250ea532b6d8d427437073a785b54b8515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373082Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#801770}
-
Amr Aboelkher authored
This reverts commit dc5e5f36. Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 Original change's description: > Import wpt@a75c689d52f70baf607c8e6c1bb84c57f48badda > > Using wpt-import in Chromium c21b8329. > With Chromium commits locally applied on WPT: > 9f52c7e4 "COOP: add reporting to redirects" > d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" > > > Note to sheriffs: This CL imports external tests and adds > expectations for those tests; if this CL is large and causes > a few new failures, please fix the failures by adding new > lines to TestExpectations rather than reverting. See: > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > > Directory owners for changes in this CL: > futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: > external/wpt/css/css-cascade > > NOAUTOREVERT=true > TBR=robertma@google.com > > No-Export: true > Change-Id: I1a13539eede33cfc0ecb838dd86dbcd04e84481d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377457 > Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#801734} TBR=robertma@google.com,wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com Change-Id: I35b79183bad9975df7d6f87fb6bbe2f50cb9e2ed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377493Reviewed-by:
-
Yuki Shiino authored
Blink is implementing CSSStyleDeclaration's IDL attributes as named properties (pretending to be IDL attributes). Recently, the named property's implementation is improved[1] to better conform to Web IDL specification, and "deletion of named properties" now throws an exception when named deleter is not defined. So, accordingly CSSStyleDeclaration has to _better pretend_ to have IDL attributes, which are deletable, by defining a noop deleter. This patch introduces such a noop deleter. [1] https://crrev.com/c/2335713 Bug: 1121628 Change-Id: I338c064b9a2ea88fa97169a9e904da0a8613e0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377035Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#801768}
-
Benoit Lize authored
The build file wants to exclude TCMalloc, but it also excludes PartitionAlloc. This is incompatible with PartitionAlloc everywhere. Bug: 998048 Change-Id: I5c234c70bd0e3b73d69fd8e648ac36be1510d872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377710Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jordan Oroshiba authored
Change is being made in order to enable future changes in behavior between the All Site Setting pages and other categories. Bug:1074245 Change-Id: I59d50af6a5c1f681ffb9b0ff9ebdf89cd14ebcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252560 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#801766}
-
Antonio Gomes authored
... instead of base::EndsWith(). BUG=787254 R=guidou@chromium.org Change-Id: Ia14a71fc3d04918cbc8d65738ad7bca3b0cb6dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363553 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#801765}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1303230f0260..b77998026e82 2020-08-26 alexrudenko@chromium.org Simplify the grid tooling settings 2020-08-26 tvanderlippe@chromium.org Typecheck bindings/BlackboxManager.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListControl.js with TypeScript 2020-08-26 szuend@chromium.org [ts] Type-check ui/ListWidget.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I899bfa5e974729b0c75fcb3d246e5027a8c21361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801764}
-
Jeremy Roman authored
This reverts commit 6a1fac8e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Mostly remove refcount thrashes of value in setAttribute. > > Relanding https://chromium-review.googlesource.com/c/chromium/src/+/2351950 > > This mostly removes the refcount thrashes in Element::setAttribute() > which accounts for nearly 13% of regression in blink_perf.bindings > set-attribute.html story when StringImpl is made threadsafe. > > Because of some reentrant behavior in Element::setAttribute() -> > Element::SetAttributeInternal() -> Element::DidModifyAttribute() -> > Element::AttributeChanged() -> Element::ParseAttribute() -> > Element::setAttribute(), the qname for the Attribute, the old value, > and the new value cannot be easily transfered into the Element's internal > ElementData::Attributes() collection while also publishing the change to > observers via the DidModifyAttribute() call. Removal of that thrash will > be done in a follow-up CL. > > Bug: 1083392 > Change-Id: I7f7f4bfa22a2e553e703c0375bd04bb77f71de23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369348 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801214} TBR=ajwong@chromium.org,jbroman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1083392,1121429 Change-Id: Ia42214b62e1efc218afb055fcc60bea52039587c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376705Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#801763}
-
Amr Aboelkher authored
This reverts commit 154433da. Reason for revert: linux-trusty-rel build and external blink web_driver tests are failing, and that's a possible root cause. See: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15138 Original change's description: > [Perfect Negotiation] Re-enable temporarily disabled WPTs. > > Now that https://webrtc-review.googlesource.com/c/src/+/180620 has > rolled into chromium, we can re-enable the disabled tests and update > the expectations that more tests are passing. > > Follow-up CLs will make us pass even more tests. > > Bug: chromium:1060083 > Change-Id: Ia1e1432746293fa395e5bda72e163f223f316b7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377707 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801716} TBR=hta@chromium.org,hbos@chromium.org Change-Id: I3250545b0fff846a8c4c3a9352f5a342ae613599 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377872Reviewed-by:
-
Fergus Dall authored
Bug: None Change-Id: Ifbda9222895575bb2471036df15c4778fe7b89bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374935 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#801761}
-
Alice Wang authored
This CL renames AccountPickerBottomSheetState as ViewState to make the code more readable. There is no behavior change in this CL. Bug: 1121499 Change-Id: Idaa9d72238e6012fe6f71dec7928ed41760d8582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375291Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801760}
-
Weilun Shi authored
The split histogram_suffies_list.xml under histograms_xml/ should also be pretty-printed. Bug: 1121852 Change-Id: Icbdc0891c214be95b51a94c0a8520b2eb2e6aaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376885 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801759}
-
Alice Wang authored
This CL cleans up AccountPickerBottomSheetTest. Bug: 1121536 Change-Id: I00d8e5506bf38411bfd16a664c1667ebbd074379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374867Reviewed-by:
-
Elly Fong-Jones authored
These importer tests rely on loading some dylibs out of //chrome/test/data/firefox3_nss_mac, which aren't yet (and may never) be available for arm64. Bug: 1121685 Change-Id: Ifb316784e3ffd851d3b507baa630f746695bdb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375895Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801757}
-
arthursonzogni authored
Without this, Canary users won't see the chrome://flags Bug: 1059303 Change-Id: I30874282ac3be605198b8e44d2e831e05289d502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377490 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#801756}
-
Martynas Sinkievic authored
This CL adds support for removing affixes from the |parseable_name| attribute stored in a |FormStructure|. The current version only removes common prefixes longer than 16 chars. The new implementation also removes both common prefixes and suffixes at least as long as |kMinCommonNameAffixLength| chars (currently set to 3). Change-Id: I53c34ca169ba669df289392b2942dfe116705056 Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332193 Commit-Queue: Martynas Sinkievič <marsin@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#801755}
-
Yi Gu authored
TBR=dcheng@chromium.org Bug: None Change-Id: Id34814442f8b763782eb70657de33b57a7e03617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375799 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801754}
-
Michael Chang authored
Control Service was never terminating due to lacking the App Server's TaskStarted and TaskCompleted methods. Change-Id: I16da30af01fbf9a04ec3996dd893548fd3699f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377147 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This status only gets sent when the UI and bridge are being torn down while a check is running. At this point, no UI update is needed. Bug: 1121145 Change-Id: I0a413da4432d346a07f7252263c2626ae93aadac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377865Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#801752}
-
Owen Min authored
EnableOriginBoundCerts EnableMemoryInfo ExtensionInstallListsMergeEnabled are all policies that have never launched and they will be deleted. VariationsRestrictParameter and DeviceVariationsRestrictParameter are internal policies and will be hidden with the new feature flag BYPASS_POLICY_COMPATIBILITY_CHECK=[Device]VariationsRestrictParameter are two policies launched years before and we only change the way of hidding the policies. Bypass the check so that we are not foced to use the current milestone. Bug: 1117637 Change-Id: I9d2cf9d77accc2e3f26d54bd5632347e285cdff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376528Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801751}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ead4ca052b99..5da7327358e3 2020-08-26 rmistry@google.com Use GCLIENT_PY3=0 in recreate_skps.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ie4d0202ee849c7ccd2aced134e1d5c334f368087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377855Reviewed-by:
-
Brian Osman authored
The color filters used for exotic color space conversion in skia_renderer are built on SkRuntimeEffect. The required signature for main() in the SkSL has changed, this just adapts to the new signature and semantics. Bug: skia:10613 Change-Id: I031cbd597810ec9629b3308db4548c5842b0b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375932Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#801749}
-
Friedrich Horschig authored
The dialog now contains banners which should not extend to the borders of the dialog since they don't user a lot of whitespace. Instead, they should use the same padding that is used for texts, too. The change applies to all users of the dialog but depends on the password check feature being enabled. Once the check is launched (which seems the most-likely scenario), we can inline the layout params into the layout file. Mocks and screenshots in the linked bug. Bug: 1121959, 1092444 Change-Id: Ifef5352c08a159e4e6bc01e024e42fe9e82f7960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377728Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801748}
-
ssid authored
The version number is not sufficient to differentiate between 32 or 64 bit binaries for symbolization, so include the module debug id in trace for correct symbolization. Change-Id: I3411821b55b9ce2c73ea616bf791866542aebe0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373235Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#801747}
-
Clemens Arbesser authored
See linked bug for details. Bug: b/166406201 Change-Id: Ie66c1a19d0f657ba25c1737211974603e5cdf08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376849 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#801746}
-
Noel Gordon authored
Comment only change. Use "metadata Worker" everywhere, fix grammatical errors, createError_ is not just used by the Worker, add minor TODO. Bug: 1114622 Change-Id: I009879b0763c7d33114acfcf1353b713e9924c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377331 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801745}
-
Morten Stenshorne authored
This flakiness is probably not limited to the virtual/layout_ng_block_frag/ version of the test, but the test seems too valuable to mark as flaky in general. TBR=rakina@chromium.org Bug: 1121965 Change-Id: If6c6df6ecc99325a80115b172000f681894586ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377927Reviewed-by:
-
nancylingwang authored
|icon_scale_| is used to decode the compress icon file, and when encode the uncompressed icon, |icon_scale_for_compressed_response_| is used for the scale. |icon_scale_for_compressed_response_| is set for web apps in the function IconLoadingPipeline::LoadWebAppIcon, but not set for Crostini icon load function LoadIconFromCompressedData, so modify LoadIconFromCompressedData to set |icon_scale_for_compressed_response_|, the same as the web apps implementation. BUG=1115831 Change-Id: I6add4f481d7c0390895352b8cdad4441c2820d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377168Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801743}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99b0f8d26cbe..c093d9ad623d 2020-08-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d4203a22..09ff1141 (801568:801677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I79979ccece7daa9cb09370c183c2c4432b326fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377852Reviewed-by:
-
chrome://flagsJonathan Mengedoht authored
Bug: 927473 Change-Id: I3023effa43f57cf5a106e11667028818f4b25df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375293Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Cr-Commit-Position: refs/heads/master@{#801741}
-
