- 01 Nov, 2019 40 commits
-
-
Scott Violet authored
This is called when the page uses window.open, or an anchor with an href=blank. BUG=none TEST=none (will be covered via instrumentation test) Change-Id: I0e0b1aeb776f1eb4712295bcd790c357dcf0a047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894673 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711889}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab7bec343496..c39a77883d7b git log ab7bec343496..c39a77883d7b --date=short --no-merges --format='%ad %ae %s' 2019-11-01 iannucci@chromium.org [gclient] Reset to parent commit with rebase_patch_ref=False instead of master. Created with: gclient setdep -r src/third_party/depot_tools@c39a77883d7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ifc638852ad10a622c64d6052e597c2236586e286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711888}
-
Bruce Dawson authored
crrev.com/c/1713826 flipped slashes from / to \ so that clang-cl commands could be copy/paste run on Windows. While investigating a recent compiler bug I had the need to copy/paste run linker commands on Windows and realized that I hadn't flipped those slashes. This change finishes the job, for lib/link commands, tested with component and non-component builds of base. Change-Id: If5570ab3093b42908bebab9944cde82da31a055d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894094 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711887}
-
Robert Sesek authored
This is a reland of 856b8913 The iOS issue was resolved by 9124e345 and a corresponding internal CL. Original change's description: > Limit GN visibility of libxml for security audit control. > > This splits the libxml_utils helper classes into xml_reader and > xml_writer targets. The xml_writer can be safely used from any target. > The xml_reader has strictly limited visibility to locations that are > audited by the Security Team. Direct access to the libxml target is now > also limited. > > Bug: 699306 > Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711536} Tbr: thakis@chromium.org Tbr: davidben@chromium.org Tbr: rohitrao@chromium.org Bug: 699306 Change-Id: I633309f7efc3c920b97dced173607d73dc48d991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894877 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711886}
-
Gang Wu authored
Bug: 1020609 Change-Id: I84fb6c13ca3ab0d3002853b17772775a7ff3eb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895968Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711885}
-
Lei Zhang authored
- For input and generated PDFs, validate all the page sizes. - Set the page size / printable area to 72 DPI, which is what the PdfNupConverterClient normally receives. Bug: 1004529 Change-Id: I615b014c08332a55c395f06352424fe1c96a4601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895071 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711884}
-
Oriol Brufau authored
Currently markers are assigned a mostly empty style, it just inherits from the list item and has some customizations like `display`. This patch makes them use the style of the ::marker pseudo-element. The inheritance is also from the list item, and the customizations are applied afterwards. The change only affects markers originated by real elements. Markers originated by ::before or ::after pseudo-elements should get the styles from ::before::marker or ::after::marker, but this will be addressed in a follow-up patch. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo BUG=457718 TEST=external/wpt/css/css-pseudo/marker-and-other-pseudo-elements.html TEST=external/wpt/css/css-pseudo/marker-color.html TEST=external/wpt/css/css-pseudo/marker-font-properties.html Change-Id: Ide2fbc344e4732257044ebd3e7966906af21c434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893265Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#711883}
-
Andrew Xu authored
This CL helps to calculate the hotseat's state based on the app list's visibility when the chromevox is enabled. If the app list shows, it ensures that the hotseat's state is kShown instead of kExtended. Bug: 1020417 Change-Id: I2354af512939c91bbcf707115ab9882856c6c78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893961Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711882}
-
dpapad authored
Fix cases where the focus was lost when navigating back from - chrome://settings/content/serialPorts - chrome://settings/content/all Bug: None Change-Id: Ibbd149272593264131787bae1df9106e8de60b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894832 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711881}
-
Tarun Bansal authored
This DCHECK made sense earlier when we wiped out the list if the preview type was no longer enabled. Issue 986888 fixed that and now this DCHECK triggers incorrectly on debug builds. Change-Id: I99fe1444f54617b4e3717005130bd3375c99651d Bug: 986888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892434Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711880}
-
Hector Carmona authored
Bug: 1014585 Change-Id: I786a8ca77bf0195463af9b560b59a82eb5ad217c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888192 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#711879}
-
Lei Zhang authored
Switch to base::JSONReader::Read() and also modernize base::Value usage in the modified functions. Bug: 925165 Change-Id: Ie0062059b2ab1a1c28e4bd658074d6ce9bd658ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894312 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711878}
-
Lucas Furukawa Gadani authored
This is a reland of 38f657d5 Original change's description: > Convert extensions to use the URLResponseHead mojom types. > > Bug: 984550 > Change-Id: I885fc575b49c4049b83b17cc4c2248daf2525b4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876974 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709596} Bug: 984550 Change-Id: I7876e758de65f6a5e0ff2af5954c738fa951343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891149Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711877}
-
Gang Wu authored
From https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZVGcxnB8fbou/files/MCEJu8Y2hyDScU0HXgbgxLFDny2Xg0-sdc8 The padding below menu should be 12dp(padding below icon) + 24dp(icon height) + 8dp(padding between menu and icon) Bug: 1011061 Change-Id: I30b9c5efbef46b071fbdf3fda831b098aac043c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894050Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711876}
-
Shimi Zhang authored
This reverts commit a72a5f6b. Reason for revert: After a discussion with Torne and Changwan, we feel it is less meaningful to put a restriction there. Hence the revert. Original change's description: > [JJI] Add validation for jsObjectName > > Since we are not using jsObjectName until the next navigation, it will > only until then we could tell if the parameter is valid or not, if it > is not valid, the injection will fail sliently. We want to provide a > early exception for developer to know if the object name is valid or > not. > > Since it is hard for us to valid the full set of the allowed JavaScript > variable name, we limited the scope to a manageable subset of it. > > Bug: 918065 > Change-Id: I74909768fc9695e6d33302d880eb211a4b250c62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894181 > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711795} TBR=torne@chromium.org,changwan@chromium.org,ctzsm@chromium.org Change-Id: Ic86d9b1681f7c806e085679b75cb713cc3b6a5c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896048Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711875}
-
Peter K. Lee authored
PrintControllerTestCase tests are unconditionally disabled. I looked into enabling them by rewriting them using XCUITest. It turned out that XCUITestElements do not give access to the actions on the Activity Services menu. Deleting tests since they are not serving any purpose. Bug: 990947 Change-Id: Ie17efff877e67ab2b1b3feb9e13bd9962e008976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894612Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#711874}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/855e8b1bc29d..aaa64b76c0b4 git log 855e8b1bc29d..aaa64b76c0b4 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 amaiorano@google.com Modify Blitter to implement FunctionT 2019-11-01 amaiorano@google.com Modify SetupRoutine to implement FunctionT 2019-11-01 amaiorano@google.com Modify PixelRoutine to implement FunctionT 2019-11-01 amaiorano@google.com Modify VertexRoutine to implement FunctionT 2019-11-01 amaiorano@google.com ReactorUnitTests: use FunctionT 2019-11-01 amaiorano@google.com Reactor: add type-safe FunctionT and RoutineT Created with: gclient setdep -r src/third_party/swiftshader@aaa64b76c0b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561,chromium:b/143479561 Change-Id: Idffec085f5c466a7cea070c82320656bcc0b87b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895875Reviewed-by:
-
Ken Rockot authored
When moving Network Service off of Service Manager, the in-process NetworkService object instance changed to never be destroyed. Some tests expect the destruction to happen by the time BrowserMain is done. This change ensures that we destroy the NetworkService instance before full browser shutdown is complete. Bug: 1016880 Change-Id: I71436d21bb66e3a318f7143d16c8bb3b0d546df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894018Reviewed-by:
-
Mohamed Heikal authored
Adds documentation about each check that is run and how to fix it if it fails as well as some general information about the links the trybot outputs. Change-Id: Iaa7507161707b392d2a56c2851a61d2cec09b4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894622 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#711871}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/f2c4e3ef544b..4c908f06d53c $ git log f2c4e3ef5..4c908f06d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 fayang gfe-relnote: Do not add peer_max_ack_delay if an immediate ACK is expected when calculating PTO timeout. Protected by existing gfe2_reloadable_flag_quic_enable_pto. 2019-11-01 bnc Simplify ConstructMisFramedEncryptedPacket() signature. 2019-10-31 nharper gfe-relnote: Swap order of operations in TlsClientHandshaker::FinishHandshake. Protected by --quic_supports_tls_handshake 2019-10-31 fayang gfe-relnote: Use PTO_RETRANSMISSION instead of PROBE_RETRANSMISSION for PTO retransmission. Also populate transport connection stats for debugging purpose. Protected by existing gfe2_reloadable_flag_quic_enable_pto. 2019-10-31 ianswett Convert kDefaultMaxCongestionWindowPackets to a flag. 2019-10-31 fkastenholz Change GetMinStreamSize API to use size_t, rather than uint16_t avoiding truncation 2019-10-31 bnc Use QpackEncoder::InstructionWithValues to refactor QpackInstructionEncoder interface. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I3358f06b7faa27a7c80d282c36ec7df5e6d0cdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895895Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#711870}
-
Jeff Yoon authored
The filtered (by dimensions) pool for ToTiOS* has one bot that is on Mac 10.13 (build227-m9), causing infra failures. Binding ToTiOS* bots to min required os version (10.14) until all bots have been upgraded. Change-Id: I42902d6f880dff1c7d2b245e65c3ff339e645d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894306Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711869}
-
Henry Jian authored
This is a reland of f0ecb909. Previously, the original commit was reverted to land another CL and push the shell apk immediately. There was nothing wrong with the original CL. Since the other CL was landed and pushed, we can now reland this CL. Original change's description: > [Android WebAPK] Link to a shortcuts file from the manifest. > > Instructions for enabling Android shortcuts: > https://developer.android.com/guide/topics/ui/shortcuts/creating-shortcuts > > This is the first step for enabling shortcuts. The server will populate > shortcuts.xml depending on the Manifest shortcuts provided (and also > generate additional string resource files). > Bug: 1010471 > Change-Id: I2e0a6118a22869766e4b5e849dabc6533cd2d306 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864805 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707889} Bug: 1010471 Change-Id: Idb2c09bc6d259766f79f837bf8de9a9e2278933b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895856Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#711868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41eccb9d43eb..029ba5a777d6 Created with: gclient setdep -r src-internal@029ba5a777d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:1018879,chromium:1018879,chromium:None,chromium:1018879,chromium:None Change-Id: I4f70d937b966f9dae7ad8ea8c98500db71515ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711867}
-
minch authored
See the recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiRldva1VIaVJPNWRrUXlfUmtXOV9zdEFmVDZR/view?usp=sharing Bug: 1016547 Change-Id: Ifb8c85dbda12b1fa7088d37beda6b8279b8ea6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881811Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#711866}
-
Henry Jian authored
Previously, the update check version is 109. From 109 to 116, we added a few bug fixes. We'd like to bump the version to include those fixes for updates. Bug: 977173 Change-Id: I95c06658753d4fcb66b772be8c8d934dffcf5d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895955Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#711865}
-
Olivier Yiptong authored
Plumb through FileInfo to the renderer, and populate the returned File object with the correct value. BUG=1018945 Change-Id: Ic11d819ea83be49df831bbda37519779be0b8781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891463Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#711864}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e3c523e49ef5..a95cbb23f5dc git log e3c523e49ef5..a95cbb23f5dc --date=short --no-merges --format='%ad %ae %s' 2019-11-01 jintao@chromium.org Add gdisp to usergroup_baseline Created with: gclient setdep -r src/third_party/chromite@a95cbb23f5dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ica85adb1f741475e35e364be2378ac664c381931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895779Reviewed-by:
-
Thomas Lukaszewicz authored
Added warning and exit when attempting to use the single_process flag to run the tests and launcher in a single process. Bug: 460513 Change-Id: I344f4477580ed81490002cd13ef5f5e4ed7a021d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894757Reviewed-by:
-
Nate Fischer authored
No change to production logic. This adds a test to ensure we do *not* log bluetooth or usb data. We do not currently log this, but it seems like a good idea to assert we don't start logging this accidentally. This leaves a comment to explain under which conditions it's OK to log this data (and, by extension, modify the test case). Bug: 1011991 Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* Change-Id: I7ba4fdd957c034eda405cbca10d07d1064eac66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889232 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711861}
-
John Budorick authored
Bug: 1001171 Change-Id: Ic27ad2d1291061bc17fb9499ba3e142e81d53a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895168 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: Ia54d48b9424c0cc048d442bf47fd3bccf8b2e907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895867Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711859}
-
Ted Meyer authored
This happens synchronously with the destruction of WebMediaPlayerImpl so that the devtools backend for MediaLog knows it shouldn't be sending events since the page may have been destroyed. Events that happen after WEBMEDIAPLAYER_DESTROYED get dropped from _only_ the devtools version. This should fix the nullptr deref bug caused by the destruction order of the blink objects and the WebMediaPlayerImpl::DestructionHelper. Bug: 794255 Bug: 1014433 Change-Id: I25e2110a31561367baf7104c77a8e5301b5afb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891078 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711858}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c93813be129d..9dd3e34fd3c3 git log c93813be129d..9dd3e34fd3c3 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 skyostil@google.com Merge "TrackEvent: Add support for arguments" Created with: gclient setdep -r src/third_party/perfetto@9dd3e34fd3c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idcccd7adc663194217ef7cb0ada6f9edc5f3618d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895792Reviewed-by:
-
Nic Champagne Williamson authored
This change adds support for the Windows system high contrast (HC) colors to themes, native themes, and typography. These platform-provided colors will take precendence and override normal colors when HC mode is enabled on Windows. This change will be followed up by further commits to enable HC colors to be used for interactive elements and the ink drop, and better specific implementations for various controls. The NativeTheme::ColorScheme has been updated to include a value for when the platform is providing the HC colors. This is currently only used on Windows when HC mode is enabled and a specific theme isn't requested. When in HC mode, the Windows native theme will return specific system colors for the color IDs. ThemeService has been updated to work in a similar manner, checking for HC mode on Windows and returning specific system colors as needed. Additionally, the IncreasedContrastThemeSupplier has been turned off for Windows HC. The typography provider has been updated to provided better style/context to color ID mappings. The title bar is now always custom drawn on Windows 10 even in HC mode. Bug: 956295 Change-Id: Ibc92dfcab5f94c06cc628b7338b8d9cfac905332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887931 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711856}
-
Lei Zhang authored
- Don't use ntp_tiles:: inside namespace ntp_tiles. - Consistently drop curly braces for 1 line if-statements. Change-Id: I67706595e1ccd13c0a059e6297c854a838d12f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895790Reviewed-by:
-
Megan Jablonski authored
Bug: 976352 Change-Id: Ia17703673ddbeac77c3ce458dfc431db351c13e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877148Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711854}
-
Andrew Xu authored
When the hidden icon of the scrollable shelf receives the a11y focus, scrollable shelf should show the icon by translating the shelf view. Bug: 1016028 Change-Id: I90013aa4fc07ed296cffdb6f02809e15f5377fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891111Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL adds a parser for parsing report endpoints on the network service. This will allow the browser enforced frame-ancestors CSP to report CSP violations using the reporting API. Bug: 759184 Change-Id: I015829a93eb30b52d77bcc34ced535ddf40621f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838159 Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711852}
-
Jeremy Apthorp authored
fixes this build error in MSSTL: ../../ui/events/blink/prediction/linear_resampling.cc(82,12): error: no member named 'min' in namespace 'std' std::min(kResampleMaxPrediction, events_dt_ / 2.0); ~~~~~^ ../../ui/events/blink/prediction/linear_resampling.cc(85,12): error: no member named 'min' in namespace 'std' std::min(sample_time, events_queue_[0].time_stamp + max_prediction); ~~~~~^ 2 errors generated. Change-Id: I412007ebe847afaa667bb606c01e2d5453123089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893754Reviewed-by:David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#711851}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27bd02bf2385..840ecb38c04e git log 27bd02bf2385..840ecb38c04e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 perezju@chromium.org [Telemetry] Move DummyStory and friends to test_stories Created with: gclient setdep -r src/third_party/catapult@840ecb38c04e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1008852 Change-Id: I243b6775e2d872c0cebaf8a67c4855b0e302099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895815Reviewed-by:
-
