Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 18 Apr, 2020 2 commits
    • Gabriel Charette's avatar
      [base] Add trace events for ::GetQueueStatus and ::PeekMessage in the Win pump. · 4191829c
      Gabriel Charette authored 
      CPU stack sampling profiler jank analysis is hinting at these methods
is this a bias or is there really jank in here? Add trace events to
balance stack sampling with slow reports.

Added trace events to both MessagePumpForUI::ProcessNextWindowsMessage
and MessagePumpForUI::WaitForWork's lookups. The stack sampling
analysis seems to be hinting more at ProcessNextWindowsMessage for
now, but a lot of this gets inlined in Release builds so it's hard to
tell for sure.

This CL also highlights a discrepancy between the checks in
ProcessNextWindowsMessage and WaitForWork. WaitForWork uses
MSG msg = {0} whereas ProcessNextWindowsMessage uses an uninitialized
MSG object. It doesn't seem necessary for this structure to be
initialized, will make it consistent in a follow-up CL.

R=fdoray@chromium.org

Bug: 899897
Change-Id: Ibd8a43e0346e6eb7e09432582a76235ed350ae6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153321
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760262}
      4191829c
    • Jesse McKenna's avatar
      desktop-pwas: WebApp.Launcher.UpdateResult metric · 56fe148e
      Jesse McKenna authored 
      This change adds the WebApp.Launcher.UpdateResult metric, which will
report failures updating Progressive Web App (PWA) launcher
executables.

On Windows, each PWA has a separate launcher executable in its web-app
data directory (located at
<User Data dir>/<profile>/Web Applications/_crx_<app ID>/).

When Chrome is launched by an out-of-date PWA launcher, it updates all
PWA launchers for the current profile. Because these updates involve
file operations and take place in the user-data directory, they may
fail due to permissions errors, etc.

This metric will allow us to monitor how often PWA-launcher update is
failing, and handle common failure causes if necessary.

Bug: 1067241
Change-Id: Ie2ea99ea2f1c284a2388e3eb52b664c6ba5af8ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146084Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#760261}
      56fe148e
  3. 17 Apr, 2020 38 commits