- 18 Aug, 2020 18 commits
-
-
Melissa Zhang authored
Bug: 1097623 Change-Id: Ib864f2ddef5774f11394c0bcf53792c27333b1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355167Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798921}
-
Sean McAllister authored
This reverts commit f82a08ba. Reason for revert: Causing breakage in linux-chromeos-chrome builder: https://crbug.com/1117021 Original change's description: > Add Remote Apps Mojo service > > This CL adds a Mojo service for Remote Apps. The service is a thin layer > which mainly forwards calls to the RemoteAppsManager. > > Only extensions under the imprivata_in_session_extension behavior feature > have access to the API. > > Bug: 1101208 > Change-Id: Ieaf9f6839ba22d86cb3fba8fa64afe49ade8e6ce > DD: go/remote_apps_mojo > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332615 > Commit-Queue: Jit Yao Yap <jityao@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798551} TBR=xiyuan@chromium.org,antrim@chromium.org,rdevlin.cronin@chromium.org,sammc@chromium.org,ortuno@chromium.org,jityao@google.com Change-Id: Ica8c3ed24d2051e87b1c4c6cbf09a3490e553a6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358605 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798920}
-
Scott Violet authored
BUG=1076463 TEST=covered by tests Change-Id: I03eed9dd1a307d92a2a7b92c59ab045b851e03a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358052 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#798919}
-
Khushal Sagar authored
TBR=sunnyps@chromium.org Bug: 1114184 Change-Id: I4f4c328ff19df11d7abe3521934e7523a7871373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360497 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798918}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/699711c7e3cd..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifb714260df5e3e19a5540ecb1441d6fccaf435d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798917}
-
Dana Fried authored
Without abs(), a drag-left (e.g. to reorder extensions) will be interpreted as trying to open the tabstrip tray in touch mode. Bug: 1117274 Change-Id: I535eeb8284bcc9d9406721efbcd9363b820c9d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360596Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#798916}
-
Fergus Dall authored
This reverts commit e771c29c. Reason for revert: Broke ChromeSessionManagerRlzTest.* tests. See: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7804 Original change's description: > Oobe: enable child specific signin feature > > Bug: 1101318 > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#798671} TBR=xiyuan@chromium.org,antrim@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I579715924cccd7f9f531f0ce1310e68254c24c44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359874Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42e3f1d3cb76..5664586374b9 2020-08-17 ddoman@chromium.org [resultdb] add ddoman@ to depot_tools/LUCI_OWNERS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib67e87a72e06dc95fc9609a55b66fb9cc39eec8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360436Reviewed-by:
-
Zhongyi Shi authored
When connection migration is enabled, if network is disconnected, migration will wait for a new network to start migration. If there is no new network being connected, instead of close the connection with ERR_NETWORK_CHANGED, throw ERR_INTERNET_DISCONNECTED to reflect the cause of failure correctly. Note if the session encounters a pre-emptive QUIC_PACKET_WRITE_ERROR before receiving OnNetworkDisconnected notification, ERR_NETWORK_CHANGED will be thrown as PACKET_WRITE_ERROR is not necessarily caused by OnNetworkDisconnected. Bug: 1115629 Change-Id: I81fae1249993926d60babb5a097f11c30cf42f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353556 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798913}
-
Sahir Vellani authored
In order to allow touch interactions to appropriately work with composited scrollbars, the scrollbar needs to be designated as a touch event consumer. This will prevent touch moves on the scrollbar from being filtered. This requires the browser to know whether a hit-testable scrollbar is present on a given platform. This change introduces the mechanism for providing the browser with that information. SetHasTouchEventHandlers is converted to SetHasTouchEventConsumers, with the consumers being JavaScript touch event handlers or scrollbars. The has_handlers boolean is converted to a bitfield containing these two pieces of information. This change does not change the behavior of the browser, and is a prerequisite to allowing touch dragging and interactions on composited scrollbars. Bug: 1082606 Change-Id: I1cf93155ffbccf8dca5196b358f343ee89208abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298346Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798912}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25f6caceffe6..8d6628854c8b 2020-08-17 mjackson@microsoft.com PWA: Update installability failure to account for display_override If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109520 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I995f3ec10246c9397b21e72f5768b7476f924bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360437Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2a9f6661597..1756465158d3 2020-08-17 fmayer@google.com Merge "Roll traceconv and trace_processor." 2020-08-17 fmayer@google.com Merge "Store field names in class." 2020-08-17 fmayer@google.com Calculate SHA after stripping. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic4afa010df3be65a141cf48c64309bca4b2e1d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360552Reviewed-by:
-
Peter Kasting authored
* Declare constants and variables in the narrowest scope possible * Remove unnecessary base:: qualifiers * Use helpers like JoinString() and std::transform() * Use more/better Time:: constants * Simplify * Use const/constexpr more * Don't handle DCHECK failure * Use TimeDelta::InMicrosecondsF() to get a double Bug: none Change-Id: I8ba31377f5f051f903018d7d9066146cf34e9a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358999 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798909}
-
Dan Harrington authored
Bug: 1117076, b/164532972 Change-Id: I6352376426a09ff444680b61537e05442db368d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360235 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#798908}
-
chrome://safe-browsingDaniel Rubery authored
This CL modifies the way the SafeBrowsingUIHandler retrieves the SB cookie so that we can display the correct cookie per-profile. Bug: 1049833 Change-Id: Ifab72742807b808c07ab324b6f0474fc7bfa63b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358592Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#798907}
-
Alan Cutter authored
This CL extends WebAppUiManagerImpl::UninstallAndReplace() to also migrate the following user preferences: - chrome://apps grid position. - standalone/browser tab launch preference. Pre-migration screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462010&signed_aid=oHAn32fAhc9IyNofMQ7C9Q==&inline=1 Post-migration screenshot before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462009&signed_aid=LhJc8aoValNlvgCzMUSiUg==&inline=1 Post-migration screenshot after: https://bugs.chromium.org/p/chromium/issues/attachment?aid=462008&signed_aid=cvtBWSuplfvc9sMKp2XvCw==&inline=1 Bug: 1105338 Change-Id: I908d11870c940f27485ac1436570659313ae794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358938Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#798906}
-
Robbie McElrath authored
This CL renames the ShouldPinControlsToContentTop field, which I landed in crrev.com/c/2284138, to OnlyExpandControlsAtPageTop. The term 'pin' had caused some confusion, as had the phrase 'content top', since that could be interpreted as either the viewport top, or the top of the page itself. I had considered OnlyExpandControlsAtTop, but 'controls at top' could be interpreted as 'top controls'. Bug: 1069498 Change-Id: Iaff131ae1379113958cdfb4803e902e08a1949ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336013 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
David Bertoni authored
The BrowserActionOpenPopupOnPopup test requires focus to run properly and was flaky when it lived in browser_tests. The test passed 3000 iterations without a flake when moved to interactive_ui_tests. Bug: 1115237 Change-Id: Ib891eaefb04f72d0ee4e5c1d5d9549fbd52b0e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350240 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798904}
-
- 17 Aug, 2020 22 commits
-
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/tERUmejT2tSaTumq5zSy0ws4x3w3pAMkEcpgdkD5WTEC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008160800_RC00.html Bug: b/161497534, b/159083441, b/162187144, b/161966844 Change-Id: Id9854948dc2f0f28eb3ae7293919c013f2bb91cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359971Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#798903}
-
Nelson Billing authored
- These special-cases were in place due to a bug in dump_syms. - The bug in dump_syms was fixed in commit https://chromium.googlesource.com/breakpad/breakpad/+/f32b83eb08e9ee158d3037b2114357187fd45a05 Change-Id: Ic39b1f8ca3cd7e513817f0ee364d72eb3e65adad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357610Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nelson Billing <nbilling@google.com> Cr-Commit-Position: refs/heads/master@{#798902}
-
Tamir Duberstein authored
Bug: 1099393 Change-Id: Id9076b0c92ac0583ffd8cb845663db3ff236c381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353294Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#798901}
-
Thomas Lukaszewicz authored
Currently MD rounded corners are using layer masking to achieve the desired clip for client views. This CL updates client views to make use of the ui:Layer SetRoundedCornerRadius() fast path that significantly improves performance vs layer masking. Bug: 822075 Change-Id: I113c6b0101145518962b22940f653fb2cc93381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359027 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798900}
-
Richard Chui authored
The wallpaper dimming effect isn't applied when the user is in overview mode and switches from tablet to clamshell mode. This is because normal and tablet mode have different default wallpaper properties (blur/opacity). After the properties are applied initially when entering overview, they are not changed when toggling tablet mode. This CL fixes this by updating the wallpaper with the correct properties when starting and ending tablet mode. Test: manual, added tests Bug: 1103019 Change-Id: I74fd97f888017f283786bc26ab87ebb39217026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340566Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#798899}
-
Jonah Chin authored
The recent change introducing PaintImage::GetSwSkImage() caused a regression that occurs when drawing accelerated resources on a software canvas. This is a quick fix to revert the culprit caller back to PaintImage::GetSkImage(). This avoids the cost of multiple readbacks that GetSwSkImage() incurs. A follow up change will introduce caching in GetSwSkImage(), at which point we can use it again. Bug: 1115686 Change-Id: I765f85acf2d53c7f379b4d5cffd86a1224be4318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358432Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e7cd224e55fa..6f74415e2f74 2020-08-17 amaiorano@google.com Update README to add details on Vulkan and less about GLES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib42522fe19ca604ab39c5b105f0a579b6786d95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360431 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Samuel Huang authored
_ANDROID_SPECIFIC_PYDEPS_FILES in PRESUBMIT.py lists .pydepts files that require the checkout to be able to build Android. The list appear to have gone stale. This CL updates the list. Change-Id: I7501fb0c7edeeeaedc00de579237cb653dfd9c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351964Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Bug: 1116928 Change-Id: I9403fedea04ae67280d77d33beed399a69a77cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360091 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798895}
-
Nathan Zabriskie authored
With OOPR Canvas we need to be explicit about how SkImages will be used in the renderer process. In OOPR mode, SkImages must be software backed because we can no longer use GrContext in the renderer. This change updates callsites of PaintImage::GetSkImage to specify what kind of SkImage is required with the new GetSwSkImage and GetAcceleratedSkImage APIs. Follow up CLs will cleanup remaining callsites of GetSkImage until we can completely remove the function. Bug: 1018894 Change-Id: I69f7247e36c7cbb5d30f444f1255dd84af968df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350027 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
-
Devlin Cronin authored
s/drew/devlin Bug: 1117280 Change-Id: I4ef12d12f3f5c58c62257a86ae8e07aceb55f6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356166 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798893}
-
Sebastien Lalancette authored
Updated the string as per UX's guidance. Bug: 1093302 Change-Id: Ia179f7e4d069d63cd84b25381f513e46c75f84b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360326Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#798892}
-
bttk authored
This field was being set in initializeToolbar() and used in initFindToolbarManager(). onInflationComplete() calls these methods in a reverse order. Bug: 1116924 Change-Id: I1899db0c9b572f3386cfe3ac480111b673c1c28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360573 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798891}
-
Lukasz Anforowicz authored
This CL adds a NOTREACHED assertion to the InitiatorLockCompatibility::kNoLock case in CorsURLLoaderFactory::IsValidRequest (in preparation for calling mojo::ReportBadMessage and returning false in a follow-up CL). Presence of the new NOTREACHED assertion requires fixing unit tests, so that they more accurately simulate the behavior of the product code. In particular: - A DCHECK has been added to CorsURLLoaderTest::ResetFactory to help ensure that all tests use a non-nullopt |request_initiator_site_lock| when simulating a renderer-side factory. - CorsURLLoaderTest::SetUp started passing non-null default initiator to CorsURLLoaderTest::ResetFactory. https://example.com was chosen as the default, because it is the most commonly used URL in other tests. This necessitated changing some tests to use the matching scheme (https rather than http). - Some tests were forced to specify a non-nullopt network::ResourceRequest::request_initiator (this is no longer okay, because if kNoLock case cannot be reached after this CL, then kNoInitiator case would crash the test). - Tests that really had to use a nullopt |request_initiator| were switched to simulating a browser-side factory (one with a nullopt |request_initiator_site_lock| and with kBrowserProcessId). Fixed: 1115222 Change-Id: I8c6e6603ba4626cf5c306ae5ca286fe1f1fb48e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350232 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#798890}
-
Jae Hoon Kim authored
CQ is facing flakes from time to time where DBus method calls into dlcservice is returning |org.freedesktop.DBus.Error.NoReply|. This logging will help narrow down if service availability is the cause as Chrome is frequently restarted during tast test runs. BUG=b:164310699 TEST=unit_tests Change-Id: Iebca6437c9407ea74c3dca06dddfb998733afae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358132 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798889}
-
sczs authored
DiscoverFeedConfiguration will make any future changes much easier (even for potential cherrypicks), and its needed so the provider can read a PrefValue indicating the last time browsing data was cleared. Bug: 1085419 Change-Id: I8324eadac2f4c0113cc707ac9b84cd84e0336ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359399 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#798888}
-
Karandeep Bhatia authored
Currently we auto-generate code for types exposed through extension APIs, functions, events and properties. However, the manifest key schemas are not auto-generated. This means that each ManifestHandler has to individually parse the manifest keys resulting in verbose code which is often incomplete and where we don’t consistently validate all the types. This also means that we are not able to auto-generate documentation for manifest key schemas and have to explicitly describe it in API introduction templates. To fix this, add support to JSON and IDL schemas to auto-generate types required for manifest parsing. Changes: - ParseFromDictionary methods is generated for such types to aid in manifest parsing. Also, constants are generated for keys used in such types. - Currently, only the list, bool, double, int64, int, object, and string types are supported to be used in manifest keys. - Also convert declarativeNetRequest code to support this new way of manifest parsing to document how this will be used. More manifest handlers will be converted subsequently. Follow ups: - A subsequent CL will add support for enums. More complex types (any, choices etc.) can be supported subsequently if need be. - Exclude manifest-only types from generated schema strings which are sent to renderer. - Support a key called "from_manifest_keys" which types can use to denote that ParseFromManifest method should be supported. Generally, most types won't need to explicitly specify this, however this will be necessary when referencing types from a different namespace. - Support a key called "is_manifest_data" which types can use to denote that the type should inherit from Extension::ManifestData. This will be useful for cases where the type can directly be stored as part of the manifest data. Doc: https://docs.google.com/document/d/1ssw82MePGVQuVha9U5MXVTm9jpK4nPftWQD5Dm0fK1c/edit?usp=sharing (Internal only) Generated code snippets: declarativeNetRequest: - header: https://paste.googleplex.com/5109785672286208 - cc: https://paste.googleplex.com/5700852025131008 simple_api: - header: https://paste.googleplex.com/5197970343460864 - cc: https://paste.googleplex.com/5480262504808448 BUG=1113513 Change-Id: I2e21d293c8e83aa301cc04ee0ac39280cf9cdf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337954 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Jao-ke Chin-Lee authored
Add basic VP9 decoding for an IVF video stream, with functionality to save the last decoded frame as PNG. BUG=crbug:1062407 Change-Id: I0e9272a50e269af658a9427e8b01548443dd467d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296872Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798886}
-
Andre Le authored
Screenshots: https://screenshot.googleplex.com/3eeab29d-1b19-4345-a222-42703cee174b https://screenshot.googleplex.com/567b0132-f7a6-4a59-8c61-3a9a7d6cbba1 https://screenshot.googleplex.com/dfb161aa-99c4-4ac4-9fbd-b06c4d01e50e https://screenshot.googleplex.com/95a48208-ffc9-4f43-8993-1f0425b884bb BUG=1114949 Change-Id: I326e13b202b315ca8548bda03acb4a9ff53577de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353174Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#798885}
-
Brian Malcolm authored
BUG=chromium:1105185 Change-Id: Ia6a7d87f4151b259552e609bc5c4c46f4470037e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355001Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798884}
-
Aaron Colwell authored
Adding more logging information to make it easier to determine why the RenderProcessHostImpl is still alive. All the new values are related to the various early return paths in RPHI::Cleanup() that cause destruction to get deferred. Bug: 1113159 Change-Id: I6dbf6966ca91681aed0c853605f1be9d736b80a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360473 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#798883}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/22e7f7a0d7d7..f926b0866fe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d81573e79447a05bd05b0236741a712f85bef01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360337Reviewed-by:
-
