GitLab

Adds a lens leveraging a rules file to tag whether a given request is
related to Ads and/or tracking/analytics. This CL also displays this in
the PNG output of the dependency graph.

Review URL: https://codereview.chromium.org/1626393002

Cr-Commit-Position: refs/heads/master@{#371504}

Adds a new experimental flag for Reading List on iOS. The flag is
toggled with Settings.bundle downstream.

BUG=581014

Review URL: https://codereview.chromium.org/1631813002

Cr-Commit-Position: refs/heads/master@{#371503}

Revert of Fix leaks in exensions_unittests after enabling Oilpan (patchset #1 id:1 of https://codereview.chromium.org/1632763003/ )

Reason for revert:
This CL didn't fix the leak. Also per the discussion in https://codereview.chromium.org/1632763003/, suppressing the leak looks like a reasonable solution at the moment. So revert this CL.

Original issue's description:
> Fix leaks in exensions_unittests after enabling Oilpan
>
> This CL adds an Oilpan's GC before tearing down the extensions_unittests.
>
> BUG=581092
>
> Committed: https://crrev.com/6ae6611de742bb291305a1df558e710213556fa4
> Cr-Commit-Position: refs/heads/master@{#371408}

TBR=rockot@chromium.org,oilpan-reviews@chromium.org,oshima@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581092

Review URL: https://codereview.chromium.org/1637013002

Cr-Commit-Position: refs/heads/master@{#371502}

The flakiness was caused by waiting for a wrong number of JavaScript
test results, which resulted in inconsistency between events that were
expected to happen and the events that have actually happened. In a
detailed manner, the reportCertificates callback in file basic.js is
wrapped through chrome.test.callbackPass method, which itself calls
chrome.test.succeed method; meanwhile the C++ code in
certificate_provider_apitest.cc didn't expect this chrome.test.succeed
call, and it behaved as if the
chrome.certificateProvider.onSignDigestRequested event handler was
already executed - which is not always true and causes flakiness.

BUG=576364

Review URL: https://codereview.chromium.org/1632053002

Cr-Commit-Position: refs/heads/master@{#371501}

This CL replaces CSSParserToken::valueEqualsIgnoringCase and
CSSParserString::equalIgnoringCase with valueEqualsIgnoringASCIICase
and equalIgnoringASCIICase respectively - calling the similarly named
function in WTF.
Some cases where CSSParserToken::value() was coerced to a String is
changed to avoid the coercion - using the CSSParserToken method
directly.
Similarly some cases that use the CSSParserString overload for
equalIgnoringCase is changed to use the method on CSSParserToken.
The dead equalIgnoringCase(const CSSParserString&, ...) function in
LegacyCSSPropertyParser.cpp is removed.

BUG=581001

Review URL: https://codereview.chromium.org/1636453002

Cr-Commit-Position: refs/heads/master@{#371500}

BUG=525873

Review URL: https://codereview.chromium.org/1633063003

Cr-Commit-Position: refs/heads/master@{#371499}

BUG=581283
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/1637853002

Cr-Commit-Position: refs/heads/master@{#371498}

+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251

Review URL: https://codereview.chromium.org/1486653003

Cr-Commit-Position: refs/heads/master@{#371497}

iostream contains a static initializer and generally should be frowned upon.
It also makes presubmit fire when touching this file.  (But after removing
this, they complain about streams, so it doesn't really solve that problem.)

BUG=none

Review URL: https://codereview.chromium.org/1626413002

Cr-Commit-Position: refs/heads/master@{#371496}

Reland of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1617263002/ )

Reason for revert:
The crash was fixed in crrev.com/1620783002

Original issue's description:
> Revert of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1591553002/ )
>
> Reason for revert:
> TracingBrowserTest.TestMemoryInfra is failing on DrMemory bot with the following
> error:
>
> UNADDRESSABLE ACCESS: reading 0x00000048-0x0000004c 4 byte(s)
> # 0 base.dll!base::Thread::task_runner
> [base\threading\thread.h:168]
> # 1 base.dll!base::trace_event::MemoryDumpManager::CreateProcessDump
> [base\trace_event\memory_dump_manager.cc:313]
> # 2 content.dll!content::TracingControllerImpl::RequestGlobalMemoryDump
> [content\browser\tracing\tracing_controller_impl.cc:1039]
> # 3 content.dll!base::internal::Invoker<>::Run
> [base\bind_internal.h:350]
>
> bug: crbug.com/580295
>
> Original issue's description:
> > Reland of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1586893003/ )
> >
> > The failure was due to flakiness fixed by crrev.com/1606983002.
> > See crbug.com/578128.
> >
> > Original issue's description:
> > > Revert of [tracing] Dump child processes' memory metrics in browser (patchset #15 id:400001 of https://codereview.chromium.org/1417003003/ )
> > >
> > > Reason for revert:
> > > This is suspected by Findit to cause failure in TracingBrowserTest.TestMemoryInfra under Mac ASan 64 Tests (1).
> > >
> > > Original issue's description:
> > > > [tracing] Dump child processes' memory metrics in browser
> > > >
> > > > The sandbox in linux prevents the process from reading the process
> > > > metrics file. To work around this issue, the browser process will now
> > > > dump statistics of the child processes too. This requires the
> > > > composable dumps support in trace viewer and telemetry.
> > > >
> > > > This CL makes following changes.
> > > > 1. Move the process totals and memory maps dump provider into a single
> > > > header as process_metrics_dump_provider in components/tracing. This is
> > > > because it is not necessary to have this in base and now the provider
> > > > knows/manages for different processes. Also the dump method are made to
> > > > handle error better, since process can vanish while dumping.
> > > >
> > > > 2. Make the dump provider non-singleton and have a register / unregister
> > > > that manages the lifetime of the dump providers.
> > > >
> > > > 3. The dump providers unregister using the new
> > > > UnregisterAndDeleteDumpProviderAsync api added by crrev.com/1430073002.
> > > >
> > > > 4. On linux the browser process dumps metrics for all processes and on
> > > > android the child processes can dump since seccomp sandbox is not
> > > > enabled in android yet.
> > > >
> > > > 5. The proc/status file is human readable stats and is not guaranteed to
> > > > have a field that is asked for. So, the NOTREACHED is removed in
> > > > ReadProcStatusAndGetFieldAsSizeT.
> > > >
> > > > 6. Since we introduce other process dumps from browser process there
> > > > could be races while unregistering and dumping. To test this, the
> > > > browser test is updated.
> > > >
> > > > BUG=461788
> > > >
> > > > Committed: https://crrev.com/4d77d76a42425282b1a3c5b7309db9b98e777f60
> > > > Cr-Commit-Position: refs/heads/master@{#369482}
> > >
> > > TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,ssid@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=461788
> > >
> > > Committed: https://crrev.com/93aa967cfcb3e933000f169b9a4f7ac84dbd96da
> > > Cr-Commit-Position: refs/heads/master@{#369535}
> >
> > TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org
> > BUG=461788
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/df4156349708e21844209290a2d3638b550e18b2
> > Cr-Commit-Position: refs/heads/master@{#370195}
>
> TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org,ssid@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=461788
>
> Committed: https://crrev.com/94bef8d8bf199e23102783a55a15c9f10bc88631
> Cr-Commit-Position: refs/heads/master@{#370836}

TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=461788

Review URL: https://codereview.chromium.org/1629393003

Cr-Commit-Position: refs/heads/master@{#371495}

isMaxSizeNone() is nonsensical for min-width. Zero (but represented as
Auto) is initial Length value for min-width, not MaxSizeNone. This
stands out after the rename from isUndefined() to isMaxSizeNone(). But
in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was
a just long alias for |false| so remove it.

Review URL: https://codereview.chromium.org/1633683002

Cr-Commit-Position: refs/heads/master@{#371494}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e78b4e2e..99af10a4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1634133002

Cr-Commit-Position: refs/heads/master@{#371493}

Some templates wants to forward all their parameters to the underlying
target except a select few they use. Previously they had to list all
the variables the underlying target supported which was error prone and
brittle if the underlying target is changed.

With this change they can just use the following:

  forward_variables_from(invoker, "*", ["my_extra_variable"])
  # my_extra_variable is not forwarded, all other variables are.

BUG=580293

Review URL: https://codereview.chromium.org/1632573002

Cr-Commit-Position: refs/heads/master@{#371492}

This CL aligns the implementation with the preload spec, so that fetches
triggered by link preload that has no `as` type, are subject to the
connect-src directive.

BUG=580758

Review URL: https://codereview.chromium.org/1632523002

Cr-Commit-Position: refs/heads/master@{#371491}

This patch adds button support on ARC notification: showing buttons and handle click events.

This CL depends on the Android side patch (http://ag/845794).

BUG=560682
TEST=manually tested

Review URL: https://codereview.chromium.org/1603753003

Cr-Commit-Position: refs/heads/master@{#371490}

Revert of Add API for custom library loading (patchset #5 id:80001 of https://codereview.chromium.org/1619673004/ )

Reason for revert:
New test (CronetUrlRequestContextTest#testSkipLibraryLoading) fails on bots

BUG=581309

Original issue's description:
> Add API for custom library loading
>
> Loading the native library can cause a crash on some older versions of
> Android. This CL provides a way for embedders to implement custom library
> loading logic that works around the issue.
>
> BUG=550584
> R=xunjieli@chromium.org
>
> Committed: https://crrev.com/12d01cb35ec0ed7a259c19dd1390b5a486d61a9d
> Cr-Commit-Position: refs/heads/master@{#371319}

TBR=xunjieli@chromium.org,mgersh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=550584

Review URL: https://codereview.chromium.org/1635033002

Cr-Commit-Position: refs/heads/master@{#371489}

BUG=454815

Review URL: https://codereview.chromium.org/1627193003

Cr-Commit-Position: refs/heads/master@{#371488}

Failures are:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/52771
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/7261

These are caused by DEFINE_STATIC_REF / DEFINE_STATIC_LOCAL with Persistent. The leaks are expected.

BUG=562431

Review URL: https://codereview.chromium.org/1635863005

Cr-Commit-Position: refs/heads/master@{#371487}

Review URL: https://codereview.chromium.org/1620893002

Cr-Commit-Position: refs/heads/master@{#371486}

As per the latest spec change, when an update successfully loaded a script
resource from the network (having bypassed the HTTP cache), the registration's
last update check time should be updated regardless of whether the installation
of the fetched resource succeeds or fails.

While the existing code updates the time stamp only when the subsequent
installation of the newly received script is successfully completed (or the
loaded script is byte-for-byte match to the incumbent script resource), this CL
makes it bump the time stamp as soon as the update succeeded.

This CL added a condition for checking whether the script resource was served
from the network:
if (net_request_->response_info().network_accessed &&
    !(net_request_->response_info().was_cached)) // This line is added.

Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/514#issuecomment-135641718

BUG=539709

Review URL: https://codereview.chromium.org/1381153004

Cr-Commit-Position: refs/heads/master@{#371485}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b3481b53..e78b4e2e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1634113002

Cr-Commit-Position: refs/heads/master@{#371484}

Oilpan: LargeObjectPage should use HeapObjectHeader::payloadSize() instead of HeapObjectHeader::size()

HeapObjectHeader::size() is a fast version of HeapObjectHeader::payloadSize() which works only
for headers in NormalHeapPages and FreeLists. LargeObjectPages must use HeapObjectHeader::payloadSize() instead.

BUG=581138

Review URL: https://codereview.chromium.org/1636983002

Cr-Commit-Position: refs/heads/master@{#371483}

Removes unused print command from command list.

BUG=559171

Review URL: https://codereview.chromium.org/1628543002

Cr-Commit-Position: refs/heads/master@{#371482}

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847

Review URL: https://codereview.chromium.org/1605273002

Cr-Commit-Position: refs/heads/master@{#371481}

Note: the unittest still uses Profile. That will be fixed in subsequent CLs.

BUG=578823

Review URL: https://codereview.chromium.org/1623223006

Cr-Commit-Position: refs/heads/master@{#371480}

For static methods it does not seem to work properly with older gcc.
Indeed the compiler consider the result as not used in this example:

sequence_token_ = BrowserThread::GetBlockingPool()->GetSequenceToken()

"error: ignoring return value of 'static base::SequencedWorkerPool*
content::BrowserThread::GetBlockingPool()', declared with attribute
warn_unused_result [-Werror=unused-result]"

The solution is just to call GetSequenceToken() directly as:
base::SequencedWorkerPool::GetSequenceToken() as it is static.

BUG=579461

R=cpu@chromium.org, nico@chromium.org

TEST= GYP_DEFINES="clang=0 use_sysroot=0"

Review URL: https://codereview.chromium.org/1610103002

Cr-Commit-Position: refs/heads/master@{#371479}

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2] https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125

Review URL: https://codereview.chromium.org/1624383002

Cr-Commit-Position: refs/heads/master@{#371478}

Remove the unnecessary and dangerous polling in startMonitoring(). mTestDelegate.mIsRunning is set directly in start(), so waiting for mTestDelegate.isRunning() does not guarantee anything. However, it does introduce the possibility of a race if the mHandler.postDelayed() call in mTestDelegate.start() switches threads.

Precisely, if mHandler.postDelayed() stays in the same thread, or causes uninteresting thread switches, the following happens in startMonitoring:

mTestDelegate.start ->
 mIsRunning = true;
 ...

CriteriaHelper.pollForCriteria ->
 mTestDeleted.isRunning() == true, exit immediately.

On the other hand, if there is an interesting thread switch in mHandler.postDelayed(), then we could have

mTestDelegate.start ->
 mIsRunning = true;
 mHandler.postDelayed()
  ... stuff happens ...
  mTestDelegate.run() is called
   mIsRunning = false;
  ... more stuff happens ..

(now back to main test thread)
CriteriaHelper.pollForCriteria ->
 mTestDeleted.isRunning() == false, loop until timeout and the test fails.

Before removing this poll, running locally the test occasionally retried tests on a nexus 4; after removing it it ran 20 times successfully with no retries. I think we have slightly higher confidence now that it won't flake on the build.

BUG=542627

Review URL: https://codereview.chromium.org/1634693002

Cr-Commit-Position: refs/heads/master@{#371477}

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=

Review URL: https://codereview.chromium.org/1632493002

Cr-Commit-Position: refs/heads/master@{#371476}

It was PaintInvalidationState::enclosingLayer(), but we actually need
the enclosing self painting layer to set repaint flags. Later changes
to optimize empty paint phases also need enclosing self painting layer.

We don't need to specially handle multicol spanner in the new function
because our paint invalidation of multicol spanner follows the true
layer painting order. Instead we need to special handle multicol
spanner in the assertion to check if the repaint flags are properly
set on layers.

This has been reviewed by mstensho@opera.com and chrishtr@chromium.org
as part of https://codereview.chromium.org/1584493002/.

TBR=mstensho@opera.com,chrishtr@chromium.org
BUG=574938

Review URL: https://codereview.chromium.org/1629563003

Cr-Commit-Position: refs/heads/master@{#371475}

Cr-Commit-Position: refs/heads/master@{#371474}

The metrics were added in the V8 patch reviewed at
https://codereview.chromium.org/1558113002
They measure
- Each of the three deprecated Promise functions
- Two nonstandard pieces of Intl functionality
- Accesses of the RegExp.prototype.unicode getter on the prototype

BUG=v8:3785,v8:3238,v8:4633

Review URL: https://codereview.chromium.org/1578143002

Cr-Commit-Position: refs/heads/master@{#371473}

This patch gets rid of rid of a redundant parameter |ResetCaretBlinkOption| from
|FrameSelection::updateAppearance()| with introducing |stopCaretBlinkTimer()|
by calling |stopCaretBlinkTimer()| at call site which calls |updateAppearance()|
with |ResetCaretBlink| to simplify source code for improving readability.

This patch is a follow-up patch of http://crrev.com/1629213002, which simplifies
code path in |updateAppearance()|.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1632673004

Cr-Commit-Position: refs/heads/master@{#371472}

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1632013004

Cr-Commit-Position: refs/heads/master@{#371471}

This adds a new BindingsPolicy exclusively for enabling
Mojo system API and ServiceRegistry modules to a render
view. Previously these were only made available in
conjunction with WebUI bindings.

While still implied by WebUI bindings availability, Mojo
modules are now also available to any view created during
a layout test run.

Part of a CL series to enable Mojo service mocks in layout
tests:

 1. https://codereview.chromium.org/1468903002
 2. this CL
 3. https://codereview.chromium.org/1470153002

TBR=dbeam@chromium.org for WebUI

Review URL: https://codereview.chromium.org/1470823002

Cr-Commit-Position: refs/heads/master@{#371470}

BUG=562431

Review URL: https://codereview.chromium.org/1609943003

Cr-Commit-Position: refs/heads/master@{#371469}

I forgot to add [Leak] when landing r371372.

BUG=
TBR=yosin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1636963002

Cr-Commit-Position: refs/heads/master@{#371468}

Parallel copy can have huge performance drop in some cases. (See issue 578923 for the detail)
For safety and simplicity, this CL makes the recursive file operations sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.

Review URL: https://codereview.chromium.org/1619733004

Cr-Commit-Position: refs/heads/master@{#371467}

Since we're no longer supporting XP, this is no longer needed.  Newer
versions of windows automatically tune the buffer sizes.

BUG=580691

Review URL: https://codereview.chromium.org/1626643002

Cr-Commit-Position: refs/heads/master@{#371466}

Review URL: https://codereview.chromium.org/1632173002

Cr-Commit-Position: refs/heads/master@{#371465}