GitLab

There are a couple of comments (in particular SVG stuff) that I
have not addressed. I have filed bug reports for those to make
sure that I get around to revisiting them.

R=haraken@chromium.org, kouhei@chromium.org, tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/267303004

git-svn-id: svn://svn.chromium.org/blink/trunk@173645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353980

Review URL: https://codereview.chromium.org/269953006

git-svn-id: svn://svn.chromium.org/blink/trunk@173644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas, pfeldman, yurys
BUG=351662

Review URL: https://codereview.chromium.org/268293003

git-svn-id: svn://svn.chromium.org/blink/trunk@173643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: mark virtual/mac-antialiasedtext/fast/text/selection-rect-rounding.html as NeedsRebaseline

and remove custom expectations of fast/transforms/shadows.html for Mac retina

BUG=
TBR=ojan, enne
NOTRY=true

Review URL: https://codereview.chromium.org/279513002

git-svn-id: svn://svn.chromium.org/blink/trunk@173641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up r173611 and remove a redundant use of get() in Document accessor.

R=ager@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/278573003

git-svn-id: svn://svn.chromium.org/blink/trunk@173640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/274563010

git-svn-id: svn://svn.chromium.org/blink/trunk@173638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Stop using SVGElementInstance in SVGElement since we want to remove it.

BUG=313438

Review URL: https://codereview.chromium.org/272623003

git-svn-id: svn://svn.chromium.org/blink/trunk@173637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/272753002

git-svn-id: svn://svn.chromium.org/blink/trunk@173636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/278583003

git-svn-id: svn://svn.chromium.org/blink/trunk@173635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FormAssociatedElement should be GarbageCollectedMixin, and this CL replaces
existing RefPtr<FormAssociatedElement> with Oilpan transition types.

This CL doesn't handle existing FormAssociatedElement raw pointers. The next CL
will handle them.

This CL moves ValidityState to Oilpan heap because ValidityState depends on
FormAssociatedElement::ref() and deref().

BUG=357163

Review URL: https://codereview.chromium.org/271533009

git-svn-id: svn://svn.chromium.org/blink/trunk@173634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The base test was marked for rebaseline on Mac at r173588
Autorebaseline happened at r173623

BUG=
TBR=ojan, enne
NOTRY=true

Review URL: https://codereview.chromium.org/275433010

git-svn-id: svn://svn.chromium.org/blink/trunk@173633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up CL for r173508.

BUG=369429
NOTRY=true

Review URL: https://codereview.chromium.org/278433007

git-svn-id: svn://svn.chromium.org/blink/trunk@173632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

marked as mac only
virtual/gpu/compositedscrolling/scrollbars/custom-scrollbar-with-incomplete-style.html [ ImageOnlyFailure ]

removed:
svg/as-object/nested-embedded-svg-size-changes.html [ Crash ]
editing/context-menu-leak-document.html [ Failure ]

marked as Debug only
svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html [ Crash ]
svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html [ Crash ]

BUG=
TBR=ojan
NOTRY=true

Review URL: https://codereview.chromium.org/270633011

git-svn-id: svn://svn.chromium.org/blink/trunk@173631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=enne, ojan
NOTRY=true

Review URL: https://codereview.chromium.org/268353012

git-svn-id: svn://svn.chromium.org/blink/trunk@173630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some layout tests call setPosition(node, offset) with large |offset| which is larger than |node|'s length but it is invalid in the standard:
https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-collapse

A typically case is that, image following HTML:
<div>text</div>
if you want to set a caret to between 'x' and 't', you should call Selection.setPostion(div.firstChild, 3).
However, many layout tests call Selection.setPosition(div, 3), which is invalid.
Many of those tests want to just set a caret to a last position of the node so this CL changes to call setPosition(node, node.childNodes.length).

I'm going to change Selection.setPosition to throw an exception for such a invalid call through Range.setStart/End.

This CL is similar to previous one:
https://src.chromium.org/viewvc/blink?revision=173167&view=revision

BUG=

Review URL: https://codereview.chromium.org/272703007

git-svn-id: svn://svn.chromium.org/blink/trunk@173629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/267283007

git-svn-id: svn://svn.chromium.org/blink/trunk@173628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/267293011

git-svn-id: svn://svn.chromium.org/blink/trunk@173627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

when input element of type file with a selected file is cloned, the cloned node should
also have the same file as selected.
HTML specification states:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html
"The cloning steps for input elements must propagate the value, dirty value
flag, checkedness, and dirty checkedness flag from the node being cloned to the
copy."

The value for the input element of type fileupload is the filename.

Behaviours in major Browser:
Firefox- clones filename
Safari, IE & Opera- do not Clone filename 

BUG=71536
TEST=fast/forms/file/input-file-element-clone.html

Review URL: https://codereview.chromium.org/267713006

git-svn-id: svn://svn.chromium.org/blink/trunk@173626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To implement the overload resolution algorithm, I'm going to first
implement basic algorithms from the spec (*without* changing
generated code), then incrementally switch existing interfaces to
the proper algorithm (changing the generated code).

This implements the "effective overload set" algorithm:
http://heycam.github.io/webidl/#dfn-effective-overload-set

The code isn't very Pythonic, but it's directly from the spec.

Next will be 'distinguishing index'.

R=haraken
BUG=293561

Review URL: https://codereview.chromium.org/274503003

git-svn-id: svn://svn.chromium.org/blink/trunk@173625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/269423005

git-svn-id: svn://svn.chromium.org/blink/trunk@173623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That is to say, WebNode::m_private should be based on Persistent<Node>.
Because all of WebNode subclasses shares it, we need to change the
classes so that they can be convertible to RawPtr instead of PassRefPtr.

We need some #if ENABLE(OILPAN) because some WebCore functions
still return PassRefPtrs.


BUG=357163

Review URL: https://codereview.chromium.org/270573008

git-svn-id: svn://svn.chromium.org/blink/trunk@173622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
There are two different events that most of the time coincide: a
JavaScript wrapper for a DOMWindow is created, and a new Document is
installed on the DOMWindow.
    
Sometimes, only the former happens, e.g. an iframe with an image as src
doesn't have an document.
    
However, for the embedder, this difference doesn't matter. It's in both
cases possible (and necessary) to install additional hooks on the
windows object.
    
Last but not least, we should never notify the embedder for changes in
isolated worlds. An embedder that is interested in these signals should
listen didCreateScriptContext/willReleaseScriptContext.
    
BUG=none
R=yurys@chromium.org,dcarney@chromium.org

Review URL: https://codereview.chromium.org/146693005

git-svn-id: svn://svn.chromium.org/blink/trunk@173621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The error code can be ABORT_ERR if a operation is aborted by the browser.

BUG=369525

Review URL: https://codereview.chromium.org/267253008

git-svn-id: svn://svn.chromium.org/blink/trunk@173620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371276
TBR=yurys
NOTRY=true

Review URL: https://codereview.chromium.org/268353010

git-svn-id: svn://svn.chromium.org/blink/trunk@173619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/274453012

git-svn-id: svn://svn.chromium.org/blink/trunk@173618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/270213006

git-svn-id: svn://svn.chromium.org/blink/trunk@173617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361729, 371104
TBR=enne, ojan
NOTRY=true

Review URL: https://codereview.chromium.org/277523007

git-svn-id: svn://svn.chromium.org/blink/trunk@173616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the rare data objects for Node and Elements into garbage
collected objects.

R=haraken@chromium.org,zerny@chromium.org,erik.corry@gmail.com
BUG=357163

Review URL: https://codereview.chromium.org/265793017

git-svn-id: svn://svn.chromium.org/blink/trunk@173615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I can't find any reason to do a layout when the self painting bit
changes. The code was added by hyatt a long time ago in
https://trac.webkit.org/changeset/43657 but the test he added still
passes without that code (as do the rest of the tests).

Lets just delete this layout code.

Review URL: https://codereview.chromium.org/275563002

git-svn-id: svn://svn.chromium.org/blink/trunk@173614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Recent CL broke run-bindings-tests on my machine:
Move modules-dependent IDL statements out of core by supporting 'implements' in RHS interface
https://codereview.chromium.org/270573005/

This is due to depending on order of files;
this is fixed by doing the moving/merging in a separate, global phase
(which we're already doing).

Also:
* Adds a test case.
* Fixes unaddressed nits.

R=haraken
BUG=358074

Review URL: https://codereview.chromium.org/270823002

git-svn-id: svn://svn.chromium.org/blink/trunk@173613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/274763003

git-svn-id: svn://svn.chromium.org/blink/trunk@173612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tkent@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/271673005

git-svn-id: svn://svn.chromium.org/blink/trunk@173611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=371264
NOTRY=true

Review URL: https://codereview.chromium.org/278583002

git-svn-id: svn://svn.chromium.org/blink/trunk@173610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=367903

Review URL: https://codereview.chromium.org/279493003

git-svn-id: svn://svn.chromium.org/blink/trunk@173609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Pass WorkerGlobalScope as a reference until we set it to RefPtr
- Wrap m_syncHelper with a function hasTerminatedPeer() for readability
- Stop holding reference on WorkerGlobalScope in
  WorkerThreadableWebSocketChannel
- Move ASSERT(m_syncHelper) to waitForMethodCompletion()
- Return a value indicating failure when waitForMethodCompletion()
  returns because of shutdown
- Make the methods not calling waitForMethodCompletion() also return
  without doing anything if the peer is already terminated
- Move task posting code into waitForMethodCompletion()
- More comments for readability

BUG=none

Review URL: https://codereview.chromium.org/265713004

git-svn-id: svn://svn.chromium.org/blink/trunk@173608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/273653003

git-svn-id: svn://svn.chromium.org/blink/trunk@173607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/273543003

git-svn-id: svn://svn.chromium.org/blink/trunk@173606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/270573009

git-svn-id: svn://svn.chromium.org/blink/trunk@173605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=162783
R=ager@chromium.org

Review URL: https://codereview.chromium.org/273503006

git-svn-id: svn://svn.chromium.org/blink/trunk@173604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=173588

BUG=371104,361729
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/278523003

git-svn-id: svn://svn.chromium.org/blink/trunk@173603 bbb929c8-8fbe-4397-9dbb-9b2b20218538