- 26 Sep, 2019 40 commits
-
-
Sunny Sachanandani authored
Make DCLayerOverlayProcessor keep track of output rects of each child render pass that has filter operations and compare that with the quad target rect when deciding whether to promote to overlay. Bug: 997517 Change-Id: Iee6cc6acfea1ae00ce1aa676138440949cfabd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817269Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#700061}
-
Steven Bennetts authored
In C++ mojo uses StructPtr for embedded structs, regardless of whether they are required, so it is possible to pass 'nullptr' for required properties, causing a runtime error when the properties are received. This CL: * Ensures that required ManagedString properties are provided in the C++ code, and fixes the set of properties provided for VPNs based on type. * Fixes some CSS causing incorrect indicators, and cleans up some logic in the JS. Bug: 1008230 Change-Id: I51484fc74e672b7b8434228abd219428461b92f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824320 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700060}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30c2b66fbabe..c5bc9d6da851 git log 30c2b66fbabe..c5bc9d6da851 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 qingsi@webrtc.org Treat wlan as a WiFi adapter name on all platforms. Created with: gclient setdep -r src/third_party/webrtc@c5bc9d6da851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2dac97cad9b3d941e4e3ba1dedea48466ab323af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700059}
-
Andrii Shyshkalov authored
R=jbudorick Bug: 988217 Change-Id: I380cca75ce78086e5768b2c4dfa5e5464487d8d1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826055 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#700058}
-
Brandon Wylie authored
Bug: 1006939 Change-Id: I80660992d19533dde83f47fb24ed358ef3a58669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824065Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700057}
-
Miyoung Shin authored
This change converts ShareService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I26f60a0ae23e851bc19b8a157a2f3923005d822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824049Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#700056}
-
Sam Maier authored
The plan was to migrate everything over to this, but it didn't happen. Since there are no users of this, it's better to not support this anymore. See https://chromium-review.googlesource.com/c/chromium/src/+/1803394/2 for an example of confusion with using compress = true. Change-Id: Ib6d666c2a937c3e024ca5fde6b59eddbd560a13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825919 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#700055}
-
Kenichi Ishibashi authored
We can remove the IPC from FailedTo{LoadClassic,FetchModule}Script() because: * After crrev.com/c/1819282 ServiceWorkerGlobalScope calls close() when top-level script fetch failed. Close() eventually invokes ServiceWorkerContextClient::WorkerContextDestroyed() which sends the IPC. * The reason we sent OnStopped IPC from FailedTo{LoadClassic,FetchModule}Script() was to support on-the-main-thread script fetch. We no longer support it. This CL also ensures that we have test coverage of the linked bug. Following browsertests fail without crrev.com/c/1819282 when this CL is landed. * ServiceWorkerVersionBrowserTest.StartNotFound * ServiceWorkerBlackBoxBrowserTest.Registration Bug: 1005650 Change-Id: Ie61b633b213ca4e8646c009d2f5a0569c55820a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824727Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700054}
-
Tim Song authored
The font rendering system seems to take into account screen resolution when deciding whether to elide the text or not. However, this looks very bad and we should never elide for these buttons. BUG=1005764 Change-Id: I5f147f47a7cad3890b7997c08a377f5ae6f381fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819560Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#700053}
-
Yun Liu authored
Bug: 1008224 Change-Id: I4ce423f92d58c5cc00630abd0479686b2edb6621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825795Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#700052}
-
Joel Hockey authored
The existing static Is*[Enabled|Allowed] functions in crostini_util are difficult to manipulate for tests. The CrostiniFeatures and FakeCrostiniFeatures make it easier to fake these methods in tests. TBR=calamity@chromium.org Bug: 1004708 Change-Id: If6381de5b1d0faf581112782d2734a5360379140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809199 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#700051}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6ac5a9250dff..64f4dd71278a git log 6ac5a9250dff..64f4dd71278a --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jiawei.shao@intel.com Add check between color state format and fragment shader output 2019-09-25 mchiasson@gmail.com Fixed compilation issues when using libstdc++ Created with: gclient setdep -r src/third_party/dawn@64f4dd71278a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9510ae1e6417f564cf534cd287063778b66182a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700050}
-
Glen Robertson authored
Change-Id: Ief702a3e9c02086063576532358da0eb5f12402c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826058 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#700049}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic0889ad21e7e491f515a51fe24e40397c0b05cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808075Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700048}
-
Tommy Steimel authored
Since we're not releasing GMC in M78, this CL disables GMC by default. Bug: 1007486 Change-Id: I8c0131710abbb393faad4d739fac53aca41e8939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823437 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#700047}
-
Steven Bennetts authored
This removes the last remaining use of networkingPrivate in Chrome OS WebUI! Bug: 1001598 Change-Id: I984ae41a3dc6949862ffb8e4556a95cef646d251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825873Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700046}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateLayeredWindowUpdater in DisplayClient. According to the change, related classes are also changed with mojo::PendingReceiver, mojo::PendingRemote, and mojo::Remote. Bug: 955171 Change-Id: Ib40de7fdf35bace79e97d1aa8a5f55e8c7c414b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824792Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700045}
-
Darwin Huang authored
Bug: 990234 Change-Id: I6c8754c21ef2a1f5b712790cd43145e4853fea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823728Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700044}
-
Xiaohan Wang authored
File chrome_child.dll is only available when CHROME_MULTIPLE_DLL_BROWSER is defined. Check CHROME_MULTIPLE_DLL_BROWSER and fix the logic in cdm_host_file_path.cc. Bug: 1008039 Test: Manually build Chrome and verified the behavior. Change-Id: I92d23b7a449ddfdfcdadc231ab0f012b7bd8b95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825163Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700043}
-
Miyoung Shin authored
This change converts SensorProvider mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I77090420741c2f274133e6dbf7f06862dd79b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820717 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#700042}
-
Mounir Lamouri authored
This reverts commit 00d10067. Reason for revert: feature not ready to launch in M78, reverting in trunk then merging. Original change's description: > [Lock screen media controls] Enable by default > > Enable the lock screen media controls by default > since these are shipping in M78. > > BUG=965546 > > Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690893} TBR=jamescook@chromium.org,beccahughes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965546 Change-Id: I97211dd536f71ee8fed4b08b1124089343f797a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826043Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#700041}
-
Steven Bennetts authored
This fixes a bug where certificate updates were not triggering a refresh in the new mojo based JS. While testing that I discovered that the current default certificate selection logic is broken. This is a subtle thing so was not noticed previously. This fixes the logic, cleans up some code, and adds some tests. Bug: 1001598 Change-Id: Ib81d7f6e093e1e5837d5272c848a3422d6a80b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825120 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700040}
-
Lei Zhang authored
Use constants from base/numerics/math_constants.h instead. Then there is no need to add _USE_MATH_DEFINES for MSVC. Along the way, fix some nits: - Use the right math function variant for floats. - Mark more constants as constexpr. - Do IWYU. - Fix lint errors. Change-Id: I9b5efe6f19a6f568aede3ad8c80012a2a7c76ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825893Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#700039}
-
Wez authored
Reason for revert: Reverting to an SDK revision that allows the "chromium" package to be updated to a local build. The previous SDK revert didn't go back far enough to fix things. TBR=sergeyu Bug: fuchsia:37329 Change-Id: I3accef797ccb4110f8bcacd7f559d6d19d1e4c3f Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825903Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#700038}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2eae4389fbdf..30d3c8afe19c git log 2eae4389fbdf..30d3c8afe19c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chrisforbes@google.com Slim down ROP handling for various formats Created with: gclient setdep -r src/third_party/swiftshader@30d3c8afe19c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I269de0f707b1778cefc94e3e8bbe40ee3eb2f047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700037}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29f7916fd56e..f703443b1f67 git log 29f7916fd56e..f703443b1f67 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 jmadill@chromium.org Use Resource IDs in RefCountObject. Created with: gclient setdep -r src/third_party/angle@f703443b1f67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Iea5158e9cf6340575b38cd0f24b16721c3b637e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700036}
-
Yue Zhang authored
* Instead of specifying the size of dialog, make it dynamic by fixing the size of the text part and let animation take up whatever left. * For dialog in landscape mode, squeeze the margin between TextViews to make more space for the animation. Bug: 1003263 Change-Id: Ic34a439b46d2dc2f207ddcf49eeed755736313a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825866Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#700035}
-
Yue Zhang authored
Bug: 1005931 Change-Id: If6e7f76d463ded6e30468bcaddd3bc99e3f94b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825902Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#700034}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95d5e25ad030..8aa759f0bb96 Created with: gclient setdep -r src-internal@8aa759f0bb96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I144b62af7df385cecc2670c81ed58a10a5d2389e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700033}
-
Andrii Shyshkalov authored
R=jbudorick Bug: 988217 Change-Id: Ic77f66fde620e93c4b4c1728f1385a4ad261507c No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825480 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#700032}
-
Renjie Tang authored
Change-Id: I79b7b9e381b1385497570ea93c56ac6d930399c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825510Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700031}
-
Mark Pearson authored
This reverts commit a7fc60bd. Reason for revert: Changes values of enum buckets for enums that are written to logs. Original change's description: > Add three UMA metrics for bookmarks addition. > > First metric collects stats on bookmark addition > sliced on profile. Second and third metric collects stats > on the count of open tabs during bookmark all tabs, for > regular and incognito users. > > Bug: 966747, 1006145 > Change-Id: I29add57c472cf5344951b4a91be465872db45485 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793184 > Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699859} TBR=ellyjones@chromium.org,mpearson@chromium.org,pbos@chromium.org,rhalavati@chromium.org,roagarwal@chromium.org Change-Id: Id6d63633d4080daebfc845474b3240c9e4fd638d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966747, 1006145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825481Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700030}
-
Michael Crouse authored
Previously, the RecordHintsFetcherCoverage was a static function that used base::Time for determining if a navigation was covered or not by a fetch. This change wraps the function that allows a clock to be passed for the unittests so that time can be easily mocked. This change also addresses the precision issue from the attached bug. The expiration time does not need to be precise even to the 10s of minutes so the test here can be made less exact. Bug: 1007427 Change-Id: I43110bbeeb26d5cdba22febd2e1cd33a5709949e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825895 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700029}
-
Alexei Filippov authored
Previously we used to skip first allocation on each thread. That accounts for certain amount of memory, especially when there are lots of threads. BUG=1007491 Change-Id: Ibe990c6094355183833fdfc598a0e8c0196a8aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825727 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#700028}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 80846d48. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I934da8fdeedd5475dc4d8c9b86990ae2db70998b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825404Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700027}
-
Connie Wan authored
This is currently causing a small number of crashes in a corner case with no known repro (see attached bug). It may become a more common pattern if extensions are able to create new, singleton grouped tabs, or if grouped tabs can be restored into new singletons. Bug: 1006708 Change-Id: I8720b021fe8cd3c677eefa7e7f7639672673b10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825660Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#700026}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69b63c9f97d0..f0faf48ddb89 git log 69b63c9f97d0..f0faf48ddb89 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ehmaldonado@chromium.org git-cl: Set legacy properties. Created with: gclient setdep -r src/third_party/depot_tools@f0faf48ddb89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1004447 Change-Id: I726aabdfb45c45b18e1e3bd1a339a09abb3797b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700025}
-
Shannia authored
Change-Id: Ifbb3fe06c160484a945aa1166b6c3f71eaa531e3 Bug: 1005405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807228Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Shannia Fu <shannia@google.com> Cr-Commit-Position: refs/heads/master@{#700024}
-
Kristi Park authored
Explicitly remove using-mouse-nav. The keydown event was prevented from propagating to the listener that removed the mouse navigation class. Bug: 1005712 Change-Id: I30b8d9c025cf5f56805134eefd6918892c19ec62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825729Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700023}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ac30b02093..692a818a2c79 git log 19ac30b02093..692a818a2c79 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 pmuetschard@google.com Merge changes I16462479,Iaac37fff,Ic0bc28b9 Created with: gclient setdep -r src/third_party/perfetto@692a818a2c79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie81cd6c736d42148d741e5e1a8cadeca392e55b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700022}
-