- 20 Sep, 2018 40 commits
-
-
Robbie McElrath authored
This migrates DomainReliabilityMonitor from NetworkChangeManager to NetworkConnectionTracker, which works with the network service enabled. Bug: 887027 Change-Id: Icc22466c2272bdc45978218d1443c77810e7f663 Reviewed-on: https://chromium-review.googlesource.com/1234855Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592946}
-
Karan Bhatia authored
r591131 unified code to close the overflow menu from the ui/layer, deleting MediaRouterActionPlatformDelegate::CloseOverflowMenuIfOpen, removing the need for a delegate. This CL removes the delegate interface and its implementations. It should have no behavior change. BUG=None Change-Id: I54bba038673c6fbba2b84aa17ad63f4c9ed7e229 Reviewed-on: https://chromium-review.googlesource.com/1229776Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592945}
-
yiyix authored
Change-Id: Ie83fb3f96f0d914a002fdcb9461066a2a29f5abe Reviewed-on: https://chromium-review.googlesource.com/1231376Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#592944}
-
Evan Stade authored
Bug: 883072 Change-Id: I24380dc595a7446e463422848916b73845945861 Reviewed-on: https://chromium-review.googlesource.com/1227357Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#592943}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52ea49706fd7..4ce287e04201 git log 52ea49706fd7..4ce287e04201 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 ianelliott@google.com Change the name of the opt'ed-in app from maps to cubey. Created with: gclient setdep -r src/third_party/angle@4ce287e04201 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I17c7fff9689dbdccf4e92a0e8b1baa24f65d03c1 Reviewed-on: https://chromium-review.googlesource.com/1236882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592942}
-
mark a. foltz authored
You can't run Views browsertests on Mac when views browser windows are disabled. TBR=imcheng@chromium.org Bug: 883976 Change-Id: I4d318db3f58743f543e278f744e3926d6e9076e4 Reviewed-on: https://chromium-review.googlesource.com/1237151Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592941}
-
Nico Weber authored
Bug: 832676 Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b Reviewed-on: https://chromium-review.googlesource.com/1236177Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592940}
-
Sarah Hu authored
Bug: 882588 Change-Id: I4f12426d6e2027640a6645cac9bd6b62b1a34fc5 Reviewed-on: https://chromium-review.googlesource.com/1232478Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592939}
-
Richard Townsend authored
Fixes an uninitialised variable caught by MSAN. This reverts commit 66a74d2f. Change-Id: I1e896476fe201fb05072970220bab5c3b20588a2 Reviewed-on: https://chromium-review.googlesource.com/1233746 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592938}
-
Justin Cohen authored
This reverts commit fbe67a95. Reason for revert: Breaks TabSwitcherTransitionTestCase\testRotationsWhileSwitcherIsNotActive Original change's description: > [ios] Fix VoiceOver Issues in Tabgrid > > - Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page. > - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable. > > Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45 > > Bug: 880079 > Change-Id: I0696786292bec375af9d5326a790700000114559 > Reviewed-on: https://chromium-review.googlesource.com/1221474 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592818} TBR=marq@chromium.org,thegreenfrog@chromium.org Change-Id: Idb378ca1c1a1405275975e47956ac94d09865ab1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880079 Reviewed-on: https://chromium-review.googlesource.com/1237174Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592937}
-
Sunny Sachanandani authored
Send an early DidNotProduceFrame if the scheduler uses a late deadline, and no new frame is expected. The DisplayScheduler uses this as a signal to draw if other producers have submitted frames. This is intended as a short-term fix to solve smoothness issues with surface for video with 30fps videos. Ideally the DisplayCompositor will have some followups as well so that one client that is slow to respond will not cause smoothness issues with another client. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icf2f067dd08836de24ea5d0cdc896dc433062d5c Bug: 874676 Reviewed-on: https://chromium-review.googlesource.com/1211917 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592936}
-
Tommy C. Li authored
Bug: NONE Change-Id: Ibb8098e156f63a43b82b25d4ba84f43002d27911 Reviewed-on: https://chromium-review.googlesource.com/1236927 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592935}
-
Paul Miller authored
Chrome uses IsFetchingEnabled() to enable getting the seed under any of these conditions: • is_chrome_branded • --variations-server-url • g_should_fetch_for_testing Chrome also enables the test config if none of these conditions are met: • fieldtrial_testing_like_official_build • is_chrome_branded • --disable-field-trial-config • --force-fieldtrials • --variations-server-url (See VariationsFieldTrialCreator::SetupFieldTrials().) So by default (is_chrome_branded=false), the seed will be disabled and the test config will be enabled. In the released builds (is_chrome_branded=true), the seed will be enabled and the test config will be disabled. But depending on flags and build args, it's possible to enable both. The same experiment in both places will then be added twice, hitting a DCHECK in FeatureList::RegisterFieldTrialOverride(). WebView shares the same conditions for enabling the test config, but before this change, would always use the seed as well, since WebView doesn't call IsFetchingEnabled(). BUG=884827 Change-Id: I3b8281a3a44ebbae894e744fc0a84d6d1f94a0d4 Reviewed-on: https://chromium-review.googlesource.com/1228913 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592934}
-
Matthew Jones authored
This patch fixes some ambiguous wording for light/dark mode icons in favor of incognito/normal and flips the incorrect accessibility text labels. This patch also makes buttons with no drawable invisible so accessibility does not try to focus them. Bug: 887001, 887010 Change-Id: Ie7ae4461035064d3aeac5c929fc9f3eb1296bbcd Reviewed-on: https://chromium-review.googlesource.com/1235203 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#592933}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7a0a5198543..d8dcf93795bb Created with: gclient setdep -r src-internal@d8dcf93795bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b32a37c27b13416ab8e6dc6e70d5086f3e69258 Reviewed-on: https://chromium-review.googlesource.com/1236481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592932}
-
Josh Karlin authored
Removes a metric that showed the resources loaded in non-ad frames. This was never referenced so it's time to remove it. Bug: 884233 Change-Id: Icc3522b515d757f4b58c30edcf7373da98453423 Reviewed-on: https://chromium-review.googlesource.com/1233937 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Mike Klein authored
We noticed recently on the Skia tree that if we build Chromium's zlib with GCC, -O3, -m32, and -msse2, deflateInit2_() crashes. Might also need -fPIC... not sure. I tracked this down to a `movaps` (16-byte aligned store) to an address that was only 8-byte aligned. This address was somewhere in the middle of the deflate_state struct that deflateInit2_()'s job is to initialize. That deflate_state struct `s` is allocated using ZALLOC, which calls any user supplied zalloc if set, or the default if not. Neither one of these has any special alignment contract, so generally they'll tend to be 2*sizeof(void*) aligned. On 32-bit builds, that's 8-byte aligned. But because we've annotated crc0 as zalign(16), the natural alignment of the whole struct is 16-byte, and a compiler like GCC can feel free to use 16-byte aligned stores to parts of the struct that are 16-byte aligned, like the beginning, crc0, or any other part before or after crc0 that happens to fall on a 16-byte boundary. With -O3 and -msse2, GCC does exactly that, writing a few of the fields with one 16-byte store. The fix is simply to remove zalign(16). All the code that manipulates this field was actually already using unaligned loads and stores. You can see it all right at the top of crc_folding.c, CRC_LOAD and CRC_SAVE. This bug comes from the Intel performance patches we landed a few years ago, and isn't present in upstream zlib, Android's zlib, or Google's internal zlib. It doesn't seem to be tickled by Clang, and won't happen on 64-bit GCC builds: zalloc is likely 16-byte aligned there. I _think_ it's possible for it to trigger on non-x86 32-bit builds with GCC, but haven't tested that. I also have not tested MSVC. The moved comment is entirely to appease git cl format. Change-Id: Ie2d8eb9ddefa1e35e6d21ee4b29797f6949b0687 Reviewed-on: https://chromium-review.googlesource.com/1236613Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#592930}
-
Xiaohui Chen authored
Bug: b:115397214 Test: locally build and test Change-Id: Ia7ccdd15906bb195e766f5a93db9e0ed2c0039ca Reviewed-on: https://chromium-review.googlesource.com/1220812Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592929}
-
Michael Thiessen authored
A downstream project wants to exclude hdpi and higher density resources, so I figured I'd land support here to reduce rebase burden. Change-Id: I780b09703f822f455912ac9a119acb3dd56112bb Reviewed-on: https://chromium-review.googlesource.com/1234221Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
-
mrefaat authored
Create a field trail entry before experimenting with 50% Beta Bug: 850760 Change-Id: Ie2796f43a0443ac8bc8a77ac2db8057b32d989d2 Reviewed-on: https://chromium-review.googlesource.com/1234356Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592927}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6dfe41ffa6e..7397af8da50b git log e6dfe41ffa6e..7397af8da50b --date=short --no-merges --format='%ad %ae %s' 2018-09-20 primiano@google.com Merge "Add performance debug mode" Created with: gclient setdep -r src/third_party/perfetto@7397af8da50b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib7a81bba65f5872420a79431273549ac288d1889 Reviewed-on: https://chromium-review.googlesource.com/1236482Reviewed-by:
-
Madeleine Barowsky authored
Bug: no bug Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If0f518894dd1264931e224f5103f2d6f75e343cd Reviewed-on: https://chromium-review.googlesource.com/1236674Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592925}
-
Joshua Peraza authored
9ae453628f50 android: handle RELRO sharing by the Chromium linker 688dcfa22ee9 android: handle modules loaded from zipfiles Change-Id: Ib295fb1e0f0571c38f9bf5603eda349b9f8e15da Reviewed-on: https://chromium-review.googlesource.com/1236467Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592924}
-
Zhenyao Mo authored
We still see a bit of hang at buffer_manager() destruction, which is the beginning of ContextGroup destruction. So we add a few pokes in context destruction before the ContextGroup destruction. BUG=749046 TEST=crash reports go down R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4726e63f2cf4fa5c1471a25ef65f8d8ac9411c09 Reviewed-on: https://chromium-review.googlesource.com/1237114Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592923}
-
Robert Ogden authored
This adds the string in the URLBar display text. See mock linked in the bug. Also changes the string name in the grd file since it's now used in more than just the verbose status. Bug: 886947 Change-Id: I41df81c607a5641e8c663b192423559ba5e84ba8 Reviewed-on: https://chromium-review.googlesource.com/1234533 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#592922}
-
Yi Gu authored
Currently we are printing out a console message upon trying to play an invalid worklet animation, e.g. no-keyframe effect. Rather, an exception should be thrown. Note that regular animations accept effects without any keyframes, but it currently does not make much sense in our implementation of worklet animation. It's a little bit strict to throw ATM, but once our implementation is able to support it we can remove this exception. Bug: 882939 Change-Id: Ia63b67b70adeb132f5df2c8679935551ec3ac1d7 Reviewed-on: https://chromium-review.googlesource.com/1225091Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592921}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5ac303c5308..9cba9ffdfdc6 git log a5ac303c5308..9cba9ffdfdc6 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dpranke@chromium.org Add the crcmod wheel for gsutil, to get it to shut up. 2018-09-20 sdy@chromium.org Suppress URLErrors when uploading metrics. Created with: gclient setdep -r src/third_party/depot_tools@9cba9ffdfdc6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875100,chromium:887540 TBR=agable@chromium.org Change-Id: I9e8794867feb346151dffeb261dc9f16089db3c5 Reviewed-on: https://chromium-review.googlesource.com/1236880Reviewed-by:
-
Jonathan Freed authored
This will be used to fetch the data from our API endpoint. It is only a fetcher and does not do any processing of the data that is downloaded. Bug: 867488 Change-Id: Ic7506af2523632c1173333ddf2a1f2183b27f72f Reviewed-on: https://chromium-review.googlesource.com/1229013 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#592919}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I14b8c97a5c749acef25b7b343cb5952c6d2dad25 Reviewed-on: https://chromium-review.googlesource.com/1234219 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592918}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0086f7aa8400..713f53360e2e git log 0086f7aa8400..713f53360e2e --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dgarrett@google.com chromeos_config: Allow multiple sharded tests on one board. Created with: gclient setdep -r src/third_party/chromite@713f53360e2e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic33e7ad5529fbd83eb0a3992bf40307feea5737d Reviewed-on: https://chromium-review.googlesource.com/1236479Reviewed-by:
-
Scott Violet authored
Before I add more exhaustive information I want to make sure I'm on the right track. This adds the count of the number of outstanding requests to add a page (url and other information) that haven't been processed yet. BUG=807009 TEST=none Change-Id: Ieb18fe74e9e91fe4f99eb1a791b04367c60cfd0d Reviewed-on: https://chromium-review.googlesource.com/1234240 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#592916}
-
Xida Chen authored
This test changes expectation for some frame throttling tests with PaintTouchActionRects enabled. The behavior is slightly different in the unit test and the comments explains why. Bug: 881890 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Change-Id: I0e6fdeebcbe016675ee082f38d8da66ce30abbeb Reviewed-on: https://chromium-review.googlesource.com/1237056 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592915}
-
James Hawkins authored
When multidevice flags are turned on. This is a stop-gap measure to prevent users from running through the deprecated Smart Lock setup flow when in the new multidevice world. R=khorimoto@chromium.org Bug: 881924 Test: none Change-Id: Ifec2bd324e55592f14a50fe6cb5331496f010eff Reviewed-on: https://chromium-review.googlesource.com/1236840Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592914}
-
Lukasz Anforowicz authored
The test flakily crashes with an unknown callstack (the crash is not reproducible locally). The speculation is that the crash is related to dereferencing a null base::MemoryPressureMonitor::Get(). If this is indeed the case, then the crash should be fixed by using base::test::FakeMemoryPressureMonitor in the test (rather than directly dispatching a memory pressure notification from the test). Bug: 887545 Change-Id: Ib922ebe4c7f85ec028f4bb202f2357c71e20687a Reviewed-on: https://chromium-review.googlesource.com/1236502Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592913}
-
Che-yu Wu authored
Highlight the file name with strong tag, so that users can scan the list easily. Bug: crbug.com/883737 Change-Id: Iaccf05983efe0414ce39fe35c1c89be4b4102d12 Reviewed-on: https://chromium-review.googlesource.com/1231835 Commit-Queue: Che-yu Wu <cheyuw@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#592912}
-
Balazs Engedy authored
Replace "We couldn't verify your identity on this device" with the string “Your identity couldn’t be verified”. Bug: 887390 Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3 Reviewed-on: https://chromium-review.googlesource.com/1236002Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592911}
-
Becky Zhou authored
+ Parameterized some more tests in NewTabPageTest + Add some tests for FeedNewTabPage on the header views Bug: 860055 Change-Id: Ie86d67d4e852117eb4074db9c522bbc219d5d4dc Reviewed-on: https://chromium-review.googlesource.com/1227178 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Ehsan Karamad authored
The fix did not work and the issue turned out to be something else. Cleaning up most of the changes made in master@{#591833}. Bug: 878359 Change-Id: I5432523622a82743d1c67e2768f70b437e580a22 Reviewed-on: https://chromium-review.googlesource.com/1236838Reviewed-by:James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592909}
-
Jordy Greenblatt authored
The settings-multidevice-setup-page listens for the event 'close' as a proxy for the password prompt being confirmed. However, the event type 'close' is ubiquitous to cr-dialog so it also fires when the forget device dialog is closed on the subpage, which causes the assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)" in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to fail. This CL only calls onPasswordPromptDialogClose_ if the close event came from the MultiDevice page's password prompt and stops the event's propagation. Bug: 887160 Change-Id: I5740061c8f9e08ee5ba9e8d99862bcec6b0a6677 Reviewed-on: https://chromium-review.googlesource.com/1235321 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#592908}
-
Samuel Huang authored
Changing 4-indent to 2-indent. Also: - Make <style> and <script> tags indent from start of line. - Fix several missing ';' in JS. Bug: 880671 Change-Id: Iddda84bbdcf5040935d27643925aebb1433580c7 Reviewed-on: https://chromium-review.googlesource.com/1237141 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592907}
-
