GitLab

The common string descriptors: iManufacturer, iProduct and iSerialNumber
should be accessible without opening the device. On Linux these can be
read out of sysfs without having access to the usbfs device node. This
is critical on Chrome OS because otherwise the permission broker needs
to be asked for permission to access the device. On other platforms we
fall back to opening the device temporarily. This will stop being the
case on OS X when libusb is no longer used and on Windows this will be
part of the initial enumeration process.

BUG=
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/601073002

Cr-Commit-Position: refs/heads/master@{#296802}

+ Correct the layout and size of the offline icon when getting a DNS_PROBE_FINISHED_NO_INTERNET error
+ Delay AudioContext initialising until required to reduce CPU usage.

BUG=417614

Review URL: https://codereview.chromium.org/601523003

Cr-Commit-Position: refs/heads/master@{#296801}

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/601283005

Cr-Commit-Position: refs/heads/master@{#296800}

Normally extensions must specify a concrete list of url patterns. But with this
patch, extensions on the whitelist can do:

 "permissions": ["externally_connectable.all_urls"],
 "externally_connectable": {
    "matches": ["<all_urls>"]
  }

and they will be able to be connected to from any url.

Also add an entry to the whitelist for the CryptoToken extension.

BUG=417062,417494

Review URL: https://codereview.chromium.org/599163003

Cr-Commit-Position: refs/heads/master@{#296799}

Make DisplayConfigurator save the requested display power
state even when it fails to configure CRTCs. This lets the
previously-requested state be used for future mode changes.

BUG=chrome-os-partner:31571

Review URL: https://codereview.chromium.org/597683004

Cr-Commit-Position: refs/heads/master@{#296798}

BUG=416209
TEST=None

Review URL: https://codereview.chromium.org/591803002

Cr-Commit-Position: refs/heads/master@{#296797}

This removes the last files regarding guava since
http://crbug.com/380688 has now been addressed.

TBR=darin@chromium.org
BUG=412673

Review URL: https://codereview.chromium.org/602203003

Cr-Commit-Position: refs/heads/master@{#296796}

There are 3 different sets of callbacks generated by AppKit in response to
swipe events. The previous code relied on assumptions about the timing of the
callbacks. It expected to receive the beginGestureWithEvent: callback before
receiving any touchesMovedWithEvent: callbacks. Yosemite AppKit broke this
assumption.

The new code stops using beginGestureWithEvent: except to determine edge cases
associated with the Magic Mouse, thus removing this implicit assumption.

Because history swiping direction is determined very early on in the life cycle
of the gesture, this CL adds some logic to ensure that the direction isn't
determined prematurely.

BUG=414103
TEST=History swiping should work as expected with both magic mouse and
trackpad.

Review URL: https://codereview.chromium.org/600743003

Cr-Commit-Position: refs/heads/master@{#296795}

Revert of Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/603833002/)

Reason for revert:
*Fingers crossed* all the Android builders are on Java 7 now.
Please comment on
https://code.google.com/p/chromium/issues/detail?id=411503#c31 if you see any Android builders failing to compile due to unknown target version 1.7.

Original issue's description:
> Revert of Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://codereview.chromium.org/601983002/)
>
> Reason for revert:
> Broke Android bots:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/2225
> http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/66337
>
> Original issue's description:
> > Revert of Revert of Set the javac target and source to 1.7 (patchset #1 id:1 of https://chromiumcodereview.appspot.com/579543003/)
> >
> > Reason for revert:
> > All the bots have been switched to Java 7 according to https://code.google.com/p/chromium/issues/detail?id=411503#c19
> >
> > Original issue's description:
> > > Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/)
> > >
> > > Reason for revert:
> > > Not all bots have Java 7 yet :(
> > >
> > > Original issue's description:
> > > > Set the javac target and source to 1.7
> > > >
> > > > BUG=336589
> > > > TBR=yfriedman@chromium.org
> > > >
> > > > Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b
> > > > Cr-Commit-Position: refs/heads/master@{#295162}
> > >
> > > TBR=cjhopman@chromium.org,yfriedman@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=336589
> > >
> > > Committed: https://crrev.com/094138696e943744d1489ebb98276b116eafed99
> > > Cr-Commit-Position: refs/heads/master@{#295165}
> >
> > TBR=cjhopman@chromium.org,yfriedman@chromium.org
> > BUG=336589
> >
> > Committed: https://crrev.com/119c6fa8247481d2e36910d30175d0214fd2ece5
> > Cr-Commit-Position: refs/heads/master@{#296630}
>
> TBR=cjhopman@chromium.org,yfriedman@chromium.org,aurimas@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=336589
>
> Committed: https://crrev.com/8be2c3f7a14b6191a5a38f187346ce4a36997a6e
> Cr-Commit-Position: refs/heads/master@{#296632}

TBR=cjhopman@chromium.org,yfriedman@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336589

Review URL: https://codereview.chromium.org/599633006

Cr-Commit-Position: refs/heads/master@{#296794}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/600523002

Cr-Commit-Position: refs/heads/master@{#296793}

is in background in WebView.

Previously, we couldn't trigger renderer's WasHidden/WasShown event in WebView because the compositer can't stop there, so the dedicated pause video IPC message was added as a work around.

Now we override the blink's page visibility, so renderer's onHide/onShow methods could be called, and compositer is still running. This patch

- Call ContentViewCore.onHide()/onShow() in AwContents
- Video playback is changed to hook into WasHidden() in RenderMediaPlayerManager to pause video, and remove a bunch of video pause code in browser side.

So, The pause of video capture and playback are both handled in renderer side now. There is no dedicated pause video IPC message.

BUG=414506

Review URL: https://codereview.chromium.org/570183002

Cr-Commit-Position: refs/heads/master@{#296792}

Also fixes some minor issues with how sizes and visible rects are
handled.

BUG=91208

Review URL: https://codereview.chromium.org/569313003

Cr-Commit-Position: refs/heads/master@{#296791}

This is used earlier in CompositeAndReadback.
Its not used any where now, so removing this.

BUG=

Review URL: https://codereview.chromium.org/604903003

Cr-Commit-Position: refs/heads/master@{#296790}

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/607593003

Cr-Commit-Position: refs/heads/master@{#296789}

BUG=N/A
TEST=unit tests passed.
TEST=manually confirmed keypad key has isKeyPad modifier.

Review URL: https://codereview.chromium.org/590953002

Cr-Commit-Position: refs/heads/master@{#296788}

HyperlinkTextView moved components in 0e6cd43e; this marks it as being exported for use in other components.

BUG=402485
TEST=component build builds

Review URL: https://codereview.chromium.org/602093004

Cr-Commit-Position: refs/heads/master@{#296787}

Obtain the inner viewport origin, touch and target rectangles
from the Blink relative to the outer viewport.
Use the zoom rectangle in the outer viewport coordinates for bitmap
generation but the inner viewport coordinates for the calculation
of the physical window zoom rect.

This change is part 2 of 2 (part 1 is Blink side change https://codereview.chromium.org/584893004).

BUG=370470

Review URL: https://codereview.chromium.org/595693002

Cr-Commit-Position: refs/heads/master@{#296786}

AddExtensionString is called quite a lot, always with a constant
string literal, which makes it a bit unnecessary to convert the
argument to a std::string before every function call.

This small change cuts away 7 KB of the machine code:

Total change: -7208 bytes
=========================
  1 added, totalling +559 bytes across 1 sources
  1 removed, totalling -471 bytes across 1 sources
  1 shrunk, for a net change of -7296 bytes (25422 bytes before, 18126 bytes after) across 1 sources
  267984 unchanged, totalling 50299073 bytes
Per-source Analysis:

--------------------------------------------------------------------------------------------------------------------
 -7208 - Source: /home/bratell/src/chromium/src/gpu/command_buffer/service/feature_info.cc - (gained 559, lost 7767)
--------------------------------------------------------------------------------------------------------------------
  New symbols:
       +559: gpu::gles2::FeatureInfo::AddExtensionString(char const*) type=t, size=559 bytes
  Removed symbols:
       -471: gpu::gles2::FeatureInfo::AddExtensionString(std::string const&) type=t, size=471 bytes
  Shrunk symbols:
      -7296: gpu::gles2::FeatureInfo::InitializeFeatures() type=t, (was 25422 bytes, now 18126 bytes)

BUG=

Review URL: https://codereview.chromium.org/571073003

Cr-Commit-Position: refs/heads/master@{#296785}

Revert of Add commit position to bisect result output. (patchset #2 id:20001 of https://codereview.chromium.org/580293002/)

Reason for revert:
Checkperms failure on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/11755

Original issue's description:
> Add commit position to bisect result output.
>
> BUG=413772
>
> NOTRY=true
>
> Committed: https://crrev.com/e0f01f8d8c79983e2cceddfd655f51ea3bccc3a7
> Cr-Commit-Position: refs/heads/master@{#296776}

TBR=prasadv@chromium.org,chrisphan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413772

Review URL: https://codereview.chromium.org/608643002

Cr-Commit-Position: refs/heads/master@{#296784}

BUG=368420

Review URL: https://codereview.chromium.org/604003002

Cr-Commit-Position: refs/heads/master@{#296783}

It is flaky on win7 (dbg) on webkit waterfall

BUG=417756
TEST=bots
TBR=phoglund@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/602233002

Cr-Commit-Position: refs/heads/master@{#296782}

This pulls in the following Native Client changes:

r13760: (mseaborn) untrusted.gypi: Factor out duplicated "--gomadir" option
r13761: (mseaborn) Fix mmap() with length > 0xffff0000 to behave consistently on 32/64-bit
r13762: (teravest) Support file path metadata for the main nexe.
r13763: (teravest) Add CreateNaClDescWithFilePathMetadata fn.
r13764: (dschuff) Switch PNaCl lib, include, and translator directories for new layout
r13765: (dschuff) Pass naclsdk_validate=0 to scons runs run by main waterfall bots
r13768: (dbrazdil) Allowed decrementing program break with sbrk() in MinSFI
r13769: (dyen) Added tests for rename functions in irt_ext.
r13770: (dyen) Added tests for unlink functions irt_ext.
r13771: (dschuff) Update revision for PNaCl r13753->r13769
r13772: (dyen) Added tests for fsync/fdatasync functions in irt_ext.
r13773: (petarj) PNaCl: Update libcxx revision in pnacl/COMPONENT_REVISIONS
r13774: (dyen) Added tests for file truncation functions in irt_ext.
r13775: (sehr) Add Nick Bray and Shyam as owners of the validator
r13776: (jvoung) Remember to va_end in callingconv test.
r13777: (shyamsundarr) a script to generate a trie from our DFA.
r13778: (shyamsundarr) updated version of mseaborn@chromium's old trie code. We will generate
r13779: (dschuff) Allow build of host tools with system compiler
r13780: (dyen) Added support for supplying futex calls under irt_ext.
r13781: (dschuff) Remove archived_frontend test and use gcc build for FYI bots
r13782: (dschuff) Clang and binutils for direct to nacl x86_64
r13783: (dschuff) Change prep_nacl_sdk header locations for PNaCl to match new layout
r13784: (dschuff) Revert r13723, r13730, r13744
r13785: (dschuff) Revert "untrusted.gypi: Factor out duplicated "--gomadir" option"

This also adjusts the SDK header copying script to put the libnacl
headers in the new location for PNaCl.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/597393003

Cr-Commit-Position: refs/heads/master@{#296781}

As a part of making Android CompositorImpl use cc's scheduler and not
post its own composite calls manually, cc needs to be able to handle
asynchronous output surface creation.

This change modifies CreateOutputSurface to instead be
RequestNewOutputSurface, which the LayerTreeHostClient must respond to
and call SetOutputSurface on the host with the new output surface once
it is ready.

Because the LayerTreeHostClient must now talk to the host as a part of
output surface creation, a bunch of unit test code needed to be
refactored to handle this.

BUG=none

Review URL: https://codereview.chromium.org/348093004

Cr-Commit-Position: refs/heads/master@{#296780}

We should not end up in the default implementation and want to track if this happens.

* Add new media stream result, "not supported".
* Add an error log in RenderFrameHostDelegate and WebContentsDelegate default implementations of the above functions and in Request... also use the new result.

BUG=416233
NOTRY=true

Review URL: https://codereview.chromium.org/584383002

Cr-Commit-Position: refs/heads/master@{#296779}

Caching these saves time recreating and remapping them.

Review URL: https://codereview.chromium.org/600953003

Cr-Commit-Position: refs/heads/master@{#296778}

BUG=416561

Review URL: https://codereview.chromium.org/603023002

Cr-Commit-Position: refs/heads/master@{#296777}

BUG=413772

NOTRY=true

Review URL: https://codereview.chromium.org/580293002

Cr-Commit-Position: refs/heads/master@{#296776}

BUG=417660

Review URL: https://codereview.chromium.org/601303002

Cr-Commit-Position: refs/heads/master@{#296775}

Thanks to swarming we can do with just one builder,
linux_chromium_asan_rel.

BUG=404694, 387743
R=jam@chromium.org

Review URL: https://codereview.chromium.org/599313002

Cr-Commit-Position: refs/heads/master@{#296774}

BUG=314889

Review URL: https://codereview.chromium.org/595413002

Cr-Commit-Position: refs/heads/master@{#296773}

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/587153003

Cr-Commit-Position: refs/heads/master@{#296772}

Previously it was possible to run into situations where CMake would fail,
write a partial CMakeCache.txt, and on the next run of update.sh, we would
think the build was already configured and skip the CMake step.

This patch removes that problem by always clearing the cache and forcing
a full re-run of CMake. This also has the benefit that if the path to the
compiler or a compiler flag changes, the build will get updated.

Note that doing a full re-run of CMake doesn't mean doing a full re-build.

Also, we should only be setting MACOSX_DEPLOYMENT_TARGET when doing bootstrap
builds. This patch fixes that too.

BUG=415670

Review URL: https://codereview.chromium.org/603943003

Cr-Commit-Position: refs/heads/master@{#296771}

Passing --trace-to-file on the command line will trace a default set of
categories to a default trace file name (trace.json).
--trace-to-file=categories --trace-to-file-name=somefile.json allow for
more configuration.

BUG=none

Review URL: https://codereview.chromium.org/542893002

Cr-Commit-Position: refs/heads/master@{#296770}

This matches the NSS port's behavior. If an unknown error within ERR_LIB_SSL,
map to ERR_SSL_PROTOCOL_ERROR. Otherwise, map to ERR_FAILED. The OpenSSL port
actually inverted this for some reason.

(This doesn't fix #417134 but maps it to a more appropriate error.)

BUG=417134

Review URL: https://codereview.chromium.org/598043002

Cr-Commit-Position: refs/heads/master@{#296769}

Enable WebGL on Mali-400 GPUs that support the EXT_robustness extension
but do *not* send context reset notifications. The reason we can do
this is that virtualized contexts are not used on these devices, so
badly behaving WebGL shaders do not affect other GL contexts. This means
that the user can close or reload the WebGL tab and other tabs in the
browser remain responsive.

BUG=288731,416690
TEST=https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/extra/slow-shader-example.html on a Galaxy Tab 3

Review URL: https://codereview.chromium.org/24037006

Cr-Commit-Position: refs/heads/master@{#296768}

BUG=416983

Review URL: https://codereview.chromium.org/606763002

Cr-Commit-Position: refs/heads/master@{#296767}

This updates the SDK forward declarations and adds dark resources.

R=rsesek@chromium.org
BUG=402787

Review URL: https://codereview.chromium.org/564953002

Cr-Commit-Position: refs/heads/master@{#296766}

The look of the focus ring now closely matches the one drawn by the
ChromeVox content script using CSS, and it smoothly animates from one
location to the next.

BUG=314889

Review URL: https://codereview.chromium.org/602813003

Cr-Commit-Position: refs/heads/master@{#296765}

This change was verified using depot_tools/watchlists.py

BUG=NONE

Review URL: https://codereview.chromium.org/604063002

Cr-Commit-Position: refs/heads/master@{#296764}

Revert of Remove unneeded Friend from chrome_metrics_service_accessor (patchset #1 id:20001 of https://codereview.chromium.org/601243002/)

Reason for revert:
We need to bring this back since the usage of it is coming back in an upcoming patch.

Sorry about that...

BYE
MAD

Original issue's description:
> Remove unneeded Friend from chrome_metrics_service_accessor
>
> BUG=
>
> Committed: https://crrev.com/ca032c3aed93e5afd7c32da76147f36a72dc4341
> Cr-Commit-Position: refs/heads/master@{#296722}

TBR=asvitkine@chromium.org,csharp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/603173003

Cr-Commit-Position: refs/heads/master@{#296763}