- 18 Oct, 2018 40 commits
-
-
Xida Chen authored
Right now the CSSPaintDefinition::Paint takes a IntSize which is the container size with subpixel snapping. At this moment there are two type cast: 1. The call site of the CSSPaintDefinition::Paint converts a FloatSize to IntSize 2. Inside the CSSPaintDefinition::Paint, GetSpecifiedSize is called which type casts the IntSize to float and uses it. This CL cleans it up by passing a FloatSize. That is, the Paint function takes a FloatSize such that type casting can be avoided at the GetSpecifiedSize. When we need to use the subpixel snapped size in the Paint function, we then conver the FloatSize to an IntSize. This CL should not introduce any behavior change. Bug: None Change-Id: I1387145c03b60380a0e0a53f2686647a54327e71 Reviewed-on: https://chromium-review.googlesource.com/c/1286440Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600770}
-
Rayan Kanso authored
According to the spec, responseReady in BackgroundFetchRecord should throw an AbortError DOMException if the fetch was abandoned. https://wicg.github.io/background-fetch/#create-record-objects (2.4.3) Change-Id: Ieadf278acd061e05b8822014d0934f050fcac702 Reviewed-on: https://chromium-review.googlesource.com/c/1283692 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600769}
-
Rayan Kanso authored
In addition, MatchAll should return all records, including unprocessed ones. To support this, the following changes were made: - Creating a registration also stores all the requests with an empty response in the cache. - When an individual request is processed, the failure reason (if any) is stored in the metadata. - The logic of GetSettledFetchesTask was moved to MarkRegistrationForDeletionTask. It checks the metadata rather than the cache itself to find a failure reason (if any). - Match/MatchAll logic was moved to a new database task (MatchRequestsTask). A new API call was added to the cache storage to allow querying request/response pairs. If a response is found to be empty it will be exposed as a nullptr. Change-Id: I631a3ef3da95117aed759a675fe591da5201eeca Reviewed-on: https://chromium-review.googlesource.com/c/1280851Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600768}
-
Colin Blundell authored
This is possible now that there is //chrome-level infrastructure for glueing an IdentityTestEnvironment instance to a Profile. Note that this particular test is somewhat unusual in that it builds multiple Profiles but does not require IdentityTestEnvironment to interact with those Profiles beyond doing initial configuration. For simplicity, we use local variables for the IdentityTestEnvironment associated with each Profile; otherwise, we would need to introduce distinct instance variables for the two. This CL also modifies the relevant IdentityTestEnvironmentProfileAdaptor APIs to return the TestingProfiles that they create as TestingProfiles; this avoids a cast that this test would otherwise require and clarifies the APIs. TBR=droger@chcromium.org Bug: 896180 Change-Id: Icba8cdc67c1667949636a96078f05e15fd79649c Reviewed-on: https://chromium-review.googlesource.com/c/1283038 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#600767}
-
Tavis Maclellan authored
Cast needs both render process ID and render frame ID for resolving URL requests to owning render frame / web contents. Bug: internal b/116784351 Test: Build cast_shell and run unittests Change-Id: Ib1913e41f33410241fe4d63fffa6c1ee68e18be3 Reviewed-on: https://chromium-review.googlesource.com/c/1280930Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Tavis Maclellan <maclellant@chromium.org> Cr-Commit-Position: refs/heads/master@{#600766}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/dom_distiller. This CL was uploaded by git cl split. R=bengr@chromium.org Bug: 809610 Change-Id: I30fc5cf421d359ac3072b38b940a783737e66f38 Reviewed-on: https://chromium-review.googlesource.com/c/1259023Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600765}
-
Charlie Harrison authored
All the functionality is in ContentSettingBlockedImageModel. This CL should have no behavior changes. Bug: None Change-Id: I7694d5968cbb514c0959d821bf0888a770477a0c Reviewed-on: https://chromium-review.googlesource.com/c/1287314 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600764}
-
Mugdha Lakhani authored
BackgroundFetchSettledFetch isn't exposed to JavaScript so we can remove this. Bug: 875201 Change-Id: Ic306b0f64897a7d7c1fbd61f64b6c635620d7bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1288357Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#600763}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/sockets_udp. This CL was uploaded by git cl split. R=rkc@chromium.org Bug: 809610 Change-Id: Id800ae4bd2e053483b447457cd78cb50657d8ace Reviewed-on: https://chromium-review.googlesource.com/c/1259032Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600762}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 681136 Change-Id: I860ea8a950d3802572c22aaeecba23f716f55d5b Reviewed-on: https://chromium-review.googlesource.com/c/1288339Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600761}
-
Ned Nguyen authored
This also updates how we compute the default for 'configuration'. First, we try to look for the configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the value of configuration using the target value. Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. Bug: 893618 Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 Reviewed-on: https://chromium-review.googlesource.com/c/1281043Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#600760}
-
Yi Su authored
Add SearchEngineTabHelper without any functionality. This TabHelper will be the main worker for custom search engines feature. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie18b9237d0f1df52d94ff2c9b4e70b299ab426b1 Reviewed-on: https://chromium-review.googlesource.com/c/1288431 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600759}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 753973 Change-Id: Ia8531202caddd46a45169eae9b5b8af77585ab80 Reviewed-on: https://chromium-review.googlesource.com/c/1288173Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#600758}
-
Tommy Martino authored
This CL implements footers in the Autofill dropdown on legacy (Jellybean - Marshmallow) Android. It does so by implementing an interface method which is currently empty. This also required AutofillPopup to be changed slightly, as the new implementation cannot be invoked after show()ing the popup. Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1 Bug: 896693 Reviewed-on: https://chromium-review.googlesource.com/c/1281723 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#600757}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 681136 Change-Id: I54485b40c1808525659f4af61369a04819c40e06 Reviewed-on: https://chromium-review.googlesource.com/c/1288493Reviewed-by:
-
Daniel Cheng authored
Bug: 891908 Change-Id: I5bbe921e0cf8462abe9be3c75c594e4a507d3118 Reviewed-on: https://chromium-review.googlesource.com/c/1280613 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600755}
-
Dave Tapuska authored
BUG=242216 Change-Id: I6f897509727b026b9d1f17227b0621b30821cc56 Reviewed-on: https://chromium-review.googlesource.com/c/1286937 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600754}
-
David Bokan authored
Bug: 798719 Change-Id: I371d41833373fe54efeb844a338840b7d862784c Reviewed-on: https://chromium-review.googlesource.com/c/1287188Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600753}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/413a5120b915..2d0fa5b17840 Created with: gclient setdep -r src-internal@2d0fa5b17840 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f6b61884ad88120573c736f2ebc486871527544 Reviewed-on: https://chromium-review.googlesource.com/c/1288681Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600752}
-
Ramin Halavati authored
A feature and flag is added to control adding an incognito window counter to the incognito icon on toolbar. Bug: 896235 Change-Id: Ic0766f2344d9caefc7ede1e5266df053d32ef2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1286423 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Jeremy Roman authored
This eliminates the use of V8CallBoolean. Bug: 670615 Change-Id: Ifaaa803e47b08018546d30ad633f861f38a8d645 Reviewed-on: https://chromium-review.googlesource.com/c/1288673Reviewed-by:
-
Mario Sanchez Prada authored
The reason we're now splitting this module into its own target is to avoid dependency cycles when migrating certain bits to the Identity service: since AuthService lives in google_apis/drive, we can't port it to the IdentityManager without incurring in a cycle caused by the identity service depending on the signin component which, in turn, depends again on google_apis. Note that we now need to make some GN targets under chrome/browser directly depend on //google_apis/drive as well in order to prevent build failures caused from happening because of such targets including headers files from //google_apis/drive. This was not required before doing this split since those targets would implicitly pull //google_apis through some of their direct dependencies' public_deps anyway. However, the new //google_apis/drive target is not listed as a public_dep anywhere, and so explicitly depending on it from those places is now required. Making this change now allows us to break the cycle since the signin component does not depend on anything in google_apis/drive, allowing us to reimplement AuthService in terms of the IdentityManager. Bug: 809440 Change-Id: Iec117d39beb073a094c180a1d855b7f33353e0b2 Reviewed-on: https://chromium-review.googlesource.com/c/1273074 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600749}
-
Max Moroz authored
TBR=liaoyuke@chromium.org,robertocn@chromium.org Change-Id: I783b07eacca213f2815f6c0f66bfb77c55b9435f Bug: 896556 Reviewed-on: https://chromium-review.googlesource.com/c/1288689Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600748}
-
David Roger authored
This CL tests that authentication tokens are revoked when the Gaia cookie is cleared, unless there is a ScopedSyncedDataDeletion in which case the Sync account is not invalidated. Change-Id: Ia0d5470eb3d41d67a93671a1d7a58bbddc23e8a3 Reviewed-on: https://chromium-review.googlesource.com/c/1258167 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#600747}
-
Thomas Tangl authored
When the user opted into unified consent and then the feature is rolled back, all off-by-default services are disabled. Bug: 894504 Change-Id: I50adddb41cab7c38162344a538eef52e04dfa999 Reviewed-on: https://chromium-review.googlesource.com/c/1280445 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Minyue Li authored
Bug: 896193 Change-Id: I046d763c004b2fafa66df76704489a1ab5d5821d Reviewed-on: https://chromium-review.googlesource.com/c/1286415 Commit-Queue: Minyue Li <minyue@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600745}
-
Hirokazu Honda authored
test-25fps.*.frames.md5 contains the golden md5 values on decoded video frames in VDA unittest. These values must be identical on any platforms. BUG=chromium:856562 TEST=VDA unittest at eve, veyron_minnie, hana Change-Id: I3c63b92dcc52b8a3a6cc1dc4a2dd9e9147e5ec7b Reviewed-on: https://chromium-review.googlesource.com/c/1172271 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600744}
-
Misha Efimov authored
This reverts commit 1e0ee862. Reason for revert: Don't use popen() as it is not available on Windows. Original change's description: > Revert "[Cronet] Create a sample app for native api." > > This reverts commit b54f7c7f. > > Reason for revert: breaking the tree > > Original change's description: > > [Cronet] Create a sample app for native api. > > > > Bug: 786559 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > > Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1274426 > > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > > Commit-Queue: Misha Efimov <mef@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#600438} > > TBR=pauljensen@chromium.org,mef@chromium.org > > Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 786559 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > Reviewed-on: https://chromium-review.googlesource.com/c/1286935 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600444} TBR=tguilbert@chromium.org Change-Id: I4935a11d8f20e97122fccd9451a201d135d5db8a Bug: 786559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/c/1286745Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#600743}
-
Arthur Sonzogni authored
Currently, this method is simply calling ResetChildren() on the current RenderFrameHost. It used to do more, but this is no longer the case. This CL removes this method. Seeing RenderFrameHostImpl::ResetChildren() in the code is more explicit about what happens. It is easier to understand. Bug: 609963 Change-Id: Ia82726f445b127ccca3758d7578e71eb32a49cbc Reviewed-on: https://chromium-review.googlesource.com/c/1286421 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#600742}
-
Michael Lippautz authored
Adds flags on all browser layers which are used for enabling in a Finch trial. Tbr: jochen@chromium.org Bug: 843903 Change-Id: I50d9aa479b1fb6e27588eae000138564f377b523 Reviewed-on: https://chromium-review.googlesource.com/c/1286854 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/613fd1daf8d6..6db99a9ca272 git log 613fd1daf8d6..6db99a9ca272 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 fmayer@google.com Add PERFETTO_DFATAL. 2018-10-18 fmayer@google.com profiling: Send total size attributed to allocation. 2018-10-18 primiano@google.com Don't create executable files (0755 -> 0644) 2018-10-17 primiano@google.com Merge "perfetto-ui: Remove flame chart for now" Created with: gclient setdep -r src/third_party/perfetto@6db99a9ca272 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895473 TBR=perfetto-bugs@google.com Change-Id: Ib4834e886bba5678a3626c5a03027053ece37b22 Reviewed-on: https://chromium-review.googlesource.com/c/1288676Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600740}
-
Marc Treib authored
Bug: 896303 Change-Id: Icf856bfa95640cbb44e75d35cc0e8514aac69e62 Reviewed-on: https://chromium-review.googlesource.com/c/1286850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600739}
-
Friedrich Horschig authored
Since crrev.com/c/1233716, the keyboard accessory doesn't affect the bottom controls anymore - which is largely correct since it uses a separate mechanism to reserve that space. Unfortunatly, the BottomToolbar (Chrome Duet feature) doesn't recognize the opened accessory sheet as a keyboard and reserves space for bottom controls that don't exist. This will change when the way keyboards are detected is reworked in crrev.com/c/1286426 but until this and its ancestor lands, the effects of the accessory on the bottom controls are reintroduces with this CL. Bug: 894747 Change-Id: I0467d10700c597cfe5fbf8a6463b220268ad6160 Reviewed-on: https://chromium-review.googlesource.com/c/1288592Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#600738}
-
Gauthier Ambard authored
This CL fixes the tests so they can run with the fullscreen refactoring flags enabled by default. It also fixes an issue with the ntp_util functions. Bug:none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iec703052548d3f7c024d47c30d7a429162144d85 Reviewed-on: https://chromium-review.googlesource.com/c/1261523Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#600737}
-
Elly Fong-Jones authored
These buttons have two modes: a context menu and an "activation", which usually shows a popup but may also take an action on the page or similar. They subclass MenuButton, so down-arrow is wired to activation instead of to opening the menu by default. This change causes extension actions to always open their context menu on down-arrow instead of activating, since otherwise the context menu is keyboard-inaccessible. Bug: 696268 Change-Id: If0f12c3ac5b1168cc74ea5df848ecf30d0662e09 Reviewed-on: https://chromium-review.googlesource.com/c/1286738Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#600736}
-
Nikita Podguzov authored
* Disable network configuration field if the field is enforced by policy. * Add policy network indicator if the field is controlled by policy. Bug: 877424 Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2 Reviewed-on: https://chromium-review.googlesource.com/c/1251447 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600735}
-
Matt Menke authored
This hasn't been used for a couple years, and ChromeNetworkDelegate and ContentShellNetworkDelegate are going away, with the advent of the network service, so it won't be hooked up to the experimental features command line flag, either. We may need to add this back to the network service at some point, but for now, simplest just to remove it. Bug: None Change-Id: If7bfffb64aa2407ad8a66cb092e726a50ed34fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1287209Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#600734}
-
Fredrik Söderquist authored
Move all stroke bounds related computations into the CalculateStrokeBoundingBox() method in LayoutSVGShape. Add a new enum StrokeGeometryClass, and pass that as an argument to the method. Currently all callsites use a constant argument value. This will be modified in a future CL. Split out computation of the bounds for non-scaling-stroke into a new method CalculateNonScalingStrokeBoundingBox(). Also fold LayoutSVGShape::CalculateObjectBoundingBox() since it only has a single caller. Bug: 435097 Change-Id: I538b31f98dc7f0777e2538ef74b5e3553b435a7f Reviewed-on: https://chromium-review.googlesource.com/c/1276770 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600733}
-
David Jean authored
Bug: 893051 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I39db4b25332a5816aebd2ab3842142060496d06e Reviewed-on: https://chromium-review.googlesource.com/c/1268018Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#600732}
-
Laís Minchillo authored
Null Java strings shouldn't be passed down to C++ code. This CL adds code to check for a null host string or null strings in exclusionList and throw a null pointer exception. Bug: 896285 Change-Id: I6af64350de8a93031741c8951a7efe2df7111ccd Reviewed-on: https://chromium-review.googlesource.com/c/1286849Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#600731}
-
