- 17 Sep, 2019 40 commits
-
-
Henrique Nakashima authored
These methods were added for crbug.com/358708 but the usage was reverted shortly after and they were not cleaned up. Bug: 995916 Change-Id: I63a4ec3756e34b56e1cccb54cbc7cf1bb9c312ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808082Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697363}
-
Jonah Ryan-Davis authored
With EGL on X11 it was necessary to create an extra child window due to https://crbug.com/326995. However, ANGLE already creates an extra child window so this is not necessary on top of ANGLE. Bug: 991577 Change-Id: I8e2d8ed1d11d7252877a48ac33296d2705038862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808340 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697362}
-
Justin Cohen authored
Since crrev.com/c/1540371 it's been safe to trigger a clear browsing data restore during a slimnav restore. This is because we DetachFromWebView during clear browsing data, and reset the |is_restore_session_in_progress| flag. DetachFromWebView already supports extracting restore urls from history, so there shouldn't be any data loss. Additionally, the delay implementation is wrong, since it's valid for a webstate to be suspended in the tab grid while in a slimnav restore state. In fact, on a restart, most tabs are in that state. So triggering clear browsing data when that suspended tab is the 'active' tab, will hang forever. Bug: 961726 TEST= 1.) Open a few tabs and create some navigation history for each (at least 10 navigation items) 2.) Quit the app 3.) Launch the app and quickly clear browsing data Change-Id: Ic0a67523f5a0e2a63f31061735c12a2a27abb09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807025Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697361}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/99f23d6ff220..04ebb2a000ee git log 99f23d6ff220..04ebb2a000ee --date=short --no-merges --format='%ad %ae %s' 2019-09-17 wl@gnu.org * src/otvalid/otvcommon.c (otv_Coverage_get_last): Guard `count'. Created with: gclient setdep -r src/third_party/freetype/src@04ebb2a000ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I7a43630e18ccc37336e3c54b294a424e508d4c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697360}
-
Anubha Mathur authored
Gif: https://imgur.com/a/eP7Irdr Bug: 963183 Change-Id: I8dd5a9a5abc4d1404385b924cbfe110e4bb62132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804522Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697359}
-
Matt Menke authored
The test depends on the specific format of the dictionary HttpServerPropertiesManager creates. This CL keeps that behavior, but reduces how tightly the expectations are coupled with the exact format used by HttpServerPropertiesManager. Bug: 1004604 Change-Id: I212976386dbd3cdecb8d0b892ecb993562386829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809498Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697358}
-
Allen Bauer authored
Bug: 651682 Bug: 651681 Change-Id: I571a9b503e066e58f6daa9713f85a7458c0f70e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808803 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#697357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d73796b0f7d..5b12fdd2a7ac git log 0d73796b0f7d..5b12fdd2a7ac --date=short --no-merges --format='%ad %ae %s' 2019-09-17 hjd@google.com Merge "Update perfetto_config.descriptor.h" 2019-09-17 taylori@google.com Merge "perfetto-ui: Add beta search tooltip" Created with: gclient setdep -r src/third_party/perfetto@5b12fdd2a7ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id468636fbb5d49fed2cac6f35c3f5ea803a67a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809665Reviewed-by:
-
Takuto Ikuta authored
This reverts commit b3373919. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81914 Original change's description: > Convert ui/ARIAUtils.js to an ES module > > ES modules allow files to explicitly import and export symbols [1]. > This patch migrates ARIAUtils.js to an ES module, while maintaining > backwards compatibility with existing usages of `window.UI.ARIAUtils`. > > The build system is updated to copy these modules verbatim, as it no > longer require pre-processing to be loaded. The `module.json` no longer > includes this file as a script, to make sure it is not double-bundled > into `shell.js`. Instead, it is added to the new field `modules`, which > contains all modules. By doing so, it becomes clear which files are > converted to modules already and which require the legacy references > to the global scope. > > This module and future modules will be imported from `root.js`, which is > added to all existing HTML application files. > > Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing > > [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import > > TBR=jochen@chromium.org > > Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> > Cr-Commit-Position: refs/heads/master@{#697238} TBR=yangguo@chromium.org,jochen@chromium.org,aerotwist@chromium.org,mathias@chromium.org,tvanderlippe@google.com Change-Id: I550f1082755ef4b9e7bc778e3afdaef324dae03a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808954Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#697355}
-
James Forshaw authored
This CL modifies the DACL for the primary LowBox token to allow the initial privileged impersonation token to open a handle to it. This is necessary as the Windows kernel implements a feature which prevents Low IL tokens accessing any securable resource which has a package SID as part of the DACL. Without the change opening the primary process token fails during warmup which causes numerous unexpected behaviors such as the process crashing. Bug: 1000447 Change-Id: I76ac6eecae08d8de6f2130e5841b50a17b3739e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783728Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#697354}
-
Natalie Chouinard authored
HyperlinkPreference's imitateWebLink styleable attribute is not currently used. Change-Id: I03acc2edbc9c0f42ae4471148918711a99f7263d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807436Reviewed-by:
-
Aran Gilman authored
Change-Id: I67a6aed61625f45968dd717e25e563ce86aa22c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809504 Auto-Submit: Aran Gilman <gilmanmh@google.com> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697352}
-
Haiyang Pan authored
* CI builder: fuchsia-x64-dbg * CQ builder (Experimental): fuchsia-compile-x64-dbg Related CL: crrev.com/c/1796483 Bug: 1001643 Change-Id: If7da449efc2e4426f0c57ab7eb3b9e1796efa3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796885 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#697351}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/142664633e0b..b18323b096a7 git log 142664633e0b..b18323b096a7 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 tbosch@google.com Allow wrapped programs to know their original name Created with: gclient setdep -r src/third_party/chromite@b18323b096a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7be3852b994b6da2ddd2cc882bb544063a16b7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809666Reviewed-by:
-
Pavol Marko authored
Remove a stale TODO. The Chrome OS sign-in Profile is now always using the built-in certificate verifier, so there's no explitily enabled it for certain policy values. Bug: 972044 Test: none Change-Id: Id4d7a2233557d4adb131199bdeb548ad43a02f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808862Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697349}
-
Martin Robinson authored
Images in CSS content are not anonymous blocks, but they are anonymous. This means that LayoutObject::GetNode returns null for them. We should handle this case. Bug: 1003047 Change-Id: I091c8890c67e85b1326d67e7f046ce5ac94d437e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804482 Auto-Submit: Martin Robinson <mrobinson@igalia.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697348}
-
James Cook authored
There are settings promo banners that contain text that isn't inside a <settings-section> element (e.g. the Chrome OS settings "If a setting doesn't show on this page" banner). If you type search text that matches this string you'll hit a JS assertion because a "parent" is null while walking up the DOM tree. The loop in question checks for null parent, but there's an if() condition that checks parent.nodeName that needs to test for null as well. Bug: 1003970 Test: added to browser_tests Change-Id: I3c5a7367464502461ab3a158c102f4ad246d9f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807777Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#697347}
-
Sigurdur Asgeirsson authored
To test the feature and parameters, invoke chrome with parameters like: --enable-features="MojoRecordUnreadMessageCount<Study" \ --force-fieldtrials=Study/Group1 \ --force-fieldtrial-params=Study.Group1:SampleRate/1/QuotaValue/10 Bug: 1003391 Change-Id: I395047c17fc54afb4caefca5d0788f541a1ddcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779023 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#697346}
-
Xianzhu Wang authored
After http://crrev.com/c/1799701, mask layers are managed as normal layers in LayerTreeHost and LayerTreeImpl, so when we want to iterate all layers we can just iterate LayerTreeHost or LayerTreeImpl without needing to deal with mask layers specially. Bug: 994361 Change-Id: Id8d16fd68829aa18f45a774da516ce6da7e9eb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802377 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697345}
-
Adam Ettenberger authored
This change is an optimizaiton for UIAs GetEnclosingElement. The cost was in calling |LowestCommonAncestor| because it would compute multiple parent AXPositions until reaching the common anchor. Creating a parent Text position is expensive because it calls |MaxTextOffset|. GetEnclosingElement didn't need an AXPosition so to reduce that cost a new method |LowestCommonAnchor| has been added which returns the AXNodeType* that we can use to find the relevant AXPlatformNodeDelegate to do our work on. |LowestCommonAnchor| may also be used to optimize other similar APIs which don't necessarily need an AXPosition object. In order to derive the AXTreeID which is necessary to find the correct AXPlatformNodeDelegate, AXNode::OwnerTree now exposes its AXTreeID. This way we can know what the AXTreeID is for an AXNode of an AXNodePosition anchor. This is already easily accessible from the other position type BrowserAccessibilityPosition, since BrowserAccessibility has access to the relevant AXTreeData. Now anchors of both position types can know what the relevant AXTreeID is for creating delegates! I measured the perf difference with std::chrono::high_resolution_clock on an unoptimized debug build. With a document that contains 2 columns of 100 divs each, and a single leaf text child in each column, and a text range that spans between the two columns. Without Patch : 439.006ms With Patch : 0.1371ms Bug: 928948 Change-Id: Ic9648ff34c7c7030c299c8484fb188a873e3af92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790066 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697344}
-
Henrique Nakashima authored
This reverts commit c1d1e24a. Reason for revert: Breaks internal bots, crbug.com/1004913 Original change's description: > Move IntentUtils to chrome/browser/util. > > Bug: 995916 > Change-Id: I0a0a14719546f8468d4a25482b3ea162def9508e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774268 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697276} TBR=dtrainor@chromium.org,twellington@chromium.org,hnakashima@chromium.org Change-Id: Id6e60e9f6e1fd48d57e39bed52f407cd6014cb07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809648Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697343}
-
Theresa Wellington authored
Move classes from chrome/android/.../widget: - animation.* - displaystyle.* - TintedDrawable BUG=951455 Change-Id: I069efffffff38bf26b16cba4eee3b461aca0cb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804221 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697342}
-
James Cook authored
Many of the tests that load the entire settings page have flaky timeouts on the debug builders. We suspect this is because the main settings page takes a long time to load in debug. Since these tests are primarily exercising JavaScript code, our team decided to just run them in release. This provides most of the value, and means that sheriffs won't accidentally disable the test globally for debug-only flake (which has happened before). Bug: 1003483 Change-Id: Ia8577faa9b2558b2f467ac3ee5cf5cd701fc7e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808183 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#697341}
-
Yann Dago authored
The traffic_annotation_auditor treats the lack of output from the traffic_annotation_extractor as nothing to check. This means some CLs skip the CQ check, if they only remove annotations. It should still check the annotations for removed annotations if the extractor successfully ran. Change-Id: I47536e1b706efd8f391448a599b2e1d1c87a3400 Bug: 1001108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804330Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#697340}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/809198edfff4..9fa8ef1f4f9a git log 809198edfff4..9fa8ef1f4f9a --date=short --no-merges --format='%ad %ae %s' 2019-09-17 mbonadei@webrtc.org absl::make_unique presubmit check. 2019-09-17 mbonadei@webrtc.org Use std::make_unique instead of absl::make_unique. Created with: gclient setdep -r src/third_party/webrtc@9fa8ef1f4f9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5d67e2749bfb92805ef1b091d6a3a6db81c6bb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809663Reviewed-by:
-
Aaron Leventhal authored
We are missing this property. It may help VoiceOver not repeat labels while the user navigates, but this is just a guess. We had the code to support the property, but weren't listing at as supported for anything. Bug: None Change-Id: Iea00480e581e62d8127a24c18da4d4a6d3b7b15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774329 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
minch authored
Bug: 1002733 Change-Id: Ia298bce1dd101fbb96af3d066ac4a04f05789013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797462Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#697337}
-
Andrew Xu authored
Fix another two tests which are broken with the flag enabled: (1) ShelfTooltipManagerTest.HideForEvents: The event generator fails to reset the mouse button. (2) ShelfWidgetTest.LauncherInitiallySized: It assumes that the shelf widget's bounds are identical with the bounds of the shelf view. However, it is incorrect with the scrollable shelf enabled. Bug: 1002576 Change-Id: Ia573eef66a25b73e45b9b69e0e435320b2f07eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808459 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697336}
-
chrome://flagsAlexander Timin authored
Add chrome://flags entry to allow pages controlled by a Service Worker to be put into back-forward. This support is highly experimental, so please use with care. In order to make this possible, BackForwardCacheWithServiceWorker feature is replaced with a parameter on BackForwardCache parameter. R=arthursonzogni@chromium.org Change-Id: I741aefed9a54f87a4c6ece2003be0e8664ddd470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807328 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697335}
-
Filip Gorski authored
This reverts commit 3088e438. Reason for revert: Breaks android-archive-rel builder https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4749 Original change's description: > Move chrome/lib/image_fetcher to chrome/browser. > > Clank HOA Lite specifies features should be in chrome/browser rather > than chrome/lib. > > Bug: 995916 > Change-Id: Ie2b91869a46d5fad8ea6daa92f479cacfeedb53d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801803 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697310} TBR=yfriedman@chromium.org,wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,wylieb@chromium.org,hnakashima@chromium.org Change-Id: Ie6064045085362a7accf7c9d18359467873617bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808487Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#697334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87be585106e6..95dfac5bc324 Created with: gclient setdep -r src-internal@95dfac5bc324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifd3a42a8d51ddaabbe3005e620b7730edeb26813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808375Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697333}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Id6b2e31c1176244a50e718d0fd283ca2fe9403e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809400 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697332}
-
John Budorick authored
Bug: 922145 Change-Id: If75f7fd57e5331d63c7ced74aa014934bb21d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796447 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697331}
-
Tomas Popela authored
It's because GCC has problems when mixing the alignas() together with __attribute__() (that is used to export the symbols). The best solution is to use ALIGNAS() macro from //base/compiler_specific.h together with alignof() to have the equal functionality that compiles on GCC as well as on clang. Bug: 819294 Change-Id: Ieb169592a2965f17a18bfc88d28418eb723a4e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806735 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697330}
-
Bill Budge authored
- Implements the move constructor and assignment operator to zero bytes_size_ and storage_type_. Otherwise clients checking for empty BigBuffers by examining the size() may try to use an empty BigBuffer (where data() == nullptr). Bug: chromium:992991 Change-Id: I23c8d8db35de76762606ecd488cbebfe1ac42ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803136Reviewed-by:
-
Peter Kotwicz authored
BUG=None Change-Id: I7348eb18a4c93b026222757e9a85503c538378d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808789Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697328}
-
danakj authored
The CreateRenderView IPC comes with a set of VisualProperties for the local main frame, and they should be set on the RenderWidget similar to how we do so for the CreateFrame IPC so that blink reads valid things off the RenderWidget while it exists and is not undead. However when the RenderWidget is undead, there is no local frame, so stop calling OnSynchronizeVisualProperties. The VisualProperties will be passed along in the future with CreateFrame in that case and set when the RenderWidget is reanimated. We must not call UpdateWebViewWithDeviceScaleFactor() after calling OnSynchronizeVisualProperties() as it dirties the compositor state, and Android WebView expects the compositor state to be clean when it sends an IPC to set the base background colour. The OnSynchronizeVisualProperties() does a Resize of the WebView which runs the document lifecycle and cleans the compositor state. So this also removes the call to that from RenderViewImpl, and places it with the OnSynchronizeVisualProperties call in RenderFrameImpl. The true purpose of UpdateWebViewWithDeviceScaleFactor() is to propagate the page zoom factor down to a new LocalFrame, and so it only needs to be called when the main frame is local as well. R=erikchen@chromium.org Change-Id: Idd06d7af65ebd01ceec03ec9591445eb7805f413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805873 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697327}
-
manuk authored
Bug: 1004857 Change-Id: I79c0507702ce816ea472943b72418273a468de62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808806 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#697326}
-
Chris Palmer authored
Use terminology consistent with the literature. Bug: None Change-Id: I3bcb1a747f23ad9418695926107b57eaa097ad41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808303Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697325}
-
Morten Stenshorne authored
NGPhysicalLineBoxFragment::ScrollableOverflow() compared the computed style passed as container_style to the computed style of each child, and it would calculate the child's relative offset only if they differed. All element nodes have their own computed style, so this only mattered for text nodes. However, if the container was an anonymous block, they'd always differ, since the computed style of a text node is the same as that of the parent DOM node. This is an implementation detail; we save some memory by letting text nodes share computed style objects with their containing DOM node. But that also means that extra care is required when working with ComputedStyle objects associated with text nodes: basically, treat all non-inherited-by-default properties (such as 'position', 'top' and 'left') as if they were set to their initial value. Bug: 1002485 Change-Id: If77d79e45c2aa55ac30dc239c738e2a40f8326f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807813Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#697324}
-
