- 27 Aug, 2018 40 commits
- 
- 
Kyle Milka authoredCheck that the embeddedsearch APIs for custom background correctly update the ThemeBackgroundInfo when called. Bug: 857256 Change-Id: I7c71ddbbdc30fa9fbcf4a2afc8387affcc39693c Reviewed-on: https://chromium-review.googlesource.com/1189082Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#586394} 
- 
Brian Salomon authoredBug: skia:8155 Change-Id: I83c2c31a0e069598d3584d4059158d70113f63d6 Reviewed-on: https://chromium-review.googlesource.com/1171022Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#586393} 
- 
Christopher Cameron authoredAdd methods mouse capture methods to the BridgedNativeWidgetPublic interface that BridgedNativeWidget implements. Have BridgedNativeWidget pass the mouse capture status to BridgedNativeWidgetHostImpl, which the NativeWidgetMac will access. Add NativeWidgetMac::GetBridgeHostImplForNativeWindow method for unittests, and merge the implementations of GetBridgeForNativeWindow, GetBridgeHostImplForNativeWindow, and GetNativeWidgetForNativeWindow. Bug: 859152 Change-Id: I25af661ad487b4f5a89bb02b1c655fb0ab27b8fb Reviewed-on: https://chromium-review.googlesource.com/1186161Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#586392} 
- 
Paul Meyer authoredThis protocol will be use to implement the WebDriver Extension Command specced here: https://w3c.github.io/reporting/#generate-test-report-command Change-Id: Idfe7fc40bc85589b1fc6e79f2d603ed01cf78840 Reviewed-on: https://chromium-review.googlesource.com/1188754Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#586391} 
- 
Etienne Pierre-doray authoredThis CL uses ScopedBlockingCall to mark blocking calls in /chromecast. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=servolk@chromium.org Bug: 874080 Change-Id: I57c774dacb924224a77f31a9644242a6931d52cf Reviewed-on: https://chromium-review.googlesource.com/1191235Reviewed-by:Sergey Volk <servolk@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586390} 
- 
Robert Ogden authoredGot one new crash over the weekend and the if (!web_contents()) check that I added was the line that crashed. Seems to me like |this| is a nullptr. Bug: 876835 Change-Id: I8ee5f1ebf64a864a9d6fb4dc6e3018a6ef8eca83 Reviewed-on: https://chromium-review.googlesource.com/1190844Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#586389} 
- 
JungHoon Lee authoredThis patch simplifies the code by using base::Erase() and base::EraseIf() instead of erase(std::remove) and erase(std::remove_if) Bug: 875665 Change-Id: I92d02ad090029fb6884b53f05d2de7715a72314a Reviewed-on: https://chromium-review.googlesource.com/1189583Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586388} 
- 
Etienne Pierre-doray authoredThis CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/chromeos/printing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=skau@chromium.org Bug: 874080 Change-Id: Ic4c282e65f8d9aa3b9c6d95d8c89c0311b8b712a Reviewed-on: https://chromium-review.googlesource.com/1191225Reviewed-by:Sean Kau <skau@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586387} 
- 
Theresa authoredBUG=877916 Change-Id: I6f3d4131fa3205170d2234c892471a4bbaf2323e Reviewed-on: https://chromium-review.googlesource.com/1191125Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586386} 
- 
Vladislav Kuzkokov authoredThis just adds new policy templates without implementation. Bug: 853724 Change-Id: Id2e0e9d0a3cbf353893fe96821e646dd0f5795a5 Reviewed-on: https://chromium-review.googlesource.com/1155120 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586385} 
- 
Pedro Amaral authoredBug: 877437 Change-Id: Id444baf870a3b9b4942f57bedb0d3b275e29ba81 Reviewed-on: https://chromium-review.googlesource.com/1191133Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#586384} 
- 
Martin Kreichgauer authoredBug: 847985 Change-Id: I4c6c004db4f5180200c421b8bc7b6c530a7d653f Reviewed-on: https://chromium-review.googlesource.com/1189105Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#586383} 
- 
Simeon Anfinrud authoredAlso clarify the role of the object returned from subscribe() by aliasing it as "Subscription". Now a reader of the code can look at the code and say "An Observable can subscribe an Observer and return a Subscription, which can be closed", just by looking at the type signatures. This nomenclature is used in other reactive frameworks like ReactiveX. "Subscription" should be much more understandable than "watch()- scope", which was how the documentation used to refer to it. Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Test: build downstream counterpart change Merge-With: eureka-internal/195817 Change-Id: I9c35bfd7fc6524fa5eb7b1c2b5eecf36813310f2 Reviewed-on: https://chromium-review.googlesource.com/1187736Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586382} 
- 
Robert Ogden authoredThis removes the previews piece of verbose status triggering from the weird security checks that offline uses. Since the preview badge is shown under all cases expect when a bad SSL page is being shown, make the code reflect that. Bug: 871839 Change-Id: If14d110f23a90b36906df7d846c5c1a8ff957baa Reviewed-on: https://chromium-review.googlesource.com/1191027 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586381} 
- 
Lei Zhang authoredChange-Id: I45224f299e5ac7fcff88241c7a5e0689603717cf Reviewed-on: https://chromium-review.googlesource.com/1189545Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586380} 
- 
Charlie Harrison authoredBug: 873316 Change-Id: I2d034ad8e7e272b487741eaa40f5318185caff6c Reviewed-on: https://chromium-review.googlesource.com/1190664 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#586379} 
- 
Simeon Anfinrud authoredThe special properties of ObserverList were not needed because of how Controller uses a Sequencer to avoid concurrent modification. This also avoids heap allocation of iterators and the use of the O(n) memory Itertools.reverse() when closing scopes. Bug: None Test: cast_base_junit_tests Change-Id: I91ef516caf07de8b9a899c17b015f2e2838fee35 Reviewed-on: https://chromium-review.googlesource.com/1191087Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586378} 
- 
Yao Xiao authoredBug: 864194 Change-Id: I84311118bdfc6921875741fa6ba31ba38bcf1fb6 Reviewed-on: https://chromium-review.googlesource.com/1185217Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#586377} 
- 
Maks Orlovich authoredCq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I305000589be2e48356c1c7168269edd83cf9a7ec Reviewed-on: https://chromium-review.googlesource.com/1191284Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586376} 
- 
Victor Costan authoredOn 32-bit Windows builds where DCHECK is enabled, ComInitCheckHook hot-patches CoCreateInstance() to DCHECK that it is called in appropriate circumstances. The hot-patching method can only be used once (details in base/win/com_init_check_hook.cc), and Chrome's usage may conflict with other drivers that may want to hot-patch the same method (example in https://crbug.com/737090). This CL adds answers to the following questions that may arise when investigating hot-patch failures. 1) Is hot-patching failing due to a bug where the HookManager singleton is instantiated twice? This can happen if base is linked in twice. This question is answered by printing the bytes that would be written to the hot-patch area, so they can be compared with the current values. 2) Is hot-patching failing due to a previous failure to revert the hot-patch? This question is answered by DCHECKing that reverting the hot-patch never fails. (The code previously just assumed that.) Bug: 877868 Change-Id: I94f81b3816417447d31fc700c6b81d8325222d1a Reviewed-on: https://chromium-review.googlesource.com/1189143 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#586375} 
- 
Doug Arnett authoredAdds about:flags support for ResourceLoadingHints and fixes an issue for determining the initial PreviewsState (where we need to "allow" ResourceLoadingHints preview even if no hints loaded for it yet (will be checked at commit time). Bug: 871795 Change-Id: I52529a29dabf6e5be23c49bf7f597783418d053b Reviewed-on: https://chromium-review.googlesource.com/1187574 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#586374} 
- 
Sarah Hu authoredPatchSet 1 is originally reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/1142384 On top of the original CL, this updates the following: 1. Notify oobe dialog state based on the visibility of the oobe dialog. 2. Send additional data SetShowGuestButtonForGaiaScreen to login shelf. Bug: 857514, 869811 Change-Id: Ic8baae2e31d2818f356e7fc79f172e4091053fec Reviewed-on: https://chromium-review.googlesource.com/1168105 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#586373} 
- 
angle-chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/89664843c656..22f7aafb44b7 git log 89664843c656..22f7aafb44b7 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 bryan.bernhart@intel.com Add webgl checks in GetActiveUniformsiv. 2018-08-27 syoussefi@google.com Fix dEQP_GLES3.functional.negative_api.shader.program_binary Created with: gclient setdep -r src/third_party/angle@22f7aafb44b7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I34db6d41e53ea531bc1045dda512de054b4c163f Reviewed-on: https://chromium-review.googlesource.com/1191144Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586372} 
- 
Victor Costan authoredChange-Id: I0cf147382da7458f9e63ddfbdec797880a78724e Reviewed-on: https://chromium-review.googlesource.com/1188827Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586371} 
- 
Lei Zhang authoredUse base::NoDestructor, range-based for loops, and initialize members in headers. Also mark some constants as constexpr. Change-Id: I7cfef2e80f8fc285af560f48cfbcaf264b03513e Reviewed-on: https://chromium-review.googlesource.com/1189542Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586370} 
- 
Alexei Filippov authoredMake Poisson sampler a separate class that is responsible for listening for allocation and doing the sampling with given sampling interval. SamplingHeapProfiler is now an observer of PoissonAllocationObserver. Once a sample added it record the native stack and stores the sample in the map. The list of recorded samples can then be retrieved by clients. TBR=ajwong@chromium.org BUG=803276 Change-Id: I1e568b9839d9cc0099704ba1b9f047c14a46a0ee Reviewed-on: https://chromium-review.googlesource.com/1189713Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#586369} 
- 
iOS Autoroller authoredTBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic7c8ce07306d1aec6915f5390a6c6107a14efa58 Reviewed-on: https://chromium-review.googlesource.com/1191243 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586368} 
- 
spirv-chromium-autoroll authoredhttps://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d94a2077d68c..06b42949b620 git log d94a2077d68c..06b42949b620 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 31666470+s-perron@users.noreply.github.com Validate uses of OpTypeFunction. (#1867) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@06b42949b620 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd0289bbb82e98dfc9200f9ebc89b4e43ec90c90 Reviewed-on: https://chromium-review.googlesource.com/1191142Reviewed-by: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586367} 
- 
Rune Lillesveen authoredWe no longer (re-)attach the layout tree from style recalc. Change-Id: Ia944649b6e12345c23ecbd7e6ea91d8d6aaba94c Reviewed-on: https://chromium-review.googlesource.com/1190205Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586366} 
- 
Alex Moshchuk authoredChange-Id: I3f664cb970a58b34e91075cf29928390878e182d Reviewed-on: https://chromium-review.googlesource.com/1191146Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#586365} 
- 
Bo Liu authoredBug: 855390 Change-Id: Icf7785b87dd04b9b2a9dd641fb7eaea6e401f611 Reviewed-on: https://chromium-review.googlesource.com/1189029Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586364} 
- 
Nicolas Ouellet-payeur authored'safe_browsing_g4_update': s/g4/v4/ Bug: 876856 Change-Id: Iefda4121e331a5005d9372e5bfcc493646e5e47d Reviewed-on: https://chromium-review.googlesource.com/1187322 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#586363} 
- 
Eric Orth authoredConvert the //net/dns:public source_set into :host_resolver and move all public headers to source. Access to these previously-public headers will now only be allowed for BUILD.gn rules listed in the friend list. Added friend entries with explanation comments for all remaining usage. Some with TODOs to remove, eg because they'll be migrated to network service. Confirmed that there are no other remaining usage in code where private headers are or are not enforced (checking unenforced by searching for "net/dns" in the error output). Removed a couple includes that were no longer needed. TBR=jochen@chromium.org Bug: 846454 Change-Id: I7bb633088689dc896f9fc27e1dec87ae699410db Reviewed-on: https://chromium-review.googlesource.com/1183981 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586362} 
- 
Antonio Gomes authoredThis is a follow up of CL https://crrev.com/c/1136518 where, CrDownloader/UrlFetcherDownloader migrated from URLFetcher to SimpleURLLoader. As part of the migration, it was verified that CrxDownloader::Result had struct members only used in unit tests: |downloaded_bytes| and |total_bytes|. Additionally, the CrxDownloader::ProgressCallback did not use its |result| parameter. This CL removes the struct members from CrxDownloader::Result as well as their use (mocked up anyways) in unittests, and removes the unused |result| parameter from CrxDownloader::ProgressCallback. BUG=844972, 871211 Change-Id: I5b36c63784ff2632f71c1e5a0cd44b6e0c7c7f37 Reviewed-on: https://chromium-review.googlesource.com/1190324 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586361} 
- 
Victor Costan authoredAppCacheResponseIO is an abstract (with pure virtual methods) base class for classes that also use WeakPtrFactories. Some method in the base class currently use the WeakPtrFactory embedded in the base class to vend WeakPtrs, which will point to instances of the derived classes. These pointers will be invalidated when the base class' WeakPtrFactory is destroyed. So, there is a time window when the weak pointers are valid, but the members in derived classes are being destroyed. To avoid reasoning about such complexities, this CL removes the WeakPtrFactory in the base class. Instead, base class methods use a virtual method to get weak pointers from the derived classes' factories. Change-Id: I343a0e1159d839b0f71fb09518704ce560b2c5ad Reviewed-on: https://chromium-review.googlesource.com/1188825Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586360} 
- 
Allen Bauer authoredThe previous patch attempting to fix this, https://crrev.com/c/1188434, didn't blend in the right direction. It got the background color calculation correct, but the title color calculation wasn't right. This change just uses GetColorWithMinimumContrast directly so that the text (and the close button icon) has sufficient contrast on a selected inactive tab. Bug: 876794 Change-Id: I8ee0a8f2a38aac60c14d104fbf75c3ef85304720 Reviewed-on: https://chromium-review.googlesource.com/1191189Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#586359} 
- 
Etienne Bergeron authoredNo code change. R=ssid@chromium.org Change-Id: I7eaef6cab924fb60dd7b242d333276dce83522aa Reviewed-on: https://chromium-review.googlesource.com/1191327Reviewed-by: Siddhartha S <ssid@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#586358} 
- 
Weilun Shi authoredChange Font Family to Segoe UI for custom link when using Windows and make it bolder for fallback icon letter. Before: https://screenshot.googleplex.com/pRPVmEC3yc8.png After: https://screenshot.googleplex.com/m16uEv78QBp.png Bug: 867778 Change-Id: I1f16dbf044cad7504617868f131b7517985cd2c2 Reviewed-on: https://chromium-review.googlesource.com/1178469 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586357} 
- 
Manu Cornet authoredThis changes the color, alpha and size of indicators according to the spec (see linked bug for the spec). Bug: 877351 Change-Id: I6237ab1f0d4727907b344147a0cf816319192b26 Reviewed-on: https://chromium-review.googlesource.com/1189196 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586356} 
- 
Eunseok Oh authoredThis patch replaces the erase(std::remove()) used in the media folder with base::Erase(). Bug: 875665 Change-Id: Id832871a1fbfcb657e4160f57ff206f93950e7ab Reviewed-on: https://chromium-review.googlesource.com/1180953Reviewed-by: Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586355} 
 
-