GitLab

This reverts commit b24859d8.

Reason for revert: fixing the test and reland

Original change's description:
> Revert "Make touchevent timestamp update on every non Stationary touch points"
> 
> This reverts commit 2131ec3a.
> 
> Reason for revert: Seems to have broken WebKit Linux Leak build.
> 
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2981
> 
> Original change's description:
> > Make touchevent timestamp update on every non Stationary touch points
> > 
> > Touch event's timestamp is set from the |first_touch_pointer_event|'s
> > timestamp. But in the case that this touch point is not changing but
> > the others changed, this timestamp is not the latest pointerevent's
> > timestamp.
> > This CL changes it to use the the latest timestamp of the pointerevents
> > in |touch_attribute_map|.
> > 
> > Bug: 973545
> > Change-Id: I08be3f58e886f40eca17d515b36ec3a6424a38ef
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705051
> > Reviewed-by: David Bokan <bokan@chromium.org>
> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> > Commit-Queue: Ella Ge <eirage@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#685612}
> 
> TBR=bokan@chromium.org,nzolghadr@chromium.org,eirage@chromium.org
> 
> Change-Id: Id5a4657d566006597c9b6db06e3736240899e8ef
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 973545
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746789
> Reviewed-by: Scott Little <sclittle@chromium.org>
> Commit-Queue: Scott Little <sclittle@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685638}

TBR=bokan@chromium.org,sclittle@chromium.org,nzolghadr@chromium.org,eirage@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 973545
Change-Id: Ia6ba0e493f8f0c495c462c2dbe5cdf4cdfa50171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747736Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686153}

This reverts commit 677de3b2.

Reason for revert: Investigation done.

Original change's description:
> Revert "viz: Defer BeginFrame throttling everywhere."
> 
> This reverts commit 86f28deb.
> 
> Reason for revert: Temporary revert to confirm this is responsible for crbug.com/982863
> 
> Original change's description:
> > viz: Defer BeginFrame throttling everywhere.
> > 
> > The initial change [1] restricted the delay in BeginFrame throttling to
> > SurfaceControl to allow the change to be merged to M76. But this
> > throttling policy is better in general so enable it everywhere.
> > 
> > [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1675464
> > R=​ericrk@chromium.org
> > 
> > Bug: 973703
> > Change-Id: Ia26c23786b1e827fa22126c06a474fca65d20280
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684216
> > Auto-Submit: Khushal <khushalsagar@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Reviewed-by: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#673856}
> 
> TBR=khushalsagar@chromium.org,ericrk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 973703,982863
> Change-Id: I3a042f8f2bdc721c0c5a20472156679d373a7bbb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740731
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684647}

TBR=khushalsagar@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 973703, 982863, 991855
Change-Id: I3d16236e4d7199fe2080200d897dd6c1bfb4f24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748082Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686152}

This CL builds the missing integration between the C++ code (starting
from the handler of the PIN requests made by extensions) and the
JavaScript code on the SAML sign-in page:

* dynamically enabling/disabling this UI when the SAML sign-in
  begins/ends;
* sending the PIN request parameters from C++ to JS;
* replying with the entered PIN from JS to C++.

The proper error displaying and other UI improvements will be done in
follow-up CLs.

Bug: 964069
Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, check that the PIN dialog appears on top of the SAML page, enter the smart card PIN, check that the login completes
Change-Id: I95c2d5e5110a967ca6b7d8f957bbc8422f62d758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742233Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686151}

Bug: 976901
Change-Id: I0751d935e2aa0307bd354b888e78408810d1f195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746601
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686150}

Accessibility actions like scroll and click are not forwarded to plugin.
In this CL we create a pipeline between mimehandler and plugin process
to pass accessibility actions. This will enable plugins to receive
and handle actions. This CL focuses on enabling just kScrollToMakeVisible
for PDF. This pipeline can be extended to handle other Accessibility
actions.

Note: RenderAccessibilityImpl::ScrollPlugin method is removed because of
three reasons
- It was not used by anyone at this moment.
- It does not give correct scroll behavior because it is only able to
  scroll an embed tag in view port. However, we require scrolling
  within the Plugin content.
- The action handling pipeline being introduced here is different from
  the HTML path ScrollPlugin uses to scroll.

Bug: 769940
Change-Id: I6f04467e2798c4a60ae08329b271480134427f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692574
Commit-Queue: Virender Singh <virens@microsoft.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#686149}

Add bug numbers in TODO comments, for easier tracking.

Bug: 953958
Change-Id: Ia6a40836aa06339af0651851fea7c993ab194d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747803
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686148}

On entering overview, windows that are stacked above the snapped window
need to stacked underneath, otherwise when we scroll it will scroll
over it.

Also changed the aspect ratio maintaining codes to account for the
overview margin and overview header.

Test: manual, added test
Bug: 981188
Change-Id: I99c368d5ab50931a1eabe7bc70bf8a5b738c2bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747027
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686147}

We walk up the render frame tree via RenderFrameHostImpl::GetParent()
and then use GetLastCommittedOrigin() of the frame tree's root as
top-frame origin for the network isolation key.  This change is to
address a potential race condition where the root frame tree node may
have been now associated with a different document.

Bug: 986167
Change-Id: I9196f70939f82c6c9ac62d5828329688db97bac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741644
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686146}

This reverts commit 116a3030.

Reason for revert: Failures here: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/28076

Original change's description:
> Adding metric to track the source of empty automatic setup events
> 
> In order to track down the root cause of https://crbug.com/964120 this
> metric is being added. In this case we're concerned with printers
> somehow being configured with a PPD while not having any make and model
> information filled in. If an automatic setup meets this "empty"
> criteria, then we track from which of the following 4 possible sources
> it may have come from:
> 
> 1. Print Preview
> 2. Printer Settings
> 3. Arc Print Service
> 4. Automatic USB Printer Configurer
> 
> BUG=chromium:964120
> TEST=None
> 
> Change-Id: If49d58663f254b726ede57754f8dbc4a17793de4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732029
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Commit-Queue: David Valleau <valleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686078}

TBR=stevenjb@chromium.org,bcwhite@chromium.org,skau@chromium.org,valleau@chromium.org

Change-Id: I397d417239094941fc006c6485ad3b6b1804908b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:964120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749729Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686145}

The only client is Content's Download Manager, so this CL has Download
Manager explicitly start a service process or an in-process service
instance as needed, rather than using Service Manager via a Connector.

Download Manager still uses a Connector to connect to the Device
Service, but that dependency will be eliminated when Device Service
moves off of Service Manager too.

Bug: 977637
Change-Id: I583fc3139e371fdda31462794a58cfeb0f40c88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742396
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686144}

Adds sczs@ as secondary owner as well.

Bug: 976901
Change-Id: Idf814b98addffd4b543cd9166d24faf2eae06a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748078Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686143}

Now that it handles desks related gestures as well.

Test: ash_unittests
Bug: 988173
Change-Id: Id9a07ccf8633c4a35d253c6f3a88b08c69c2a53d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747086
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686142}

This test flakes under e.g. the Fuchsia x64 bot, seemingly due to a
timer unexpectedly firing, suggesting that the test is inherently racey.

TBR=tommycli

Bug: 991035
Change-Id: I99bb125c63e985339b4f210784c771fa5fadc438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749762Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686141}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/192e8a67cfe4..d6186f993681

git log 192e8a67cfe4..d6186f993681 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 ehmaldonado@chromium.org depot_tools: Run Python scripts using vpython (Part 1)

Created with:
  gclient setdep -r src/third_party/depot_tools@d6186f993681

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: I74bbab021b9556879b85c3ff36f57058beaf3129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749002Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686140}

As a result of increasing thread priority of gpu process for performance tests on mac
(https://chromium-review.googlesource.com/c/chromium/src/+/1637522), the upper values need to be updated, to match the new values.

Values used in this patch are the 99 percentile of the last 200 perf results of runs of GPU fyi bots.
https://docs.google.com/spreadsheets/d/1AfP6a0LZ3DHF26LAA6mFAdc0okqI7HFb_-j8Nt_5b-g/edit?usp=sharing

Bug: chromium:992550
Change-Id: I644375e32e46138fe4f932566dc77074c119ffc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746949Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686139}

I misconfigured this previously to trigger on commit *and* nightly.
This removes the commit trigger.

Bug: 961025,922145
Change-Id: I52ebf58a584087524551600acfa1525d74d531c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747395Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686138}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/c6c3c1b498..4ef574064e
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/c6c3c1b498..4ef574064e

Bug: None
Change-Id: Idfa04070603a5a01718a937d1cdde15c0e2b7eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748889Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686137}

https://android.googlesource.com/platform/external/perfetto.git/+log/703b48c36369..f0fc887f5682

git log 703b48c36369..f0fc887f5682 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 lalitm@google.com Merge "ci: experimental perf testing framework"

Created with:
  gclient setdep -r src/third_party/perfetto@f0fc887f5682

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I2d8fd2b4ecb704d3a53b06b38346cafbf5e1acf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747970Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686136}

The AppCompat bug that made this workaround necessary (see original bug:
https://crbug.com/474695) was fixed >4 years. Cleaning up now that it's
no longer applicable.

Tested UI on KitKat, Lollipop and Pie.

Change-Id: I6fb6b73a2c96d8d4fab0ef28710503011e86e77a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747030Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686135}

Using wpt-import in Chromium 552c8814.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"
7486899f "Fix bug where composite: replace did not replace previous effects"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ifc61c9a443bdf6547b3f9522c2a03c2b88141b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749524Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686134}

The connection request code lived in the IndexedDBDatabase, which
already has a lot of it's own code and caused that class to be huge
and confusing.

This patch is the first step towards refactoring that part of the
code out into its own class. It is a purely non-functional change
which moves the code into a new class
'IndexedDBConnectionCoordinator' and simply delegates calls from
IndexedDBDatabase to this new class.

R=cmp@chromium.org

R: cmp@chromium.org
Bug: 992474
Change-Id: Ia3d394e097fe245fc6ecf0b57ca35986faa45670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745840
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686133}

Added ARMENIAN SMALL LETTER SHA (U+0577), ARMENIAN SMALL LETTER CHEH (U+0573), BOPOMOFO LETTER J (U+3110) to confusable mapping

Bug: 896453
Change-Id: I45b0b2dff9eeb0faeff5f8a10ce4829440124ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740614
Commit-Queue: Sean Kelker <seankelker@google.com>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686132}

Currently, DownloadItemView's view hierarchy looks like this:

  DownloadItemView (button-ish)
    Filename (text)
    Status (text)
    More options (real button)

DownloadItemView is not a real views::Button, because Button does not
support having child views in this way. As a result, DownloadItemView
reimplements a lot of the event-handling logic from Button. After this
change, the hierarchy is instead:

  DownloadItemView (view, role = group)
    Open (button)
    Filename (text)
    Status (text)
    More options (button)

Which un-confuses VoiceOver and allows removing a lot of the Button
reimplementation from DownloadItemView.

One extra complexity is drag events: DownloadItemView is intended to
be draggable, but after this change drag events will instead land on
the open button, which does not have the local state to implement
dragging. The open button therefore forwards these drag events to the
DownloadItemView so it can implement dragging.

Bug: 957352
Change-Id: I5cbcd1ccd13a83126e6e4579a5d9c9fe2b9b9b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745460
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686131}

The serial_number field of UsbDeviceInfo is optional. A couple places
were missing checks. This was exposed by r678566 which removed code that
previously guaranteed that this string would always be present (but
empty).

Bug: 992656
Change-Id: I825f0cac256adc6ab509f43cbc8ce4df69390fc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749452Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686130}

This holdback records histograms as it normally would, but holds back
the actual preconnect.

Bug: 992542
Change-Id: I38b62a04ab817d802a8519816d4b0c48aa767a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747032Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686129}

After http://crrev.com/c/1636110 this class became unused and should be
deleted.

Bug: 882467
Change-Id: I1cc5c1bd593ac383f6c7494452c801adf5b4645c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721028
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686128}

Bug: 896775
Change-Id: Ib5535bcf945fb8377e9be9a98951298947d51b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747152Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#686127}

https://skia.googlesource.com/skia.git/+log/8d1b0bceedd6..ca9e187dfaa7

git log 8d1b0bceedd6..ca9e187dfaa7 --date=short --no-merges --format='%ad %ae %s'
2019-08-12 halcanary@google.com SkMetaData: drop unused pointer ownership

Created with:
  gclient setdep -r src/third_party/skia@ca9e187dfaa7

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@google.com

Bug: None
Change-Id: I4c026028233ae8fc64d2b824c7002d36298a40d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747969Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686126}

NGBoxFragmentPainter::PaintBoxDecorationBackground and
BoxPainter::PaintBoxDecorationBackground have diverged and this patch
brings them back together. The primary change is how the hit test rect
code now shares the same paint_rect calculation as the background
painting code. This will make it much simpler to implement the scroll
hit test painting for PaintNonFastScrollableRegions in a followup
patch.

This fixes a LayoutNG bug, likely due to the removed (fixed) TODO in
NGBoxFragmentPainter::RecordHitTestData, which is reflected in an
updated test expectation. The relativeChildContainer value now matches
the pre-NG value. The non-virtual expectation has many other differences
and has not been updated.

Bug: 989570
Change-Id: I208655b46dbd6dad0d36132dcc9b7dd5e977d96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749292
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686125}

Bug: 981064
Change-Id: Ic223d402a49d0931d173d8206ff48ad7d6980367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749563Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686124}

This CL removes
1. the DownloadRequestHandleInterface class.
For network service, destroying the ResourceDownloader object should
cancel the url request, pause/resume are handled in DownloadFile and
is not in DownloadRequestHandleInterface.

2. the UrlRequestContextGetter param from DownloadItemImpl::Start().
This is not used any more.

BUG=934009

Change-Id: I41d7b0c6f484432ced43328520c2097f9686fad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743267Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686123}

There was only one non-test usage. It is replaced by calling
GetCookieListWithOptionsAsync with an appropriate CookieOptions.

This also adds a convenience method to make a CookieOptions
that includes all cookies, as several uses were avoiding using the
deprecated method by using GetCookieListWithOptionsAsync with a manually
constructed all-inclusive CookieOptions.

Bug: None
Change-Id: I87cd563e41bc69e27a725c3fe8fdee05172360dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745808Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686122}

Also add kite icon badge to right side of child view of
parental controls.

Bug: 991742
Change-Id: Iba3e5f5d64a578543b36e425c04849251ee46ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745246Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686121}

Add the GPU.SharedImage.ContentConsumed UMA to trace
how many rastered shared image are never read.

Bug: 985024
Change-Id: I7e8d7af1e322a50176cb4355ed88939166d701a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720793
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686120}

This reverts commit cca778ec.

Reason for revert: Crashing tests on startup because path has a / in it

Original change's description:
> [aw] Migrate geolocation preferences.
> 
> The geolocation preferences should not be shared among AwBrowserContexts.
> 
> Bug: 963875
> Change-Id: Ia5dd0667cd7c97148772e6334f9204303ff0c03f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741812
> Commit-Queue: Anna Malova <amalova@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#685951}

TBR=torne@chromium.org,amalova@chromium.org

Change-Id: I134a045647fd1ab5a9127a29ac894a77ac3b4729
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749625Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686119}

It is possible in case of partial requests for transactions to go from
reading the response body back to reading headers for the next range
and then back to reading the response body.
In some code paths the |io_buf_len_| is set to the headers length and
then used as the length of the read buffer provided by the calling site
which is incorrect. More details in
https://bugs.chromium.org/p/chromium/issues/detail?id=986211#c66

This CL fixes the issue by having a separate member field read_buf_len_
which is only set to length of the read buffer provided by the calling
site in Read().

Manually verified the asan issue reproduced while loading the site
http://mahokubota.com doesn't come after this patch.

Bug: 986211
Change-Id: I223656e7e1eb8906d1e0415fac184faea1042b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747389Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686118}

Add GetCreationTime() function to profile, which returns the date/time the user profile was created.

This is needed for use in the trigger checks for HaTS.

Bug: 807714
Change-Id: I53567f417d5342a6209fc1e838323860085118a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730835
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686117}

A link to a source is now displayed in the element properties panel.
Clicking on the link opens the source panel where the header file is
loaded. Right clicking on the link gives the option to open in new tab,
which opens the header file in Chromium code search.

Change-Id: I0314ff285e727bdcc7a9a58201cb6f9089a4c718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719164
Commit-Queue: Kristyn Hamasaki <khamasaki@google.com>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686116}

There was starting to become a long list of these and it was a little
unclear what each of them were for.  This should help.

Change-Id: I930d1f7d693839501175b3b452f8499dbadca228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747384Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#686115}

This CL adds the support of temporary license support to FuchsiaCdm.
FuchsiaCdm maintains a map from session ID to its corresponding
fuchsia::media::drm::LicenseSession. Besides, it simply converts
Chromium data types into fuchsia data types.

Bug: 966191
Test: Shaka player WV content "Dig the Uke". Tested with other CLs.
Change-Id: I21776910158eacb228d940b1747f6fcb1fab494c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743251
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686114}