GitLab

- Refactor ShareTargetType into public
- Introduce ShareTargetType to advertisement class
- Handle encoding/decoding the device type
- Set device type when creating an advertisement in the browser process
- Pass device type to browser process via mojo advertisement
- Set device type in ShareTarget

Bug: 1114667
Change-Id: Iaa728c231ec5ab53dcf8b3796528a78e39c3a5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367679
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800648}

https://chromium.googlesource.com/catapult.git/+log/7a2e3f83964f..12559f038590

2020-08-21 johnchen@chromium.org [Catapult] Update Node and npm version for tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1119563
Tbr: zhanliang@google.com
Change-Id: I5ec1c46e1beced1af7612167ce76d29be3dbdd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368149Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800647}

On 1909 Windows builds, it looks like the touch injection APIs are
very flaky and thus leading to increased flakiness in the VK API
tests that use touch gesture to show/hide VK and test the VK policy.
In this change I've rewritten all the tests using simulated touch
gesture APIs that don't use system touch injections.

Bug: 1108551

Change-Id: I936f4835cc3688b865ec8f1587c4d8a6eaba2a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368158Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#800646}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I7e61d433f8a1debaba49f52db5a5c71d3cb39cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368441Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800645}

Previously, our query would select all of Internals>Network>* and then
subtract bugs with one of the out-of-scope components. The problem is
this filters out bugs that contain both an in-scope and an out-of-scope
bug component.

The new queries use an additive approach that names each of the
in-scope components directly.

NOTRY=true

Change-Id: I8526c49a38d45d41caa4d53b3c6103d281e7f4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367983Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800644}

enable_run_ios_unittests_with_xctest ensures that the test target
type is ios_xctest_test. However, ie/ ios-beta-device, the unit
tests are actually not run with --xctest flag on.

To allow flexibility, we'll pass the --xctest flag in testing/
buildbot/ if needed, instead of mandating this, and to comply
with downstream behaviour.

Bug: 912681
Change-Id: I36769420792e7959a3e8873551b6968c770d1c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368492
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#800643}

Bug: 1115755
Change-Id: I481a8f6498188681216d13df32ee41436cd1306c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358056Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800642}

This is a reland of feab4f74

Original change's description:
> cros: Add alternate keys for interacting with window cycler (alt+tab).
> 
> Currently a user can only cycle the window cycle list using alt+tab or
> alt+shift+tab. Also, the user can only confirm their selection by
> releasing the alt key.
> 
> This CL improves the interactivity of window cycler by introducing the
> following changes. Pressing the left and right arrows now move the
> selection while the window cycler is open. Pressing enter or space
> now confirms the selection.
> 
>       WindowCycleControllerTest.KeysConfirmSelection
> 
> Test: WindowCycleControllerTest.LeftRightCycle,
> Bug: 1067327
> Change-Id: I03682c5545bf82415b9e71a4814bf5c1b0c196bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358586
> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800423}

Bug: 1067327
Change-Id: Ie05f898abe3565fca603b70450bf3a6d92a9caf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368467Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800641}

Follow-up to:
https://chromium-review.googlesource.com/c/chromium/src/+/2343314
Ensure x11::Connection is only used on a single thread

Due to the above changes, content_shell now uses more X11 connections
per instance than previously. On machines with hugh numbers of cores,
this was causing run_web_tests to crash as the tests it ran tried to
more connections at a time than the default limit (256) of its Xvfb
instance allowed.

Bug: 1120107
Change-Id: Ie31fb509e91a9d7828b5f26f2b3885f857c56e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368420
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800640}

Removes all references except for md5 and base64.

Bug: 1120190
Change-Id: I33f8f8c6966e22c92b1e6e31e468b23cf6a95354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368422Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800639}

Bug: b/165829625.
Test: manually.
Change-Id: Iabee17198e1887b7498bb01e45c03a133f0df800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352518
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800638}

Using wpt-import in Chromium b4c47b9a.
With Chromium commits locally applied on WPT:
3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()"
9f52c7e4 "COOP: add reporting to redirects"
f3b221b0 "[COOP] access reporting: Extend report.body.type values."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I29ed553bd0719a460d24f8dbac093d2f16c22370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368997Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800637}

First this change gives CupsPrintersManagerFactory access to the both
the OffTheRecord(OTR) and non-OTR guest profile when logged into Guest
mode. Before, using GetBrowserContextRedirectedInIncognito, only the
non-OTR recording guest profile was available to
BuildServiceInstanceFor.

Second, this change filters to only create CupsPrintersManager with the
OTR profile when in Guest mode. The OTR profile is needed by the
UsbPrinterNotificationController to open the System Web App(SWA)
Settings page to configure USB printers. There is a check
(https://osscs.corp.google.com/chromium/chromium/src/+/master:chrome/browser/ui/browser.cc;l=471)
that only OTR guest profiles are allowed to open SWAs.

For the other profile users in CupsPrintersManager, there's no impact
for using the OTR guest profile vs. the non-OTR guest profile.

Fixed: 1116062
Change-Id: Icbc000f36f178cbf30f1a85dbbe94b16cfe1f3b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368234
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800636}

It has been passing since crrev.com/c/2365132 which avoids raster
translation for layers without text. For the test, the layer is the
scroll corner layer.

TBR=wangxianzhu@chromium.org

Bug: 1116681
Change-Id: Id917ef6e094218de552719205362a8cd1a4da027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367451Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800635}

TBR=bling-team@google.com

Change-Id: I9a3d0673a97fcf4062ea827c9eca1b81e3dc5411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368507Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800634}

This CL does the following things:
(1) Implement a helper function to return the clipboard data's
main type.
(2) Create custom views for menu items.

Note that no UI change is introduced by this CL.

Bug: 1112888
Change-Id: I226411dfc6ccfa4cc7fa59f3adbc7f510f7c7dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355015
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#800633}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7508751f4e1..662c01bba296

2020-08-21 tvanderlippe@chromium.org Remove ProtocolProxyApiWorkaround
2020-08-21 tvanderlippe@chromium.org Add durations for individual presubmit steps
2020-08-21 tvanderlippe@chromium.org Update TypeScript to 4.0.2
2020-08-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-08-21 tvanderlippe@chromium.org Manually update DevTools Chromium DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1116989
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6f2e34f6ea6ddd34ee83aec3d540ec6591025887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369170Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800632}

study.

Bug: 973801
Change-Id: I52143c3144fbeea6d822bad965513b0bb3551bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364953
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800631}

LayoutThemeDefault::ActiveListBoxSelectionBackgroundColor were defined,
but not actually used as
LayoutTheme::ActiveListBoxSelectionBackgroundColor (and friends) weren't
virtual. This patch removes these unused functions.

Additional simplify some of the bool switches by:
 - Moving the default behaviour into LayoutTheme
 - Removing PopsMenuByAltDownUpOrF4Key which always returned true.

There should be no behaviour change.

Change-Id: I8b28f2b22dbf986d9d4ba3e02e8ae9c5b5c2a2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369332Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800630}

This CL batches signin.SigninHelperTest.

Bug: 1120258
Change-Id: Ie2b907c070437a2f76005c181763c78db7ea75e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367860
Auto-Submit: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800629}

Change:
Move the following references into CPRImpl, and provides PRImpl with
getters to access them:
* mRenderFrameHost
* mPaymentRequestOrigin
* mPaymentRequestSecurityOrigin
* mTopLevelOrigin
* mMerchantName
* mCertificateChain
* mIsOffTheRecord

Acronym:
CPRImpl = ComponentPaymentRequestImpl
PRImpl = PaymentRequestImpl

Bug: 1102522

Change-Id: I7e501efed0ab8b4ddc061cebe5170e19be99ab73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357630Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800628}

Separating the branch configuration by file has been rather unwieldy and
would only get worse when it is necessary to maintain a 3rd subset of
builders for LTS. This puts the information about what branches the LUCI
resources are applicable to with the resource.

Bug: 1119446
Change-Id: I1c8622b7084fd332ae16fcdc9afe5d6e30dc1811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365915
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800627}

The nested loop process the native events but not the tasks which looks
like a hang if not inhibited.

Bug: 806174, 1120381
Change-Id: Ie298b16a4e0f8cdd6c4ba398d71a7fee02b9d46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369253Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800626}

Make ClosedTabCache listen to MemoryPressure listener and
flush the cache if the memory pressure level is critical.

Design doc:
https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU/edit?usp=sharing

BUG=1100946

Change-Id: I73afb124ab596ae9bd9db1bed84684088c174096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352942Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Commit-Queue: Andreea Bacanu <aebacanu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800625}

Bug: 1062154
Change-Id: I9c0550e34d6c88ab8a9db4d546852349bc9740d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368920Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800624}

While fixing tests that started to fail with use_x11 && use_ozone
config, I encountered some additional expectations that were
not part of USE_X11 builds before.

And given that we are heading towards use_x11 && use_ozone build,
we need to continue to run tests and other stuff as it'd be
a single use_x11 build.

Also, it seems like our Ozone clipboard impl is more advanced
than non-Ozone/X11. Thus, disable this expectation for x11.

Bug: 1085700
Change-Id: I01f27f213f595ae5d635fa76d68164a8a178141b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367061Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#800623}

Rather than CHECK-failing before transmitting a message, this adds a
DumpWithoutCrashing at serialization time. This will preserve useful
crash stacks to identify offending messages but will no longer result
in the poor user experience of crashing processes, including the
browser.

Fixed: 1098442
Change-Id: I638410f4787e833e9cb92573f26e9e7167d1bec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365852
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800622}

']' was appended accidentally.

Bug: None
Change-Id: I5e07be3848a4b8b2483f8e2a7e61126ae8eeefb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368696
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800621}

This CL increases the SDR luminance (on HDR-capable systems and
with an HDR-capable display) to 85%, following instructions from
the PM office amd also to line up with Apple's maximum SDR value
(equivalenty, HDR headroom) when brightness is at the max.

Bug: b:165824699
Change-Id: I1bbfbba3512d87f84c26e5acc71cfd8f59a07e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367872
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800620}

we seem to miss some test coverage for non-ozone
X11. currently, non-ozone X11 uses dndclient
ozone and should also run tests for that.
though, two tests fail. thus enable the test
suite for use_x11 and disable failing tests.

A bug to fix the failures has also been created

Bug: 1085700
Change-Id: I9a669f18d8e5affc71d5b1e8c21e48f3b8a1765b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366898Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#800619}

For pixel tests with a single parameter for renderer type, implement
improved test name suffixes. For example, the test name
"RendererPixelTest.SimpleGreenRect/1" might become
"RendererPixelTest.SimpleGreenRect/SkiaGL" which indicates the test uses
SkiaRenderer with the GL backend.

Bug: 1047820
Change-Id: I18b8cbc29313b4d05ecfda020c310caa548f22fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367439
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800618}

As the default device will fallback to one of the other devices listed
in the audio device picker. We should avoid showing the default device
when we know which of the other devices it falls back to.

Due to complications with how the default device is reported by
PulseAudio, it is not possible to reliably know which device default
falls back to on Linux. Hence, on Linux the default device will still
be shown.

Bug: 1118193
Change-Id: I6c7d3a6f23d9cd7d2963f9e72e9b140f70bbb231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363256Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/master@{#800617}

This CL was initially generated by //tools/gn/roll_gn.py and
picks up the following changes:

https://gn.googlesource.com/gn/+log/e327ffdc..6f13aaac

    6f13aaac [visibility] Consider configs in visibility check
    5da62d5e Fix native MinGW build
    0649bd9a Add MSYS as a platform.
    501b49a3 clang: Add support for C++ modules in deps
    03df22eb [rust-project] Add "proc_macro" as dep for proc macro targets
    b489f906 Add support for Solaris and illumos systems

6f13aac is a breaking change, in that it addresses gn bug #22,
where `visibility` was not actually enforced on configs (it was
enforced only on targets); as a result, we have some visibility
violations that are now picked up with the new GN binary.

This CL fixes those violations.

Change-Id: I52b6e01f31ce64c1926e97b699b7f8a399dbf9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360685
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800616}

Bug: 1101318
Change-Id: I7297f1522333927db4c14609c57747f79fe87829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366737Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#800615}

This case is specific to when window.open() is used, then the opener
write()s into the newly opened document and adds a <meta refresh> tag
with the refresh url set to the opener's url.

When document.write() is called from another document, the targeted
document's url is updated to the caller's url. Therefore, the act of
writing the <meta> into the newly opened window causes the opener and
the opened window to have the same url. Because the <meta refresh>'s
url matches the current one, it is flagged as a reload, rather than as
a redirect to a new url. However, the browser process has not seen a
commit in the newly opened window, so it gets confused and refuses to
update the url for a reload when a reload shouldn't be possible.

This CL detects that case and ensures that it is treated as a
non-reload navigation, which ensures the state sent to the browser
process is coherent.

Bug: 1112815
Test: http/tests/history/document-write-meta-refresh-in-opened-window.html
Change-Id: Ie665bdf40435728bf6bd4fae5ed8ffda99014800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359377
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800614}

Swap product name and version calls as expected in function signature

Bug: 1103752
Change-Id: I9e21b8c57c6134aee6d66c0e9685146876ee7c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368242
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800613}

There should be no behaviour change.

Change-Id: Ic6d5d5d2ccebbaf2e8ef3bd72a89f9cf50b88add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368440Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800612}

(Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2332664)

Chrome and WebView have supported basic Android ATrace tracing, but the
current approach has some shortcomings:

1) Android R changes the way atrace session activations are broadcast,
   breaking the code in WebView listening for activations
   (OnTraceEnabledChangeListener). This means you can't trace a running
   WebView app with atrace.

2) Neither Chrome nor WebView record early startup events to atrace,
   which means all events before the native library has loaded are
   lost.

3) It's not possible to specify trace categories via atrace, which means
   we need more cumbersome alternative solutions (i.e., command line
   flags) for startup tracing.

4) Writing ATrace events is only supported in WebView.

This patch reworks the ATrace integration to resolve these problems and
to align the Chrome and WebView implementations. In short, ATrace
session management is moved to the common (TraceEvent) layer, and Chrome
and WebView only differ by which trace tags they listen to (APP vs.
WEBVIEW).

We also add a way to declare trace categories through per-app tags:

$ atrace -a org.chromium.chrome,org.chromium.chrome/<category_filter>

(Note that the plain package name without any category filters must
always appear in the list on its own.)

Multiple categories can be separated with a double colon:

$ atrace -a org.chromium.chrome,org.chromium.chrome/cat1:cat2

Or by specifying the the app several times to get around the 91
character limit for each entry:

$ atrace -a org.chromium.chrome,\
            org.chromium.chrome/cat1,\
            org.chromium.chrome/cat2

Finally, to capture Java startup events into a tracing session
controlled by the system's Perfetto service instead of atrace, a
special "-atrace" category can be used to only write events into
Chrome's own tracing service instead of atrace. This way when we
connect to Perfetto later in the startup sequence and establish
the real tracing session, startup-related events can be flushed
into that session without emitting duplicate events into ATrace.

TEST=atrace -a org.chromium.chrome

TEST=atrace webview

TEST=atrace -a org.chromium.chrome

TEST=atrace webview

TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-*:cc

TEST=atrace -a com.google.android.gm,com.google.android.gm/-*:cc webview

TEST=atrace -a org.chromium.chrome,org.chromium.chrome/-atrace

Bug: 1095587, b/160768681
Change-Id: Ifc1488cc1a045bb79a804f13596935234fc7a163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364635
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800611}

The Clank team is reviewing the ownership
of all `/android` directories and updating OWNERS
as part of an effort to normalize code health metrics
across different data sources.

https://docs.google.com/document/d/1aP5GMLwcKkdshT9YLS1dkeGAfNSNoLzdUfWvvt0qVLU

Bug: 1112872
Change-Id: I58cfb139d7692f67b80694c65946bb4537380e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368502
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800610}

This is responsible for:
- Mediating between the controller and WebUI layers.
- Managing the widget the WebUI interface lives in.
- Holding the web view the WebUI interface lives in. This is necessary
  because creating a renderer on demand caused unacceptable latency in
  the commander prototype.

Reviewer note: Please note that there are 5 separate paths to close
- Dismissed by controller via ViewModel
- Dismissed by browser via Hide
- Dismissed by WebUI via OnDismiss
- Window closed (possibly from parent window closing)
- Object destroyed
I'm pretty sure they're all safe, but this part definitely needs a
second pair of eyes.

Bug: 1014639
Change-Id: I422754923a0be3ce3e2b7b6a500add76f7e5ecd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364225Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800609}