- 02 Oct, 2013 40 commits
-
-
guohui@chromium.org authored
These are needed for https://codereview.chromium.org/24647003/ BUG=287883 R=oshima@chromium.org Review URL: https://codereview.chromium.org/25035004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226481 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
compositor_bindings/ will be moved separately since it is its own beast. cpp_* will also be moved later. BUG=265753 TEST=None, just moving files around. :/ R=jamesr@chromium.org,avi@chromium.org,jochen@chromium.org Review URL: https://codereview.chromium.org/25378002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226477 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
This is only visible when the create_browser_with_oobe browser option is specified. BUG=294183 TEST=manual Review URL: https://codereview.chromium.org/23619077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226476 0039d316-1c4b-4281-b951-d872f2087c98
-
flackr@chromium.org authored
BUG=301879 TEST=WindowSelectorTest.MinimizedWindowVisibility TEST=Minimize a panel / window. Enter and exit overview twice. Window should be visible both times. Review URL: https://codereview.chromium.org/25551002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226474 0039d316-1c4b-4281-b951-d872f2087c98
-
engedy@chromium.org authored
BUG=298036 NOTRY=True Review URL: https://codereview.chromium.org/24533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226473 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/25478006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226471 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226470 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=298225 TBR=mark@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/25512003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226469 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Following crrev.com/226280, fixes renamed method. BUG= TBR=qyearsley@chromium.org,tonyg@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/25494006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226468 0039d316-1c4b-4281-b951-d872f2087c98
-
hidehiko@chromium.org authored
Shares most of methods in DirectoryContents and its sub classes. Removes all sub classes of DirectoryContents, instead create factory method. BUG=279614 TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually. Review URL: https://codereview.chromium.org/25263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226467 0039d316-1c4b-4281-b951-d872f2087c98
-
oysteine@chromium.org authored
Separated out basic performance metrics gathering in the PerformanceMonitor to run independently from the metrics/events database code. The former will now run even without the performance-monitor-gathering flag. Added an UMA event which triggers when the browser process never runs below X CPU utilization over a period of Y seconds. BUG=279660, 273320 Review URL: https://codereview.chromium.org/23825004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226466 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
> Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds > > VS2010 changed the default to 0 meaning weaker checks in our > release builds. This commit changes it back again. > > BUG=289691 > NOTRY=true > > Review URL: https://codereview.chromium.org/23464081 TBR=wfh@chromium.org Review URL: https://codereview.chromium.org/25445003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226462 0039d316-1c4b-4281-b951-d872f2087c98
-
philipj@opera.com authored
The listeners were being removed in the completion callback to chrome.cookies.set instead of in the chrome.cookiesonChanged listener. Nothing guaranteed the order of these two, so the test begun failing when delete started waiting for flush in <https://chromiumcodereview.appspot.com/18032002>. Simplify the tests by using listenOnce/listenForever. BUG=302914 Review URL: https://codereview.chromium.org/25677004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226456 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226455 0039d316-1c4b-4281-b951-d872f2087c98
-
kuan@chromium.org authored
cause: bookmark bar state in Browser wasn't updated when BrowserView::OnActiveTabChanged queries it to update the bookmark bar. fix: determine new bookmark bar state in Browser before calling BrowserView::OnActiveTabChanged. BUG=299131 TEST=verify per bug rpt Review URL: https://codereview.chromium.org/25500003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226454 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
This caused files to be sometimes retained as directories, making it impossible to restore access to them. BUG=301692 Review URL: https://codereview.chromium.org/25443008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226453 0039d316-1c4b-4281-b951-d872f2087c98
-
komatsu@chromium.org authored
Rename IBusLookupTable to CandidateWindow, and move the code location from dbus/ibus/ibus_lookup_table.h to chromeos/ime/candidate_window.h Along with this rename, this patch also renames variable names from (table or lookup_table) to candidate_window. BUG=293117 Review URL: https://codereview.chromium.org/24946003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226452 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=rmistry@google.com Review URL: https://codereview.chromium.org/25619002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226451 0039d316-1c4b-4281-b951-d872f2087c98
-
eugenis@chromium.org authored
BUG=302993 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/25587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226450 0039d316-1c4b-4281-b951-d872f2087c98
-
hajimehoshi@chromium.org authored
CLD2 returns zh-Hant insteaad of zh-TW, but this is an incompatible behavior. I fixed it by simply converting it in Chromium. Some other language codes than zh-TW/Hant are also changed, but they doesn't affect the Translate feature. BUG=301360 Review URL: https://codereview.chromium.org/25212002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226449 0039d316-1c4b-4281-b951-d872f2087c98
-
eugenis@chromium.org authored
BUG=302156 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/25665005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226448 0039d316-1c4b-4281-b951-d872f2087c98
-
jzern@chromium.org authored
92d47e4 improve VP8L signature detection by checking the version bits too BUG= Review URL: https://codereview.chromium.org/25563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226447 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
VS2010 changed the default to 0 meaning weaker checks in our release builds. This commit changes it back again. BUG=289691 NOTRY=true Review URL: https://codereview.chromium.org/23464081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226446 0039d316-1c4b-4281-b951-d872f2087c98
-
komatsu@chromium.org authored
This class is a controller of ModeIndicatorWidget. BUG=177765 Review URL: https://codereview.chromium.org/25670002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226445 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This is the last change required to enable the Ethernet EAP policy on ChromeOS. BUG=126870 (For preferences_browsertest.cc) TBR=nkostylev@chromium.org Review URL: https://codereview.chromium.org/23451044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226444 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This improves a fix in r218251, after which the signinDelegate on the signin view would not be replaced when the model changes, but when both models were signed out. BUG=297437 TEST=Have the OSX App Launcher enabled and a single, signed out profile. Delete the profile from chrome://settings, then click sign in on the app launcher. Chrome should not crash. Review URL: https://codereview.chromium.org/25649004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226443 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
NICE_TO_HAVE will pre-render the soon-bin, which is based on both velocity and distance. Previously, EVERYTHING will also pre-render the eventually bin. NICE_TO_HAVE is a better fit for the Android WebView memory management model where we assume a webview will not go berserk with memory. Note that this can still fill up on fling. BUG= NOTRY=true Review URL: https://codereview.chromium.org/25648003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226442 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
One developer on my team was writing a browser test, but the test would just hang. Turns out he forgot to start the embedded test server. I think we can make the failure a lot clearer by adding a DCHECK which will clearly point out the problem. I know that GetURL doesn't mean the test makes a request to the server as such, but the returned URL will almost always be fed into a NavigateToUrl request, so checking for this here will probably be helpful in almost all cases. R=phajdan.jr@chromium.org BUG=301625 Review URL: https://codereview.chromium.org/25238003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226441 0039d316-1c4b-4281-b951-d872f2087c98
-
jinsukkim@chromium.org authored
This is the expected behavior if the user agent intends to not attempt to fetch the resource until the user requests it explicitly. Review URL: https://codereview.chromium.org/23797004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226440 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
TBR=juberti@chromium.org BUG=298300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226436 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
rebuildMenu was only rebuilding the NSMenu, not the menu Model. Do both. Also add tests, and remove the unused AppListMenu::CURRENT_USER, to fix a broken test related to the test not observing the user model properly. BUG=302882 TEST=Open the App Launcher on OSX. Go to chrome://settings and add a user. The new user should appear in the App Lanucher profile selctor. Review URL: https://codereview.chromium.org/25535006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226435 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=estade@chromium.org BUG=none TEST=less TODOs Review URL: https://codereview.chromium.org/25409002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226434 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Make UploadDataStream::Reset public. Call Reset() from HttpNetworkTransaction's dtor. Add tests. BUG=244725 TEST=net_unittests --gtest_filter="*HttpNetworkTransactionTest.CancelDuringInitRequestBody*" Review URL: https://codereview.chromium.org/25217002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226433 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
Test introduced in r226182. BUG=302908, 295758 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/25474004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226431 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
TBR=juberti@chromium.org BUG=298300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226430 0039d316-1c4b-4281-b951-d872f2087c98
-
fangjue23303@gmail.com authored
BUG=none R=kalman NOTRY=TRUE Review URL: https://codereview.chromium.org/25665002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226429 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal(). Add WaitForServiceToBeAvailable() Add test. BUG=141009 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/25488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226428 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226427 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=158649:158674&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/25654002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226426 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
MessagePumpDefault was incorrectly using system time instead of monotonic time for PostDelayedTask. This was fixed in r226378 so we don't need this workaround any more. BUG=293736 Review URL: https://codereview.chromium.org/25628004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226425 0039d316-1c4b-4281-b951-d872f2087c98
-