- 16 Nov, 2020 40 commits
-
-
Rohit Rao authored
Multiple content suggestions tests load pages with the same title, and tab grid cells appear to stick around from test to test. They are hidden and in the tab grid behind the BVC, so they can't be seen by the user, but they are visible to EG matchers. EG tests were failing because the same page title was shared by multiple tests, and the second test was seeing duplicate labels between the NTP entry it was trying to tap and a hidden tab grid cell from the previous test. This was not turning the bots red because the test passed on retry, when run in isolation. This CL fixes the test failures by adding grey_sufficientlyVisible() to the matcher, so that it no longer matches against hidden tab grid cells. BUG=1148938 Change-Id: If0d8b958cace5aa34dfe5e2ed854620b5adc51ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538116Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827764}
-
Boris Sazonov authored
This reverts commit f4a2ff7e. Reason for revert: https://crbug.com/1149027. Original change's description: > [Test] Refactor BookmarkPersonalizedSigninPromoDismissTest > > Refactor BookmarkPersonalizedSigninPromoDismissTest to use > AccountManagerTestRule and ChromeActivityTestRule instead of > SyncTestRule so that it can be batched easily. > > Bug: 1145843 > Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827278} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145843, 1149027 Change-Id: I59fad358639d2b85378dfff422fbe9adf7b75a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540287Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827763}
-
Christoph Schwering authored
This reverts commit 2239f82c. The CL crrev.com/c/2506575 is broke the aeropostale and bestbuy captured-site tests starting with build 3111: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel?limit=200 Bug: 1101280 Change-Id: Iaab775e74c8ec5c20616973f031ce6597deb2290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538213 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#827762}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605484714-baf112bc95e811272919ec65bd3b64ed1dae8200.profdata to chrome-win32-master-1605506334-6616cc9fde8be6f4a346f03421646a2f18c74624.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I964d5d8cc106c92eb755539c12d9ffbbec734db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827761}
-
Karandeep Bhatia authored
In preparation of adding support for session scoped rules (which are not file backed), split the class FileBackedRulesetSource into two classes: a RulesetSource base class and a FileBackedRulesetSource derived class. Since the session scoped ruleset will not be file backed, it will use the RulesetSource class. BUG=1043200 Change-Id: Ia06d4b2ca956de516a542aa3dc69bc70cbe1829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495787 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827760}
-
Sylvain Defresne authored
Conceptually, //ios is on top of //base, so having a dependency from //base/ios on //ios is breaking the layering (this also make it difficult to use //base without using all of Chromium). Implement IsMultiwindowSupported() and IsSceneStartupSupported() by checking for the scene API manifest information in the app Info.plist which is more robust as it will work for any iOS app build on top of //base that set the information in Info.plist even if they do not re-use the rest of Chromium. Bug: none Change-Id: I5ea006ea617c284dc114b2f8f8ecd6eb2f2dcc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529122 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827759}
-
Henrik Boström authored
This CL adds two tests that were discovered missing while reviewing the test coverage, both of which we PASS: - getStats(tracks) throws if multiple senders have the same track. (Actually it turns out such a test already existed, the old one is removed because it was asserting unnecessarily many things.) - RTCStats.timestamp should increase with time elapsed. This CL also makes exsting tests more behavior driven. For example, a test that advertises itself to test that "report containing peer-connection stats and outbound-track-stats" should not fail because we have not implemented RTCCodecStats.sdpFmtpLine - this is a different behavior. As such, tests that are designed to test the existence of a stats object are updated only to verify that. What the old tests were verifying - that the ENTIRE REPORT is valid and complete - are moved and tested in a separate test that asserts everything. These tests we still fail because of sdpFmtpLine. Lastly, the outbound-rtp tests are updated to perform an O/A exchange. If the senders have not been negotiated to send, there doesn't exist an encoder or RTP packetizer and as such we shouldn't expect to see outbound-rtp objects yet. Bug: chromium:1148286 Change-Id: I50d476f1af41cfae80c77486481e3de06a1d8f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534911Reviewed-by:
Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827758}
-
Robbie Gibson authored
The TabStrip uses a CGAffineTransform to implement RTL. Because of this, when we display the snapshot for the thumb strip transition, the CGAffineTransform for the transition also needs to take the RTL behavior into account. Bug: 1094335 Change-Id: I736a2b2b74781407f8b685bfb21bef81ab8c0ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536444 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This CL scrolls the grid view controller to a newly inserted item when it is inserted. Bug: 1094335 Change-Id: I38f497ce7b37eeacfad92ef17f8f9d469d618d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534912Reviewed-by:
-
Marc Treib authored
This removes some usage of "association" terminology, which is a concept that doesn't exist anymore. It also adds a few TODOs for further "proper" cleanups. Bug: 1102837 Change-Id: Ib628ff6c065ec532065d3c053d0cc7594e7bbd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539912Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#827755}
-
Olesia Marukhno authored
Also move all permission dialog browser tests to separate file. Bug: 1148277 Change-Id: I69006766d26d8193f883df2671427cc0eecc2bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534855 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#827754}
-
Jasmine Chen authored
Adds interfaces for persistent indicator integration. This includes: - RegisterServerWithToken to register CameraHalServer with an added token-based authentication mechanism. - RegisterClientWithToken to register CameraHalClient with token. - TokenManager which issues and authenticates unguessable tokens for trusted HAL clients (Chrome, Android). - Migrates Chrome VCD to register its CameraHalClient with tokens. - CameraHalServerCallbacks for CameraHalServer to notify CameraHalDispatcher of updates on the server side, including camera activity changes. Refer to go/cros-camera:dd:perm for the details on the design. Bug: b:170075468 Test: Build and deploy simplechrome. Verify Chrome with new interface sends IPC calls cros-camera with both the old and new interface. Change-Id: Idd52d184b922e2df5578fd38efcf01fa13334569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501104 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827753}
-
Morten Stenshorne authored
If we want to break before the first line in a fragment, we need to check if there's an incoming inline break token, and add that one to the builder, rather than assuming that we should always resume at the beginning of the inline formatting context. The new test would either freeze or trigger a DCHECK failure without this fix. Bug: 1122901 Change-Id: Ib698d477aef18d11dbe1436eaf12d5d52bdc023d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537834 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827752}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605484714-e7960c8b645b53c1b4adeb64d7f205eadd5164b6.profdata to chrome-win64-master-1605506334-ef94e462f1073999e0940c25684c1ff8aa83ac59.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iceed8608787b7989935236e369a0bab116fb44df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539730Reviewed-by:
-
Maria Kazinova authored
Unlike login forms, change password forms are often kept on page after successful submission. This CL allows to detect submission for change password forms that are cleared with HTMLFormElement::reset(). Bug: 1146373, 1147363 Change-Id: Ib1013c91310c5a9277ec9aa2f44c4fc6ab539acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514380 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827750}
-
Henrik Boström authored
Making this feature enabled-by-default correlates with a spike in crashes https://crbug.com/1148964. However, the crashes also correlate with similar crashes on Chrome OS which are unaffected by this change. This CL disables our feature to see if and how this may affect crashes in the next Canary. The plan is to enable it again when we have a better idea what's going on. Bug: chromium:1148964 Change-Id: I67343de24a3f619ab51684e1cd2576bbec49a774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537841 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#827749}
-
Luciano Pacheco authored
Change runtime_loaded_test_util.js to avoid referring to global types or names to prepare to run the background pages as JS modules. When running as JS modules these global names aren't available. Move to use an API defined in the `window.background` which is the interface BackgroundBase. Change the functions using getVolumeManager() to use async/await to improve their readability. Note that test.util.async.unmount() was invalidly calling the volumeManager.unmount() with callback. Fix by calling the callback after the unmount() is finished. Change test_util_base.js to expose the required dependencies to runtime_loaded_test_util.js because when running as JS modules those aren't visible when loading the runtime_loaded_test_util.js. Bug: 1133186 Change-Id: I9b5a52f6ca88cc13881862132d6e331c0dec2f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537256 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827748}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c72157bb26b4..7f0f67f786d1 2020-11-16 petermarshall@chromium.org [typescript] TypeScript-ify profiler/ProfileTypeRegistry.js 2020-11-16 jacktfranklin@chromium.org Enforce kebab-case naming of custom events 2020-11-16 tvanderlippe@chromium.org Fix unused type vars errors for upcoming `@typescript-eslint` upgrade 2020-11-16 janscheffler@chromium.org [DataGrid] Ignore creation nodes in e2e tests 2020-11-16 wolfi@chromium.org Add setting for recording network log If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4fbaae4064f7316f38b70756ef1259271726a42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539739Reviewed-by:
-
Richard Stotz authored
This CL adds a non-functional QuotaClient to NativeIO and attaches it to NativeIOContext. Bug: 1137788 Change-Id: If61bbcc08df6b2c5179882f7aa8b9f5b1a0645bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467899Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827746}
-
Alex Rudenko authored
In preparation to adding persistent overlays for flexbox, this CL renames GridHighlightTool to PersistentTool to reflect that it'd handle all persistent overlays. Depends on the frontend CL: https://crrev.com/c/2523254 Bug: 1145997 Change-Id: Id9c565b9b27140dbd088f6b8cdf3125e6d386f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523175 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#827745}
-
Stepan Khapugin authored
Disable tests: AutofillAddCreditCardTestCase/testAddButtonOnValidNumber AutofillAddCreditCardTestCase/testCancelButtonDismissesScreen AutofillAddCreditCardTestCase/testAddButtonOnValidNickname Bug: 1149306 Change-Id: I64c024251e78df6c35fc5515fe8ec576d1a4f687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537642 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827744}
-
Mathias Bynens authored
This patch removes the dependency on a dynamically-generated anchor element just to get the origin of a given string representing a URL. Change-Id: I3fdc9416da768ca44f168622538af191093cd804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535051Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#827743}
-
Yuichiro Hanada authored
arc::InputMethodPrefs is a thin wrapper of the input method related preferences. It provides convenient methods to update the preferences according to a state of ARC IMEs. Bug: 1139332 Test: unit_tests Change-Id: I98d0e2845df1031340633df77908d76c3f3cd237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537811 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#827742}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf281d84688d..1c231bde8eaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hkamila@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hkamila@google.com Change-Id: I0ab1f9bbe8a610898bca43dca6c9e33a5c6da5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539734Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827741}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/977fe86b8a57..c72157bb26b4 2020-11-16 alexrudenko@chromium.org Rename HighlightGridOverlay to PersistentOverlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1145997 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide6aefb9f4f91250ce86e69017dd73229bab6daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539768Reviewed-by:
-
Henrique Ferreiro authored
Source targets outside of Blink cannot depend on mojom_platform because of the way the component build is setup. This CL adds a comment about how to indirectly depend on it. Change-Id: Id4b7727ba6d8045b95a907700bc41d5c8cbaea0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529164Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827739}
-
Wojciech Dzierżanowski authored
Replace the semi-deprecated ExecuteScript*() functions with the modern counterparts ExecJs(), EvalJs(). While we're here, let's make sure the test doesn't try to requestPictureInPicture() until metadata has been loaded. Bug: 1138168 Change-Id: Id247c2922f26e922417496f9cc406317ac061ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529121 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#827738}
-
Matt Falkenhagen authored
Bug: 842296 Change-Id: I2880dd9dada92fb0c3e1424b17b7b21738cb3dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538867 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827737}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Ia91cfc1d8f72bf56c18236e7ac926bca90aa3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532218Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#827736}
-
Colin Blundell authored
This CL does the initial bringup of ad tagging and blocking functionality in WebLayer. To do so, we do the following: - Bring up an implementation of SubresourceFilterClient and attach it to WebContents instances - Instantiate subresource filter navigation throttles on navigation - Instantiates and configures SubresourceFilterAgent instances in the renderer The organization and code added is modeled after that in //chrome. We have left TODOs for significant pieces of functionality to be added in followups (e.g., showing of the infobar on Android). One thing to note is that ad tagging/blocking only triggers on Android in WebLayer, as it requires having a safe browsing database instance and WebLayer does not have one on platforms other than Android. This CL also adds browsertests of this initial functionality: - that the subresource filter activation state is computed on page loads - that ads are blocked on activated pages if they are flagged by the ruleset Bug: 1116095 Change-Id: I1db0136709014004c221bb0251551eaeac3538e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526087 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#827735}
-
Alice Wang authored
This CL removes the dependency of account_picker package in the package incognito_interstial to facilitate the modularization of the incognito interstitial package. Bug: 1148718 Change-Id: I155fe25ba66611d201aabd3540e8b6559d6e86ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536441 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827734}
-
Noel Gordon authored
Add a file_manager/resources/BUILD.gn action('gen_main_html') to use a script to auto-generate SWA main.html from files app main.html. Update file_manager/resources/file_manager_resources.grd file to fetch auto-generated SWA main.html from the generated resources directory. Bug: 1113981 Change-Id: I116d5fb15e63148e3a1cdbe9cf7e179a53165957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536584 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827733}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ide951861c15b6a4b1b36aff3e6bba1324c30be18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538569Reviewed-by:
-
Alice Wang authored
This CL removes mContentWidth update from the root view's OnLayoutChangeListener and updates this variable in onContentSizeChanged. Bug: 1148421 Change-Id: I149b21a83a8145d030221f7c026feeace50fbaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536874Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827731}
-
Morten Stenshorne authored
When processing incoming break tokens as part of block child layout, do not call NGLayoutInputNode::NextSibling(), because: 1: We're not going to use the result 2: It would trigger a DCHECK failure in some cases If we're resuming at a float in an inline formatting context, we'll do this directly from the block layout algorithm. However, the float may have inline-level siblings, and those should be handled by the inline layout algorithm, not the block layout algorithm. NGBlockNode::NextSibling() (rightly) chokes on inline-level boxes, so just avoid it. There will always be an inline break token which will take care of this correctly for us. The attached test used to DCHECK-fail (but otherwise pass) without this fix. Change-Id: I826c30b362f2ae40af12f1b7cf1b0a9e8cd9ccfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537675Reviewed-by:
-
arthursonzogni authored
There is a dedicated function for everything that should be set/reset when committing a new document. It's better adding new stuff inside, instead of immediately outside. Bug: 1113294. Change-Id: I3e076455d46c0658c06eb9452627ff7b38c06da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537684Reviewed-by:
-
Alex Rudenko authored
Bug: 1121900 Change-Id: I579156dd5b9411324fb88b76bbd12bfb17397d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537633Reviewed-by:
-
Nico Weber authored
This reverts commit d8f7927c. Reason for revert: We rolled in a fixed clang. This workaround should no longer be necessary. Original change's description: > win: Disable CFG in release component builds for a bit. > > After the 2nd-to-last clang roll, release component builds make > chrome crash on launch due to CFG. Disable CFG for component builds > until we roll in a fix. > > This does not affect shipping chrome, which doesn't use component builds. > CFG was already disabled in debug component builds. > > Bug: 1147194,1147445 > Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826317} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1147194 Bug: 1147445 Change-Id: If377b6d66f1a78105b1d41db8e68a30da9e39fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539354 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#827727}
-
Ce Chen authored
after launching feature to non-Incognito Mobile & Incognito all platforms. Bug: 925072 Change-Id: I564833f2051b4b5b04980a119b121f2ee2e6da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537521 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827726}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1cda495274bb..1f2fcddd3963 2020-11-13 afdx@google.com spirv-opt: Set parent when adding basic block (#4021) 2020-11-13 jaebaek@google.com spirv-opt: properly preserve DebugValue indexes operand (#4022) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I4db3b49a0ad2c6b0bd2940777d3b013e5db2a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539729Reviewed-by:
-
