- 11 Nov, 2020 22 commits
-
-
Brandon Wylie authored
This is a requirement to prevent logging against the wrong account. Once AGSA supports incognito mode, then this can be removed. Bug: 1117271 Change-Id: I9aed4cb6bf5945e4f5e69488ba847e69474ae7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530089Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826040}
-
Istiaque Ahmed authored
EventAckData::IncrementInflightEvent can legitimately fail if worker is already stopped or is stopping. This will (later) result in corresponding DecrementInflightEvent to fail as well, but that results in ESWMF_INVALID_DECREMENT_ACTIVITY bad_message. This CL makes EventAckData to not send bad_message in this case. Bug: 966652 Test: None Change-Id: I7b95ac40b36bf394be1de2407248b5d8d2b3b1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528921 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826039}
-
dpapad authored
In preparation of moving all IDR_WEBUI_JS_* resources to webui_generated_resources.grd, the new webui_generated_resources.pak file needs to be included in several places. Bug: 1132403 Change-Id: Icd151d11d0a67b2e6944f75486093a9f9fe2fcc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521843Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826038}
-
Nate Chapin authored
Change-Id: I0f48c0823bf8a811b635522eb433bc277f5c238f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530589 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#826037}
-
Alexander Surkov authored
base::DictionaryValue is deprecated, switch tree formatter API build tree methods to base::Value Bug: 1133330 Change-Id: I3852bcbb68fcc587dd531933180963331df6c265 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518919 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826036}
-
Gregory Guterman authored
This reverts commit 933ec987. Reason for revert: https://crbug.com/1147440 The change is calling a function not available on Win7. https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getcurrentinputmessagesource Original change's description: > Ignore rogue window management mouse move events > > Do not process window management mouse messages (WMMMs) when the pen is active over the client area. > > Windows sends window management mouse messages at the mouse position when windows open or close (e.g. Aura tooltips and Status Bubbles), including WM_MOUSEMOVE, WM_NCMOUSEMOVE, and WM_SETCURSOR. This is a longstanding Windows behavior designed to ensure that mouse cursor visuals and hover states update when the foreground window changes. However, this behavior does not extend to pen input, so WMMMs always come with the mouse coordinates instead of with the pen coordinates even if there is an active pen. > > In Chromium, WM_POINTER processing in the window non-client area are "promoted" to mouse messages in order to allow for interaction with the native window frame (e.g. resize handles, title bar, and window caption buttons). However, WM_POINTER messages in the window client area are handled as Chromium events without any mouse promotion; in this latter case, mouse position and pen position are not guaranteed to be in sync. > > Since Aura tooltips and Status Bubbles appear as custom windows on pen hover, opening/closing them causes Windows to send WMMMs. Consequently, users might see visual flickering as hover states flip back and forth between pen and mouse positions. In order to ensure that these WMMMs do not interfere with hover states, we must ignore such messages until the pen is no longer active. > > This change affects only Windows 8 and newer clients, which use the WM_POINTER API. > > Bug: 1147222 > Change-Id: I44335348f933f48edcfe665b396f133388169957 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525220 > Commit-Queue: Brian Liu Xu <brx@microsoft.com> > Auto-Submit: Brian Liu Xu <brx@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825665} TBR=pkasting@chromium.org,brx@microsoft.com Change-Id: If6840d4b4ddd352ee6e54dcfb2fcd0aa09579469 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530802Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#826035}
-
Yu Han authored
This reverts commit a2c6108b. Reason for revert: Suspect cause of tree closure. https://ci.chromium.org/p/chromium/builders/ci/Cast%20Android%20(dbg)/115938? Original change's description: > Android: Enable custom lint checks from aars > > Some aar files (e.g. androidx) that chrome depends on contain a lint.jar > file and/or a annotations.zip file. The lint.jar file includes custom > android lint checks. The annotations.zip file contains @IntDef and other > annotations needed for lint checks that are usually available by source > but are not available in aars. > > By using these files, we can make our existing lint checks more > comprehensive as well as benefit from lint checks by the aar library > authors. > > See newly ignored checks in lint-baseline.xml which is updated in this > CL as an example. Actually fixing these errors is left for future CLs > in order to enable them quicker and avoid unnecessary relands. > > Bug: 1078229 > Change-Id: I3a8e67a9c41b8e8fbe339632f795b2aaab63456e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510793 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826017} TBR=wnwen@chromium.org,mheikal@chromium.org Change-Id: I9b1fc0745465fcdd9b153dbbe2495b3b912b25da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531179Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826034}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c04a0132be6c..f3c829047220 2020-11-10 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7b750dc7337d to 0573714bfd0f (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I1f99130160d63d843a1ae88bdf7b9f824cef3907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826033}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fa36737aeb08..5db9eeec2f2e 2020-11-10 jalyn@microsoft.com Settings: Allow users to create chord shortcuts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f39d51b87cd66c4c9f0cf6aac6308739a34a83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530245Reviewed-by:
-
Aaron Leventhal authored
What's happening is that as the search field goes from empty to having text, the shadow generic container inside of the input goes from not being in the tree to being in the tree. But in AXNodeObject::ChildrenChanged(), we use LastKnownIsIncludedInTree() and we can't update it to a new value. So we think it's still not included in the tree, and update the parent's children. But we also need to update its children too. Bug: 1146214 Change-Id: I7b6c7ec6780d63fbcb0206e1d682f719d51acac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530289Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 891908 Change-Id: Ia9ea8e79468ff037d4b6f18a6bf8d0405faab341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529291 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826030}
-
Michael Hansen authored
Adds disable/enable logic for the confirm button when on the contact visibility selection page during the onboarding process for Nearby Share. Screenshot: https://screenshot.googleplex.com/AKUymEEvWtvCTrU.png Bug: b:168841167 Change-Id: Idf6d92f743c282262e410b2ec2a0045a0ad5d4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527892 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826029}
-
Mason Freed authored
In crbug.com/920571, several changes were made for performance reasons, and one of these changes was to stop breaking lines and just allow each source line to take up one view-source-table line. This did improve performance (significantly in some cases, e.g. 150X), but this is a behavior change that caused some developer pain. This CL puts back word breaking, temporarily, while a solution to the developer pain point is found. Bug: 920571 Change-Id: I2fc744c034b9ff90ca6e560fda5b077a8a8a1bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529969 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Jazz Xu authored
This CL makes the following changes: 1. Adjust notification layout for CrOS. 2. Make artwork always displayed as square. Bug: 1144314 Change-Id: I27d7c4c958c84bf4e4d25cc72db84546c78cd635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523396 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826027}
-
Clark DuVall authored
Bug: 949535 Change-Id: I8f958933aec6b35f61a176c2e91513e7ce2c460d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530090Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#826026}
-
Salvador Guerrero authored
This CL modifies the Android Application state listener to record the new status as a strongly typed trace argument Change-Id: I5491b19eeba73d2af2165441514b163eefb1e37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523737Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#826025}
-
W. James MacLean authored
At present ChildProcessSecurityPolicyImpl::SecurityState stores only a single BrowsingInstanceID (the lowest) even though its associated process may contain multiple BrowsingInstances. This may lead CanAccessDataForOrigin to consider the wrong BrowsingInstance when performing its checks for opt-in isolated origins. This CL converts SecurityState to track an ordered set of all the BrowsingInstanceIDs so that they can all be checked. CanAccessDataForOrigin is modified to return 'true' if *any* BrowsingInstance in the set would allow the access, otherwise it returns 'false', and logs the failure reasons for each of the BrowsingInstances. This CL also includes delayed cleanup of BrowsingInstance state from ChildProcessSecurityPolicy when BrowsingInstances are deleted. This avoids memory leaks but may pose a small risk of renderer kills. We will monitor the CanAccessDataForOrigin crash keys to see if such cases occur in practice. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2446370. The issues that led to https://crbug.com/1141877 are fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2523732 and include a test that becomes meaningful once this CL lands. Bug: 1135539, 1141721 Change-Id: I33da01254aaf9e0bb29635cf6b68d85f4823684f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522904 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826024}
-
Chris Lu authored
Now that |low_entropy_provider| is used later in VariationsFieldTrialCreator::SetupFieldTrials(), VariationsFieldTrialCreator::CreateTrialsFromSeed() shouldn't own |low_entropy_provider|. Bug: 1138603 Change-Id: I53ba8d2b7160bd3c9f02e92af4bd53ca72c63f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525856 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826023}
-
Etienne Bergeron authored
This CL is fixing the DCHECK for GetSubstringBounds(...) which was detected to fail sometime on albatros build. 1) Use IsBoundedBy(...) instead of Contains(...) The first problem was cause by the range [end,end) which is not considered to be part of the range (a.k.a Contains(....) will return false). IsBoundedBy accepts the empty ending range to be part of the range. 2) Some eliding behaviors may break the mapping between text indexes and display text indexes. The new check implementation is ensuring that eliding is not causing any invalid offsets. We are expecting clusterfuzz to hit these DCHECKs until it's fixed. R=gab@chromium.org, msw@chromium.org Bug: 1146674, 1085014 Change-Id: I219ef476009fc85edb7b836d5143022f51ecb8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521252Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826022}
-
Thomas Guilbert authored
Currently, when a H264 chunk cannot be converted to a DecodeBuffer, we return a nullptr. This means that conversion errors are reported as "null or empty" decoder buffer errors. This CL fixes the issue by surfacing a media::Status along with the nullptr. Bug: 1139089 Change-Id: I018715b56f65b96e843e6af19c9b8300b73b1f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523750 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#826021}
-
Michael Bai authored
Framework has a bug which causes a exception in a race condition, the exception make the app crash. This patch catches this specific exception to prevent crash. Adds a new set of tests for NotificationTask, its subclasses and PlatformAPIWrapper to verify the capture exception working correctly. Bug: 1131430 Change-Id: Ia6ef93c47421700c0e52b1de267c6be00d0dd51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521224Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#826020}
-
Emily Stark authored
https://chromium-review.googlesource.com/c/chromium/src/+/2523674 introduced a Finch feature for showing Safety Tips on Safe Browsing delayed warnings. In that CL, I neglected to update one spot where the new feature should be checked: for computing the security level of a page when a Safety Tip is showing. This CL fixes that bug and adds a test. Bug: 1146471 Change-Id: I69e794fb2a2c087855bce9c43694620efe490336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529949Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826019}
-
- 10 Nov, 2020 18 commits
-
-
Becca Hughes authored
Adds support for provider selection for signed out users by storing their selection in a pref. Change-Id: I8f2016556542007e634ef450f1a9fb1f766af33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523560Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Peter Wen authored
Some aar files (e.g. androidx) that chrome depends on contain a lint.jar file and/or a annotations.zip file. The lint.jar file includes custom android lint checks. The annotations.zip file contains @IntDef and other annotations needed for lint checks that are usually available by source but are not available in aars. By using these files, we can make our existing lint checks more comprehensive as well as benefit from lint checks by the aar library authors. See newly ignored checks in lint-baseline.xml which is updated in this CL as an example. Actually fixing these errors is left for future CLs in order to enable them quicker and avoid unnecessary relands. Bug: 1078229 Change-Id: I3a8e67a9c41b8e8fbe339632f795b2aaab63456e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510793 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826017}
-
David Van Cleve authored
This change expands the Trust Tokens browser tests to cover additional signing-related cases: - issuance and redemption against one issuer, then signing against a different issuer -> should fail - signing includes timestamp header if requested - gamut of signRequestData parameter: `omit` should lead to no signature, `headers-only` to signature over SRR, ... - non-OK header in additionalSignedHeaders -> should error Previous changes (crrev.com/c/2308860, crrev.com/c/2309007) added more tests covering issuance and redemption. Bug: 1071293 Change-Id: I702e0f3e3d17c703239e66781af2c64bc0cb0fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308866Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#826016}
-
Connie Wan authored
Needed because of the generated file components/translate/content/common/translate.mojom.h, which is included in a public dep here: https://source.chromium.org/chromium/chromium/src/+/master:components/translate/content/browser/BUILD.gn;l=21 Bug: 1147383 Change-Id: I515742ab54905755c9f40ea30ad64fb1f61d78d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530203Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#826015}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604998756-dde3841da8adecb7243697161fbddafddb9cdeef.profdata to chrome-win64-master-1605020074-68960f639156f9ccbd07438455ce3664424ac683.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7969ebffaa34d6de5744654c37cbc085f87280d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529198Reviewed-by:
-
Yu Han authored
Disable virtual input tests for chrome_all_tast_tests Bug:1147607 NOPRESUBMIT=true NoTry: True Tbr: shengjun@chromium.org Change-Id: I53cb09bab71d0019037344f0a03c03715253f443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530652Reviewed-by:
-
Luciano Pacheco authored
and <files-icon-button> Bug: 1133186 Change-Id: Iadbe0630cf2398c41c2a1eb2a50851528543b6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526893Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826012}
-
David Tseng authored
R=dmazzoni@chromium.org Change-Id: Id32a26c536542f0aa80da6471cb1f801230554a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530745Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826011}
-
James Cook authored
Lacros uses wayland server-side cursors, via the wayland protocol extension zcr_cursor_shapes. That extension is ash/exo-only. As an optimization, lacros skips loading cursor assets for cursors where it knows it will use server-side cursors. See https://chromium-review.googlesource.com/c/chromium/src/+/2516972 However, if you run an ozone/wayland/linux build against ash/exo as the wayland server, the cursor factory will load the cursor asset, but WaylandWindow will not use it. This trips a DCHECK. This only affects developers. In production, ozone/wayland/linux does not run against ash/exo. Likewise, lacros always runs against ash/exo. Avoid the DCHECK by explicitly limiting server-side cursor use to lacros builds with ifdefs. Bug: 1147529 Change-Id: Icf99271278e304fd357d6e69b7289cf66fe151a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530258Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826010}
-
David Dorwin authored
StartWebEngineForTestsInternal() was previously including an empty string from CommandLine's argv[0] in the component launch_info. While WebEngine ignored this, it is technically incorrect and would fail if copied for some other components. Also update comments and other terminology related to switches and arguments. Specifically, CommandLine's "args" does not include switches, which means GetArgs() cannot be used for this. Change-Id: Icb1944bfc92405664f973d126cab0c543b42ac4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511750Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826009}
-
Sophie Chang authored
Bug: 1146151 Change-Id: I11e43077984753aa8bbae25abd7841e2fa862500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530200Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#826008}
-
Guido Urdaneta authored
This CL introduces MediaStreamTrackGenerator, a specialized version of a MediaStreamTrack that exposes a writable stream that allows applications to produce frames. In terms of the model presented by the Media Capture and Streams spec [1], this allows creating a track with a custom source. [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings Bug: 1142955 Change-Id: I5f2a4426174aef50bdc6fe6a2bcec2268702932a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524321 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#826007}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1da47d0..2dbcdc10 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d6e06defecd6a2af22c51eb6d2788c7f35160b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530255Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826006}
-
chrome://nearbyCurt Clemens authored
A previous CL added support for creating text attachments using query parameters to chrome://nearby. This CL expands that support to allow passing file paths to be shared, e.g. chrome://nearby/share?file=/path/to/file1.png|/path/to/file2.jpg Bug: 1145684 Change-Id: Ie8fb9aa6ec82404393045a7ee1d52597572f5f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530261Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#826005}
-
Ilya Sherman authored
R=mpearson@chromium.org Bug: None Change-Id: Ia99bd611c2ec48277be2dc1a6b8986319f0997fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462684 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#826004}
-
Connie Wan authored
This CL adds the implementation and tests for the Move function, which rounds out the functions in the Tab Groups API. Bug: 1106846 Change-Id: If943b628272aed06b700162dab85ccab4091b842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419754 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
TBR=droger@chromium.org Bug: 1145565 Change-Id: Ie2460e40a2ccafcee3116d667797a1ac8518d10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529875 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#826002}
-
Paul Moy authored
Add several more unit tests to LorgnetteClientManager to cover the more complex cases which haven't been covered yet. These mostly involve successful end-to-end scans, as well as one failure for a scan which started successfully but failed before completing. Bug: b:169573779 Change-Id: Ib19c997250731aa097a2032b83e60d8fd2d49ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523435Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#826001}
-
