- 06 Oct, 2020 40 commits
-
-
Mike Wittman authored
Re-enables the profiler at a low rate on the render thread in Android ARM32 canary, to test the hypothesis that the crashes seen in https://crbug.com/1135152 were due to the module loading occurring after sandbox initialization. The re-enabling moves ~50ms of work onto the main thread so is intended to be landed only temporarily. Bug: 1135152, 1004855 Change-Id: I66f71aa391c5f3369c77ef8ca1d7866221d9c66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453795Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814399}
-
Michael Hansen authored
The original change was reverted due to a test failing on linux-chromeos-dbg. Reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/2448510 The fix was to remove the browsePreload() override so that the test starts on chrome://os-settings to ensure that strings.m.js is loaded. Original change's description: > [Nearby] Validate device name in onboarding. > > This adds support for validating the device name that a user enters > during the Nearby Share onboarding flow. Validation happens as the user > types and also when they try to proceed to the next screen. If an > invalid name is detected, an error message will appear and the "Next" > button will be disabled. > > Screenshots: > https://screenshot.googleplex.com/3USR7ftg7QCwJhR.png > https://screenshot.googleplex.com/6Cr6pedUxWnUKju.png > > Bug: b:169582004 > Change-Id: I07d4822e0ea099b30d23ed34a5f70f01940a3009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441150 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Michael Hansen <hansenmichael@google.com> > Cr-Commit-Position: refs/heads/master@{#813193} Bug: b:169582004 Change-Id: I48e1aa7325db74f673cb3e6bc60de49ca8b7af9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448665Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#814398}
-
Brian Malcolm authored
For managed users/devices, the manager for Dasher organizations will be a domain name (foo.com), but for FlexOrgs it will be an email address (user@foo.com). BUG=chromium:1081272 Change-Id: Ia5fe346a88c7e4d147a3d7e2182118ac84b3b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450726Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814397}
-
Vladimir Levin authored
This patch ensures to restore a forced graphics update which is skipped when the layer is locked. This is a speculative fix for the referenced bug. TEST=Unfortunately, it seems to be a rare case that I cannot reproduce Bug: 1133244 Change-Id: I5526e2fb8fe52b598ba7eda7fe2159fe20047659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452929 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814396}
-
evliu authored
This CL removes the SODA builder test definitions from the Chromium repo as they will be added to the src-internal repo. Bug: 1122784 Change-Id: Id5bc7d77c1a61294c62fe49c8339dbd9a1b233c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453907Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#814395}
-
Tibor Goldschwendt authored
These histograms let us analyze usage of the shopping task module in more granularity than what NewTabPage.Modules.Usage.shopping_tasks allows. Bug: 1133904 Change-Id: Id7470f6b2f0cbb7553dba406e57d5f62afd788c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443392Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814394}
-
Robin Lewis authored
When cloud policies is enabled, GCPW will try to read the list of allowed domains from Omaha policy if they have been fetched already. If not it will fall back to the registry entry as before. Bug: 1134817 Change-Id: Ia68a799af2216898e10e0c25ac94fbb2421e5afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446546Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#814393}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601985365-aec4f74ada9d9ee3d8abbdb4ce83b168ed5b8f37.profdata to chrome-linux-master-1602007017-f47632c7e04b048b996f98c97bed5ef2bab09ddf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I39546a1ebbcb36c75f9e4f6bc431fed4f4b73fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454151Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814392}
-
Bo authored
This reverts commit 7e927f71. Reason for revert: DumpWithoutCrashing generating too much noise and not useful. Fixed: 1135529 Original change's description: > aw: Add DumpWithoutCrashing to debug terminator > > Hopefully getting the stack and some info of of when a > !normal_termination and kInvalidSigno happens will be helpful to pin > down the cause. > > Bug: 1115216 > Change-Id: I4bda59c1e27782e7688d1594c8af6efba6c1c9c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448058 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813865} TBR=boliu@chromium.org,torne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115216 Change-Id: Ib4cdc1f95e9340ad700e82500452c920786546d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453503Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814391}
-
Joe Mason authored
This prepares for a pending commit to the internal chrome_cleaner repo which will delete the internal copy of import_util.py: * Add separate GetChromiumRootDirectory and GetInternalRootDirectory functions to clarify the ambiguous term "root directory" when called from the internal repo mounted at //chrome/chrome_cleaner/internal. * Move all the functions that depend on being called from inside the chromium source tree to a separate import_paths.py script. (All the current callers of these functions happen to be in //chrome/chrome_cleaner/internal.) * Delete code to find a local copy of find_depot_tools. It's no longer supported to run this script without calling gclient sync, which will update depot_tools. R=proberge Bug: 1004848 Change-Id: I829851f332975c950f1dcde59735ee96f34f295e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451810Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#814390}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33b42e12ab71..0ce2c5409484 2020-10-06 adlai@google.com Reland "Reland "Take GrContext private, GrDDLContext inherit from GrRecordingContext"" 2020-10-06 johnstiles@google.com Improve error reporting from SkSL include files. 2020-10-06 mtklein@google.com Revert "retry retry absl" 2020-10-06 herb@google.com turn on using new for op pools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: If4def02c6c27ae693d6cb0ff1d6d219257bf8268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454153Reviewed-by:
-
Peter Boström authored
Widens modal dialogs from 320dp to 448dp, which is currently only WindowNamePrompt. Bug: 1106422 Change-Id: Id8db619b09bdb8cff8f6caaa3def215178558565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453895 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814388}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I179056a834bfc2704de33c3c84e14b9604788228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451590Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9929780af36a..6fadc23db4ad 2020-10-06 jeffyoon@google.com Adding OWNERS file for osx_sdk recipe module If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia0d208f1cc1dfea19bbf9d8129ab0f78dcc0f6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453324Reviewed-by:
-
Oystein Eftevaag authored
TBR=sullivan@chromium.org NOTRY=true Bug: 1135672 Change-Id: I04a0479cc9e3ba4f66adadee3c9be7a319699124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453506 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814385}
-
Russell Davis authored
See the new tests for exact repro steps. These issues were caused by preexisting internal state that wasn't getting properly reset but which only caused problems in combination with the new `find_match = false` mode. Change-Id: Ic4adb54cd748223fac48af6c9eac2ae169c6d09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448680Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814384}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601834343-82769562e4ad5e12ea73b5c2f85a14b80cd4e56c.profdata to chrome-mac-master-1602007017-ff22e69e8516bb0ed861dff91d905b52f8e377d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I443827a92e9d7f05739b108629802e84015913cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453322Reviewed-by:
-
Darin Fisher authored
Changes the interface to use SkBitmap, which is passed over Mojo IPC using BigBuffer (shared memory). This is then wrapped using a special subclass of webrtc::DesktopFrame (one less copy). There are still more copies than would be desirable here. We have the initial copy created by Ash. That is translated into a BigBuffer for transport over Mojo. That is then copied back to a SkBitmap. Avoiding those copies and even reusing the transport buffer are an exercise for a later CL. The interface design also unifies screen and window capture in a way that is consistent with webrtc::DesktopCapturer. This also enables a path to adding support for multiple screens in a future CL. There's a good deal of complexity in this CL to handle version skew. QueryVersion doesn't work synchronously, so a nested event loop is used on the background thread where DesktopCapturerLacros runs. That is safe, since this is a dedicated thread, but not ideal. The deprecated methods are re-implemented in terms of the newer interface. Bug: 1094460 Change-Id: I2b2f86df08612b79faae7da547ff1242c05ac467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443404Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814382}
-
Weilun Shi authored
Move inputs to the template file instead of the actual build targets because these build targets share the same inputs. Bug: 1134434 Change-Id: Ie3f06675b6e27e302c5851d51cade7a94bb50199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444175Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#814381}
-
Azeem Arshad authored
https://chrome-internal.googlesource.com/chrome/deps/barhopper/+log/d5422b6ec462..ad3c4382875a $ git log d5422b6ec..ad3c43828 --date=short --no-merges --format='%ad %ae %s' 2020-10-05 azeemarshad [Barhopper] Fix include dependency checks. Created with: roll-dep src/third_party/barhopper Bug: 1093185 Change-Id: I0a369792f404992a40152e53a55989e277bb1353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453430Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814380}
-
Robert Sesek authored
- Allow reading the directory contents of ~/Library/Preferences and ~/Library/Preferences/ByHost - Allow reading of all com.apple.driver* plists in ~/Library/Preferences/... - Allow reading /Library/Preferences/com.apple.security.plist to read the global trust settings - Allow sysctl-read hw.busfrequency_max - Deny access to a new macOS 11 UsageTrackingAgent Mach service Bug: 1126350 Change-Id: I0be9a9f8a1830dbfac4486f9c21e05a6e5d336d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453900Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9a64fc651dfe..15f1e5d585c5 2020-10-06 pfaffe@chromium.org Revert "Implement support for the JavaScript formatter API" 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-06 michael.liao@microsoft.com [Bindings]: add undefined check for createLiveLocation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128416,chromium:1134634 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3bc2d6bdcf2b8d4ce081f80344de37cd37ce1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454149Reviewed-by:
-
Sean Kau authored
ChromeOS Printing is actively using: Printing.CUPS.PrinterAdded Printing.CUPS.PrinterRemoved Printing.CUPS.PrintersDiscovered Printing.CUPS.PrinterSetupResult to monitor printer setup health. Bug: 1089320 Change-Id: Iefa06c26161190f9c422b7dfafaaf7be1050892f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451519 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
Minor refactor: DidRequestPermission is rendered more readable with an early exit in case there is no implementation. Change-Id: Icd06cd9e18162a3363138d830fe8e01e41c32a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450839 Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#814376}
-
Shrek Shao authored
Suppress conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html on Nexus5X validating cmd decoder TBR=kbr@chromium.org Bug: 1135659 Change-Id: If0499fa84a73b6a63d04475b8c65998fe6cab05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453989Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#814375}
-
Tommy Nyquist authored
These tests were previously failing only on Marshmallow, but are now failing on Lollipop, and Pie as well. Bug: 1127786, 1135682 Change-Id: Ib6c49f8ffa6997568fa74171b293e1bcfc41b7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453497Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#814374}
-
Jamie Madill authored
This reverts commit 0919ca8b. Reason for revert: Failing ChromeOS FYI bots. Bug: 1135720 Original change's description: > Re-land "Switch angle_unittests to isolated script API." > > Re-land with these tests disabled on Lacros. > > Uses the new 'use_isolated_scripts_api' feature added here: > https://crrev.com/c/2425210 to switch the tests to the ANGLE > standalone testing harness. > > Bug: angleproject:5124 > Change-Id: I456aaeeb961f56f6b6e171ea13fb11c566704317 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446997 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814046} TBR=ynovikov@chromium.org,dpranke@google.com,jmadill@chromium.org Change-Id: Iafddb986616b76cc3db528dd9be777ee30637a55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453504Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814373}
-
Mason Freed authored
With declarative Shadow DOM, the clone method has been updated to clone templates that contain attached shadow DOM. This perf test exercises that functionality. Bug: 1042130 Change-Id: Ic31a298c722e10c55e130f704af9c7ccf4c8c72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448649 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#814372}
-
Cammie Smith Barnes authored
Change-Id: I350b1e28e4dd4314557094c27ed0a80db42addab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431403Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#814371}
-
Kyle Horimoto authored
Before this CL, MessageSenderImpl and MessageReceiverImpl assumed that the phone and Chrome OS device had the same endianness. This CL fixes the issue by converting from host to network endianness when sending messages and converting from network to host endianness when receiving messages. Bug: 1106937 Change-Id: Idaa3b56f9450030aaf2c5460a2cae18ec4869d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453271 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814370}
-
Liquan (Max) Gu authored
Context: * Moves PaymentRequestTestRule into the chrome_test_util_java target so that the clank_test_java target can depend on it. * Moves the factory adding of PaymentAppService out into getInstance so that PaymentAppService doesn't have to load all factories in the tests. Bug: 1091475 Change-Id: Ia8873e8135de5e2c76bed9b3541c49390e40f700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398916Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814369}
-
Alexander Cooper authored
In order to migrate the InstallHelpers out of chrome, their dependency on SimpleConfirmInfoBarBuilder needs to be broken. This change creates a class that both InstallHelpers can use, XrInstallInfoBar, which inherits from the components ConfirmInfoBar. ArCoreInstallHelper is also modified to take in a ContentInfoBarManager to display this item, so that it can be moved to components when the corresponding ArCoreInstallUtils java class can be moved. Unfortunately, content does not have a good way to get the specific InfoBarManager at this time, so a wrapper class is created to get the embedder-specific InfoBarManager. Note that due to the dependency on the ArCoreShim, ArCoreInstallUtils cannot be moved out of //chrome just yet. Due to the fact that the VrCoreInstallHelper lives in the VR DFM, some issues arose around strings when attempting to port it, so this change only ports the ArCoreInstallHelper to the new classes. Bug:1064073,960542 Change-Id: Icec9bd2535dde0378c16aafc9bafd98db4927ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442990 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#814368}
-
Sean Gilhuly authored
Color artifacts can occur if the color space used for rasterization does not contain the full range of sRGB values. In this case, default to using sRGB for rasterization. Bug: 1073962 Change-Id: Id8cbc0b5e917cf6160f8b34b46f231427144a442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438196 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#814367}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia457b8c33868de995a1fa9655c23a5cc4c016df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453910Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#814366}
-
My Nguyen authored
Rolling out map4 to 1% stable in http://cl/335531678 Bug: b/166523259 Change-Id: Ie5de747bc3c56d12f5425083de5f2c245cc6f9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449656Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#814365}
-
Vladimir Levin authored
This patch ensures that the DCHECK doesn't trigger when checking that the dirty bits have been cleared on the graphics layer updater. This follows the same pattern as the update, skipping checks on locked children. R=chrishtr@chromium.org Change-Id: I81ae6a6ca4279472dd3433db9f23b2295fd52ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452849Reviewed-by:
-
Ian Wells authored
When enable_jdk_library_desugaring=true, this change allows shrinking of the generated "j$" dex from ~400 KB to 36 KB. ConcurrentHashMap is available before before Java 8 but with a bug: crbug.com/905903 Bug: 1056751 Change-Id: Ibaaeba2f714c0e8b17295cbe48098786ad173448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446989Reviewed-by:
-
Hazem Ashmawy authored
Add tests for toggling flags and the persistent notification. Also remove test batching for flags fragment tests to so the flags service is killed when the process is killed leaving a clean state. Fixed: 1130599 Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" Change-Id: I0cb416471d3b79e98ed9ef8ad5e760b4bfaa1083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438534 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814362}
-
Ian Kilpatrick authored
As above. Previously this was handled by LayoutFlexibleBox. Bug: 845235 Change-Id: Id4899b487c92b723341c8251601f317abb6618c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451732Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814361}
-
Eugene But authored
Notable changes: - Record pending URL for chrome://inducebrowsercrashforrealz to distinguish self inflicted UTEs - Extend PreviousSessionInfo to store navigation URLs - PreviousSessionInfo only stores URL origins as requested by Privacy team - Use URLs from PreviousSessionInfo for synthetic crash reports Bug: 1103752 Change-Id: Idbde05b634e840fe377c4803b357fbef03c36170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451298 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814360}
-
