- 17 Aug, 2020 40 commits
-
-
Rob Buis authored
Remove 'lengths-2.html' from test expectation file since it started passing recently. Bug: 6606 Change-Id: Ib3a849f26fda7d343eee66106801bf8dc828961f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359037 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#798737}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/abe07b943855..e7cd224e55fa 2020-08-17 capn@google.com Don't rely on VectorType::get() default parameter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If61c65b68bdf2cb1f8f2e0894d4ecf965a312fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798736}
-
Omer Katz authored
Visiting an ephemeron pair checks if the key is alive. It did not check if the key was in construction. If that check happens on a concurrent thread (that didn't happen to mark the key before) then there is no sync between the threads (the in construction check is generally used as the sync) and the is a data race between creating the key and concurrently checking if it's alive. This CL adds an in construction check for the key as a sync point. If the ephemeron key is in construction, we treat it as marked and trace the value (the key will be marked by the end of GC). This allows concurrent marking to handle the value rather than leave it for the mutator thread. The key is marked either by the write barrier when pushing it to the HashTable, as a previously in-construction object if we get a marking step with no stack, or conservatively during the atomic pause (if it's not marked by regular marking). Bug: 1116801 Change-Id: I2b75bbca3a8986285c905eb024560c4ad2525826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358744Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798735}
-
Olivier Li authored
Bug: 1087530 Change-Id: Ibd93974dfa6563a42e9e12133fe6d61bd5628a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342250 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798734}
-
Theresa Wellington authored
Consider tabs still being restored in the total incognito count stored in the tab state metadata file when serializing. Also group ids/urls for tabs still being restored with their respective models. BUG=1111594 Change-Id: I85482d4f9cc936966a8aaff672b49cb1a839cd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358380 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#798733}
-
Dirk Pranke authored
At some point initially (I think)? chrome_elf_unittests was a very thin binary that could not link in //base/test/launcher to run as a regular chromium gtest-based test. However, that appears to have changed quite a ways back is a regular chromium gtest-based test. However, it was still configured as a "raw" test, which meant that we could only look at the exit code from the test and not rely on it conforming to the normal chromium gtest command line API. This CL fixes that. Bug: 816629 Change-Id: I184af40d56feb01050a2ddcec020827250a51b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354664Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#798732}
-
Swapnil authored
Field name for downloading stage should be in sync with the server side proto. It is |downloading_stage| on the server side, hence the field name on client side should be downloadingStage. Currently it is downloadStage. For reference, server side proto is: https://source.corp.google.com/piper///depot/google3/chrome/cros/reporting/api/proto/extension_install_events.proto;l=55?q=chrome%2Fcros%2Freporting%2Fapi%2Fproto%2Fextension_install_events.proto&ct=os&sq=package:piper%20file:%2F%2Fdepot%2Fgoogle3%20-file:google3%2Fexperimental Bug: 1108257 Change-Id: I4f5826beb1ea9e54b094b7a598966f72e3e8895b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356385Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#798731}
-
Xianzhu Wang authored
Previously it returns thinkness in DPI (or window length), and the callers may scale it to a viewport length, but sometimes the scale was missing, causing the scrollbar to be too thin in highdpi and other bugs. Now let all ScrollbarTheme methods use viewport lengths. This fixes bug 1049412, and other bugs, such as - scrollbar margin was not adjusted for highdpi; - thumb minimum length was not adjusted for highdpi; - default width of LayoutTextControl didn't consider highdpi for the hypothetical vertical scrollbar. Bug: 1049412 Change-Id: Id7281db8e96f78db7c9a6633a1b43dc160da6f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358995Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798730}
-
David Black authored
Conditions are: - Onboarding feature should be targeted to "new" users - "New" users are users who haven't interacted w/ Assistant in 28+ days - Once shown in a user session, we should continue to show onboarding in that user session until an Assistant interaction takes place - Once shown in any user session, we should continue to show onboarding in each subsequent user session until we reach a maximum of 3 This CL also deprecates Warmer Welcome which is being replaced by the new onboarding feature. Bug: b:157510970 Change-Id: If60ac0e9f7d87aaf2240e76a5ba4e5fe06e8dd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324801 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798729}
-
Sophie Chang authored
Bug: 1113287 Change-Id: I0dd3b14bc9538b71686e9dbac9b258eaec0a2015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356749Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798728}
-
Victor Costan authored
Change-Id: I472582eaea658d2ee8a4c157a0161611d2aca2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359229Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798727}
-
Alexander Timin authored
This reverts commit 19a1e60d. Reason for revert: crbug.com/1117192 Original change's description: > Add tracing support for mojo handle kinds > > Support tracing of mojo handle and remote/receiver kinds. Thus provide > more precise debugging information for developers. Also avoid > generating fallback literals for base::trace_event::ValueToString. > > Bug: 1103623 > Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005 > Commit-Queue: Karel Král <karelkral@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798588} TBR=rockot@google.com,altimin@chromium.org,karelkral@google.com Change-Id: I3fc0ca207c2b99324083c8f512903cf74757f8bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359083Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798726}
-
Philipp Hancke authored
BUG=webrtc:6625 Change-Id: I840ccfe138b544ba4956eda6382ac4f3897a8720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352807 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#798725}
-
Victor Costan authored
Bug: 1000959 Change-Id: Ia0bed864089e14ad413a409fb646706b17cc96fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359232 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#798724}
-
anthonyvd authored
This reverts commit a0c9fe7f. Reason for revert: Appears to be the culprit for https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14160? Original change's description: > Adding androidx.window to android_deps > > Also fixes warning in android_deps where buildCompile or test targets were > triggering vulnerability errors when they aren't shipped. > > androidx.window is being added to implement Web APIs related to dual screen > and foldable devices. See: > https://groups.google.com/a/chromium.org/g/blink-dev/c/_1_ljYsaqrU/m/qOoHJ7MhAgAJ > > TBR: OWNERS check broken for new android_deps OWNERS file > Change-Id: I350a1f464be2ecb0111004c89aaa87477c7e7e96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354599 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798709} TBR=yfriedman@chromium.org,wnwen@chromium.org,smaier@chromium.org Change-Id: Iea77c415621965f007da4eb7f322d0332eb6214e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358587Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798723}
-
Ian Clelland authored
The 'none' default allowlist has been removed from the spec, as it was never used, and further spec changes have made it unlikely that it will be usable in the future. Bug: 1095641 Change-Id: Ib7b5eae2e022f726dc6dc616ef3382f2d82861df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354419Reviewed-by:
Charlie Hu <chenleihu@google.com> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#798722}
-
Yuke Liao authored
This CL makes views_unittests and extensions_unittests to run in non-experimental mode so that it's Sheriffed to prevent regressions. Bug: 1111979 Change-Id: Ifb403b5a63fe2a7424445a32006ce919972f5fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358055 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798721}
-
Robert Ogden authored
If a prerender finishes after a navigation, the page_ is no longer the correct one. Adds an early return case from the previous DCHECKs. Bug: 1116966 Change-Id: Iee1ca67d1a257a2390ff372dff94634db079197c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359552 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798720}
-
Egor Pasko authored
This reverts commit db50a5ab. Reason for revert: Regression on a few metrics: http://crbug.com/1116715 Original change's description: > fieldtrial_testing_config for DiscardCodeCacheAfterFirstUse > > We intend to make a wider rollout/experiment of the feature to discard > the code cache. No changes are expected in the lab. Update the config to > confirm no effect on bots. > > Bug: 1045052 > Change-Id: I5c0a6443f9cefac93391d957a1fcefffc72adea3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356709 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798280} TBR=pasko@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045052 Change-Id: Ie0d3d9c45320bd61a6959f467185b72596dc439c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358833Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798719}
-
Joe Mason authored
R=chrisha Bug: 1080672 Change-Id: I4b24d1e77e9dcc228d606f6d484127b04ca0dadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339219 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#798718}
-
Hoch Hochkeppel authored
Adding a new feature flag to allow enabling the WebShare functionality on the platforms (OS and Chrome OS) where it is being actively developed. http://crbug.com/1035527 Change-Id: I5cd9274457c86c957360ff7e6a0b61f1c474e124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357091Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798717}
-
Peter Kasting authored
Bug: 1116440 Change-Id: I969ef6466a56fdd8d4d76cc2d8abbeeeff830536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356969 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798716}
-
Henrique Nakashima authored
This allows the recipe to specify which gn should be run. Bug: 1098864 Change-Id: Ia7d770b1783ca4d0d44596f7f82481f92da8d16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357453 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#798715}
-
Charlie Hu authored
Previously, boolean PolicyValue is missing a constructor with type specification on PolicyValue class. It caused some inconvenience on code generation and testing. With the introduction of enum PolicyValue, this becomes more obvious because enum type's constructor also comes with a type parameter. In order to simplify the codegen and testing logic, this CL adds a dummy constructor for boolean type PolicyValue. Note: the constructor with type parameter aims to distinguish policy values that have same C++ type representation but different policy value type, e.g. IncDouble and DecDouble, Enum and Int. Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#798714}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c4380f2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I4ef0f8a93b00f250a20106dadd0ac3dfda806d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358585Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798713}
-
Philip Rogers authored
This patch extracts out the stacking context grouping properties from ComputedStyle::HasGroupingProperty, and uses this for the stacking context decision. This has the effect of not creating a stacking context for clip which, unlike clip-path, does not create a stacking context: https://drafts.fxtf.org/css-masking-1/#propdef-clip Bug: 1115003 Change-Id: I4bd5d3c61a2bb34a56a089cbeaca260fc9bf2eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358473 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798712}
-
Victor Hugo Vianna Silva authored
Before the CL, the class-level documentation affirmed that simply adding a kTestType switch to the CLI would cause this factory to replace the ChromeWebUIFactory. This was true when it was first introduced [1] but nowadays it seems that users have to replace the factories by hand (see the 7 callers of the constructor). [1] https://codereview.chromium.org/6992019/diff/10003/chrome/browser/ui/webui/chrome_web_ui_factory.cc Bug: None Change-Id: Ic9413976b1fd6eb8b1e5ce8c58112629471143c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360270 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#798711}
-
Ken Rockot authored
This corrects some deficiencies in the Storage Service's sandboxing support by eliminating all remaining instances of direct filesystem traversal within DOM Storage, replacing them with appropriate FilesystemProxy usage. A few new IPCs are added to the Directory mojom interface in support of this, and a new delegate is added to support use of sql::SandboxedVfs with a FilesystemProxy backing it. Bug: 1052045 Test: content_browsertests with StorageServiceOutOfProcess and StorageServiceSandbox enabled Change-Id: I8e7593d9424be705cb3c2bf561a4fe4c5d61251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350542 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798710}
-
Sam Maier authored
Also fixes warning in android_deps where buildCompile or test targets were triggering vulnerability errors when they aren't shipped. androidx.window is being added to implement Web APIs related to dual screen and foldable devices. See: https://groups.google.com/a/chromium.org/g/blink-dev/c/_1_ljYsaqrU/m/qOoHJ7MhAgAJ TBR: OWNERS check broken for new android_deps OWNERS file Change-Id: I350a1f464be2ecb0111004c89aaa87477c7e7e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354599 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#798709}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4232.0-r1 to 86-4183.59-1597659923-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I48162ae3c8d57702f9a924aa8da0ad7895352546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798708}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4232.0-r1 to 86-4183.59-1597657121-benchmark-86.0.4232.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If2e8c35f1f41d02464479dc4be66a5ac2df8041e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798707}
-
Alexander Dunaev authored
The recently landed change [1] has introduced a pure virtual method for ui::Clipboard on Ozone, which has broken the hybrid build that has USE_OZONE and USE_X11 set together. This CL fixes that by adding a stub implementation of that method to ui::ClipboardX11 with Ozone enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2307234 Change-Id: Ia93c8b488f7ffd2009200f894acd6d77ccdb1351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346671Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#798706}
-
Daniel Cheng authored
Change-Id: Id6929dd6a8e36813bdfa480ff227409cc3a1f760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359154 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#798705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3bd3c99b4d5c..b93d82c4c5a8 2020-08-17 pfagerburg@google.com my_activity.py: add coreboot gerrit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ib0ecb837876e08087b8c8332e3b5f65a66fc3dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798704}
-
Matthias Körber authored
Adds logic to merge the names stored in a local and remote profile. Adepts the bridge util tests to work with structured names. Change-Id: Ide42931f3f36809b9f72a666e2941ce1418f040d Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358672 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#798703}
-
Peter Kasting authored
Mostly these want to be OnceCallbackList, which didn't use to exist. Bug: none Change-Id: I5ff42f68fb391ce7cee6fe02cf3aed508e1e89e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354805 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#798702}
-
Malay Keshav authored
This patch adds trace events using GPU timer queries to measure the composite time per frame. The trace events are per quads and uses the ready timestamp to synchronize with the trace timeline. NOTE: This only works on intel mesa based devices. Other drivers may not work as expected. Bug: 1092700 Test: Manually ran trace events on atlas device. Change-Id: I1c8ee41e2c769129e28a9a3d28bfe77dd1ddd8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284010Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#798701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/866d2894ebd1..5cfa7194d55e 2020-08-17 nigeltao@google.com Drop support for Wuffs v0.2 2020-08-17 johnstiles@google.com Simplify SkSL::String by removing unused parts. 2020-08-17 reed@google.com Migrate to using SkPathBuilder 2020-08-17 robertphillips@google.com Better encapsulate the GrDrawOpAtlas w/in the GrSmallPathAtlasMgr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I9dc02d126f35440c23f1d537c54aae16b89b4f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798700}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib89e59df47b8994a269fe4fe33bd8fda718f473b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798699}
-
Roman Aleksandrov authored
This is a reland of 67a4df6f CL was reverted cause of failing chromeos-betty-pi-arc-cfi-thin-lto-chrome due to reaching deadline on one of the tests. This is gonna be fixed by increasing time limit. See details here: https://crbug.com/1116379 Original change's description: > LoginScreen: Show TPM lock status. > > If TPM is locked show banner with steps on how to fix this issue. > > Bug: 1114656 > Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#797992} Bug: 1114656 Change-Id: Iba50daf1d1b892539e00d9be04fc2b8c0a5a279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359992Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#798698}
-