- 05 Jun, 2019 40 commits
-
-
Peter Wen authored
3.6 Canary 2 is now available on gLinux. Tbr: agrieve@chromium.org Bug: 620034 Change-Id: Id62c9bfb42ad902636cb655266e9abb2333558db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645384Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666348}
-
Chase Phillips authored
This is meant to be a no-op change which allows an IDBRequest to no longer have an associated callbacks object when the request response handling is initiated. It's a no-op because currently HandleResponse() only results in (maybe) an event being enqueued with no real immediate dispatching of the event. A future change will switch event enqueueing to instead immediately dispatch in some cases, and at that time it will be necessary for the request to have its callbacks object detached to properly handle the event. Bug: 965136 Change-Id: Iaddc0254234b6ba2985f324f21fef2841e8bcf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639155Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#666347}
-
Miguel Casas-Sanchez authored
A gbm_device must be closed using gbm_destroy_device(); this CL introduces ScopedGbmDevice with a custom deleter that does just that, and uses it in the place where it's needed now -- I'll also use it in crrev.com/c/1635929 imminently. Bug: 970923 Change-Id: I954c1f4bfdf0d6ca8ef91f336eb21fc2d255ee6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643684 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#666346}
-
Jan Krcal authored
This CL removes ProfileSyncServiceAutofillTest and all its dependencies not used elsewhere. The same functionality for the fully launched USS implementation is now tested in AutofillProfileSyncBridgeTest. Bug: 836718 Change-Id: I5b6f9372c1ee7aa17ffe385f5275efbee85a4543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642548Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666345}
-
Eugene But authored
This function always returns true, so the result was inclined in toolbar_egtest.mm. EG2 Tests can not import ios/chrome/browser/ui/util/ui_util.h (which declares IsRefreshLocationBarEnabled), so the function had to be removed. Bug: 884723 Change-Id: I7ab40c5016ca2b17c95d4fd6294df67cdcc55d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642111Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666344}
-
Kyle Horimoto authored
This CL hooks up the StartActivation() call with OtaActivatorImpl. With this CL, the flow is ready to be used by the WebUI dialog. This CL also adds virtual inheritance for FakeCarrierPortalHandler to ensure that we avoid the "diamond problem" for multiple inheritance. Bug: 961084 Change-Id: I79e0e583d6ed3fade8961f6c82241020394945e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629788 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666343}
-
Eugene But authored
These includes can not be compiled with EG2 so they should be removed. Bug: 922813 Change-Id: I60137b39e7b882d8224280ac7e77a8e832652370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639670Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666342}
-
Min Qin authored
DataObjectImpl::OnDownloadCompleted() in os_exchange_data_provider_win.cc will reset the StoredDataInfo object. And this object has a scoped_refptr to the DragDownloadFile. So DragDownloadFile could get deleted right after this call. This CL fixes the issue by not calling any further method after OnDownloadCompleted. BUG=968303 Change-Id: I61b99264767e00df33141ed3f9090dfeff554c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644147Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666341}
-
Robert Liao authored
BUG=937566 Change-Id: I412c5e383e454e375ba3b10fcec05058b7347422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644319Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666340}
-
Eugene But authored
This file is already EG2 compatible. Bug: 922813 Change-Id: Ib5b072dd7d1a3973017c2ee490c5d7e42dce335d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643239Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#666339}
-
Sigurdur Asgeirsson authored
This is the document I wish I could have read rather than all the implementation. Maybe this will save others time in the future. Change-Id: I1858808ba4cce584625325fea383a5b2332da395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635414Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666338}
-
Pâris MEULEMAN authored
The main purpose here is the refactoring of the almost identical RegisterAndFetchPolicyBeforeSignIn and isUserManager. This brought some simplification on the java code, with the removal of the native call to ShouldLoadPolicyForUser. Bug: 963400 Change-Id: I828f9a328bc153ebc6325f194fb34206bbe40e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628721 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666337}
-
Jose Dapena Paz authored
Other HasFraction methods as in PhysicalUnit are declared already constexpr and using it. It breaks GCC build. Bug: 819294. Change-Id: I0c4bd9bd206d45cf31f7fa815ce8533718a425cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645222Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#666336}
-
Takumi Fujimoto authored
Enable the features in tests in waterfall. Disable DialMediaRouteProvider in unrelated tests that fail because of it. Bug: 956609,956621 Change-Id: I930296900b4f452652785892e73d9860814aff88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620548Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#666335}
-
Navid Zolghadr authored
Add callback supports to the RenderWidgetTargeter and use the async targetting in drag and drop code and register a callback to send drag events using the callback. Note that since drag and drop events aren't WebInputEvent it is not possible to use FindTargetAndDispatch function of RenderWidgetTargeter at this time. The original CL https://chromium-review.googlesource.com/c/chromium/src/+/1596840 was reverted due the added test being flaky. This CL is the same as the original CL expect it has the same test with another way of checking the logic. TBR=sadrul@chromium.org Change-Id: I95ac25a554a2964c3c5a0ebeee97b4d041d74a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642979Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666334}
-
Jesse Schettler authored
WebContents::GetDelegate() can return nullptr when handling a keyboard event. BUG=b:64863368 TEST=While browsing a PDF with an ARC Custom Tab, press Ctrl and verify no crash occurs Change-Id: I113a41d23f27409d52bcfe313cb4142f7562f905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645816Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#666333}
-
Kyle Horimoto authored
The "configure network" dialog displays a configuration error in some cases when it should not. This was caused by the fact that we were inspecting the last_error attribute of NetworkState, even if there is no current error. To fix this issue, I removed the NetworkState::GetErrorState() function and updated clients to simply call the error() function instead. Bug: 968474 Change-Id: I2d351057ec8b0d2d35a0ea8a46a4515413bec9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642692Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666332}
-
Natalie Chouinard authored
Fix issue with support library Fragment constructors being removed by Proguard when they are only used through reflection via Fragment.instantiate. Bug: 969590 Binary-Size: Expecting to recoup some once all Fragments are migrated Change-Id: I14f92ad651069bde7212ce20e6f7b934f2f49232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641443 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#666331}
-
Joshua Pawlicki authored
The verifier will work with both crx2 and crx3 (at least, until crx2 is gone forever...) Bug: 970891 Change-Id: I85665748a816e952f80df6e5509fb71fc0743d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643353Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#666330}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961073,969812 Change-Id: Iff5ca80465118a03cb6d5b544ad67acc7b22b9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640784 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
ListHashSet is deprecated in favor of LinkedHashSet. HeapLinkedHashSet's invalidate iterators when the container is modified. This does not happen in this usage, so replacement is simple. Bug: 614112 Change-Id: I43ed7c4c12ed5b1c6cdb369210a60c3da2358bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641162Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#666328}
-
Xiyuan Xia authored
- Replace ShutdownController mojom interface with cpp; - Current ShutdownController -> ShutdownControllerImpl; Bug: 958217 Change-Id: I53a78b3366934aeaf2da36d39d889e0b73801f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643985 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#666327}
-
Kurt Horimoto authored
crrev.com/c/1529921 resizes the WebViewContentView to match the CRWWebControllerContainerView's frame when it's added to a new window. However, BVC resizes the container view to match the content view bounds in |-displayWebState:|. The frame was later reset by the fullscreen resizer when BVC.broadcasting is reset to YES when the animation finishes. This CL updates |-displayWebState:| to account for the current viewport insets so that the frame remains constant during the settings dismissal animation. Bug: 963108 Change-Id: Ifd44277f7c88bfea60e292387468483a521e5f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644419 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
John Emau authored
This change updates our eslint configuration to parse ECMAScript 9 syntax which includes the object literal spread operator. Change-Id: I9fadc40b2832e92a32f4ee94fddaf9c719046413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639178Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: John Emau <johnemau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#666325}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I50319fd4bfe60035d1c4535ec971692bbfb2428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666324}
-
Robert Liao authored
BUG=937566 Change-Id: I43e91f3b8b35cb44e9463f417522fdb28cee0ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642241 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666323}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961068 Change-Id: Idf3c932175ebf7d17187648fd508e471f06c40ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640781Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666322}
-
Robert Ma authored
wptserve (especially its pywebsocket component) produces too many log messages to stderr which can block the pipe since the parent process (wptserve.py) does not read from the pipe until the server exits. This change redirects the stderr of wptserve to a log file (in a way that's still compatible with the error logging and cleanup logic in ServerBase, see _log_errors_from_subprocess and _remove_stale_logs respectively). Bug: 968904 Change-Id: I08200bf7d895c844652cd50e627e270671f25369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641436 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#666321}
-
Robert Liao authored
BUG=937566 Change-Id: If69c7186b7870369f179cf72ba42b65d8e808160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644460 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#666320}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961064 Change-Id: I1aa3f6165fdc264b1cfdd7ae20b4fc354495c19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639052 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#666319}
-
Min Chen authored
1. Extend the expires time of 'Power.PowerButtonMenuAction' by some branches. 2. Add label for feedback source type kFeedbackSourceAssistant, which might be missed while adding the type. Bug: None Change-Id: I088f8a9041b6d293bad64469d2a72dc1da050f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643499 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666318}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2f31cc65dea..075cb05bdeb5 git log d2f31cc65dea..075cb05bdeb5 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 jbudorick@chromium.org tryserver: add a 10 minute timeout on fetching CL info from gerrit. Created with: gclient setdep -r src/third_party/depot_tools@075cb05bdeb5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7126b721a096019ceed371b2fa5c3db687b8f210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645794Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961075 Change-Id: Ib3c729da5cf45d77c9130f66cedb911434ccd03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641562 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#666316}
-
Xida Chen authored
It appears that this expected.txt is causing the failure on Mac: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/23664 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/12244 Deleting this should work. Bug: 968791 Change-Id: I6134b3c67fa38a316b66ab97be2eb7a46525d364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645378Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666315}
-
James Cook authored
The color computation tries to inset its samples by 1 pixel on each edge, but that doesn't work for 1 pixel wide images. Skip the inset if the image is too narrow or too short. See bug for details. Bug: 970343 Test: Added to gfx_unittests Change-Id: If558a8bbacb27d9011da93868ad3b6f0e72f8754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644299 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
about://gpuMaggie Chen authored
Some gpu bugs are related to the monitor refresh rate. Adding this display information will help us on gpu debugging. Bug: 964095 Change-Id: I54d468dd192110a77f2aa46f7d441ed257f06491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644232Reviewed-by:
-
James Cook authored
Follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/1640601 Remove unused C++ message handlers: * Search engines * Fonts * Import browser data None of these are used in OS settings. Bug: 960937, 950007 Change-Id: I8a74207f03d2ed66cbf919dfa16cbe6dce04b8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645131 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#666312}
-
Bill Orr authored
The output XML contains a relative path to the mojom file. On Windows, the expected path contains '\' separators, but the actual contains '/'. tools/metrics/histograms/update_use_counter_feature_enum.py will update the enums.xml file, but uses a hardcoded path. The fix is to use a hardcoded path for third_party/blink/public/mojom/web_feature/PRESUBMIT.py as well. Bug: 966496 Change-Id: Iad605bea175ee86abe7bb8c160ae2be30bf8f65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627636Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#666311}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 961029 Change-Id: I189cfe1a129ed7af4f87d256e3ecf1d9d84a392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638920Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666310}
-
Michael van Ouwerkerk authored
Bug: 969978 Change-Id: I320b622be2113fb3b6edb98e48e9178c92c826b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645304 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#666309}
-
