- 09 Nov, 2018 40 commits
-
-
Qiyu Hu authored
A relevant patch is ag/5473995. Bug: b:111367421 Test: build Change-Id: Icdf9cf1dcd6b391ef4190c4fac89c00ef3fddb54 Reviewed-on: https://chromium-review.googlesource.com/c/1327332Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#606935}
-
Katie D authored
Uses a drop-down rather than a slider or text field because this seems like it would be easier for Autoclick users to activate. This still needs UI review but is hidden behind the --enable_experimental_accessibility_features flag. Bug: 894907 Change-Id: If4de66488df32ea2929961159ebfdaad15216f55 Reviewed-on: https://chromium-review.googlesource.com/c/1324376 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606934}
-
Henrique Grandinetti authored
Bug: 899980 Change-Id: I4916f6e284a1fd0a99fff2c9d60535a389fb4655 Reviewed-on: https://chromium-review.googlesource.com/c/1329082Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#606933}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/63924982b3fd..ffec6a8edd68 git log 63924982b3fd..ffec6a8edd68 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 wutao@chromium.org Make tricky-chrome-pfq important Created with: gclient setdep -r src/third_party/chromite@ffec6a8edd68 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id0f114f713ec094b9d39c6f1e09c2cf67d57c297 Reviewed-on: https://chromium-review.googlesource.com/c/1329982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606932}
-
Vaclav Brozek authored
Chrome currently won't autofill credentials into forms which have a "new-password" field. A better criterion seems to be: only fill into forms with a "current-password" field. This CL adds a UKM metric to understand the impact of such change. Privacy review of this metric: The whole UKM event "PasswordForm" has been reviewed in crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding new metrics for this event is OK under certain conditions (see the linked doc). The new metric, which measures changes to filling on load of forms for which the user previously stored some credentials, satisfies such conditions, in the opinion of the CL author, and hence is covered by that review. The new metric has been added to the requested spreadsheet listing all passwords-related metrics. Bug: 895781 Change-Id: I8bb6537f97c96d0ed345d885a7ddd7c065370b22 Reviewed-on: https://chromium-review.googlesource.com/c/1326497Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606931}
-
David Benjamin authored
This causes Write to block on the ServerHello, which is a somewhat interesting I/O pattern. Bug: 641225 Change-Id: I0faf9783cf027848e832c091032e5cd0efa2ceee Reviewed-on: https://chromium-review.googlesource.com/c/1285449 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606930}
-
John Abd-El-Malek authored
r603810 recently turned on the IO checks for ChromeOS browser tests. Change-Id: Iaf3c654361a0502d5069a5e90a494d78df90ee90 Reviewed-on: https://chromium-review.googlesource.com/c/1329882Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#606929}
-
Vlad Tsyrklevich authored
Use Chromium's allocator shim interface to create a shim that samples allocations to the GuardedPageAllocator. Add a function to enable GWP-ASan that checks various feature flags to see if GWP-ASan should be enabled and with what parameters. In order to optimize the allocation hot-path, sampling is performed using a thread-local counter to avoid contention. The sampling interval is sampled from a poisson-distribution with a supplied frequency. In order to optimize the deallocation hot-path, the GuardedPageAllocator bounds are stored in global variables and the bounds check referencing those globals are inlined into the deallocation routine to avoid the indirection of accessing GlobalPageAllocator::PointerIsMine through a singleton. Bug: 896019 Change-Id: Id389d95a23067e2518cd58316db7b12935ec84af Reviewed-on: https://chromium-review.googlesource.com/c/1306401 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606928}
-
Miguel Casas authored
This CL follows crrev.com/c/1056168 and removes |image_id_| from CanvasResourceGpuMemoryBuffer, since it's not needed (it was mentioned in that CL description but finally not removed). Bug: 839970, 903837 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7540363f131e3a33609c945e68c8106992e0ba77 Reviewed-on: https://chromium-review.googlesource.com/c/1130170Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#606927}
-
Jesse Doherty authored
Use the size of the staged log instead of the size of the hash to check if it should be uploaded on cellular. Bug: 902465 Change-Id: Ic7ffe0c5d5639b99f590c4ad7ebbf334254ea05f Reviewed-on: https://chromium-review.googlesource.com/c/1329501 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#606926}
-
Tarun Bansal authored
Skip iframe elements when predicting the next navigation. Change-Id: I2720ad4e59b70ca40a385e966e4c38844c83a1e2 Bug: 903884 Reviewed-on: https://chromium-review.googlesource.com/c/1328708Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#606925}
-
Akihiro Ota authored
Added functionality to set the isContentInvalid attribute of NodeAccessibilityInfo, with the larger goal of exposing this information to TalkBack. Added a test to check the presence of this attribute in an invalid editText object. R=dmazzoni@chromium.org Bug: 847233 Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db Reviewed-on: https://chromium-review.googlesource.com/c/1320219Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#606924}
-
David Benjamin authored
This avoids depending on the name of the C struct. BoringSSL already provides a header with forward declarations. Change-Id: I0187f4c51c674746d5926b372ab48ea0e72eae4e Reviewed-on: https://chromium-review.googlesource.com/c/1287044Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#606923}
-
Martin Kreichgauer authored
This reverts commit bb253c29. This is a reland of the original breaking commit, d0392055, with a fix for the build failure. Bug: 898718 Change-Id: I0e14e97861d060bb6378dc6ad43ca52806812f1e Reviewed-on: https://chromium-review.googlesource.com/c/1328232 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#606922}
-
Xianzhu Wang authored
Previously PaintChunk::hit_test_data was updated only in HitTestData::RecordHitTestRect(), so when we copied cached subsequence, the PaintChunks didn't have hit_test_data. Now add HitTestDisplayItem to store the hit test data in display items, and update PaintChunk::hit_test_data in PaintArtifact constructor. Change-Id: I8a96823f15c0107fc21e5b388763ebfc3925eef0 Reviewed-on: https://chromium-review.googlesource.com/c/1325570 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606921}
-
Kristi Park authored
Remove the Most Visited 'loaded' event listener after the 'loaded' message is sent. This was interfering with other domAutomationController listeners in subsequent script executions. Bug: 903265 Change-Id: Iccd33d3eb04330a23880735b48a00d2f97a50866 Reviewed-on: https://chromium-review.googlesource.com/c/1327425 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606920}
-
Tom Tan authored
Some assembler directives are OS specific, like .type and .hidden only make sense in ELF. They are not valid for Windows ARM64 even with the same assembler syntax. This change defines macro to select directives according to target OS. This looks like a convention for assebmly source code. Bug: 893460 Change-Id: I7b5a8dc1648987932f11422d3b393513b6b69fbe Reviewed-on: https://chromium-review.googlesource.com/c/1327884Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#606919}
-
Roman Aleksandrov authored
Just simple refactoring. Bug: 792774 Change-Id: I90e97fb8fd4e1ab5bb91f03b19ec8031eeb24375 Reviewed-on: https://chromium-review.googlesource.com/c/1326145Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#606918}
-
Michael Lippautz authored
Bug: 902286, 843903 Change-Id: I2f4a836bfb448e092a7301a326c0caed722d607e Reviewed-on: https://chromium-review.googlesource.com/c/1329175Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606917}
-
Bailey Berro authored
Adds is_chromeos checks to the build files for the add-smb-share-dialog Bug: chromium:887135 Change-Id: I7ba729324c9e523f82924927f6eab86be8e4247f Reviewed-on: https://chromium-review.googlesource.com/c/1323806Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#606916}
-
Sky Malice authored
Bug: 901331 Change-Id: I597c20c8726c0d25c37de04c1001502e535bf6f5 Reviewed-on: https://chromium-review.googlesource.com/c/1318831Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#606915}
-
Katie Dillon authored
Missed changing these two perf tests while making this change: https://chromium-review.googlesource.com/c/chromium/src/+/1318390 Bug: 903445 Change-Id: I8d151bfc464aae4cc1d0bd8fa993607cde25d18d Reviewed-on: https://chromium-review.googlesource.com/c/1327524Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#606914}
-
Sadrul Habib Chowdhury authored
Report when the presentation-timestamp reporter by the driver is earlier than the swap-time. Report this metric on all platforms. Change the metric for reporting presentation-timestamps from the future to be reported on all platforms (instead of just android). This also removes DumpWithoutCrashing() for the future-timestamps. BUG=894440 Change-Id: I663fdeab41b3f7de3e76f0e0ae440efbdae79bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1325417 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#606913}
-
Sergey Poromov authored
Together with CRX_INSTALL_ERROR_* reason, the details of the failure are reported in a separate "Extensions.ForceInstalledFailureCrxInstallError" histogram. Bug: 787970 Change-Id: Icd76bf2f1b15f219aa99f37385e77a63eb3573f2 Reviewed-on: https://chromium-review.googlesource.com/c/1323652Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606912}
-
sczs authored
Since the InfobarView is no longer communicating its size to Infobar.cc there's no need to have the machinery necessary so Infobar.cc communicates with our InfobarContainerView. The InfobarContainerView will be updated via the VC viewDidLayoutSubviews which was the change made on https://crrev.com/c/1321849/ Adds an extra test case. Bug: 892376 Change-Id: I5457c17a8e1e586b02b5ca9906abd4341e5a56d4 Reviewed-on: https://chromium-review.googlesource.com/c/1325034Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606911}
-
James Cook authored
Ash has a transitive dependency on the device fingerprint service, so the test-only ash_shell_with_content won't start up without declaring that requirement. Bug: none Test: run ash_shell_with_content, it starts Change-Id: Id8acd41c154738a9470b8b19f63da93fede1740f Reviewed-on: https://chromium-review.googlesource.com/c/1329623Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#606910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5fc6c2c52e7b..7b37bbfad45f git log 5fc6c2c52e7b..7b37bbfad45f --date=short --no-merges --format='%ad %ae %s' 2018-11-09 lalitm@google.com trace_processor: fix ordering of slices in trace storage Created with: gclient setdep -r src/third_party/perfetto@7b37bbfad45f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2743499d550e8c172a3ef0bc894051d09c8515b8 Reviewed-on: https://chromium-review.googlesource.com/c/1329981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606909}
-
Vlad Tsyrklevich authored
TBR=caitkp@chromium.org Bug: 896019 Change-Id: I59ead55fbc258d981092c7e99d935a2a518a8921 Reviewed-on: https://chromium-review.googlesource.com/c/1324873 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606908}
-
Mike Wittman authored
Starts sending a small amount of data using the new format written by the new profile builder, for initial testing. Bug: 851163 Change-Id: I1b8f5adae4ac5eeed2ab30e79e49790b5916f6dc Reviewed-on: https://chromium-review.googlesource.com/c/1327808Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606907}
-
manuk authored
Bug: 891303 Change-Id: I682561e9427a0f2dedf356744bc66d28eff64ccb Reviewed-on: https://chromium-review.googlesource.com/c/1329444Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606906}
-
Ehsan Chiniforooshan authored
The flags were accidentally removed in crrev.com/c/1318395. Bug: 903312 Change-Id: I89c20ceb807bb68ebb35f24bccf83fbc9482a117 Reviewed-on: https://chromium-review.googlesource.com/c/1329548 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#606905}
-
kylechar authored
If we don't have a valid shared memory handle return early and don't try to map the memory. Also move check for duplicated ids earlier in the function. Bug: none Change-Id: I53b113cc3da2149d15fa70afa8bc8d52bc362e8d Reviewed-on: https://chromium-review.googlesource.com/c/1326842 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606904}
-
Xiaohui Chen authored
Bug: 870515 Test: locally build and run Change-Id: Ic2b5be8d7ff3bf694ddbb8cb29511b3bb5ad610e Reviewed-on: https://chromium-review.googlesource.com/c/1318691 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606903}
-
Ivan Sandrk authored
One of the new disclosure strings on the login screen was deemed a bit too strong on the words and was causing people to be distressed, therefore we are reverting it to the previous version. Bug: 903810 Change-Id: I761b978fb553024bcfb2ac2efd7e208d513ee703 Reviewed-on: https://chromium-review.googlesource.com/c/1329781 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#606902}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5a766d7. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I5d99a196dac4514f62d75d2ea68d038358c7fd12 Reviewed-on: https://chromium-review.googlesource.com/c/1329441 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606901}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=sky@chromium.org Bug: 766678 Change-Id: I3b6193072a7049433d38a61ff62c1f34454c7b5e Reviewed-on: https://chromium-review.googlesource.com/c/1324454 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606900}
-
Steven Bennetts authored
This CL moves SendKeyEvent to ChromeVirtualKeyboardDelegate which is the only place it is used. It also: * Uses aura::EventInjector instead of EventSink::OnEventFromSource so that events will be injected properly in Mash. * Removes the undocumented histogram (without documentation it is very unlikely that it is used): VirtualKeyboard.KeystrokesBetweenBackspaces Bug: 876138 Change-Id: I39836f5593587c32ccb229ca32a2126199500533 Reviewed-on: https://chromium-review.googlesource.com/c/1313208 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606899}
-
Yi Su authored
This CL let iOS SearchEngineTabHelper extend FaviconDriverObserver so that it has equivalent functionality as the SearchEngineTabHelper in /chrome/browser/ui/search_engines. Bug: 433824 Change-Id: If49d1b46d90b2250c2b378d77d9e3cea5cdd96a5 Reviewed-on: https://chromium-review.googlesource.com/c/1329171 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#606898}
-
Arthur Sonzogni authored
This reverts commit 4ff885a1. Reason for revert: CHECK not reached. The URLLoader to blame was the WebRequestProxyingURLLoader. Original change's description: > BlobUrlLoader: Instrument for bug 882661. > > In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody > without sending OnReceiveResponse before. > > Add instrumentation to check this never happen with this class. > > Bug: 882661 > Change-Id: Ia9df5debbc03f0a5296c64edbcf6d975806bc021 > Reviewed-on: https://chromium-review.googlesource.com/c/1304435 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605181} TBR=kinuko@chromium.org,mek@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882661 Change-Id: I16e8a5709f34d6909445c9cb0f674f07702ff594 Reviewed-on: https://chromium-review.googlesource.com/c/1329782Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606897}
-
Douglas Creager authored
Piece by piece, we are moving the Reporting and NEL processing code from URLRequest and friends into HTTPNetworkTransaction, to make sure that we produce reports for network requests as defined by the spec (e.g., for redirects and cached responses). This patch moves the processing of the Report-To configuration header. Bug: 895823 Change-Id: Id6f51eefdb9afc43ad3841fb3c3f6d6b39fd2943 Reviewed-on: https://chromium-review.googlesource.com/c/1293555 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#606896}
-