GitLab

Currently UiElementContainerView does not auto scroll when the focus in the
AssistantCardElementView changes, e.g. during Tab traversing.
This patch surfaces the OnFocusChangedInPage event from WebContentsImpl
to NavigableContentsObserver, so that the UiElementContainerView can do
scroll accordinglly.
In this patch, if the bounds of the focused node is clipped by the
container, it will scroll the node to the center of the container.

Bug: 966806
Test: manual
Change-Id: I974db35731b85fdcb957d9898ae921a12dbd7607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885253
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713180}

This is a reland of 55549387

Original change's description:
> Fix RenderText itemization for complex emoji
> 
> 
> 
> This CL is a refactoring on the way RenderText do
> 
> ItemizeTextToRuns for the corner cases where a run
> 
> should be split in grapheme clusters.
> 
> 
> 
> The previous code was naming these cases:
> 
>   * Unusual characters
> 
>   * Special characters
> 
>   * Non-regular characters
> 
> But they should be more specific on the purpose of splitting the runs.
> 
> 
> 
> Also, the algorithm used for splitting a sequence of codepoint
> 
> was based on the code block of the corresponding codepoints
> 
> and few cases where trying to merge adjacent codepoint in
> 
> a grapheme. The algorithm was incorrect multiple cases (e.g. emoji).
> 
> 
> 
> Unicode provide a way to split a sequence of codepoints into
> 
> grapheme and grapheme clusters.
> 
> They provide a state machine which is using the codepoint proporties
> 
> to decide if the current location is a grapheme boundaries.
> 
> 
> 
> The ICU library is providing an API over the character properties
> 
> to help iterating over graphemes.
> 
>   * ubrk_open
> 
>   * ubrk_first
> 
>   * ubrk_next
> 
>   * ubrk_close
> 
> 
> 
> The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is
> 
> providing an easy to use wrapper over that API.
> 
> 
> 
> 
> 
> The current CL is replacing the previous characters based splitting
> 
> algorithm by the graphemes based version.
> 
> 
> 
> 
> 
> 
> 
> See emoji sequence:
> 
>   http://www.unicode.org/reports/tr51/
> 
>   1.4.5 Emoji Sequences
> 
> 
> 
> The full emoji list:
> 
>   * http://unicode.org/emoji/charts/full-emoji-list.html
> 
> Emoji data, used to make our unittests:
> 
>   * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt
> 
> 
> 
> 
> see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/)
> 
> see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h
> 
> see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h
> 
> Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712704}

Change-Id: I64c877907d6e961bd223a7c4cb1193c240b0b7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900347Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713179}

The compositor surface is opaque, which means when video is lifted
into a separate surface during fullscreen below the compositor
surface, it is never showing through.

Always set the compositor surface to translucent for now, which will
use more memory even when not in fullscreen.

Bug: 1022042
Change-Id: I2ff368dfa2a04ba0e62891039244c0bcb148e6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899901Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713178}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f73369ec458..2d87f9edb488


Created with:
  gclient setdep -r src-internal@2d87f9edb488

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:992974
Change-Id: I3ff53a1e3e9f0260747d79cc9624fc7310c1f57e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901794Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713177}

All machine_level_user_cloud_policy* files under chrome/browser/policy
are renamed to chrome_browser_cloud_management*. Updating the per-file
oaner as well.

Bug: 1010704
Change-Id: Ib8bafb1c36227c3d725d973b38d3b330cda445a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900551Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713176}

Previously, the document provider backed off upon receiving http 200 responses
with certain error codes (403 & 503). However, the backend sends http 400 and
499 responses to notify the client to backoff.

This CL modifies doc provider to backoff upon receiving any of the backoff
responses: http 200 w/ code 403, http 503 w/ code 503, http 400, and http 499
responses).

To avoid having to wait for this CL to rollout, the backend may be modified to
reply with the http 200 backoff responses. If that is the case, once this CL
rolls out to stable, the backend will return to sending http 403 and 499 backoff
responses. Afterwards, the document provider will be modified to no longer
listen for the http 200 backoff responses.

Alternatively, if the backend is never modified to send http 200 backoff
responses, backoff won't work until this CL rolls out. Regardless, the document
provider should be modified to only listen to one set of backoff responses going
forward.

Bug: 1022071
Change-Id: I60070be5a0f727bfda3cf165daed03a82efbb277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900400
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713175}

This CL connects the App Service with the Pref Service. This is to
allow the App Service store and retrieve preferred apps from the
preferences file.

BUG=853604

Change-Id: I2802173d80126595966626af5d1ff1f42761c49f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892475Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713174}

As the aidl directory contains more than just aidl files, the name
is mildly confusing. This renames it to 'interfaces' ('interface'
would be nice, but 'interface' is a reserved word, event for package
names).

BUG=none
TEST=none

Change-Id: I29e9fb737d8f7bbe5b586d26399d78ff262c1bd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901727
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713173}

InProcessGpuMemoryBufferManager wasn't providing memory dumps for
GpuMemoryBuffers it allocated. Any GMBs allocated for the GPU process
weren't accounted for in memory traces. Share the implementation with
HostGpuMemoryBufferManager by refactoring it into AllocateBufferInfo
class.

Bug: none
Change-Id: Ieaf1597106bee2562b0fc99a47243f55af7faf5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894457
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713172}

This cl removes dump without crashing in case of multiple attempts to
record journey logger bit vector. Dump without crashing is not needed
anymore since enough stacktraces and events_ are gathered from stable
channel.

Bug: 994675
Change-Id: I150704344deff3ec8dcf5def01386a8104dc7264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900252
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713171}

This moves content::PageVisibilityState into blink and uses this instead
of a boolean for blink::Page's visibility. A follow-up CL will use the
kPrerender state to set a Page as not hidden but not fully visible for
certain capture scenarios.

This CL is not intended to change behavior yet.

crbug.com/995131#c24 describes this series of changes.

Bug: 995131
Change-Id: I41d05228c1ca830ce57ffcb3a04735279bf324f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898471
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713170}

The url-safe base64 encoding of the credential_id was being sent to Payments
server, but only standard base64 is accepted. This CL ensures only standard
base64 is used.

Bug: 949269
Change-Id: I423ab314aeb6a40f21dcc1e9304329afa7a52147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897493Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#713169}

This is a reland of ef04b24c.

Fixed in the reland:
  * Now stripping out -checkdiscards from test targets.

Original change's description:
> Android: Add @CheckDiscard to proxy native wrappers.
>
> This will cause compile errors for proguard_enabled builds if generated
> proxy native classes aren't fully inlined and removed.
>
> An example where this would happen is caching the result of
> WrapperClassNameJni.get() in a member variable.
>
> Example errors:
> Item void org.chromium.base.MemoryPressureListenerJni.<init>() was not discarded.
> Some JNI wrapper classes were not fully optimized.
> org.chromium.base.MemoryPressureListenerJni should not appear in a release .dex file.
> Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda.
> ...
>
> Item void org.chromium.base.library_loader.LibraryPrefetcherJni.<init>() was not discarded.
> Some JNI wrapper classes were not fully optimized.
> org.chromium.base.library_loader.LibraryPrefetcherJni should not appear in a release .dex file.
> Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda.
> ...
>
> Bug: 993421
> Change-Id: I488640859a939d41eed2e44bb01904062942257d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894151
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712239}

Bug: 993421
Change-Id: I14edd406de4028dfef2761d7129b7579238a3ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898303
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713168}

Change-Id: I8da35697fa6df741be7269c4566b9b7636557412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901642Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713167}

This change moves the error reporting out of
TransactionalLevelDBDatabase and into the leveldb environment
configuration. This allows better separation of logic, and also removes
dependencies of TransactionalLevelDBDatabase on indexed_db/.

Bug: 1015212
Change-Id: I3ce7e3b2896e2e1555114500d48789192a1381ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898779
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713166}

FlexibleBoxAlgorithm flips the positions of items in RTL row containers.
Legacy flips items in RTL column containers before setting their
positions and I thought I'd have to do something similar in LayoutNG.

But LayoutNG assumes children will be positioned without flipping for
RTL; the fragment flips children automatically upon creation [1]. So
this patch prevents FlexibleBoxAlgorithm from flipping for RTL in
FlexNG.

[1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/ng/ng_physical_container_fragment.cc?rcl=70b1c5fbc63772bd98d26d26ddded71ca96f5f1f&l=76

Bug: 845235
Change-Id: I672b0b8b4f9781c54edaa60cb2ce7e0f46610cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889011Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713165}

This CL moves the ui/base/now_playing component into the new System
Media Controls component as the Mac implementation. This CL adds a
SystemMediaControlsMac object which holds both the
NowPlayingInfoCenterDelegate and RemoteCommandCenterDelegate and uses
the combination to implement the SystemMediaControls API.

Bug: 949596
Change-Id: I7f82ff6c3f86836530f7af4843e0b4c832ee4e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898513
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713164}

https://webrtc.googlesource.com/src.git/+log/2f2049af23f4..33cff37c6035

git log 2f2049af23f4..33cff37c6035 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
2019-11-06 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
2019-11-06 mbonadei@webrtc.org Disable goma on GCC bots.
2019-11-06 alessiob@webrtc.org Reland "RNN VAD: prepare for SIMD optimization"

Created with:
  gclient setdep -r src/third_party/webrtc@33cff37c6035

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:1021931
Change-Id: Ic69036492cbab4c0979e23608a3047c300cb44db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899599Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713163}

https://skia.googlesource.com/skia.git/+log/0efc01d54063..3dce06be0e24

git log 0efc01d54063..3dce06be0e24 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-06 jvanverth@google.com Fix issue with RenderPipelineDescriptor creation
2019-11-06 mtklein@google.com JIT splat(0) as xor
2019-11-06 bsalomon@google.com fix tolerance in read pixels tests

Created with:
  gclient setdep -r src/third_party/skia@3dce06be0e24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: I7355b4e068d6396c5b56bd9b993790c34094c1f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713162}

During a GetRealPan request, either the "encrypted_cvc" field is set, or the
"fido_assertion_info" field is set, but never both.

Bug: 949269
Change-Id: I5f44efc175c8401e99bd6d5236f859319577e8d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897494Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#713161}

This change contains the prototype implementation of EditContext APIs.
EditContext simplifies the process of integrating a web app with advanced
text input methods such as IME, VK shape-writing, speech recognition etc.
EditContext decouples text input from the HTML DOM view.
Rather than having the web platform infer the data required to enable
sophisticated text input mechanisms from the HTML DOM, the author will
provide that data explicitly through the API surface of the EditContext.
Additionally, EditContext communicates events driven from text input UI
to JavaScript.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/
           master/EditContext/explainer.md

Test: run_web_tests web_tests/editing/input/edit-context.html

Bug: 999184

Change-Id: I36f115bf37e6ea2adb64c2f42e024dc800b56480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868848
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713160}

https://android.googlesource.com/platform/external/perfetto.git/+log/c1c6fa243e83..1171cdd4f791

git log c1c6fa243e83..1171cdd4f791 --date=short --no-merges --format='%ad %ae %s'
2019-11-06 lalitm@google.com Merge "trace_processor: optimize filtering a range into a BitVector"
2019-11-06 lalitm@google.com Merge "trace_processor: improve SelectRangeWithBv for start == 0 case"
2019-11-06 lalitm@google.com Merge "trace_processor: make filtering of non-null columns faster"

Created with:
  gclient setdep -r src/third_party/perfetto@1171cdd4f791

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I5abaa004ca159ba79a2fc21fe048558c6b5e44a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901545Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713159}

This CL renames:
- Verifier to CurrentPageVerifier.
- VerifierDelegate to Verifier.
- TwaVerifierDelegate to TwaVerifier.
- corresponding test classes.

Bug: 1017114
Change-Id: I8c9e9688ba1eca415bc3c4b4951e2839db458c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899987Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713158}

This CL prevents out-of-order sync token releases from causing a
client's scheduling state to go back in time. Prior to this change, if a
client submitted a release for a sync token with a release count that
was earlier than the last release count, we would update the last
release count to the earlier one. This would mean that a sync token
could get "unreleased."

Test: added unit tests to enforce the new behavior.
Bug: 1013502
Change-Id: If8404101789a277dacfd2337971fd60136f07d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898714
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713157}

BEFORE: http://screenshot/pUOjJiTuqw7.png
AFTER: http://screenshot/bgRxAxYz5M6.png

Bug: 1021994
Change-Id: I3abf24d71335e4fa38d1cb12b201122af4391df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900276Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Felipe Cerqueira <cerqueira@google.com>
Cr-Commit-Position: refs/heads/master@{#713156}

This CL use IsA<HTMLBDIElement>(element) in place of
IsHTMLBDIElement(element)

Bug: 891908
Change-Id: I46e044864bfbc347655e74134fd7e0d02d005646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899636Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#713155}

This CL was partially created by
//base/android/jni_generator/jni_refactorer.py.

The docs still need to be updated properly to explicitly declare the
old approach as deprecated.

Bug: 929661
Change-Id: I4593c4b30886f25ea4629567e1dfa31b95ce298f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901645
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713154}

Bug: 1016428
Change-Id: I8e0881ff2d924be0c1a62b87750714f12e935a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897829
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713153}

This CL fixes the clusterfuzz issues reported (see "Fixed" below) by
using WTF::Bind and WrapPersistent in RTCPeerConnectionHandler::AddICECandidate.

This is a regression from crrev.com/c/1899786, where code used to
have a WebRTCVoidRequest wrapping RTCVoidRequest instances (garbage
collected). Now that RTCVoidRequest is used directly, we need to
properly wrap-persist its instances with WTF::WrapPersistent
when passing it to callbacks.

Reason: With Oilpan and WTF::Bind, raw pointers of garbage collected
objects are not allowed.

Fixed:1021919

R=haraken@chromium.org

Change-Id: If9128d73f288bf0e39495effd8e33779a81cc0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901726
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713152}

This CL updates FrameInterferenceRecorder to compute
agent interference metric (using cluster_id to identify agents)
and records it as
TimeRunningOtherAgentsWhileTaskReady.

FrameInterferenceRecorder should be renamed
AgentInterferenceRecorder as a follow-up.

Bug: 1019856
Change-Id: I0ad429f3f77f7612d77b010de10f88383727cc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888091
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713151}

Bug: 1018268
Change-Id: Ib5a8e881fc958715984d40188e3f3bb054b40427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894412
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713150}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=vakh@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I9adb0b38d8b12adb9a7571c40928e5ac0de078db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894885
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713149}

https://swiftshader.googlesource.com/SwiftShader.git/+log/88264e3e188d..27a3d31d7a9d

git log 88264e3e188d..27a3d31d7a9d --date=short --no-merges --format='%ad %ae %s'
2019-11-06 jonahr@google.com Fix issues presenting MetalSurfaces

Created with:
  gclient setdep -r src/third_party/swiftshader@27a3d31d7a9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:1015454
Change-Id: Ie90efeabc21b48b0756529528d37868608fc0666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#713148}

When a page is restored from the back forward cache, there is
currently no way to know its navigationStart time since we aren't
updating performance.timing.navigationStart (which is undesirable),
even though users of bfcache might want to know the navigationStart
time to measure latency. To solve this, we are modifying the
pageshow event’s timeStamp to correspond to the navigation start of
the history navigation. Note as event.timeStamp is defined as time
elapsed since the beginning of the document lifetime [1], this is
effectively the difference between the initial navigationStart and
the navigation start of the last navigation.

[1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp

Note that we are only updating this for pageshow events for pages
that were persisted (restored from the back forward cache).

For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing

Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713147}

Bug: 954850
Change-Id: I6020a3a9cc04b696cbaa4554acd08ec83753bac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900687Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713146}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=jzw@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: Ib72a7df0175f5cd438052510e6ddf1eeefbefa59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895644
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713145}

Weak processing happens after marking. This phase happens after marking
and markbits should not be changed any longer. While the markbit for the
backing store is local, it prevents a refactoring that avoids passing
around the Visitor for weak callbacks.

See the patch for reasoning of liveness and moving consistency.

Change-Id: I1c593b288e0ffc4f9c3cbf16a211eac29360abfd
Bug: 982754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901037
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713144}

GpuMojoMediaClient::gpu_memory_buffer_factory_ is guarded by
BUILDFLAG(USE_CHROMEOS_MEDIA_ACCELERATION), however it is only used in
the ChromeOS specific code path.

This results in the following error if standard Chrome is built with
use_vaapi=true or use_v4l2_codec=true on Linux:

In file included from ../../media/mojo/services/gpu_mojo_media_client.cc:5:
../../media/mojo/services/gpu_mojo_media_client.h:77:38: error:
    private field 'gpu_memory_buffer_factory_' is not used
    [-Werror,-Wunused-private-field]
  gpu::GpuMemoryBufferFactory* const gpu_memory_buffer_factory_;

Add "defined(OS_CHROMEOS)" to the #ifs that guard the field declaration
and assignment in the constructor to match the code path that uses it.

Test: compile and run media_unittests with use_vaapi=true on Linux
Test: compile and run media_unittests simplechrome (chromeos-amd64-generic-rel)
Change-Id: Ic621272e06d4e5457572f1eadbd9f549638446a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898280Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713143}

Skip initialize DTC for AppListSyncableService if device
is set to tablet form factor.

factor devices.
devices between user sessions.

Bug: 1013732
Test: ApplistSyncableService is disabled on tablet form
Test: Applist position persist on tablet form factor
Change-Id: I5ed15c8d0c3381d4d6ebea5397b8a00779b653cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901627
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713142}

ScrollingCoordinator::UpdateCompositedScrollOffset() assumes that the
scroll layer exists. We should not call the function when we haven't
created the scroll layer.

The check was not needed before crrev.com/c/1895081 because we created
the layers earilier (during CompositeUpdate). After the CL we created
the layers during PrePaint, but VisualViewport::DidSetScaleOrLocation()
can be called earlier.

Bug: 1020181
Change-Id: Ie9a341928ed13e02b4edbefdfbc513f1ecb22be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899598
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713141}