- 22 Jun, 2018 40 commits
-
-
Ioana Pandele authored
This is a temporary wiring that is no longer needed once crrev.com/c/1097478 lands. Bug: 835234 Change-Id: I0acc8816724dbc523755327f46515fbdcba4fde6 Reviewed-on: https://chromium-review.googlesource.com/1110227Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#569608}
-
Mikhail Montsev authored
Use ui::test::ScopedEventTestTickClock instead of SetEventTickClockForTesting. EventsXTest did not call SetEventTickClockForTesting(nullptr) and, eventually, GestureProviderAuraTest suffered from that. It's better to use RAII idiom in this case because RAII makes impossible to forget to call SetEventTickClockForTesting(nullptr). Change-Id: I80b079ef37a77618d76f14912f7d6c40d39ab66b Reviewed-on: https://chromium-review.googlesource.com/1030108 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569607}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7999d926809f..c5a26a769e69 git log 7999d926809f..c5a26a769e69 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 hferreiro@igalia.com [win-cross] Support using a zip file for the Windows SDK Created with: gclient setdep -r src/third_party/depot_tools@c5a26a769e69 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852347 TBR=agable@chromium.org Change-Id: I3801e60259035c8ffd595364ae65795e7f371be3 Reviewed-on: https://chromium-review.googlesource.com/1111917Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569606}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 888b6b53. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19958 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=robertma No-Export: true Change-Id: I1f8599db536df6562f936ec3162bdb059747080c Reviewed-on: https://chromium-review.googlesource.com/1111898 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569605}
-
Peter Beverloo authored
Right now they're additive, which is a bug. Bug: 800152 Change-Id: Ib1312dd921e18c17e872d4dea2c5962604cfecca Reviewed-on: https://chromium-review.googlesource.com/1110231 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#569604}
-
Adithya Srinivasan authored
Removes content/renderer/speech_recognition_dispatcher and moves functionality into blink. Also removes layering in blink/public/web that is now unneeded. Design doc is linked in the bug below (Comment #15). Bug: 781655 Change-Id: Ie777279386b08b2fd897bb5cefa1855733f19cb3 Reviewed-on: https://chromium-review.googlesource.com/1081092 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#569603}
-
Matt Falkenhagen authored
This UMA can be misleading because it also is recorded for controllers without fetch event handlers. These service workers don't run on page load and don't intercept requests, so it's probably best to not count them. But we are not currently using the UMA, and it's under "Experimental" so we can remove it now and add back an improved metric if the need arises. Bug: 854851 Change-Id: I6f40b573aa950c44a761f8c7ceebf3b7d8ded665 Reviewed-on: https://chromium-review.googlesource.com/1111751Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569602}
-
Takuto Ikuta authored
This is for faster link time on compile and isolate tests step of linux-chromeos-rel builder Link time comparison of some binaries between this tryjob, https://ci.chromium.org/b/8943035780027076400 [1] and https://ci.chromium.org/b/8943036433296462960 [2] is like below. browser_tests: 54.076s -> 31.285s unit_tests: 1m49.235s -> 34.616s components_unittests: 1m36.197s -> 29.543s isolate tests step time is reduced from 6 mins 12 secs to 2 mins 10 secs. [1] https://chromium-build-stats.appspot.com/ninja_log/2018/06/22/swarm1444-c4/ninja_log.swarm1444-c4.chrome-bot.20180622-013034.23287.gz/table?dedup=true [2] https://chromium-build-stats.appspot.com/ninja_log/2018/06/22/swarm1476-c4/ninja_log.swarm1476-c4.chrome-bot.20180622-005824.18926.gz/table?dedup=true Bug: 794423 Change-Id: I09981de84d2ab3cc9a7a63a599f2284781f71368 Reviewed-on: https://chromium-review.googlesource.com/1111757 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569601}
-
Paul Meyer authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/z4CWYor4UpQ Bug: 731810 Change-Id: I8146e6af6edba7b0ab844a47afb4d889b081e117 Reviewed-on: https://chromium-review.googlesource.com/1110351 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#569600}
-
Colin Blundell authored
In preparation for porting GCM to use IdentityManager to fetch access tokens rather than ProfileOAuth2TokenService, this CL refactors how GCMAccountTracker internally stores pending requests. Currently it stores them as a vector of raw OAuth2TokenService::Request pointers; when such a pointer gets passed in OnGetToken{Success, Failure}, it looks it up in the vector to delete it. However, the IdentityManager facilities do not pass pointers to the analogous "request" objects (called AccessTokenFetcher), while the client is still responsible for deleting those objects when desired. This CL changes GCMAccountTracker to maintain a map of account IDs to OAuth2TokenService::Request unique_ptrs. When a request is complete, it simply erases the entry in the map by key. One hiccup is that GCMAccountTracker currently can make two concurrent requests for the same account: - It makes token requests for accounts in AccountTracker's list of accounts that are in GCMAccountTracker's TOKEN_NEEDED state. - When it makes a request, it transitions the state of the account to GETTING_TOKEN. - When it receives a notification that an account has signed out, it transitions that account to ACCOUNT_REMOVED state. - When it receives a notification that an account has signed in, if it has the account in ACCOUNT_REMOVED state it transitions that account to GETTING_TOKEN state and refetches access tokens. However, GCMAccountTracker already short-circuits out of taking any action on completion of access token requests if the account is in ACCOUNT_REMOVED state (beyond deleting the request). This CL simply changes GCMAccountTracker to never make two concurrent token requests for the same account by deleting a token request when transitioning an account to ACCOUNT_REMOVED state. Bug: 809923 Change-Id: I2bae540133ae4db3f2cfea47332b2907dd88dd6d Reviewed-on: https://chromium-review.googlesource.com/1104689 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569599}
-
Adithya Srinivasan authored
Directly use types in base/numerics/checked_math.h instead. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I883a476d93c316c4ff6ded62e453e939a4dbb5ec Reviewed-on: https://chromium-review.googlesource.com/1108976Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
The user gets a feedback that the password is saved during editing. TBR=rouslan@chromium.org Bug: 851021 Change-Id: I2d254b4b366d67fee5283898b769362902008b15 Reviewed-on: https://chromium-review.googlesource.com/1110229 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#569597}
-
Siddhartha authored
GetAllocatorDump is used to check if dump was created. Do not return black hole dump from here. BUG=854668 Change-Id: Ife41be2622e9476d8e45586ace3ea316012341c3 Reviewed-on: https://chromium-review.googlesource.com/1111017 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569596}
-
Sebastien Marchand authored
This is a reland of bdb95bb9 with a fix for a conflict with https://chromium-review.googlesource.com/c/chromium/src/+/1093091 Original change's description: > Reland "RC: Connect the Local DB to TabHelper and add browsertests." > > This is a reland of 8f4ffc9a with a fix > for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory, > the HistoryService::Delete task didn't always had time to run before we > assumed that the entry had been removed from the history, this fix this > by running RunUntilIdle() several time (until the deletion has > complete) > > > > Original change's description: > > RC: Connect the Local DB to TabHelper and add browsertests. > > > > Bug: 773382 > > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9 > > Reviewed-on: https://chromium-review.googlesource.com/1088196 > > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568519} > > Bug: 773382 > Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8 > Reviewed-on: https://chromium-review.googlesource.com/1106940 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569311} TBR: fdoray@chromium.org Bug: 773382 Change-Id: I9b2f648f30d418b22972d4eadd026311971a5ae9 Reviewed-on: https://chromium-review.googlesource.com/1110002Reviewed-by:
-
Farah Charab authored
base::FeatureList::IsEnabled call is relatively expensive, so we cache the values of the features in the main thread. Change-Id: Ic725ff1d695cf01150139240d4f1b60d8b9a72a7 Reviewed-on: https://chromium-review.googlesource.com/1109214 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569594}
-
Andy Paicu authored
'unsafe-hashed-attributes' renamed to 'unsafe-hashes' 'unsafe-hashes' matches style attributes correctly now 'unsafe-hashes' works for javascript: URLs 'unsafe-hashes' tests added and ammended spec (approved and to be submitted at the same time as this CR): https://github.com/w3c/webappsec-csp/pull/311 I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4dohVXDfEI4/tO6rhuv4AwAJ Bug: 771922 Change-Id: I018cc0f73d492cb4057ff4c41d9be4df8438036c Reviewed-on: https://chromium-review.googlesource.com/1095217Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569593}
-
Ryan Daum authored
This DCHECK was triggering on debug cast build while using a port of PartialMagnificationController. Bug: none Test: manual Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I31273be8602f5e9bf9a114d91119cf7b9b374d87 Reviewed-on: https://chromium-review.googlesource.com/1110024Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#569592}
-
Vaclav Brozek authored
The old (renderer-process) FormData->PasswordForm parser failed to ignore non-text inputs, such as radio buttons. This CL adds filtering non-text fields out. Note that the new parser (browser-process) does filter out non-text field already. Bug: 851808 Change-Id: I60b121cb5cc15bdae0d96dba9119c2d704d079b2 Reviewed-on: https://chromium-review.googlesource.com/1111849Reviewed-by:
-
Nico Weber authored
This reverts commit e092b1bd. Reason for revert: SecureChannelClientImplTest.TestMultipleConnections has been failing consistently on the waterfall since this landed. Started here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/9728 Original change's description: > [CrOS Multidevice] Integrate SecureChannel API into ProximityAuthMonitor. > > This injects a ClientChannel into ProximityAuthMonitor, which is used if the > chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used > to get the current RSSI of the connected remote device. > > In the future, the "rolling average RSSI" that is calculated in > ProximityAuthMonitor will be moved to the SecureChannel API, and returned > by it. However, to reduce immediate migration work, that logic is kept > in ProximityAuthMonitor for now. > > R=jhawkins@chromium.org, khorimoto@chromium.org > > Bug: 824568, 752273 > Change-Id: I8d6485a5a0018fe43595b880c25a2fa9af5a1b75 > Reviewed-on: https://chromium-review.googlesource.com/1106616 > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: James Hawkins <jhawkins@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569425} TBR=jhawkins@chromium.org,khorimoto@chromium.org,hansberry@chromium.org Change-Id: Ie22413bae9011ed505220115fa1c711fc1c7e626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824568, 752273 Reviewed-on: https://chromium-review.googlesource.com/1111937Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569590}
-
Martin Šrámek authored
The Flash permission toggle is shown in page info iff Flash was ever used on a given website. When ephemeral Flash permissions are enabled, we Sync this piece of information to make the toggle appear on all devices, to somewhat counteract the reduced usability of the ephemeral permission. At the same time, migrate the Feature object to //components so that we can refer to it from the relevant code. Bug: 850062 Change-Id: I69a843233e8c1f13abdd7027fddeb4d4692a5af6 Reviewed-on: https://chromium-review.googlesource.com/1109685 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#569589}
-
Ulan Degenbaev authored
Currently resource_coordinator::TabLifecycleUnit controls reloading of a bloated renderer process and notifies the tab helper. This CL moves the renderer process reloading to the tab helper, so that all code related to bloated rendere is in one place. Bug: 835806,808143 Change-Id: I1577872a1adc043a87bb2f599b211d3be9708f5c Reviewed-on: https://chromium-review.googlesource.com/1097481 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569588}
-
Friedrich Horschig authored
This CL provides the native code to the "Manage passwords..." link in the passwords accessory bottom sheet. Bug: 853747 Change-Id: I275171b1889d3ea85e3d8c3eda7feab8eed06495 Reviewed-on: https://chromium-review.googlesource.com/1110131 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569587}
-
Ned Nguyen authored
Bug: 855302 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifedb4069548c3c1706ae5b95e3ad922522b89178 Reviewed-on: https://chromium-review.googlesource.com/1111461Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569586}
-
Arthur Hemery authored
DocumentState is only ever instantiated in DidCreateDocumentLoader and we are guaranteed that this is a new DocumentLoader. Change-Id: I1f26c9ea0f06d72f6071cd0a83d16cdf2f12a1cd Reviewed-on: https://chromium-review.googlesource.com/1108198Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#569585}
-
jonross authored
We've analyzed the existing errors in both surface sync and viz content_browsertests. This updates the filters used on the FYI bot. TEST=surface_sync_content_browsertests, viz_content_browsertests TBR=fsamuel@chromium.org Bug: 849746 Change-Id: Id081a42d959ab2c97d98e56089320998d63bebdf Reviewed-on: https://chromium-review.googlesource.com/1110027Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569584}
-
Friedrich Horschig authored
This CL sends the corrected strings for passwords right upon creation. That fixes the issue of having plain white sheets when only the password generation option is available. (Later, this same call will also provide the manual password generation and a link to all passwords.) Bug: 835234 Change-Id: Ie38b76231e371f6d4bb88b2152c04a3f47dd98cc Reviewed-on: https://chromium-review.googlesource.com/1110117 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This implements a throttle that will advertise origin policy support to the server, and will request an policy if necessary. (This CL doesn't do anything with the manifest yet. That is coming in subsequent CLs.) Gated on --enable-features=OriginManifest. Bug: 751996 Change-Id: I3ebfa834c29f3eb17568917d1eff83a9261529ac Reviewed-on: https://chromium-review.googlesource.com/1088918 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#569582}
-
François Beaufort authored
This makes sure video loaded in a iframe is loaded before attempting requesting Picture-in-Picture in browser_tests. Bug: 853643 Change-Id: I2ad236ac24d42a89194e3dbb9ace4b9f56961d92 Reviewed-on: https://chromium-review.googlesource.com/1103570 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#569581}
-
Dominic Farolino authored
This CL removes the console deprecation web features as well as fixes more tests that fail with the deprecated console methods removed. Until the v8 CL that actually removes these deprecated methods lands however, we have to disable tests on the Chromium side until v8 auto-rolls with the removed methods. See crrev.com/c/10821128. Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pNn_QZxtRlg R=kozyatinskiy@chromium.org, mkwst@chromium.org Bug: 706804 Change-Id: I14f4b43373941871333389c9fc8f0f3f770d71b6 Reviewed-on: https://chromium-review.googlesource.com/1105628Reviewed-by:
-
Mikel Astiz authored
More explicit state handling is introduced with a switch, and some dead code is replaced with a DCHECK. Bug: 855375 Change-Id: I644d26e63bf51bf0cb56362afa0fa990f75e8be7 Reviewed-on: https://chromium-review.googlesource.com/1111708Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569579}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd58665a..600abcfe Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7d73cf6854fd1b106887f34f316212c3412939db Reviewed-on: https://chromium-review.googlesource.com/1111694Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569578}
-
David 'Digit' Turner authored
Android App Bundle support requires using recent versions of the bundletool and aapt2 programs, which are not part of the Android SDK copies used by internal and public Chrome checkouts at the moment. Also, these tools are still evolving quickly, and their latest releases are not part of official Android releases yet. To solve this, this CL adds two new directories under third_party/android_build_tools/, in order to store their corresponding files. Note that each tool's binary files are distributed through DEPS as CIPD packages. For reference, bundletool is officially distributed from github (see https://github.com/google/bundletool), and aapt2 from Google Maven. Note that in the latter case, our script at tools/android/roll/android_deps/fetch_all.py cannot be used, because the corresponding .jar file contains Linux-specific binaries (executable and libraries), and our Maven-handling Gradle plugin doesn't know how to deal with these. BUG=845405 R=agrieve@chromium.org,jbudorick@chromium.org,thakis@chromium.org,benmason@chromium.org,chromium-third-party@google.com Change-Id: Id650acb9eb55f361fe18f6aa0995776aee832eec Reviewed-on: https://chromium-review.googlesource.com/1110225Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#569577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47afd98b. With Chromium commits locally applied on WPT: 3d33f9c5 "Sec-Metadata: Strings are quoted in structured headers." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19953 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources TBR=robertma No-Export: true Change-Id: I6347c427a57bca1b9f979d8321e783971178e28e Reviewed-on: https://chromium-review.googlesource.com/1111695 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
Forms with only "new password" fields, i.e., fields which should contain previously unknown passwords, are generally not to be filled. A previously unknown password is unlikely to be among those stored with Chrome. However, due to errors in form field classification, it can happen that despite Chrome's conclusion, the form actually contains fields worth filling. This CL makes it possible to fill such fields on-demand. Bug: 854123 Change-Id: I800290c4aabb91fb0fd661d083dc76af02c6895c Reviewed-on: https://chromium-review.googlesource.com/1108209 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
With this CL, a tapped suggestion in the passwords keyboard accessory sheet is filled into the last selected input for field. If that form field is not a password field but the selected credential is, nothing will happen. The autofill_agent has detailed knowledge of the form field and tracks the last selected input field. The password_autofill_agent queries the autofill_agent for that field and fills it with the selected credential. Bug: 811747, 854152 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id8ac5330269bcc8b8326a5e050789260e119d5e8 Reviewed-on: https://chromium-review.googlesource.com/1104338 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/120b2e4f2660..7999d926809f git log 120b2e4f2660..7999d926809f --date=short --no-merges --format='%ad %ae %s' 2018-06-22 sergiyb@chromium.org Revert "cpplint: Pull in upstream changes" Created with: gclient setdep -r src/third_party/depot_tools@7999d926809f The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:852898 TBR=agable@chromium.org Change-Id: I86c1fb4b07615d8f4569fb5271a4cc04bed8e8da Reviewed-on: https://chromium-review.googlesource.com/1111696Reviewed-by:
-
François Beaufort authored
This make sures the close icon in the Picture-in-Picture window is centered properly. Screenshot: https://imgur.com/a/3n6fNDW Bug: 836389 Change-Id: Id3418ad003440ab60c28ba748096237b853d2c61 Reviewed-on: https://chromium-review.googlesource.com/1109937Reviewed-by:
-
jdoerrie authored
This CL changes the title of the autofill section to use sentence case. TBR=hcarmona Bug: 854562 Change-Id: I362f8516bd2854f3f6a65ccf5790b3d1f06456f8 Reviewed-on: https://chromium-review.googlesource.com/1111713Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569571}
-
Haruka Matsumura authored
RecordInfo.cpp was removed the condition of HeapListHashSet from the list of types that we check the inlineCapacity. Because HeapLishHaseSet has inline capacity. Also, we fixed a test, so stubs.h was removed ConditionalDestructor. Change-Id: I32a950fea200918c8ede8eccfdd3c015e2fa575d Reviewed-on: https://chromium-review.googlesource.com/1111739Reviewed-by:
-
jdoerrie authored
This change updates the section headers of the passwords and autofill section to reflect the Autofill Home proposal Bug: 854562 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If582fadf067ad02b1a5642aca8f6f5083497e37e Reviewed-on: https://chromium-review.googlesource.com/1107704 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#569569}
-
