- 30 Dec, 2020 15 commits
-
-
Sophie Chang authored
Maybe this will help fix the download manager test flakes Bug: 1156112 Change-Id: Ice1add6879733c53eff58d932d177e63be3505d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606718Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b185d5bb82fb..ce202c065f97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: Ie3b5d125b9d691f9e062248682eb6b51b9551e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839679}
-
Sophie Chang authored
Doing it this way to get more correct metrics around coverage and to verify against server metrics for when this reactive prefetch can trigger TBR=jwd@chromium.org Change-Id: Ie8dc14673ea905c5a51e6fc130857e5255840da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599445 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#839678}
-
Stefan Zager authored
CompositingRequirementsUpdater is responsible for setting PaintLayerCompositor::compositing_, while GraphicsLayerTreeBuilder is responsible for attaching PaintLayerCompositor::RootGraphicsLayer() into the layer tree of its embedding document. The current code uses slightly different logic in those two places to determine whether an iframe is compositing, which may lead to inconsistent state when an iframe is throttled. This CL make them use the same logic. Bug: 1133662 Change-Id: I13276c0b0fb25921936d5319d4d983d720595557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606654 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839677}
-
Noel Gordon authored
Move the DriveSyncHandler fake definition after the VolumeManager fake and all the volume-related fakes. Bug: 1113981 Change-Id: Id0999b986230ae32d55baac07a8babaff45dcfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604785Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839676}
-
Austin Sullivan authored
Bug: N/A Change-Id: I08d9bb1facccd82648389453ea88067e7e1786d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601577 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#839675}
-
Takumi Fujimoto authored
Bug: 1160947 Change-Id: Iecc70cc8de059979bef787512b6bd3d2196d9890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600263 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#839674}
-
Hui Yingst authored
Bug: 1162346 Change-Id: Ifb876edf670d0346d3b38469349bd0d80028671c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602847Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839673}
-
Lukasz Anforowicz authored
Before this CL, in presence of AllowNonStandardSchemesForAndroidWebView, there would be an inconsistency between origins calculated for about:blank URL by Blink and //url: - The assertions added by this CL to SecurityOriginTest, NonStandardSchemeWithAndroidWebViewHack would pass before and after this CL (always returning an opaque, unique origin for "about:blank" URL). - The assertions added by this CL to OriginTest, NonStandardSchemeWithAndroidWebViewHack would fail before this CL (returning "about://" origin for "about:blank" URL) and pass after this CL. Before and after this CL, Blink would use an opaque origin because ShouldTreatAsOpaqueOrigin in Blink's security_origin.cc would match "about" in SchemeRegistry::ShouldTreatURLSchemeAsNoAccess. This CL makes sure that IsValidInput in //url's scheme_host_port.cc also takes no-access schemes into account. Making sure that Blink and //url origins are consistent is a step toward being able to calculate the origin to commit on the browser-side. Without this CL, Android WebView tests (e.g. ...android_webview.test.LoadDataWithBaseUrlTest#testNullBaseUrl) would fail in the follow-up CL here: https://crrev.com/c/2581008/13 Change-Id: Ic302abb8f61b16bacdcd5dc15f33718f94c106c9 Bug: 888079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601844 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#839672}
-
Noel Gordon authored
Remove definition of addEventListener() and retain the definition that takes arguments addEventListener(type, name). Bug: 1113981 Change-Id: Ibf97bf6a7cef740a58ad96e2823c39150f2b7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606405 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Mila Green authored
Bug: 1144151 Change-Id: I4890a1cfb7a02b038683620418e6032e907b6561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601281 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839670}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifeecc1b42d57c2a2643ff87ff47d39301e25983a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839669}
-
Bruce Dawson authored
Anti-virus programs and other scanners may briefly lock new files which can lead to frequent problems with saving bookmarks and other files that use the ImportantFileWriter. This attempts to deal with this by retrying the racy ReplaceFile step a few times. This change also adds instrumentation to record how many retries are needed, for future tuning. It also moves the SetLastError call as close as possible to the function that will consume the last error code. This is only done on Windows because that is hoped to be the only place where it happens. Bug: 1099284 Change-Id: I7aa9a27e137d3df2c402de5f13bbe911521a711d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559156Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#839668}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f81d75f9eee..b185d5bb82fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: huiyingst@google.com Change-Id: I489e6d765f9125b2961d2d140fd3322908c41d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606804Reviewed-by:
-
Chris Mumford authored
Make IndexedDBContextImpl::data_path_ a constant member as it is never changed. Doing so makes it easier to reason about safe access on different sequences. set_data_path_for_testing() existed, and was used by IndexedDBQuotaClientTest, but was only ever set to the same path passed to the IndexedDBContextImpl constructor. Also make IndexedDBContextImpl::data_path() return a const reference to avoid unnecessary creation of intermediate base::FilePath instances. Bug: none Change-Id: If7c5a960c30dd7d4858fd332437548d7363247d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606651Reviewed-by:
-
- 29 Dec, 2020 25 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0eb61724c8f1..9a38e5b60dcc 2020-12-29 enga@chromium.org Make HLSL cache key guard comment ASSERT more specific If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ie51c8dadcf6b78bf5887689d34e3b32531fbfb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606766Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I82ee74c4d68eb5b7c6b33933a5a256cb578c93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606705Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5dd3d7ff936b644ad2eb1345ba1e4ffe785fe220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606712Reviewed-by:
-
Hui Yingst authored
[iOS]Re-enable [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] for iPad testing. [FallbackViewControllerTestCase testNormalFieldHasManualFallbackIconsAfterReadonlyField] is only flaky on iPad. This CL re-enable this test for iPhone. Bug: 1162301 Change-Id: I8b53271babcca2b561ecf9b8169eaa3b83dc18b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606626 Commit-Queue: Hui Yingst <nigi@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#839662}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie5eb6d9e312cb37190ebdf28540558e1cc546dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606348Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839661}
-
Dylan Cutler authored
This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Make CanonicalCookie's constructor private. Bug: 1102874 Change-Id: I124942d0aea21cc26a9ee36f35032bde3cb6fba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595450Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#839660}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I37d9caff3d8fee1d226419441068d0a227ec26f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606686Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839659}
-
Toni Barzic authored
The goal is to avoid excessive image load requests if the backing file gets modified multiple times in quick succession. BUG=1139115 Change-Id: I5ecf0171d28c5c2882f660039a6923e0951ed68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606383Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839658}
-
Jeffrey Kardatzke authored
This adds UMA stats for the following: 1. Selection between Chrome CDM and platform CDM (Beanstalk) 2. System codes for rejected promises from platform CDM (to distinguish these from the same errors w/ a browser CDM) 3. Status for output protection query/result (to distinguish these from the same data w/ browser CDM) BUG=b:153111783 TEST=Builds and runs, histogram presubmits pass Change-Id: I7a51b49594b6ac36500b52d602252bdd29b4c1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597899 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839657}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67a477b85b60..fe4611c18e9d 2020-12-29 reed@google.com Alias two sets of enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Iec3cb68ef03731808a99f6d9c7017f45540e4259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606706Reviewed-by:
-
chrome://file-managerNoel Gordon authored
image_loader_client.js re-writes the requesting client's origin to the image loader exension's origin before sending the request to the image loader extension (using chrome.runtime.sendMessage). Add a re-write RegEx for chrome://file-manager. Note that this assumes chrome://file-manager has enabled chrome.runtime.sendMessage. Bug: 1113981 Change-Id: I8381eb60bdacb958521f1b34bfceb0e00bff2b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602963 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Clark DuVall authored
This was needed because the libraries were in the feed module, but have now been moved to the base module. This will hopefully fix a crash loading the libs on some devices. Bug: 1160654 Change-Id: Ie33114d6f5963325c096dea9f60e029d7d40e19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606187Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839654}
-
chrome://file-managerNoel Gordon authored
Allow chrome://file-manager to connect to the image loader. Note: this assumes chrome://file-manager has enabled chrome.runtime.sendMessage. Since the manifest.json "externally_connectable" permission is used to allow chrome://file_manager access, we must now list all the extension |ids| that are allowed to connect to the image loader extension in the "externally_connectable" permission. The ids are taken from the static ImageLoader.ALLOWED_CLIENT_ORIGINS list. Also add 'chrome://file-manager' to ImageLoader.ALLOWED_CLIENT_ORIGINS list, which is still used to allow (or block) connecting sources based on their URL origin. Bug: 1113981, 1123261 Change-Id: I96b0db1a0155510f95285cda8f5c7c62e6fece9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600433 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf79653b86f0..2f81d75f9eee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huiyingst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1160654 Tbr: huiyingst@google.com Change-Id: I8086e4ffcdec56897d670f413d253439ce3bcec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606744Reviewed-by:
-
Yi Chou authored
BUG=b:175781791 Change-Id: I70cec4f96accb0b24ae079ab0fab4e6441ecf671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597523 Auto-Submit: Yi Chou <yich@google.com> Reviewed-by:
-
evliu authored
Bug: 1158463 Change-Id: I6d9c29a72fae0e4cab62660883fa0b93d842b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606381Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#839650}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I0d457b5d7b251fd552c50617a9d3520aa8e965b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604947Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#839649}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2847bbcf303..47ee6a7b096a 2020-12-29 penghuang@chromium.org Add build flags to disable desktop gl backend 2020-12-29 jmadill@chromium.org Vulkan: Make shader variable info maps a class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ia74b26db14201c05cfe134dc8860cf0eef507686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606382Reviewed-by:
-
Kyle Horimoto authored
Before this CL, this loadTimeData boolean was missing in OOBE, resulting in a console error. This CL moves it to a shared location which is called from both OOBE and settings. Fixed: 1162251 Change-Id: I42e9504e903ff3fa26d797b26c8bf19967f022c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606708Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#839647}
-
Lukasz Anforowicz authored
The UMA was only needed to evaluate the safety/risk of shipping the feature. The feature has been enabled since r798414 / Aug 2020. Bug: 917457 Change-Id: Ieb73cb32d9dce587ef40a0d3b85de5956333bf72 Fixed: 1160833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600396Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Hui Yingst authored
[iOS] Disable [PasswordViewControllerTestCase testIPadTappingOutsidePopOverDismissPasswordController]. TBR=javierrobles@chromium.org Bug: 1162296 Change-Id: I1ee3f801b18dd8d950e9ba021b01571c34dcda93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602255Reviewed-by:
Hui Yingst <nigi@chromium.org> Reviewed-by:
-
Austin Eng authored
Bug: 1162117 Change-Id: I6aae742dae7330cc35234c5982ca619316e6b1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605885 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Evgenii Stepanov <eugenis@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#839644}
-
Matt Reynolds authored
Bug: 1030841 Change-Id: Ie79eba7a869784ece023aea5ab499b7618128dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582628 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#839643}
-
Michael Ludwig authored
This simplification was requested as part of feedback to: https://chromium-review.googlesource.com/c/chromium/src/+/2527768 Bug: skia:9310 Change-Id: I487d38decc258201767e8a7849f1051ced983163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600380Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#839642}
-
David Roger authored
The MergeSession flow will be deprecated soon, it's better to keep the histograms, as they may help in checking that the deprecation is going well. Fixed: 1140090 Change-Id: Ife217655abd9026f4eeecaf5ef5b136f7739d8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595746 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
