GitLab

If the alwaysOnTop property is enabled, but the app.window.alwaysOnTop
permission is not specified in the manifest, app window creation will
now fail with an error.

BUG=371213
TEST=browser_tests 
(PlatformAppBrowserTest.WindowsApiAlwaysOnTopNoPermissions)

Review URL: https://codereview.chromium.org/274123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270045 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270044 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173886:173932&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/270583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270043 0039d316-1c4b-4281-b951-d872f2087c98

There was a small regression in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929
in the range r270006-r270012 which seems to be normal growth. This updates expectations as per
http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations

This is a followup to http://src.chromium.org/viewvc/chrome?revision=270015&view=revision which fixed linux-64

BUG=none
TBR=bokan@chromium.org,qyearsley@chromium.org

Review URL: https://codereview.chromium.org/282803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270042 0039d316-1c4b-4281-b951-d872f2087c98

Previously it has shown vendor-name + volume-name + device-id where
the last part does not mean anything for the end users.

BUG=370692

Review URL: https://codereview.chromium.org/289443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270041 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds support to opening a file. It is currently no-op, and it is
not yet bound to fileapi.

In order to bound it to fileapi::AsyncFileUtil, we need to implement closing
operation, and reading operations first. Otherwise, creating a snapshot
(required by fileapi::AsyncFileUtil) is not possible.

TEST=unit_tests: *FileSystemProvider*OpenFile*
BUG=248427

Review URL: https://codereview.chromium.org/284443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270040 0039d316-1c4b-4281-b951-d872f2087c98

The perfect hash table containing all registry controlled domains is
replaced by a compact graph (a dafsa) to reduce binary size and PSS
of the running process. Size of the new structure is about 33kB
compared to 380kB for the perfect hash table.

Patch by Olle Liljenzin <ollel@opera.com>, originally at
https://codereview.chromium.org/197183002/

BUG=370672
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/270363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270039 0039d316-1c4b-4281-b951-d872f2087c98

This may have caused indexed_db layout tests to start failing.

> Add most of the metadata-handling code for blobs.  It's not quite all there, but
> this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
> couple of fake calls to keep the compiler happy.
> This CL also makes SetUpMetadata a member in order to ease testing in a later CL.
> 
> This depends on https://codereview.chromium.org/261843004/.
> 
> BUG=108012
> 
> Review URL: https://codereview.chromium.org/266333002

TBR=ericu@chromium.org

Review URL: https://codereview.chromium.org/281623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270038 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering(). (https://codereview.chromium.org/277123002/)

Reason for revert:
This seems to have broken NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0 Linux Tests (dbg)(2) and Win7 Tests (dbg)(1).
Will provide links and stdio on the new CL. This is speculative, if the issue won't go away, the revert will be reverted.

Original issue's description:
> Rename AudioRenderer::Play/Pause() to Start/StopRendering().
> 
> This makes a clearer separation between methods for controlling the
> actual rendering of audio versus methods for controlling the state of the
> renderer (i.e,. flushing and seeking).
> 
> Consequently, clean up AudioRendererImpl to reflect the separation
> between rendering methods and state change methods.
> 
> BUG=370634
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270017

TBR=dalecurtis@chromium.org,xhwang@google.com,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634

Review URL: https://codereview.chromium.org/274443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372634
TESTS=unittests and manual

Review URL: https://codereview.chromium.org/276093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371184

Review URL: https://codereview.chromium.org/273283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270035 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the webrtc video quality test page generic so that the
same page can be used for more than one tests. The paramters are now extracted from the video stream itself.

BUG=286290
TEST=out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest* --run-manual --ui-test-action-max-timeout=150000

Review URL: https://codereview.chromium.org/254803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270034 0039d316-1c4b-4281-b951-d872f2087c98

When using the quit/sign out shortcut (ctrl-shift-q) on chrome-os display the string "... to sign out" instead of "... to quit"

BUG=365166

Review URL: https://codereview.chromium.org/275243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270032 0039d316-1c4b-4281-b951-d872f2087c98

Mageia uses urpmi, but the autodetection code currently selects yum. Fix that.

Review URL: https://codereview.chromium.org/264913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370658

Review URL: https://codereview.chromium.org/266363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270030 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an Extensions.LoadCreationFlags UMA histogram which logs an
aggregate of a user's extension's flags.

BUG=None

Review URL: https://codereview.chromium.org/240613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270029 0039d316-1c4b-4281-b951-d872f2087c98

It's regressed in  https://codereview.chromium.org/226293005.

BUG=368365
TEST=CursorLoaderX11Test.Scale, also tested manually
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/280133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270028 0039d316-1c4b-4281-b951-d872f2087c98

Android does not use location_bar_view but its own LocationBarView, and this
still requires access to ToolbarModel::GetText() to show formatted URL
to its users. We need to reuse GetText() to get formatted URL.
    
BUG=365567,293227

Review URL: https://codereview.chromium.org/251983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270027 0039d316-1c4b-4281-b951-d872f2087c98

Which glibc defines h_addr as a macro to h_addr_list[0],
newlib has a separate h_addr member in struct hostent.

To correctly handle this, h_addr should be set to match h_addr_list[0].

BUG=None
R=binji@chromium.org
TEST=bots

Review URL: https://codereview.chromium.org/275533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270026 0039d316-1c4b-4281-b951-d872f2087c98

Moves NonBlockingTypeProcessor from sync/internal_api to sync/engine.

It's become increasingly clear to me that the NonBlockingTypeProcessor
will be too big to expose outside of sync.  When it comes time to export
its functionality, we'll need to define a wrapper class with a simpler
interface.  This means that there's no benefit to keeping it in
internal_api.

There is a benefit to moving this to sync/engine.  In this location, it
should be able to collaborate more closely with its sibling, the
NonBlockingTypeProcessorCore.

We intend to start adding lots of code to this class soon.  It's a good
idea to get this move out of the way first, so we can have a better git
history in the end.

BUG=351005

Review URL: https://codereview.chromium.org/280693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270025 0039d316-1c4b-4281-b951-d872f2087c98

This clean up alarm, declarative, idle, push_messaing API.

R=kalman@chromium.org
BUG=354046, 354458
TEST=unit_tests

Review URL: https://codereview.chromium.org/275383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270024 0039d316-1c4b-4281-b951-d872f2087c98

This matches the behaviour of the DelegatedFrameHost used by mac and
aura, and ensures the RenderWidgetHostViewAndroid does not try to
return resources twice since the client callback would be called from
LoseAllResources otherwise.

R=aelias
BUG=372486

Review URL: https://codereview.chromium.org/275813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270023 0039d316-1c4b-4281-b951-d872f2087c98

This is to address TODO and keep the naming consistent.

BUG=none
TEST=none due to no functionality changes

Review URL: https://codereview.chromium.org/285623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371108, 359845

Review URL: https://codereview.chromium.org/280043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270018 0039d316-1c4b-4281-b951-d872f2087c98

This makes a clearer separation between methods for controlling the
actual rendering of audio versus methods for controlling the state of the
renderer (i.e,. flushing and seeking).

Consequently, clean up AudioRendererImpl to reflect the separation
between rendering methods and state change methods.

BUG=370634

Review URL: https://codereview.chromium.org/277123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270017 0039d316-1c4b-4281-b951-d872f2087c98

this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
couple of fake calls to keep the compiler happy.
This CL also makes SetUpMetadata a member in order to ease testing in a later CL.

This depends on https://codereview.chromium.org/261843004/.

BUG=108012

Review URL: https://codereview.chromium.org/266333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270016 0039d316-1c4b-4281-b951-d872f2087c98

There was a small regression which http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929
in the range r270006-r270012 which seems to be normal growth. This updates expectations as per
http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations

See also the perf dashboard at https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=270012&checked=core

BUG=none
TBR=bokan@chromium.org,qyearsley@chromium.org

Review URL: https://codereview.chromium.org/279413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270015 0039d316-1c4b-4281-b951-d872f2087c98

Blink try bots are failing due to failure of
Tools/Scripts/lint-test-expectations

These were broken in previous CL, b/c the lint test weren't run:

Suppressions for DirectWrite tests (line thickness)
https://codereview.chromium.org/283503003

TBR=borenet, robertphillips
BUG=372497
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/288493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344451

Review URL: https://codereview.chromium.org/286553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270012 0039d316-1c4b-4281-b951-d872f2087c98

This does some small cleanup of a bunch of little things without any logic
changes.

BUG=239656

Review URL: https://codereview.chromium.org/270863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270010 0039d316-1c4b-4281-b951-d872f2087c98

* CHROME_PATH_ESCAPE was wrong (Windows doesn't need space escaping)
* run.py wasn't running a debugger
* Chrome wasn't being run with --no-sandbox when debugging 
  Windows. Turns out that is the only case where it is needed.

BUG=364223
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/272243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270009 0039d316-1c4b-4281-b951-d872f2087c98

The avatar icons should not look skewed in any setting.

This CL is a partial revert of https://codereview.chromium.org/212603011/ (specifically, the portions that changed the dimensions of the avatar icons).

BUG=367022,369495,341608

Review URL: https://codereview.chromium.org/268073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345759

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269445

Review URL: https://codereview.chromium.org/254083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270007 0039d316-1c4b-4281-b951-d872f2087c98

incognito and/or given access to the file:// scheme.

BUG=372047
R=rdevlin.cronin@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/273253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270006 0039d316-1c4b-4281-b951-d872f2087c98

Currently we rely on webmediaplayer to inform webview about fullscreen change.
With https://codereview.chromium.org/277823002/, we no longer need to do so.
When entering fullscreen, the page will be resized to fullscreen, and that will call Will/DidEnterFullscreen for us.
When leaving the fullscreen, ToggleFullscreenForTab() will request the tab to exit fullscreen. That should trigger the Resize() call and send Will/DidExitFullscreen for us.

BUG=367346

Review URL: https://codereview.chromium.org/275163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270005 0039d316-1c4b-4281-b951-d872f2087c98

Previously cached gethash responses were valid either if the last update
was recent enough, or if the item itself were recent enough.  Switch to
supporting independent item lifetimes to prepare for API v3 (which sends
lifetime information from the server).

BUG=357763

Review URL: https://codereview.chromium.org/280013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/282653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366310
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/285503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269998 0039d316-1c4b-4281-b951-d872f2087c98

This change separates the logic into two different classes. It also
- Brings back a bounce animation when there is only one window that was
lost at some point in the past.
- Removes the minimized animation if there is only one window while alt tabbing.

Basically I brought back from the past two classes,
WindowCycleController and WindowCycleList and adapted them
to work with the new codebase. Also, I moved some tests from
WindowSelectorUnittest to WindowCycleControllerUnittest, and 
removed the ones that are now irrelevant. 

Finally, we are also dropping support for alt-tabbing while
in overview mode in favour of cancelling the latter.
BUG=365786
TEST=none

Review URL: https://codereview.chromium.org/260883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269997 0039d316-1c4b-4281-b951-d872f2087c98

This parameter is unused, so we don't need to pass it down to
DidChangePriority() anymore.

This is another small chunk from r267947 unlikely to regress anything.

BUG=265753, 338338, 237249
TEST=content_shell works fine + content_unittests --gtest_filter=ResourceDispatcherTest.*
R=jam@chromium.org

Review URL: https://codereview.chromium.org/272343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269996 0039d316-1c4b-4281-b951-d872f2087c98