GitLab

Apart from some simple classes (Foo, Adder), the existing test suites
really don't share very much code. After https://crrev.com/c/1053338
they will share even less. Split out the threaded tests to their own
file to reduce complexity.

This is largely a verbatim move (preserving order), apart from
whitespace changes.

Bug: 842987
Change-Id: I555662a5516add7267abd1608f54fd13cbd7d97c
Reviewed-on: https://chromium-review.googlesource.com/1175508Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583447}

biod collects some metrics that aren't taken care of by Chrome (see
CL:1166462) for the Chrome-side metrics.
Specifically biod knows about the capture/matching latency. We also add
the number of fingers that have been enrolled as it's more readily
accessible to biod than it is to Chrome.

The corresponding Chrome OS CL is CL:1173770

R=xiaoyinh

Bug: 862295
Change-Id: I8ae56d278fd9af4494bb969e7ff6e8bb336ad2bb
Reviewed-on: https://chromium-review.googlesource.com/1175458Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nicolas Norvez <norvez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583446}

This CL adds a new set of APIs for getting/setting the states of the
multi-device features as well as adding an observer pattern for
receiving updates to these feature states.

Bug: 824568
Change-Id: If79c713b9737a738bcb9347871f0db913b7abb5b
Reviewed-on: https://chromium-review.googlesource.com/1172707
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583445}

This new notification alerts the user about a pending TPM firmware
update for the device and directs them to the about page to trigger
update installation. We currently only show the notification for a
case where the user has already decided to install the update, but
another powerwash is required to clear a vulnerable key that may have
remained in some cases.

BUG=chromium:872746
TEST=Manual

Change-Id: Id0bf5146d411af1741bb35f7e6d4c8d2437a0080
Reviewed-on: https://chromium-review.googlesource.com/1175794Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583444}

Change QSF::Job to create a new connection on the alternate network if the original connection fails on the default network before handshake is confirmed.

Bug: 790547
Change-Id: I161c09bf97f98540dd8eb6e83c811ca34d31f883
Reviewed-on: https://chromium-review.googlesource.com/1175191Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583443}

See bugs for more detail; this only helps M+ where we're using
the callback API now and can get the true error status earlier
than we could before.

This also adds a log message when onError is called so that we
can debug these more easily in the field.

BUG=873094, 610523
TEST=none

Change-Id: I3fbae95e872fe430f7dd0ddc70b01552492bd64a
Reviewed-on: https://chromium-review.googlesource.com/1176168Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583442}

<button> is type="submit" by default. Adding type="button" will prevent
the Cancel and Delete buttons from triggering the "submit" event.

Bug: 874018
Change-Id: Ie72ec07ddbaeccee29588612fc8938f268150f20
Reviewed-on: https://chromium-review.googlesource.com/1174804
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583441}

Safe browsing is a low bandwidth category and it worth collecting
the information since it may affect system wide performance.

Under that caterory, the main important trace events are to detect
whether or not the chrome_cleaner tool is scanning or cleaning. We
suspect that the cleanup tool is having system wide impact and may
explain janks observed in slow-reports.

R=oysteine@chromium.org

Change-Id: I604fdb89fd2bbbb0b13751c281cc0d936f426848
Reviewed-on: https://chromium-review.googlesource.com/1176264Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583440}

This CL changes the signature of GpuVideoAcceleratorFactories'
 VideoFrameOutputFormat(size_t bit_depth)
to
 VideoFrameOutputFormat(media::VideoPixelFormat pixel_format)
which is needed for the next CL (see also crrev.com/c/1171569).

VideoFrame::BitDepth() is extracted to media/base/video_types.cc.

Bug: 873345
Change-Id: I0afb480657ffb5ae5c3b01b6384832221476e1e9
Reviewed-on: https://chromium-review.googlesource.com/1174946Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583439}

This reverts commit ec552f22.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 583369 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWM1NTJmMjI5NTM5NzM4NzFjZWExZTYyNWNmNmIzNjZjOGMzNjM0NQw

Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71344

Sample Failed Step: mash_browser_tests (with patch)

Sample Flaky Test: ChromeSitePerProcessPDFTest.SendSyntheticTapGestureOOPIF

Original change's description:
> Set touch action Auto in MaybeSendSyntheticTapGesture
> 
> The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent,
> in which case the TouchActionFilter::allowed_touch_action_ has no value
> and will result in a crash.
> 
> This CL set the allowed_touch_action_ to auto to fix the issue. A
> browser test is added.
> 
> Bug: 873211
> Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a
> Reviewed-on: https://chromium-review.googlesource.com/1169585
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583369}

Change-Id: I2b4c4fb6b76a7a904603e7bf1086fe4f42d9f1e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873211, 874667
Reviewed-on: https://chromium-review.googlesource.com/1176503
Cr-Commit-Position: refs/heads/master@{#583438}

interactive_ui_tests: These tests are flaky on debug builds.
browser_tests: These tests are failing on official builds.

Bug: 862472
Change-Id: I4ec7ae2c6f42abd3ccaf023dc803d3317faa1434
Reviewed-on: https://chromium-review.googlesource.com/1176206Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583437}

This CL turns ShellSurfaceBase::OnSurfaceCommit into a template method
to isolate logic for ShellSurface and ClientControlledShellSurface.

Bug: b:77972398
Test: exo_unittests
Change-Id: Iad359c3754f9955fd34ea372a06e6d53999b8877
Reviewed-on: https://chromium-review.googlesource.com/1176182Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583436}

This fixes a bug where the browser window is left open and the dialog
title rolls over from "A Chromium update is available" to "A Chromium
update has been available for N days" which causes the title to wrap.

This is only a band-aid fix, calling BubbleFrameView::UpdateWindowTitle
should either push the width or height of the dialog to accommodate for
the longer title string.

Bug: chromium:869448
Change-Id: Ib78082e386111cb1da3835952fb9644051c6e572
Reviewed-on: https://chromium-review.googlesource.com/1173664
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583435}

PlatformSharedMemoryRegion leaked handles after serializing into the IPC message
on Windows, Mac and Fuchsia. Serialization code incorrectly assumed that
HandleWin, MachPortMac and HandleFuchsia classes take ownership over the handle.

What really happens is that HandleFoo is passed to WriteParam(), which causes
ParamTraits<HandleFoo>::Write() to be invoked, before it returns, creating the
HandleAttachmentFoo, which will duplicate the handle.

By the time we return from WriteParam() the handle should have been duplicated
into the serialized message, so we can safely let the PSMR close the handle when
it goes out of scope.

This CL makes the PlatformSharedMemoryRegion serialization repeat the logic of
the base::SharedMemoryHandle serialization as if the OwnershipPassesToIPC() flag
is always set to true.

Bug: 873313, 873668
Change-Id: I4e98ff9483a48970ebcb2fcf6b150f447af82794
Reviewed-on: https://chromium-review.googlesource.com/1175918
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583434}

At request of PM/UX, disable playstore search in the launcher.

Bug: 872397
Change-Id: Id3887904084be816e70a530bd143abe034a9d613
Reviewed-on: https://chromium-review.googlesource.com/1170990Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583433}

Bug: 835029
Change-Id: Ia7a73145c3d4840bd73db80170bc7eafef24ca8f
Reviewed-on: https://chromium-review.googlesource.com/1173067Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583432}

There is only one caller and it does not pass in a GURL.

Change-Id: I4ceef596436183e43e2276b3978b5f3137101eb1
Reviewed-on: https://chromium-review.googlesource.com/1175555
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583431}

This CL adds NetLog events to SQLitePersistentCookieStore.

This is split off from rdsmith@'s CL at
https://chromium-review.googlesource.com/c/chromium/src/+/925181

TBR=marq@chromium.org

Bug: 801910
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6404a341bbebbd19078b834a483804f4b8468447
Reviewed-on: https://chromium-review.googlesource.com/1174570
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583430}

This reverts commit 4eb610a5.

Reason for revert:  Causing browser crashes when launching the play store on ChromeOS on Octopus machines. b/112321675

Original change's description:
> Enable apps grid gap by default
> 
> Bug: 871448
> Change-Id: I3f8b2c4c9e22065c6615db7d3fab8c8c6b1a7e20
> Reviewed-on: https://chromium-review.googlesource.com/1164245
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581039}

TBR=xiyuan@chromium.org,weidongg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871448
Change-Id: I4c43f73fead16eb2c8208d9447968775d6d12dba
Reviewed-on: https://chromium-review.googlesource.com/1174780Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583429}

Under normal circumstances, gamepad state can only change in
response to certain triggers. By using the gamepadController test
API, the gamepad state may be changed in response to many more
triggers, including gamepad events themselves, which may cause
some events to not be dispatched. This CL modifies the layout test
to only change gamepad state outside of gamepad event listeners.

This CL also removes a hack where the string representation of the
gamepad state was being compared instead of the underlying buffers.
This hack was intended as a workaround for a bug caused by incorrect
buffer reuse behavior. The bug still exists but the test is modified
to test the reuse behavior as intended.

BUG=855760

Change-Id: I75144ae68efa355992d03692e2fd52b2f832281f
Reviewed-on: https://chromium-review.googlesource.com/1173329
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583428}

These histograms are currently empty due to (a) incorrect reporting or (b) lack of reporting.

Change-Id: Ia19b49a713fc59e57f10cdfa1d5344e39c63ee2e
Reviewed-on: https://chromium-review.googlesource.com/1173325
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583427}

Bug: 870145
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I56a5bb19f366ce570ca058f85853a35df472b4cf
Reviewed-on: https://chromium-review.googlesource.com/1176221Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583426}

This change uses an undocumented interface to the Mac SMC (System
Management Controller) to read power consumption by different parts of
the computer, including CPU and GPU(s). These web pages and projects
were all helpful, or critical, in writing it and checking assumptions:

- https://opensource.apple.com/source/PowerManagement/PowerManagement-271.1.1/pmconfigd/PrivateLib.c.auto.html
- https://opensource.apple.com/source/IOKitUser/IOKitUser-647.6/pwr_mgt.subproj/IOPMLibPrivate.c
- https://web.archive.org/web/20140816041243/http://www.parhelia.ch/blog/statics/k3_keys.html
- https://stackoverflow.com/questions/28568775/description-for-apples-smc-keys
- https://github.com/theopolis/smc-fuzzer
- https://github.com/beltex/SMCKit/
- https://github.com/hholtmann/smcFanControl/
- https://github.com/Chris911/iStats
- https://github.com/RehabMan/OS-X-FakeSMC-kozlek/
- https://www.virtualbox.org/svn/vbox/trunk/src/VBox/Devices/EFI/VBoxSmcUtil-darwin.cpp

Bug: 871801
Change-Id: I4dcd8e06b7506743e9c5e7514c7f6f9c8f2b3205
Reviewed-on: https://chromium-review.googlesource.com/1165314
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583425}

Loads the original page on a 404 or 503 server response. Further actions
for these response types will be in follow up CLs.

Bug: 864656
Change-Id: I861685e0d19f5597ade3ed814e9847a3595d9e31
Reviewed-on: https://chromium-review.googlesource.com/1171799
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583424}

The DispatchKeyEvent in InputMethodWinBaseIMM32 does not have any code
special to IMM32, so I move it to InputMethodWinBase, which can be
shared by both InputMethodWinBaseIMM32 and InputMethodWinBaseTSF.

This CL does not have any new behavior change. This DispatchKeyEvent
works when TSF is enabled, but I will try to use TSF API to replace
PeekMessage API in the following CLs.


Bug: 657623
Change-Id: I0b03f7b393660676ff26df1a9bdbfbbd43dc6a45
Reviewed-on: https://chromium-review.googlesource.com/1173336
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583423}

This implements exponential backoff to increase the wait time after each
retry attempt.

This CL also increase the default number of retry attempts to 4.

Bug:864565
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I99c167e1329bbb83d86d310e2acf164cd3f3e7cf

NOTRY=true # linux-chromeos-rel flake

Change-Id: I99c167e1329bbb83d86d310e2acf164cd3f3e7cf
Reviewed-on: https://chromium-review.googlesource.com/1176089
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583422}

PIN is hashed differently, and this hashing needs to happen even if the PIN
keyboard is not shown but the user can submit via PIN.

Bug: 873328
Change-Id: I658d7343628c6d24a42179966f1aa3c54ed3a4a8
Reviewed-on: https://chromium-review.googlesource.com/1173257
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583421}

BUILD_DATE used to take the current time and then set BUILD_DATE to
the first Sunday of the month (unofficial builds) or to that date at 5am
(official builds), so that the date stays constant for a while, to
keep binary hashes changing less frequently. (BUILD_DATE makes it into
base/, so most binaries contain it.)

This behavior is kept, but it's now based off the timestamp of the most
recent commit.

This has the advantage of being deterministic, so for example if some
Android bot builds the same revision twice, it's now guaranteed that
both builds will end up with the same timestamp. The motivation is that
I want to reland https://chromium-review.googlesource.com/1161104 which
broke Android bots which assume fully deterministic BUILD_DATEs and
currently only work by accident due to write_build_date_header.py not
rerunning in incremental builds.

Since querying git is slow and the timestamp will be queried at
gn gen time in a follow-up change, let lastchange.py write the last
commit's timestamp in a file next to build/util/LASTCHANGE and then read
that in write_build_date_header.py.

For official chrome builds we ship, this shouldn't make much of a difference,
since there's always recent commits when we ship those (if only to
update chrome/VERSION).

When syncing to an old revision (past the revision this change lands in, of
course -- say this lands and then 2 years pass, and then you sync back
1.5 years), that will now have an old date while it had a current date
before. This could happen while bisecting. You'd get more security
interstitials while bisecting.

Embedders might ship old Chromiums without having a recent commit
in src. These would have BUILD_DATEs in the past.  I announced this change on
https://groups.google.com/a/chromium.org/forum/#!topic/embedder-dev/Ymk3bHPQ45M
We can add an explicit opt-out if requested.

Build date currently affects:
- HSTS lists (considered valid for 70 days past build date)
-- but only enabled for official chrome builds (GOOGLE_CHROME_BUILD
   check in TransportSecurityState())
- certificate transparency (considered valid for 70 days past build date)
- invalid cert date interstitial (warns if system clock is
  more than 2 days behind build date, or more than 365 days
  in the future)
- browser upgrade detector indicator UI (stops checking after
  build is 12 weeks old)
- field trials (kNoExpirationYear is 2 years past build date)

//base:build_date already depends on lastchange_file and only reruns
when that file is touched (and on full builds).

Lots of prior discussion in https://codereview.chromium.org/1641413002/
(this approach but without widening was suggested in comment 26,
comment 46 mentions security concerns from agl, comment 67 onwards are about
security too. Eventually http://crbug.com/584880 got filed with a plan similar
to this CL here, but there was no time to evaluate the proposal at the time
due to internship schedule reasons. I talked to security -- namely,
felt agl ncarter carlosil -- and everyone thinks this has no obvious issues.)

Obsoletes https://chromium-review.googlesource.com/c/564598/, a prior attempt
at getting deterministic builds (opt-in, by setting an env var with the desired
date).

Bug: 314403,584880,871173
Change-Id: I6ccd78bff005572a9fa391e9820f4f5f83583c50
Reviewed-on: https://chromium-review.googlesource.com/1167913Reviewed-by: Alex Mineer <amineer@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583420}

Bug: 821021
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic6422ecc5f2298c25a8720a7dfeac17114ede0ad
Reviewed-on: https://chromium-review.googlesource.com/1173492
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583419}

Everything in the struct should have a reasonable default value and the
struct param itself is optional using base::Optional.

Include DNS qtype and initial priority support in the new parameter.
Lots of tests added in now that qtype and priority are supported by the
new API.

I'll add a similar struct of optional params to the mojo API in the next
CL.

Bug: 821021
Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4b628364e53f1c3fdf34819071b6562eaedc9c14
Reviewed-on: https://chromium-review.googlesource.com/1171574
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583418}

Add a check for tablet mode and dismiss virtual keyboard after submitting a query in tablet mode

Bug: b/112274024
Change-Id: I715dfb43d3db3211f81e1ac72cde6f62777dbc7f
Reviewed-on: https://chromium-review.googlesource.com/1176174
Commit-Queue: Xiao Yang <yanxiao@google.com>
Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583417}

Changes:
Transition dragged item to the corresponding position in folder icon
after drag is complete or cancelled.

Demo: https://drive.google.com/open?id=1b2zfBf_owGMfh3wcdmXGWZoKn-bcQs7t

Bug: 873853
Change-Id: I18fc427ac2a2b803274e9ff101fcd3aab9bdd7a3
Reviewed-on: https://chromium-review.googlesource.com/1174854
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583416}

With cryptohome's async event loop being deprecated, this calls the modern
RemoveEx function.

Bug: 211405
Change-Id: I5286ce56596969f21a2455697ef7ccc3fd85a98b
Reviewed-on: https://chromium-review.googlesource.com/1141327
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583415}

Bug: 864705
Change-Id: Ifefb1df326d50f321bb2936979284c545156b38d
Reviewed-on: https://chromium-review.googlesource.com/1141048Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583414}

for single-process-ash. Specifically to get the Env from the Widget not
the static.

BUG=847992
TEST=covered by tests

Change-Id: I508f5cbd6dabaecea00cedd05f1702db37df9a2c
Reviewed-on: https://chromium-review.googlesource.com/1176375Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583413}

Currently, the builder is configured to use goma on the recipe side but
not in mb, causing it to build with -j500 but doing local builds. The bot
running the build does not appreciate that.

Bug: 869973
Change-Id: Id27616762caff158ad660b2b6f2d8ed42a29a41b
Reviewed-on: https://chromium-review.googlesource.com/1176269Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583412}

https://chromium.googlesource.com/chromium/buildtools/+log/9a90d9a..2dff9c9

This rolls GN from "UNKNOWN" to 1413 (4cf8d15..e134e49, 33 commits):

  https://gn.googlesource.com/gn/+log/4cf8d15..e134e49

  $ git log 4cf8d15..e134e49 --date=short --no-merges --format='%h %ad %s'

  e134e493 2018-08-13 Support specifying target and host platform in gen.py
  dd6a3831 2018-08-13 Switch to libc++ on Linux
  c218b836 2018-07-02 Don't use -- in exec_script
  27ef6b4e 2018-08-13 Fix gn_unittests
  f8f395ac 2018-08-10 Remove sarcastic error message.
  f9dbfd12 2018-08-10 Avoid trailing slashes for directory in compilation database
  c0744edf 2018-08-04 Add string_replace builtin function
  09171294 2018-07-31 [output_conversion] Add output_conversion options
  c2717deb 2018-08-02 [compdb] Properly escape for JSON
  f4facf42 2018-08-04 Don't allow ./ before target name.
  499868c6 2018-07-18 port gn to aix
  387e3ab4 2018-07-23 Add an OWNERS file.
  11e09914 2018-07-31 [docs] Updating documentation for compdb
  e2a2940a 2018-07-31 [target] Propagate configs across toolchains when specified
  d2d7ecb2 2018-07-30 Default to "ar" instead of "llvm-ar"
  9ae36b8b 2018-06-13 Update AUTHORS to reflect Chromium-tree contributions
  9a9ed6df 2018-07-26 Move all docs to toplevel docs/ folder.
  cad6b537 2018-07-23 Add notes about the CLA and gn-dev@ to the README.
  5d9a4e9a 2018-07-20 Make ICF an option in gen.py
  d7111cb6 2018-07-16 Enable identical code folding link option
  a6c2a5d5 2018-07-15 Use -ffunction-sections and -fdata-sections
  796ed47b 2018-07-16 Add reference.md
  63b72701 2018-07-15 Make LTO an option in gen.py
  d9bca564 2018-07-13 Fixes for --out-path and --no-sysroot
  0e4f3935 2018-07-13 Add options necessary for Chromium's bootstrap.py to forward to gen.py
  6ef28560 2018-07-13 Correct grammar in current_{cpu,os} docs
  8ce4e49a 2018-07-02 [gn] Add --export-compile-commands switch to gen
  f0b4405f 2018-07-09 Don't pass -flto.
  9911c782 2018-07-03 [command_args] Properly set file and line in dict
  39687ba9 2018-07-03 [command_args] Strip the preceding whitespace in comments if not padding
  fdc7a748 2018-06-29 Improve --version per discussion
  9cd5057b 2018-06-29 [recipes] Add --tags to git fetch command
  3ddcf64a 2018-06-29 Make gn --version work

TBR=fjhenigman@chromium.org

Change-Id: I54ae8b0c6d64174ec27e8eae7870eaa67d1dc037
Reviewed-on: https://chromium-review.googlesource.com/1173727
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583411}

Use the autoclick mojo app when running mash.

Use ash for high contrast mode, not the window service API (which
doesn't work under mash).

Bug: none
Change-Id: I2423ec0fcc90bde9b5f4835450411009ca720427
Reviewed-on: https://chromium-review.googlesource.com/1175234Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583410}

https://chromium.googlesource.com/angle/angle.git/+log/21e5e85a4976..c1551dc2a7dc


git log 21e5e85a4976..c1551dc2a7dc --date=short --no-merges --format='%ad %ae %s'
2018-08-15 till.rathmann@gmx.de D3D11 fix: Mipmapping was used although disabled via Sampler


Created with:
  gclient setdep -r src/third_party/angle@c1551dc2a7dc

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I39589a080b39acdeab50d2a7a07a38b9c1f0e2e7
Reviewed-on: https://chromium-review.googlesource.com/1176241Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583409}

display.html prompts a user for a stat-file produced by
generate_perf_report.py and displays it in a table.

Change-Id: Ia82ab50eaedaef35e8c38ca49d8e602f2b6d22b6

Bug: 839491
Change-Id: Ia82ab50eaedaef35e8c38ca49d8e602f2b6d22b6
Reviewed-on: https://chromium-review.googlesource.com/1108965
Commit-Queue: Stephan Stross <stephanstross@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583408}