- 07 Mar, 2018 40 commits
-
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I9fc7d132c4204787d1fe406b7d6428475499068c Reviewed-on: https://chromium-review.googlesource.com/952324Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#541601}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I0b8b9b17a69d01986adf328b808c71bacd2fb8fe Reviewed-on: https://chromium-review.googlesource.com/953046 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541600}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f43d0a5. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13459 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: garykac@chromium.org: external/wpt/clipboard-apis TBR=robertma No-Export: true Change-Id: I9c6a82fe266d6ac06672792957e389e69b534ad4 Reviewed-on: https://chromium-review.googlesource.com/953402 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541599}
-
mrefaat authored
These tests started failing once they were landed. created crbug/819658 to track progress and re-enable them. link for logs: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/10443/steps/ios_chrome_unittests%20%28iPhone%206s%20iOS%2010.3.3%29%20on%20iOS-10.3.3 Bug: 819658 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I470732c12bffc2e8e105c159c8616d679771381c Reviewed-on: https://chromium-review.googlesource.com/951649Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#541598}
-
Sidney San Martín authored
This reverts commit a47974de. Reason for revert: https://crbug.com/819339 This breaks the flow of: 1. Click a tab. 2. Shift-click to select a range of tabs. 3. Release shift and drag the tabs out into a new window. …because the ListSelectionModel which backs the tab strip clears the selection when the active item is changed. It's going to take some work to make it behave the right way. Original change's description: > Switch tabs on mouse down instead of mouse up. > > This is consistent with other Mac apps and with Views, and makes the tab > strip feel more responsive. > > Bug: 799230 > Change-Id: I45a375f5892c10e5886e18f27ba049eb6215a17f > Reviewed-on: https://chromium-review.googlesource.com/895925 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533373} TBR=ellyjones@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 819339, 799230 Change-Id: I9921e0d41669d6783ff0f8f3f0d4b0746eb72b68 Reviewed-on: https://chromium-review.googlesource.com/953304 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541597}
-
erikchen authored
Change-Id: I4d083c46e027f9a1806c1bfb2c752ebb7e462f46 Reviewed-on: https://chromium-review.googlesource.com/952992Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541596}
-
Philip Jägenstedt authored
These all redirect. Process was to copy into browser, follow redirect and copy URL back. In a few cases where the anchor wasn't there, I found the correct URL instead. Really in order to get the URLs in *.idl correct, related to https://github.com/w3c/web-platform-tests/issues/7784. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iab73c1d51b1da4ab66c0e8314b0b3e701bbd19f2 Reviewed-on: https://chromium-review.googlesource.com/952298Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541595}
-
Matt Menke authored
And add support for it to services/network. This CL introduces network::mojom::ChunkedDataPipeGetters which is similar to DataPipeGettter, but is used for chunked uploads, which allow consumers to start uploading a request body before its size is known. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7d7dfad4b6e33329cf56f7c9d1666944a7b25475 Bug: 746977 Reviewed-on: https://chromium-review.googlesource.com/908828 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#541594}
-
Alexei Svitkine authored
The previous UMA API reported the hardware class in capital letters. This CL makes the new code also be capitalized. Changes the variations comparison logic to be case insensitive so that lowercase value continue to work. The benefit of having consistent UMA and variations values is that we can use UMA to get the set of possible values withour relying on any external source. BUG=810872 Change-Id: Ia291143e3022edfa701a1454d45b05040d1043d2 Reviewed-on: https://chromium-review.googlesource.com/953333Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#541593}
-
Darren Shen authored
This patch: - Deletes unused interface.html - Fixes <div> tag in tests. - Adds case-sensitivity tests. Bug: 774887 Change-Id: I194ec7549991bfcd7708e640458246b40fc3ab03 Reviewed-on: https://chromium-review.googlesource.com/952509Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#541592}
-
Eric Stevenson authored
Updated via: build/android/binary_size/apk_downloader.py \ --update 65 530369 --update 66 540276 Change-Id: Ic811189e614f2b883a5894f03bd49043cb69af31 Reviewed-on: https://chromium-review.googlesource.com/951872Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#541591}
-
Jiaquan He authored
Bug: 733662 Change-Id: I54774d88af76dca872af17da2438648ff0c13cc5 Reviewed-on: https://chromium-review.googlesource.com/952100Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#541590}
-
file:///Lukasz Anforowicz authored
file URIs should map to "file:///" site. The same site needs to also be used for blob:file:///... URIs - this is what is fixed by this CL. Bug: 697111 Change-Id: Iff9e9a1552eb747ecd576aefdc5085009588690b Reviewed-on: https://chromium-review.googlesource.com/953129Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#541589}
-
mark a. foltz authored
- Removes references to 'description' and 'status' in MediaStatus. Removal from the mojo interface will be done in a separate patch. - Don't show media title if it is empty, undefined, or duplicates the route description. This works around scenarios where the Cast media controls are sending duplicates. - Fixes a bug: JS calls to set the max dialog height were being made before the WebUI was loaded. This may a the cause of flakiness on the Media Router bots. Bug: 786208 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2df6f28be0644ae3815f8dadee3cf53b2deeddd2 Reviewed-on: https://chromium-review.googlesource.com/949448Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541588}
-
Marijn Kruisselbrink authored
Also deduplicate total_bytes_ and expected_content_size_, as well as get rid of code for dealing with unknown total_bytes_ as it isn't actually possible to get to that codepath. Bug: none Change-Id: I4d9f442bf04d450d289d717bd12f721e48b80a50 Reviewed-on: https://chromium-review.googlesource.com/953125Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#541587}
-
Donn Denman authored
This reverts commit ba4d1c49. Reason for revert: Broke the N5 compile. Original change's description: > [TTS] reland mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org > > Original CL: > > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Change-Id: I824837419cd4116b26b32170009e7a7c3308d109 > Reviewed-on: https://chromium-review.googlesource.com/952679 > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541569} TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org Change-Id: I25de406ee1c18aa1468d23dcafc81d4930f5717f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754862 Reviewed-on: https://chromium-review.googlesource.com/953369Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541586}
-
Shuotao Gao authored
This reverts commit 92aa9f81. Reason for revert: inspector-protocol/heap-profiler/heap-snapshot-merged-nodes.js is failing since https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/6477 until https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/6482 when this revert is created. Original change's description: > Reland "[heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot." > > This relands commit d690c638. > > Original change's description: > > [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot. > > > > Each DOM node has a corresponding JS wrapper node. In heap snapshot > > they appear as duplicates. > > > > Example retaining path with duplicates: > > - [1] in InternalNode @2041178784 > > - [1] in HTMLDivElement @2041079168 // DOM node > > - [3] in HTMLDivElement @2231// JS wrapper > > - retainer in Window / @2105 > > > > The heap snapshot generator now can merge an embedder node with a node > > returned by EmbedderGraph::Node::WrapperNode() function. > > > > This patch implements the WrapperNode() function for each DOM node. > > > > Bug: chromium:811925 > > Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019 > > Reviewed-on: https://chromium-review.googlesource.com/928503 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#539132} > > > Change-Id: I4223d1369874ad34dfff1a74d5725360c360300c > Reviewed-on: https://chromium-review.googlesource.com/951252 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541403} TBR=ulan@chromium.org,haraken@chromium.org,hbos@chromium.org Change-Id: Ic99975f4052831b7a799c882a2227e1a64d04f97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/953368Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#541585}
-
Xiaohan Wang authored
This partially reverts https://codereview.chromium.org/2858393002/ Now mojo CDM is enabled by default, there's no contention on the main render thread any more. Change the audio buffer size back to the original value. Note that it's still possible that audio performance is not as good as clear audio due to extra decryption overhead. So still keep a separate kStartingCapacityForEncryptedInMs constant to keep the ability to choose a different capacity for encrypted audio. Will watch our metrics to see whether we need more adjustment on this value. Bug: 718161 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7420950d05e35892d1ef595a77ee716f8a716d2f Reviewed-on: https://chromium-review.googlesource.com/946864Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541584}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b2a75aa2..1666d944 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If3ad5817d4c149bc51f0d51b19eaa94907dcdfc1 Reviewed-on: https://chromium-review.googlesource.com/952989Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#541583}
-
Owen Min authored
This is a new implementation of DesktopCloudPolicyStore. It has - Different path of policy cache The policy files are store as "$user_data_dir/Policy/Machine Level User Cloud Policy" and "$user_data_dir/Policy/Machine Level User Cloud Policy Signing Key". - Global dm_token and client_id It will load the policy cache from disk iff the global token is existed. And it will validate the dm_token and client_id with the global ones after store/load. Bug: 812641 Change-Id: If02ad77388fc197f20dc25c04c1f852e1827253a Reviewed-on: https://chromium-review.googlesource.com/940442 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#541582}
-
Tarun Bansal authored
Bug: 810806 Change-Id: I9bbea1cb50278a31fe4c95c6cf6c730ad9e37abc Reviewed-on: https://chromium-review.googlesource.com/944509Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541581}
-
Peter Collingbourne authored
mini_installer is a "special" target that avoids linking against vcruntime by defining a custom entry point. In normal Windows builds, exe_and_shlib_deps will be empty, so depending on it has no effect. But when building with use_custom_libcxx=true, exe_and_shlib_deps depends on libc++, which in turn depends on vcruntime, leading to undefined symbol errors at link time when the custom entry point is used. This change avoids the dependency on exe_and_shlib_deps unless the custom entry point is disabled, i.e. when we are linking with asan. Bug: 801780 Change-Id: Ieff8004ef14c9fda20ff23234cab364ae949afbe Reviewed-on: https://chromium-review.googlesource.com/952068 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541580}
-
Xiaohan Wang authored
Pepper CDM support is deprecated, so is ppapi CDM adapter binary. This CL removes all CDM adapter related code from CdmHostFiles. Also removes all CDM related code from PpapiThread, including CDM host verification code that uses CdmHostFiles. Bug: 772160 Change-Id: I727063d60eeccc60330c10c2fa9339bdc72813a3 Reviewed-on: https://chromium-review.googlesource.com/947923 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#541579}
-
Takumi Fujimoto authored
The histogram name for sink type selection was not the same as the one in histograms.xml, and was not being recorded as a result. This CL fixes that. Bug: 783850 Change-Id: Ia6c1d983c8933ae9c0dedd83cbe0d1ef7df13db1 Reviewed-on: https://chromium-review.googlesource.com/951895Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#541578}
-
Ovidio Henriquez authored
This change refactors the Web Bluetooth test API to use the DeviceUUIDs helper class defined in BluetoothDevice. Additionally, this change finishes the implementation of SimulateGATTServicesChanged, and as a result, tests are updated to set the next discovery response before calling this interface. BUG=719826 Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d Reviewed-on: https://chromium-review.googlesource.com/939984 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#541577}
-
Nico Weber authored
Several changes to the bindings [1] landed while the change that added the mock writer was in review [2]. The mock writer wasn't rerun right before it landed, so its output is out-of-sync with the bindings metadata. Rerun the generator to fix things up. This is a prerequisite for a change I want to make to the generator. 1: https://chromium-review.googlesource.com/c/chromium/src/+/766687, https://chromium-review.googlesource.com/c/chromium/src/+/779087 2: https://chromium-review.googlesource.com/c/chromium/src/+/772810 Bug: 761432,550065 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1ad3658c8f92bdd587d1659bb21d58ac71a549f6 Reviewed-on: https://chromium-review.googlesource.com/953382Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541576}
-
Philip Jägenstedt authored
This is a mechanical replace plus some line breaking. Done because https://github.com/GoogleChromeLabs/webidl-diff uses these URLs to decide where to go look for specs with IDL to scrape. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I929161a414e825ce6bf2e17ea295a0af78e30fd7 Reviewed-on: https://chromium-review.googlesource.com/952539Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541575}
-
Philip Jägenstedt authored
The non-numbered variants are used in other places, so this is not new. Purpose is to avoid finding these URLs in https://github.com/GoogleChromeLabs/webidl-diff. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I59731c0588df176f18390c21a792b2ec99ba42fc Reviewed-on: https://chromium-review.googlesource.com/952530Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541574}
-
Artur Khachatryan authored
Chrome version for Windows is updated. On the previous commit I had entered a wrong Chrome version 540270. Updated with the correct version of 540272. Change-Id: I6b14cf4ce08e7ece73397eeef0e4f15521ae85e5 Reviewed-on: https://chromium-review.googlesource.com/952115Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541573}
-
Stephen McGruer authored
This reverts commit c838bf40. Reason for revert: virtual/threaded/animations/hit-testing/composited-with-hit-testing.html fails in Debug, flaky in Release Builders failed on: - WebKit Linux Trusty (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29 - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Flakiness Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fanimations%2Fhit-testing%2Fcomposited-with-hit-testing.html Bug: 819591 Original change's description: > Web Animations: use WTF::Optional for Animation::start_time_ > > Bug: 791086 > Change-Id: I916508fc5cf0c16543decd3f8197d034f2a4e6d8 > Reviewed-on: https://chromium-review.googlesource.com/941963 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541223} TBR=flackr@chromium.org,smcgruer@chromium.org Change-Id: I2094317fbf67d28bb5c32124a7d3fa62c7323a3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791086 Reviewed-on: https://chromium-review.googlesource.com/953363Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#541572}
-
Sorin Jianu authored
Bug: 819645 Change-Id: Iff4fbf906aa5e066db462aa41365e158969bc9b2 Reviewed-on: https://chromium-review.googlesource.com/953065 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#541571}
-
Trent Apted authored
The way GTK theming is plumbed through is very subtle, and we don't know yet how that should influence new color schemes. This CL tries to isolate (and make explicit) the complexity required for GTK theming on Desktop Linux by introducing OmniboxTint::NATIVE, as distinct from LIGHT and DARK used everywhere else. Bug: 819425, 801583 Change-Id: I34ad8113f5e66843dab685c3ce3470dd7bd7f675 Reviewed-on: https://chromium-review.googlesource.com/952503 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541570}
-
Donn Denman authored
Replaces the whole call chain for ShowUnhandledTapUIIfNeeded between Blink and Chrome/WebView with Mojo messaging. Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo that sends a Mojo construct of the same name to the Browser which has a service installed via a RenderHostFrame observer. All functionality should remain unchanged. NEW CODE: The CSTabHelper now creates an UnhandledTapWebContentsObserver that connects the Mojo service via UnhandledTapNotifierImpl. That Impl calls back through Java to the CSTabHelper to the CSManager to notify that a Tap has occurred. The CSTabHelper ignores these notifications when CS is disabled. The mojo message is only sent to the browser if the tap is unhandled and the other required conditions are met. UPDATED TESTS: Test notification is now done through mojo messaging, so we now only know if the tap was unhandled, not whether the page changed or other details about why the tap was unhandled. Updated the test page by adding nodes that do not trigger, and removed the mousemove handler since it's unrelated to tap handling. BUG=754862 TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org Original CL: Reviewed-on: https://chromium-review.googlesource.com/841544Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Change-Id: I824837419cd4116b26b32170009e7a7c3308d109 Reviewed-on: https://chromium-review.googlesource.com/952679 Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541569}
-
Devlin Cronin authored
We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest files under chrome/test/data/extensions/manifest_tests (which are not usually named manifest.json). This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: Id8b03de2bd26a70d313e85cf56433e3788686e2d Reviewed-on: https://chromium-review.googlesource.com/950225Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541568}
-
Vlad Tsyrklevich authored
Implement platform-specific ProtectedMemory behavior, specifically implement setting memory read-only/read-write, checking whether a given pointer points to read-only memory, and identifying the beginning and end points for the protected memory section. Bug: 771365 Change-Id: I814ed932f3b57dc674ae342f79622fc84c92c351 Reviewed-on: https://chromium-review.googlesource.com/765009Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541567}
-
Corentin Wallez authored
BUG= Change-Id: If0e07f2a53c084f3fdedc5e9b78a76aab5402048 Reviewed-on: https://chromium-review.googlesource.com/953207Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541566}
-
Yafei Duan authored
There will be a StrictMode violation in a callback in PopUpInfo.onClick. Fixing by disabling StrictMode during the call. For more details please refer to the bug, this can be reverted if the root cause is the CL mentioned in the comment #3 in the bug. Bug: 819410 Change-Id: Ib79f83835b7938b327daec30e884a03924e7e32e Reviewed-on: https://chromium-review.googlesource.com/952673Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#541565}
-
Peng Huang authored
TBR=stgao@chromium.org Bug: 819683 Change-Id: I48ea37df344775b577d1231286a20f46584b7634 Reviewed-on: https://chromium-review.googlesource.com/953130Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541564}
-
https://chromium.googlesource.com/angle/angle.git/+log/7618eaf9ad45..e4c5a23b1148 $ git log 7618eaf9a..e4c5a23b1 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 jmadill Vulkan: Always use LOAD for RenderPass attachments. 2018-03-06 tobine Roll (1/2) LVL version forward and disable VANGLE 2018-03-02 cwallez Allow rectangle textures to be sample with texture() in ESSL3 Created with: roll-dep src/third_party/angle BUG=757974 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iec15cbc5752aebe0c3da0b7788b784db67df6e85 Reviewed-on: https://chromium-review.googlesource.com/952961Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541563}
-
Xiaohan Wang authored
We are not using PPAPI to host CDMs anymore. Hence no need to specify PepperType for KeySystems. Bug: 772160 Change-Id: Ie9d2f34ef49e93b0039e9e3718ee95392289281a Reviewed-on: https://chromium-review.googlesource.com/947808 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#541562}
-