GitLab

The default implementation provides no subservices. Its purpose is to fulfill a dependency (in unit tests)
when other BrowserContextKeyedServices depend on an ExtensionSystem. Tests that actually need subservices
can override the necessary methods to provide them.

Also, this defines a MockExtensionSystemFactory template for ease of use with MockExtensionSystem subclasses.

BUG=348066

Review URL: https://codereview.chromium.org/460203002

Cr-Commit-Position: refs/heads/master@{#289235}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402453

Review URL: https://codereview.chromium.org/463053002

Cr-Commit-Position: refs/heads/master@{#289234}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289234 0039d316-1c4b-4281-b951-d872f2087c98

Modify permissions and checks in GuestView, WebUI, and
extensions to allow <extensionoptions> to be used within WebUI.
In the GuestView infrastructure, allow guest views in WebUI to
be created without extension ids. In extensions, allow extension
options-related APIs to be used in WebUI contexts. In WebUI,
relax the CSP to allow internal browser plugins.  


BUG=386842

Review URL: https://codereview.chromium.org/453613002

Cr-Commit-Position: refs/heads/master@{#289233}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289233 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, ImageTransportSurfaceFBO had the property
that it would un-schedule the GPU channel at a swap, and then
re-schedule the GPU channel when the swap was acknowledged by
the browser process.

Separate out the re-scheduling of the channel into the function
ImageTransportSurfaceFBO::UnblockContextAfterPendingSwap.
Previously, this re-scheduling was done after receiving an ack in
the form of the AcceleratedSurfaceMsg_BufferPresented IPC.

Because the re-scheduling of the GPU channel is no longer blocked
on the AcceleratedSurfaceMsg_BufferPresented IPC, issue that
IPC from the UI thread in the browser when the SwapBuffers IPC
is processed (instead of doing so on the IO thread immediately).
Get rid of the hacks being used prevent the IOSurface from being
freed while the SwapBuffers IPC was bouncing from the IO thread to
the UI thread.

For IOSurface-based ImageTransportSurfaces, re-schedule the GPU
channel immediately, because the ui::Compositor in the browser
process is responsible for "feeling" the GPU back-pressure in its
CompositingIOSurfaceLayer. Prevent the IOSurface from being freed
while it is in-flight by keeping around an extra reference to all
in-flight IOSurfaces (the reference is taken at SwapBuffers and is
released at AcceleratedSurfaceMsg_BufferPresented).

For CAContext/CALayer-based ImageTransportSurfaces, re-schedule
the GPU channel when the ImageTransportLayer in the GPU process is
displayed (the back-pressure is "felt" within the same process).
Because the CAContext used for this ImageTransportSurface is static
for the lifetime of the ImageTransportSurface (unlike IOSurfaces
where re-allocation at resize is common), there is no need to keep
around references to in-flight surfaces.

BUG=312462
R=jbauman
TBR=kbr

Review URL: https://codereview.chromium.org/454243002

Cr-Commit-Position: refs/heads/master@{#289232}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289232 0039d316-1c4b-4281-b951-d872f2087c98

This CL re-lands https://codereview.chromium.org/414383002. It fixed a bug
where debug testers failed to find binaries. TryServer failed to catch this
bug due to the fact that rel and dbg testers are sharing the same checkout on
bots. https://codereview.chromium.org/452263002/ was submitted to make sure any
tester that downloads and extracts archive will clean it up.

BUG=329102
R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/465723002

Cr-Commit-Position: refs/heads/master@{#289231}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289231 0039d316-1c4b-4281-b951-d872f2087c98

When changing networks, send a new mdns query for devices,
since the device list was flushed.

Review URL: https://codereview.chromium.org/463253002

Cr-Commit-Position: refs/heads/master@{#289230}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289230 0039d316-1c4b-4281-b951-d872f2087c98

> Update ui::CompositorObserver instrumentation
> 
> We'll want to make it the case that ui::CompositorObservers don't
> outlive their ui::Compositors on all platforms. Update the instrumentation
> and TODOs to reflect this, and move them to be behind DCHECK.
> 
> BUG=403011
> 
> Review URL: https://codereview.chromium.org/467703003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/467153002

Cr-Commit-Position: refs/heads/master@{#289229}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289229 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org, sergeyv, pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/461403002

Cr-Commit-Position: refs/heads/master@{#289228}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289228 0039d316-1c4b-4281-b951-d872f2087c98

Previously, ExtensionUninstallDialogViews called CloseNow() on it's own
delegate's Widget if it was destroyed before an Accept/Cancel handler
was called. However, the Widget had already been freed by the Widget
hierarchy, resulting in a crash.

Made ExtensionUninstallDialogViews notify
ExtensionUninstallDialogDelegateView when it closes, so now either order
is possible: either class can be destroyed first (either by the user, or
by the views hierarchy) and the other will be safely destroyed.

TEST=Open the App List in ChromeOS, then right-click on an app and
select 'App Info', then click 'Remove'. Now click away from the app list
to dismiss it. Previously, this would cause a crash.
TEST=Open the App List in Linux, then right-click on an app and
select 'App Info', then click 'Remove'. Now click the 'close' button in
the app info dialog to close the dismiss it. Previously, this would
cause a crash.

BUG=390414,400909

Review URL: https://codereview.chromium.org/412483006

Cr-Commit-Position: refs/heads/master@{#289227}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289227 0039d316-1c4b-4281-b951-d872f2087c98

cast_simulator should call .Pass() to pass the PacketPipe for
simulation.

TBR=miu

Review URL: https://codereview.chromium.org/463373003

Cr-Commit-Position: refs/heads/master@{#289226}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289226 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an old TODO, makes recording more robust and improves the
cycle time of the record_wpr unittests from about 33s -> 26s on my MBP.

BUG=388256

Review URL: https://codereview.chromium.org/465213002

Cr-Commit-Position: refs/heads/master@{#289225}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289225 0039d316-1c4b-4281-b951-d872f2087c98

We'll want to make it the case that ui::CompositorObservers don't
outlive their ui::Compositors on all platforms. Update the instrumentation
and TODOs to reflect this, and move them to be behind DCHECK.

BUG=403011

Review URL: https://codereview.chromium.org/467703003

Cr-Commit-Position: refs/heads/master@{#289224}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289224 0039d316-1c4b-4281-b951-d872f2087c98

> Create NaCl build of gtest.
> 
> BUG=401761
> 
> Review URL: https://codereview.chromium.org/401453002

TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/466303002

Cr-Commit-Position: refs/heads/master@{#289223}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289223 0039d316-1c4b-4281-b951-d872f2087c98

There was a race condition where GetTokenService could be called on an
already destroyed TokenServiceProvider (see linked bug for details).
Update Core to ensure TokenServiceProvider is not destroyed out from
under the token service task runner thread.

BUG=401119

Review URL: https://codereview.chromium.org/458753006

Cr-Commit-Position: refs/heads/master@{#289222}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/453033004

Cr-Commit-Position: refs/heads/master@{#289221}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289221 0039d316-1c4b-4281-b951-d872f2087c98

This reduces telemetry_unittests cycle time by ~12s on all platforms.


BUG=402956
TEST=NO_TVCM=1 tools/telemetry/run_tests action_runner play seek

Review URL: https://codereview.chromium.org/463013003

Cr-Commit-Position: refs/heads/master@{#289220}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289220 0039d316-1c4b-4281-b951-d872f2087c98

Currently when unpublishing or unsubscribing, we still keep playing or recording
audio till it times out. We need to keep a track of which operations have
requested playing or recording and once those operations are unpublished or
unsubscribed, we need to appropriately stop the record/playback.

To do this, the first change is to stop keeping a list of tokens, instead we
just keep a list of operations. If we send our currently playing token to the
server, it is guaraunteed to _not issue another token, unless our current token
is going to expire in less time than is on the publish. In that case, we simply
replace our currently playing token with the new one, making sure that we
always just need to keep one token around.

With this, the logic for playing/recording is completely changed. Now we just
check if we have active transmit/receive, and if we do, we ensure that we are
playing our current token (or keep recording); if we do not have an active
transmit and we are playing, we stop playing. For all other cases our
ProcessNextTransmit and ProcessNextReceive is a nop.

The one ugliness in the code is that we have to keep the code for processing
the audible and inaudible tokens in the same class, since the WhispernetClient
can only give 'one' method tokens back. If two different classes call the
WhispernetClient to encode tokens, the get samples callback from the second
will overrite the callback for the first, hence the first class will never
get its samples back. Once we find a way around this, we can just have two
AudioDirectiveHandlers, one for audible and one for inaudible, but till then
we need to keep this processing together in one AudioDirectiveHandler.


R=xiyuan@chromium.org
BUG=392028

Review URL: https://codereview.chromium.org/461803003

Cr-Commit-Position: refs/heads/master@{#289219}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289219 0039d316-1c4b-4281-b951-d872f2087c98

The crash occurs because of a timer dereferencing a null engine pointer.
The crash appears to have occurred due to this patch https://codereview.chromium.org/427583003/

Fix is to cancel all timers when the pdf instance is being torn down before
destroying the engine.

BUG=403036

Review URL: https://codereview.chromium.org/462283002

Cr-Commit-Position: refs/heads/master@{#289218}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289218 0039d316-1c4b-4281-b951-d872f2087c98

Force a commit if the top controls animate the scroll offset. This prevents main
and impl scroll offsets from remaining out-of-sync, which can cause problems
with subsequent touch interaction.

BUG=402907,364340

Review URL: https://codereview.chromium.org/461083002

Cr-Commit-Position: refs/heads/master@{#289217}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401761

Review URL: https://codereview.chromium.org/401453002

Cr-Commit-Position: refs/heads/master@{#289216}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402943

Review URL: https://codereview.chromium.org/464243002

Cr-Commit-Position: refs/heads/master@{#289215}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289215 0039d316-1c4b-4281-b951-d872f2087c98

Clicking on the install button for a paid app will now open the webstore
page for the app, where the user can sign in (if not signed in already)
and see the price of the app / buy it.

BUG=319024
TEST=Check installing paid and unpaid apps from the app launcher search
results.

Review URL: https://codereview.chromium.org/448543002

Cr-Commit-Position: refs/heads/master@{#289214}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401588

Review URL: https://codereview.chromium.org/450053003

Cr-Commit-Position: refs/heads/master@{#289213}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289213 0039d316-1c4b-4281-b951-d872f2087c98

Keep trackers demoted when it is being synced from local to remote, so that the tracker is not chosen for another LocalToRemoteSyncer instance.

BUG=344769
TEST=unit_tests --gtest_filter=LocalToRemoteSyncerTest.*

Review URL: https://codereview.chromium.org/446793002

Cr-Commit-Position: refs/heads/master@{#289212}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289212 0039d316-1c4b-4281-b951-d872f2087c98

Screenshot:
http://i.imgur.com/RILqQqe.png

BUG=234425

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288418

Review URL: https://codereview.chromium.org/359493005

Cr-Commit-Position: refs/heads/master@{#289211}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289211 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289210}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289210 0039d316-1c4b-4281-b951-d872f2087c98

Revert of GN: Specify grit generated output paths to be the same as gyp's. (patchset #1 of https://codereview.chromium.org/454253004/)

Reason for revert:
Broke GN compile and try jobs

http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN

Original issue's description:
> GN: Specify grit generated output paths to be the same as gyp's.
> 
> BUG=401588
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289149

TBR=brettw@chromium.org,jamescook@chromium.org,yoz@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401588

Review URL: https://codereview.chromium.org/461213003

Cr-Commit-Position: refs/heads/master@{#289209}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289209 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Split Screen mode implementation. (patchset #3 of https://codereview.chromium.org/461503002/)

Reason for revert:
Breaking "Linux Chromium OS ASan LSan Tests (3)" http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2721

Original issue's description:
> Split Screen mode implementation.
> 
> Implements Split Screen mode and window cycling behavior.
> Resubmit of https://codereview.chromium.org/420603011/
> 
> TBR=oshima@chromium.org,mukai@chromium.org
> 
> BUG=383421
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289064

TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383421

Review URL: https://codereview.chromium.org/468053002

Cr-Commit-Position: refs/heads/master@{#289208}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289208 0039d316-1c4b-4281-b951-d872f2087c98

Segfault occurs in internet_options_handler.cc when accessing a
non-existent policy. This was introduced in https://crrev.com/427903004.

Please note: http://imgur.com/sD3vz0W.jpg

BUG=403111
R=pneubeck@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/470433002

Cr-Commit-Position: refs/heads/master@{#289201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289201 0039d316-1c4b-4281-b951-d872f2087c98

This file was just a placeholder, including blink_test_environment.h
waiting for Blink to be updated.

Now that Blink was updated and rolled into Chromium, we can remove it.

Chromium side (part 1) ->
https://src.chromium.org/viewvc/chrome?revision=288636&view=revision
Blink side (part 2) ->
https://src.chromium.org/viewvc/blink?revision=179977&view=revision
Chromium side (part 3) -> this patch

BUG=None
TEST=webkit_unit_tests
R=avi@chromium.org

Review URL: https://codereview.chromium.org/463603003

Cr-Commit-Position: refs/heads/master@{#289200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289200 0039d316-1c4b-4281-b951-d872f2087c98

- keyboard overlay and partial_screenshot overlay should do nothing
  if there are already overlays.
- overlay_event_filter should cancel the existing delegate if
  another delegate is trying to activate.

BUG=341958
R=jamescook@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/461093003

Cr-Commit-Position: refs/heads/master@{#289199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/465143002

Cr-Commit-Position: refs/heads/master@{#289198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289198 0039d316-1c4b-4281-b951-d872f2087c98

Decoders can register to get notified when a Decryptor is set.
setContentDecryptionModule() provides a new Decryptor to
WebMediaPlayer. Since the decoders run on the media thread, it may
take some time for the old Decryptor to get detached and a new one
connected. Adding a callback to be used so that
setContentDecryptionModule() knows when the Decoders are done with
the notification. The additional callback is optional. This will be
used to resolve the setMediaKeys() promise on the blink side.

BUG=358271
TEST=media unittests and EME layout tests pass

Review URL: https://codereview.chromium.org/416333011

Cr-Commit-Position: refs/heads/master@{#289197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289197 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289195}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289195 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

Review URL: https://codereview.chromium.org/467943002

Cr-Commit-Position: refs/heads/master@{#289194}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289194 0039d316-1c4b-4281-b951-d872f2087c98

Notify the ContentViewClient of selection and insertion-related events,
allowing customized behavior depending on the state of selection. This is
particularly relevant for informing how the selection text string is being
updated.

BUG=400824

Review URL: https://codereview.chromium.org/469483002

Cr-Commit-Position: refs/heads/master@{#289193}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289193 0039d316-1c4b-4281-b951-d872f2087c98

Has a JavaScript file that contains a function to tell whether or not a
page is an article and related functions to get a string of that JavaScript
so that it can be injected into the page.

BUG=383630

Review URL: https://codereview.chromium.org/464973002

Cr-Commit-Position: refs/heads/master@{#289192}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289192 0039d316-1c4b-4281-b951-d872f2087c98

This changes the currently unused V8ObjectVar to store a pointer to the
instance rather than a PP_Instance ID. This is just more convenient for
the code which uses the V8ObjectVar. When the instance is deleted, the
pointer will be cleared so it should always be valid or NULL.

BUG=351636

Review URL: https://codereview.chromium.org/464653003

Cr-Commit-Position: refs/heads/master@{#289191}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289191 0039d316-1c4b-4281-b951-d872f2087c98

Made changes based on new API level to make Lint happy in all
builds.

BUG=327768

Review URL: https://codereview.chromium.org/460453002

Cr-Commit-Position: refs/heads/master@{#289190}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350219
TBR=thestig

Review URL: https://codereview.chromium.org/460183002

Cr-Commit-Position: refs/heads/master@{#289189}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289189 0039d316-1c4b-4281-b951-d872f2087c98