GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/19157ee4a2fd..e2645e44ad6b

2020-09-01 lalitm@google.com Merge "ui: fix io related thread state bugs"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I9661ff293e10eba49a891f8cb61c072ed253bcfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387447Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803457}

This CL removes all studies in fieldtrial_testing_config.json where
neither the study name nor any of enabled or disabled feature names
appear as a string literal elsewhere in the codebase.

This CL has been generated semi-automatically:
1. Download cleanup.py attached to https://crbug.com/1053702#c3
2. Generate cleaned-up list of studies:
   $ python3 ~/Downloads/cleanup.py \
         testing/variations/fieldtrial_testing_config.json \
         ~/scratch/out.txt
3. Copy the output:
   $ cp ~/scratch/out.txt \
         testing/variations/fieldtrial_testing_config.json
4. Format the output:
   $ python testing/variations/PRESUBMIT.py \
         testing/variations/fieldtrial_testing_config.json

Bug: 1053702
Change-Id: I100d97a68aabeba2f7c182cc9ddc478314d71dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379730
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803456}

This CL handles the case that a widget is destroyed and its content
view is alive when GetIndexInParent is called with the view.

For instance, OmniboxPopupContentsView is not destroyed even though
|popup_| widget is destroyed and Orca calls
atk_object_get_index_in_parent on the view. Since it doesn't on the
children list, it meets DCHECK from
AXPlatformNodeBase::GetIndexInParent().

Since GetParent() returns the application node for views if it
doesn't have the parent, checking the parent doesn't work for this
case.

This change overrides GetIndexInParent at AXPlatformNodeAuraLinux
and before calling AXPlatformNodeBase::GetIndexInParent() it checks
if the node is valid.

AX-Relnotes: n/a.
Bug: 1122523
Change-Id: Iba6c8cb852a8e91c775bf5f8c14bc54e83e15643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379395
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803455}

This is done by saving the expanded/collapsed state when the tab is switched and restoring it when the tab is reselected.

Bug: b/159308598
Change-Id: Ib2f9c511c96557291251ef4b723bd88e4aa1721c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362824
Commit-Queue: Michele Mancina <micantox@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803454}

Using wpt-import in Chromium 77ffd97a.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mek@chromium.org, stevebe@microsoft.com:
  external/wpt/native-file-system

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Change-Id: Ia4b2e0f08bb0ac9d2a0688b56ff8ab5ac796760d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386762Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803453}

Both IDBKey and PolicyValue Mojo unions where being wrapped with a
struct with the union as its only member. This CL simplifies that
representation by removing the outer struct.

Change-Id: I0fdfbdca7ae6553e48248e2a6a39a062120c6797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374449
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803452}

TBR=mlamouri@chromium.org

Bug: 1123879
Change-Id: I12fd316791e1597bf506ea3547bcd36f9c9659ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387019Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803451}

Dice to the chrome://signin-internals.

Bug: 1115247
Change-Id: I91bce3fe2280d011fdae74969838119eedfda30c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377930
Commit-Queue: Diana Zagidullina <dizg@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803450}

This CL updates the wording on the System-proxy notification to add more
clarity for non-technical users.

Bug: none
Test: none, not a functional change
Change-Id: I3c50e34d00484f7179344e0a4de564fe1b7be5de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366727Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Andreea-Elena Costinas <acostinas@google.com>
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/master@{#803449}

This is a reland of 8ce938a2

Fixes vulkan tests on Linux FYI SkiaRenderer Vulkan
and angle tests on Linux Ozone FYI bot.

Original change's description:
> Reland "Reland "X11 and Ozone: enable use_x11 and use_ozone""
>
> This is a reland of 75363679
>
> Original change's description:
> > Reland "X11 and Ozone: enable use_x11 and use_ozone"
> >
> > This is a reland of f985905e.
> >
> > This change broke our headless build:
> > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed.
> >     assert(ozone_platform_x11)
> >     ^-----
> > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included.
> >       "//ui/events/platform/x11",.
> >
> > Fix:
> > Don't include x11 build for headless case.
> >
> > Original change's description:
> > > X11 and Ozone: enable use_x11 and use_ozone
> > >
> > > This is the final change that enables use_x11
> > > and use_ozone for Linux builds and (as it was
> > > before) excludes X11 for chromeos, chromecast,
> > > lacros.
> > >
> > > in order to run ozone/X11/wayland, one must pass
> > > —enable-features=UseOzonePlatform
> > > —ozone-platform=x11 or wayland. otherwise,
> > > non-ozone/X11 is used.
> > >
> > > it’s also possible to completely disable X11
> > > so that clients, who need that kind of build can
> > > continue to have that.
> > >
> > > Bug: 1085700
> > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > > Cr-Commit-Position: refs/heads/master@{#801523}
> >
> > Bug: 1085700
> > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#801692}
>
> Bug: 1085700
> Change-Id: Ia5ed2af9376354d3378d8edd98a7a1446f13c88b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379190
> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802773}

Bug: 1085700
Change-Id: I26fb00938adc6a9e49576257ca316f23830e9cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382834
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803448}

There is a handful of pointers that cause crashes when converted to
CheckedPtr. With exception of one, they experience a tag mismatch when
dereferencing/extracting the pointer. And one pointer appears to be
assigned an unallocated address.

These require further invesitagion, but for now blocklisting them, so
that we can get perf numbers.

Bug: 1069567
Change-Id: I8fb0f371161d08b25a1ffec9ac55596b86994185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358933Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803447}

- Diagnostic app can be accessed through the launcher and app drawer.
- Feature flag must be enabled.

Bug: 1120206
Test: SWA integration test
Change-Id: I9add3d5e2f9fe1a79a0d9109426714464e2bf0df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377516
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803446}

Reflecting the required changes in the upstream to comply
with Chromium. The support of the regression tests will
be crucial for unittests whenever there's a usage of
private_membership.
The CL also allow using base/files to retrieve the
regression tests file.

BUG=chromium:1110365

Change-Id: I7837808de2c74552c55fc88836568825c80a47ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323335Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#803445}

The previous implementation reads the entire file into memory
before writing, which can OOM the renderer for large files.
(E.g. video).

`Blob.stream()` isn't in closure's type system yet, and the
WritableFiles API implements streams in an unusual way. So much of
this CL is type gymnastics.

Implements an end-to-end test in C++ that re-reads the contents of
the test directory on disk after triggering a rename.

Updates the mock objects we use for JS unit tests to handle the
calls made by the streams API.

Bug: b/153021155
Change-Id: I59a6cfb6064b0980f967d95a550aa21ed04472eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370884Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803444}

There should be no behavior change here.

Fixed: 1064999
Change-Id: I6ed43e100964580c27659f746e4769af65f7a6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386007
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803443}

Bug: 1102312
Change-Id: If7bb0c7cbfc4338561ac83bc6d507680cab87b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379735
Commit-Queue: Paula Vidas <paulavidas@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#803442}

The "overflow" menu referred to the old extensions toolbar UI; now we
use the terminology of "pinned" and "unpinned". Update a few of these
sites - most notably in the ExtensionContextMenuModel.

Note: This deliberately does not update any references in old UI code,
since those still (conceptually) refer to the overflow menu.

Bug: 1100412
Change-Id: I2d3f968f548f43e9aaa1e4d7fa01b99c1ef4f02c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387137
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803441}

Bug: 1007662
Change-Id: I19fd3daebee1d9c7934998ee4a0f68bd471d2cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379443Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803440}

Bug: chromium:1116430
Change-Id: Ida6f9d13deff9bcb0b38f14bb599d43566f33563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376809
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803439}

The profile menu avatar has a 2px border that is the same color as the menu's background and is supposed to update the color on OS theme change (light/dark).

This CL updates the code to make the avatar border color react to theme changes and handles transparency of incognito and guest mode avatars for future design update.

Design Decks:
 - Profile Menu: go/project-spaces-ux
 - Incognito/Guest Menu: go/alignmenus

Screenshots:
 - Before:
    profile:   https://screenshot.googleplex.com/5ydatsL5AmqvRqX.png
    guest:     https://screenshot.googleplex.com/B2vDNBsUxP4FMjY.png
    incognito: https://screenshot.googleplex.com/7ap4gkSv9uWhrMt.png
 - After:
    profile:   https://screenshot.googleplex.com/9LgdaKqQRNu7YwW.png
    guest:     https://screenshot.googleplex.com/5PyK4TMUjdmucrk.png
    incognito: https://screenshot.googleplex.com/BRbPrfVTDV8ZWQz.png

Bug: 1123476
Change-Id: If742e78b59882fa1c423b6f931805ab8bb1e1e3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385377
Commit-Queue: Mariam Ali <alimariam@google.com>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803438}

We did not have proper checks for |app_launcher_| previously, causing
it to behave unexpectedly/crash for cases of ARC kiosk, when this
variable was not set. Now, we are setting this value properly and
there should be no failures.

Also making KioskLaunchController tests generic.

Bug: 1121911
Change-Id: I1acec49f251391c4060ba46725a754ed6de48cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385379
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803437}

This patch removes a runtime enabled feature OutOfBlinkCors as
the feature was fully launched and the runtime flag should be
always enabled in Blink.

This patch contains only trivial changes, and will leave
TODOs for additional works to remove some more functions.

As blink unit tests run without the runtime flag enabled,
following tests do not work with OOR-CORS and do not make
much sense any more. They are removed in this patch too.

- ThreadableLoaderTest::DidFailRedirectCheck
- ThreadableLoaderTest::CancelInDidFailRedirectCheck
- ThreadableLoaderTest::ClearInDidFailRedirectCheck

  Redirect limits are not handled in the ThreadableLoader any more.
  Redirect-loop emulated at the mock layer does not make sense,
  and does not generate any error and these tests just hang-up.

This is part of the work to remove the kOutOfBlinkCors feature.

- WebAssociatedURLLoaderTest::CrossOriginWithAccessControlSuccess
- WebAssociatedURLLoaderTest::CrossOriginWithAccessControlFailure
- WebAssociatedURLLoaderTest::RedirectCrossOriginWithAccessControlFailure

  These tests verify very basic CORS functionalities for BlinkCORS.
  As ThreadableLoader does not handle CORS checks any more, these
  unit tests are not a right place to ensure that. We already have
  similar tests for CorsURLLoader in the network service, and wpt
  provides enough integration tests.

- ResourceLoaderTest::ResponseType

  This test verifies if ResourceLoader can calculate response
  tainting for BlinkCORS. As CORS checks are disabled in
  ResourceLoader and we just use the type provided via network
  service, we don't need this test.

Bug: 1053866, 1003943
Change-Id: I656a86a42873ddbeafeae70d611b3072b6926c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379336Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803436}

Fold it into LayoutFlexibleBox, which is the current super class.
This CL has no behavior changes.

Bug: 1040826
Change-Id: I8ebdf9b508e0253f3ac6781a340c15cf4b3b1e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386440
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803435}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f428aa39ca2b..8a0ebd40f86d

2020-08-31 jaebaek@google.com Correctly replace debug lexical scope of instruction (#3718)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com
Change-Id: I892ea85a32811293d000362f56cb4b89f3e25dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387582Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803434}

This CL corrects the bug number in TODO that states need for using
correct profile in KeyboardAccessoryIPHUtils. Since TrackerFactory
returns same instance for both regular and off-the-record profile, the
code blocks work correct, but they are not safe in case of future change
in underlying code. This CL makes the correction on comment as well.

Bug: 1041781
Change-Id: If989ff26ddef811ab82d8eeb954054e507c01f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385376Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803433}

base::LockImpl should not be used directly, and is no longer used
outside of base. Make its member functions private to enforce that.

Bug: 1061437
Change-Id: I4797e08a548edb4d1e77e969071955c8759a1ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379682Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803432}

As of implementing Perfect Negotiation these WPTs have been timing out
on some bots. Running locally, the tests are very slow to run (because
some of them are stress tests) and anecdotally it takes 20-30 seconds;
but I've never been able to repro a real failure locally. I can't tell
if the Timeouts on the bots are due to real bugs or due to the tests
simply being too slow to run on bot infra.

This CL splits the tests up into separate files, giving each test more
time to run. This CL also makes the stress tests run for less
iterations. With these changes, it is reasonable to assume that the
bots will be able to run them unless we have a real bug.

Let's re-enable the tests with these changes and keep an eye on the
bots...

TBR=hta@chromium.org

Bug: chromium:1123832
Change-Id: Ief43b998479caf91f9216718d6b7259e01256202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386796Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803431}

The regression was only for |NGPaintFragment|, and it works
as expected when |FragmentItem| is enabled.

This patch adds a test to avoid possible regressions in
future.

Bug: 1123375
Change-Id: Ic7e1f941e8ae887b5b571e7f510cf3d8d9870e63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387464
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803430}

By resizing the fields for origin and username, they are properly
aligned if the layout direction changes.

Screenshots in the linked bug.

Bug: 1122517, 1092444
Change-Id: I4aecec81ad84bd71072eacbd87ca63bc2bab3cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377815Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803429}

Roll Chrome Win32 PGO profile from chrome-win32-master-1598857126-da6d6f9c34b393846886ccd27545501972c5d864.profdata to chrome-win32-master-1598908665-e5f1c62a762858adc54e97055fdde89a186c58c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com
Change-Id: I57aec5bb014560f722177c5741a99b9ecb458a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386674Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803428}

This patch changes |NGInlineNodeDataEditor::VerifyItem()| not to crash
when there are no inline items after editing.

This situation can be happend when editable contains only an editing
text node holds only collapsed spaces, e.g. "ab" => " ". When Text
node contains only collapsed space, we don't attach layout object then
we don't call |LayoutText::SetTextWithOffset()|. But when Text node is
editing text, we attach layout object then |VerifyItem()| is called for
no inline items.

Bug: 1123251
Change-Id: I7e88e461d7cb3f1a37cfae8a9a4a196ef2cbc02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386917
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803427}

the related standard currentRoundTripTime is defined in seconds:
  https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
and having the calculated stat on a different timescale is confusing.

BUG=None

Change-Id: Iac04deef1bb0c346c5bd7e08a944764b4c29e845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300100Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#803426}

TBR=estade@chromium.org

Bug: 1123852
Change-Id: I2205c0c8e20a01d757c45b85c71495346382f39e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387568Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803425}

about_flags.* is already owned by everyone to allow for easy addition
of flags. This CL is doing the same for its BUILD.gn file to allow for
easier addition of new flags.

Bug: None
Change-Id: I343351d361620b1977951d0769db54cde8444b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385301
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803424}

After crrev.com/c/953723 the code on iOS and non-iOS platforms has
diverged and there is no code that can be shared.

Bug: None
Change-Id: Ib80dcda88904df5a0d50a392d5d0c3dbbac60c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385888
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803423}

Change-Id: I49d19a57d9cafab3d6986f5e3beb15dfcc8dbe4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379950Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803422}

Roll Chrome Mac PGO profile from chrome-mac-master-1598831810-48c324362c2be2fbbcf6a178b22d323ccaa14725.profdata to chrome-mac-master-1598939551-edd6085454846bcef7c23e82dabdb750adc99d31.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ie1e4f568f6bd58c7a1f6aaa77d488d5cc78282c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387379Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803421}

This reverts commit 252fed6f.

Reason for revert: This test testMinidumpFromRendererHang is consistenly
failing in many builders
e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome

Original change's description:
> Add hung renderer minidump test
> 
> Adds a test for exercising Telemetry's hung renderer detection/crashing
> code. If Telemetry detects a hung renderer, it should crash the hung
> renderer process and the GPU process so that we can get minidumps to
> diagnose the root cause.
> 
> Bug: 1119564
> Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803200}

TBR=bsheedy@chromium.org,johnchen@chromium.org

Change-Id: I98f3e0e3d62c6f1c291105bdb8f7990381879749
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1119564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386797Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803420}

The workaround to hide the profile menu view before showing the
ProfileSigninConfirmationDialog is no longer needed. The dialog is now
modal on all platforms and takes the focus away from all other menus.

* Original bug: https://crbug.com/404711

Change-Id: I3b2dc4cfe2b0f8f36e8539ff6ee52024fe78b8df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386736
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803419}

Modal dialogs shouldn't have the X close button. This button is
redundant as the dialog already has the Cancel button.

Screenshot: https://drive.google.com/file/d/1eYpxgg4HuPjdpXs2Ea6FeRp3KPGFRWnF/view?usp=sharing

Fixed: 1122471
Change-Id: I179e34e8bceac980d9835332e2d7dc521a67f4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387015
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803418}