GitLab

This CL hides the "Site setting" action when notifications are shown by WebAPKs.
The "additional settings in the app" link will be removed from the notification
settings for WebAPKs in the System UI in Android O. Before Android O, the
settings gear to open app-specific settings shown on the rear of a notification
following a long-press will be gone as well.

BUG=654539

Review-Url: https://codereview.chromium.org/2826223002
Cr-Commit-Position: refs/heads/master@{#467843}

BUG=661774

Review-Url: https://codereview.chromium.org/2843333004
Cr-Commit-Position: refs/heads/master@{#467842}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/40d75ac..f7157c2

BUG=696223,715696

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2844703002
Cr-Commit-Position: refs/heads/master@{#467841}

URLsToEntriesWithAccess is heavy operation especially on slow storage
devices such as MTP connected ones.
Previously, progress center was updated only after
URLsToEntriesWithAccess was finished. As a result, it took more than 30
seconds for a user to receive feedback in some cases.

BUG=712547
TEST=manually tested.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846763002
Cr-Commit-Position: refs/heads/master@{#467840}

from content, chrome, and net/.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481

Review-Url: https://codereview.chromium.org/2835533002
Cr-Commit-Position: refs/heads/master@{#467839}

WebRTC creates threads internally. Thread::Stop() is a blocking operation,
so it's not allowed on the network thread. To work around this problem
WebrtcTransport::PeerConnectionWrapper uses ScopedAllowIO when closing
PeerConnection. But it's not longer enough - some threads are stopped
later when the factory is destroyed. Updated PeerConnectionWrapper
destructor to destroy the PeerConnectionFactory with ScopedAllowIO.

BUG=714699

Review-Url: https://codereview.chromium.org/2847803003
Cr-Commit-Position: refs/heads/master@{#467838}

Add a transparent Activity in Chrome to handle the Browser Action
Intent. This CL also deals with parsing the information of Browser
Action request from the Intent. Later, this Activity will open a
context menu from Chrome with the request information.

BUG=706696

Review-Url: https://codereview.chromium.org/2786283002
Cr-Commit-Position: refs/heads/master@{#467837}

Since blobs can die during transit (pending mojo change), we can prevent
this by holding onto the blob handles in the IDBRequest until we get the
response back from the browser.

R=pwnall,jsbell
BUG=351753,710736,713409

Review-Url: https://codereview.chromium.org/2828953002
Cr-Commit-Position: refs/heads/master@{#467836}

There's a report of a crash when trying to disable the fading
background view during ChromeHomeNewTabPage creation. This change
adds a null check and retrieves the fading background view from
the activity each time it is neeed rather than caching.

BUG=716015

Review-Url: https://codereview.chromium.org/2850623003
Cr-Commit-Position: refs/heads/master@{#467835}

Previously when test results presentation does not receive any json
input file, the script will raise a parser error. This is confusing to
developer, because they may mistake the parser error in this script as
the cause of the crash, instead of the reason why no json input file is
given at the first place.

In this cl, test results presentation will not raise error anymore when
no json file is given.

BUG=715972

Review-Url: https://codereview.chromium.org/2845973004
Cr-Commit-Position: refs/heads/master@{#467834}

GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
googletest repository. In order to cope with this, the googletest
repository is now sourced at third_party/googletest.

The file/directory layout of Google Test is not yet considered stable.
To minimize disruption while Google Test stabilizes, Chromium code will
be insulated from third_party/googletest.

* testing/gtest/include/gtest/ and testing/gmock/include/gmock have
  been populated with headers that forward into the appropriate locations of
  third_party/googletest

* testing/BUILD.gn has been populated with the targets
  //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
  depend on the appropriate //third_party/googletest targets.

All Chromium code should keep depending on the targets and headers
in testing/{gtest,gmock} for now.

BUG=630705
TBR=rkc

Review-Url: https://codereview.chromium.org/2779193002
Cr-Commit-Position: refs/heads/master@{#467833}

This changes the mus interface to pass a CursorData instead of a
CursorType. The previous patch had mus clients create CursorDatas on
ozone platforms, and this patch passes CursorDatas across the mojo pipe
and passes it to the native ozone platform on the window server.

BUG=705037

Review-Url: https://codereview.chromium.org/2830703003
Cr-Commit-Position: refs/heads/master@{#467832}

BUG=710263,710264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2844723003
Cr-Commit-Position: refs/heads/master@{#467831}

BUG=

Review-Url: https://codereview.chromium.org/2068843002
Cr-Commit-Position: refs/heads/master@{#467830}

This option is being removed from Cronet.

BUG=716108

Review-Url: https://codereview.chromium.org/2845093005
Cr-Commit-Position: refs/heads/master@{#467829}

To reduce path_from_webkit_base() usage.

- Remove rmtree()
  Only one callsite, and it called this function with an absolute path.

- Remove relative path resolution in remove()
  There are two callsites, and only one of them passed relative paths.

This CL should have no functional changes.

BUG=710535

Review-Url: https://codereview.chromium.org/2842393003
Cr-Commit-Position: refs/heads/master@{#467828}

site_list.html was relying on flex related CSS classes defined in
the deprecated iron-flex-layout.html, but it was not explicitly importing
that file. When I migrated iron-flex-layout.html to the new
iron-flex-layout-classes.html at crrev.com/2840713002, the UI broke and
revealed the missing dependency.

BUG=715903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846973002
Cr-Commit-Position: refs/heads/master@{#467827}

If |public| of a target contains files, count them as recognized
headers as well.

BUG=661774

Review-Url: https://codereview.chromium.org/2841323003
Cr-Commit-Position: refs/heads/master@{#467826}

Allows derived classes to access/run the SessionExpirationUpdateCB that
gets passed in to Initialize(). This follows the same pattern as the
other session callbacks in CastCdm (OnSessionClosed(),
OnSessionKeysChange()).

BUG=

Review-Url: https://codereview.chromium.org/2847923002
Cr-Commit-Position: refs/heads/master@{#467825}

In order to void path_from_webkit_base() in test_expectations.py, this CL change
it to path_from_chromium_base(). lint-expectations messages will be changed from:

LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:3319 and LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html

to

third_party/WebKit/LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines third_party/WebKit/LayoutTests/TestExpectations:3319 and third_party/WebKit/LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html

BUG=710535

Review-Url: https://codereview.chromium.org/2850433002
Cr-Commit-Position: refs/heads/master@{#467824}

Fix https://crrev.com/aee5ec5b3423c48e79c296a054636d60473cfa8d

BUG=704700,711414

Review-Url: https://codereview.chromium.org/2841403003
Cr-Commit-Position: refs/heads/master@{#467823}

The original CL got reverted because the CTS Test [1], that
expects Android Location provider to be used, failed. This CL adds a flag to enable
explicitly the GMScore provider, and uses it
from Chrome.

[1] https://android.googlesource.com/platform/cts/+/master/tests/tests/webkit/src/android/webkit/cts/GeolocationTest.java

Original CL description -----------------------------------------------

This CL adds LocationProviderGmsCore.java, an implementation
of LocationProviderFactory.LocationProvider interface using the
Google Play Services (GMS) provided location.

The tests content/public/.../LocationProviderTest.java are removed
and instead a new pumped up one is added in device/geolocation,
doing what the previous one was doing and parameterized to try
other location provider APIs (was: android only, now: mock,
android and GMS core).

BUG=706014

Review-Url: https://codereview.chromium.org/2809813002
Cr-Commit-Position: refs/heads/master@{#466239}
Committed: https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546a44f5603b99c

patch from issue 2809813002 at patchset 260001 (http://crrev.com/2809813002#ps260001)

TBR=  aelias@chromium.org, reillyg@chromium.org, agrieve@chromium.org who LGTM PS1

Review-Url: https://codereview.chromium.org/2836213002
Cr-Commit-Position: refs/heads/master@{#467822}

On Android, we currently always tell Blink that we will be using
fullscreen overlays. However, the MediaPlayerRenderer does not support
them, and does not attempt to use them.
The result is that Blink avoids drawing any gutter, which causes the
default background color from the LayerTree to be show instead. When no
overlay has been created, the default color is white.

This CL updates WMPI::SupportsOverlayFullscreenVideo to only return true
when we are not using the MediaPlayerRenderer.

BUG=711888
TEST= manually tested on an HLS and non HLS video.

Review-Url: https://codereview.chromium.org/2840973002
Cr-Commit-Position: refs/heads/master@{#467821}

link to the document from extension.h

BUG=None

Review-Url: https://codereview.chromium.org/2823033002
Cr-Commit-Position: refs/heads/master@{#467820}

This CL to introduce a WebThread to run WebAudio graph rendering.

FYI: with the box 2d demo on my local machine (MacPro), the release
build of this patch was able to render 50 cubes concurrently before
glitch, which is similar to the current stable build that runs only on the
audio device thread. No significant performance regression is observed.

Design doc: https://docs.google.com/document/d/1WnqZHcA2TQjS1aKvzx2nnJ2y2tWK1Xp_0BhFGpsryaQ/edit#

BUG=706133

Review-Url: https://codereview.chromium.org/2777903005
Cr-Commit-Position: refs/heads/master@{#467819}

The original_display_ field in ComputedStyle currently has generated
storage, but not copy and compare. This patch makes it use generated
copy and compare. Previously, 'has_custom_compare_and_copy' was set
to true, so the generator did not generate a compare and copy for
OriginalDisplay. By removing that line, we fall back to the default
value of false, which means the generator will now generate a
compare and copy.

This patch does not change behaviour, as the newly generated code is
the same as the code being removed.

Diff of generated files:
https://gist.github.com/darrnshn/942c8c2b4a5e42fe9b5c214388f0901f/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2831933003
Cr-Commit-Position: refs/heads/master@{#467818}

This patch fixes many NPEs in PepperWebPluginImpl where Sergeant
Pepper forgot to check the instance before using it. The instance
may be null due to re-entry and a comment has been added about this.

BUG=715747

Review-Url: https://codereview.chromium.org/2835193008
Cr-Commit-Position: refs/heads/master@{#467817}

During cross-process navigation after crash, RenderFrameHostChanged is
called early with new RFH, and the old one goes away. This happens before
ReadyToCommitNavigation and we should change current RFH to avoid accessing
the stale one.

BUG=711451

Review-Url: https://codereview.chromium.org/2841123002
Cr-Commit-Position: refs/heads/master@{#467816}

All instances of ManagedTetherProperties are replaced by (non-managed) TetherProperties. This change is due to the fact that tether properties are not managed by policy.

This CL also adds API tests for the functions which can return Tether networks.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847453002
Cr-Commit-Position: refs/heads/master@{#467815}

- Add the floor, ceiling and grid quads.
- Add the content backplane to avoid reticle jumping around the edges.
- Configure the scene reticle distance limit based on content.

BUG=715573
TEST=Verified background on regular page; no background in WebVR.

Review-Url: https://codereview.chromium.org/2844313002
Cr-Commit-Position: refs/heads/master@{#467814}

SetSubText() in HoverHighlight view should not be called
if the parameter string is empty, otherwise multi-line
rows in the system menu will have the incorrect layout
of their primary text.

BUG=715615
TEST=manual

Review-Url: https://codereview.chromium.org/2844933003
Cr-Commit-Position: refs/heads/master@{#467813}

BUG=690020

Review-Url: https://codereview.chromium.org/2842163003
Cr-Commit-Position: refs/heads/master@{#467812}

BUG=707057
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2852493002
Cr-Commit-Position: refs/heads/master@{#467811}

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549

Review-Url: https://codereview.chromium.org/2849483002
Cr-Commit-Position: refs/heads/master@{#467810}

This is in preparation for updating/adding tests for the change to support
run-time switch of decoders.

- Move decoders to be selected to a vector to avoid duplicate code.
- Add |decoder_| to track the currently selected decoder.
- Remove DECODER_INIT pending state since this is rarely used.
- Allow FakeVideoDecoder to use different display names. This is needed
  to check what decoder has been selected.

BUG=695595
TEST=Refactor only. No changes to existing tests.

Review-Url: https://codereview.chromium.org/2835203006
Cr-Commit-Position: refs/heads/master@{#467809}

The CL http://crrev.com/2801873003 introduced regression: it
unconditionally added the text processing menu items to the selection
menu. Originally these items were skipped in case isInsertion() or
isSelectionPassword() returned true.

This CL restores the old behavior.

BUG=714090

Review-Url: https://codereview.chromium.org/2847793003
Cr-Commit-Position: refs/heads/master@{#467808}

This CL primarily removes the internal WindowsNdisApi class
which is only meant to be used for the unsupported Win XP and
Vista, and leaves only WindowWlanApi internal class in place.

Furthermore it simplifies the remaining WindosWlanApi code
by linking directly against wlanapi.dll, which makes unnecessary
a number of other file-static functions, the factory method
and the library functions defintiions and variables, yay!

It also removes a chunk of file-static functions that became
unused; only one GetNetworkData() remains.

PS4 UPDATE: this CL actually could not remove the dynamic loading
of wlan_api.dll because it's not available by default in
some/all Server 2008 R2 installations, including some of our
win_chromium_rel_ng slaves, which failed. See
https://www.bonusbits.com/wiki/KB:Wlanapi.dll_missing_on_Windows_Server_2008_R2

(However, we can remove the WindowsNdisApi class because those
Server2008R2 installations would explicitly enable WlanApi.dll
to access Wifi anyway).

BUG=714477

Review-Url: https://codereview.chromium.org/2842613002
Cr-Commit-Position: refs/heads/master@{#467807}

Review-Url: https://codereview.chromium.org/2844603002
Cr-Commit-Position: refs/heads/master@{#467806}

This adds a 'Open file' option in the DevTools 3 dot menu and updates the
style of the Sources placeholder text with a new entry
'Ctrl-Shift-P Run command'.

BUG=700184

Review-Url: https://codereview.chromium.org/2716683006
Cr-Commit-Position: refs/heads/master@{#467805}

ImeController::CanCycleIme() and ImeController::CanSwitchIme() should first
check if IME state is NULL and if it is, ignore the cycle / switch action
because it does not make sense before IME initialization.

BUG=703510

Review-Url: https://codereview.chromium.org/2806613002
Cr-Commit-Position: refs/heads/master@{#467804}