- 02 Apr, 2020 40 commits
-
-
Natalie Chouinard authored
Test succeeded 10/10 times locally, and no log data available on the bug or flakiness dashboard (disabled >6 months ago). Re-enabling to monitor whether flakiness still exists. Pre-emptively increasing timeout to MediumTest either way since this test is more than a simple unit test. Bug: 994726 Change-Id: Iaa645356906b17ff17c44cc49c4c76c7b9dac4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134204Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#755973}
-
Varun Khaneja authored
It is being replaced by SafeBrowsingProtectionLevel that was already landed via https://crrev.com/c/2129284 Bug: 1056483,1066371 Change-Id: Ibe8eeaa6d1563f770fd2c29001745f819764bf0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134201 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755972}
-
Vidhan authored
Bug: 1045401 Change-Id: I419495ab251cb8b2bd69e183eb39a402c4d58fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095058 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#755971}
-
Ulan Degenbaev authored
The corresponding UKM metrics already exist and were approved by privacy team: https://goo.gl/X5eYHh The metrics will help evaluate the upcoming young generation GC optimizations. Bug:1054771 Change-Id: I8caa8cce5e7b253aee76714f980a9ecd6242c530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130186Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755970}
-
David Bertoni authored
This test was disabled because it was flaky on ChromeOS. I ran it for 3000 iterations on the bots and there were no flakes on any platform. Bug: 1019669 Change-Id: I7e4e7665375903d531e1fbfc9862b14e25b2c024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132602Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755969}
-
Peng Huang authored
This CL enables the ExternalVkImageBacking on Windows platform, but it only supports pixel copy code path for now, the vulkan external memory extension is not used. Bug: None Change-Id: I44955572175d218ec613b41eddf40eb0655fac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125705Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755968}
-
Yao Xiao authored
Bug: 1032681 Change-Id: Iafad2367d8887afb1df67094aef996a2f2873da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121657Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#755967}
-
Sophie Chang authored
Bug: 1064414 Change-Id: Ib81bea9adf5bfe04b65b324c98779caf616e1e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119224Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755966}
-
Patrick Monette authored
This reverts commit 5047802a. Reason for revert: https://crbug.com/1066450 Original change's description: > Reland "[PM] Connect dedicated workers to their client frames in the graph." > > This is a reland of 8e70db4d > > Original change's description: > > [PM] Connect dedicated workers to their client frames in the graph. > > > > Bug: 993029 > > Change-Id: Iae20fa0ede4421782fc5fbf2851d21c83cfbf4c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095452 > > Commit-Queue: Patrick Monette <pmonette@chromium.org> > > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753319} > > Bug: 993029 > Change-Id: I859f004b938164a02e43b74e6f9225d25e90d083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122476 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754620} TBR=pmonette@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993029, 1066450 Change-Id: I738ef7877b1b841eb9aea5af0a3427959e5857cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134199 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#755965}
-
Sammie Quon authored
This requires some changes to WindowMiniView to make it more customizeable as UX specifically only wants shadows on overview and not alt-tab. Changes made were to apply effects on an icon supplied through a window property, in this case a shadow. Also, adding shadow to a label will shift the text. Since we want to keep the text right aligned with the icon, make OverviewItemView header layout code custom (previously was using the default from WindowMiniView FlexLayout). Test: manual Fixed: 1028845 Change-Id: Ief8e9bbccc42fa198ff31729b735edc519d78270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128835Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755964}
-
Xianzhu Wang authored
We have fixed crbug.com/1064341. TBR=pdr@chromium.org Bug: 1064341 Change-Id: I0d156a40c590c5b2bd5dbd01a6a9bf2f4e3d50e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134203Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755963}
-
Dave Tapuska authored
maxlength-number.html sends multiple keys in one call. Iterate across the keys string to send more than one character. Move another test that uses the actions API to the unsupported section. Reland 39760144 without the pause.html expectation removed. Change-Id: I9cb0a2f68a5792615c711d59e29dbca9830e2f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133872 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755962}
-
Archana Simha authored
Bug: 1066117 Change-Id: I816361f5ff166cc6888e3634a7f624fae2e11f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134388Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#755961}
-
rajendrant authored
Handles the following cases: 1. When the litepages server and the origin server both fail the response, it should not go into a infinite loop. 2. When the initial image itself is a litepages URL, no redirect should happen and no metrics recorded. TBR=tbansal@chromium.org Bug: 1059606 Change-Id: I477839ab09493445a085d646a4da4fb22c5981c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128944 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#755960}
-
Frank Tang authored
Added value missed in https://chromium-review.googlesource.com/c/chromium/src/+/2092942 Bug: 1056846 Change-Id: I96c2800dd8d1ffbd2cdaf6baff0b538122a96747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116586Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755959}
-
Ulan Degenbaev authored
This removes some unused metrics and bumps expiration date of remaining metrics to 2021-04-01. Bug:1061974 Change-Id: Id5a7ec27e006b0ecaff56c8724982af660fd69b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130346Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755958}
-
Brian Sheedy authored
Re-disables the BrowserMinidumpTests on chromeos-board-betty-pi-arc, as they were recently accidentally re-enabled on that board. TBR=wenbinzhang@chromium.org Bug: 1038043 Change-Id: I9b5ca67e8079bcadd88217cca2c78846585bb858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134196Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#755957}
-
John Z Wu authored
For credit card saves where the name is missing, a fix flow may be offered to the user to add one. Bug: 1066690 Change-Id: Ifdfcbd016a8ba79635c9aa592b5a12192b8b8cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132943 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#755956}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idc7772296f9a39f4bd8ec721750868e5682d2a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134576Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#755955}
-
Ulan Degenbaev authored
Instead of unmapping directly, Free() returns DeferredUnmap that needs to be run after releasing the lock. Bug: 1067006 Change-Id: I2638d370a5b36867d73adcbaf8988c4259ff05a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132155Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755954}
-
Eric Orth authored
SystemNetworkConfigManager::GetStubResolverConfig() and the chrome_browser_net::DisableDohFor...() util methods from chrome/browser/net/dns_util.h moved to the new class. Everything moved as-is without changes except that GetStubResolverConfig() is now non-static and uses a saved PrefService field instead of always passing it in. The new class is owned by the singleton SystemNetworkConfigManager instance and can be retrieved using a GetStubResolverConfigReader() static method. Added a static ...for_testing instance in SystemNetworkConfigManager because DnsProbeServiceTest was running in a state where SystemNetworkConfigManager couldn't be instantiated and was thus previously relying on everything being static. TBR=rsleevi@chromium.org,aee@chromium.org Bug: 1064346 Change-Id: Ic3cb65a42254f1e6640d80a5024dd847f0cd7f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132538 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#755953}
-
Ken Rockot authored
This extracts the mojom parsing logic from mojom_bindings_generator.py into a new mojom_parser.py script within the mojom tool directory. Apart from simply moving the parsing logic to a new script, this also changes how the parse result is persisted by an intermediate build step for subsequent build steps to consume. Prior to this change, the parsing step emitted a ".p" file for each processed .mojom file. This was nothing more than a serialized version of the parsed AST with [EnableIf] feature filtering applied. Every subsequent step for the mojom in question would load this AST, then recursively process its import dependencies while loading their ASTs in turn, before finally processing all of the aggregated data (resolving references, computing field packing data, etc) to produce a Module object suitable for bindings generation. This CL rolls most of that processing into the parsing step (with more to follow in future CLs), and the resulting computed Module object is persisted to a ".mojom-module" file. To generate bindings for a given .mojom file, the generator can simply call Module.Load() on the corresponding .mojom-module produced by the parser. The loaded Module is sufficient to inform code generation with no need to resolve dependencies, process other modules, or perform other complex computations on the model. Each mojom-module is thus entirely self-contained, replicating the full contents of all transitive import dependencies. This means the build consumes more disk space with intermediate build artifacts, but it also means generation steps are faster and simpler. This CL should result in no net changes to the final build outputs. Bug: 1060471 Change-Id: Ic21b737409ac1329f0f8a8751bf021f2de4768a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128966 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#755952}
-
danakj authored
The test changed with --enable-gpu-rasterization instead of --force-gpu-rasterization but the trybots didn't pick up the right expectations somehow on Mac 10.14? Running rebaseline-cl doesn't pick up the diff from the 10.14 bot, and putting the image in mac-mac10.14 doesn't get used. So it is put in virtual/platform/mac/. The old global mac on is copied to each other version individually. Running optimize-baselines seems to produce failures on Mac 10.10, 10.11, and 10.12, so I am not doing that. The 10.10, 10.11 and 10.12 bots share the same image but they each have a separate copy so that they pass, as they do not seem to agree with optimize-baselines about how they fallback. R=kylechar@chromium.org Bug: 1066392, 866140, 1065893 Change-Id: I6b1fc4de8d0a872fe2d66c8154362d62f8f01a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133871Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755951}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/5a39301cb829..98502c3bedc6 $ git log 5a39301cb..98502c3be --date=short --no-merges --format='%ad %ae %s' 2020-04-02 wub gfe-relnote: (n/a) In QUIC BBRv1, default enable connection options LRTT and BBQ2, and deprecate unused QUIC connection options BBS1 and BBRS. Protected by --gfe2_reloadable_flag_quic_bbr_default_exit_startup_on_loss. 2020-04-02 bnc gfe-relnote: undeprecate gfe2_reloadable_flag_quic_create_incoming_stream_bug 2020-04-02 bnc Use |offset| in QuicReceiveControlStreamTests for easier readability. 2020-04-02 bnc gfe-relnote: Emit H3_SETTINGS_ERROR and H3_MISSING_SETTINGS when appropriate. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-01 quiche-dev Add Pigeon USPS GSO Support via quic::PigeonWriter. 2020-04-01 dschinazi Add default returns to MockSendAlgorithm bandwidth calls 2020-04-01 dschinazi Improve decryption error logging 2020-04-01 renjietang Remove QuicStreamIdManager::DelegateInterface::OnStreamIdManagerError(). 2020-04-01 wub gfe-relnote: False deprecate --gfe2_reloadable_flag_quic_bbr_startup_rate_reduction. 2020-04-01 dschinazi Parameterize QuicSecretTest by QUIC version 2020-03-31 dschinazi Fix DebugDFatalIfMarkingClosedStreamWriteBlocked test 2020-03-31 renjietang Remove unnecessary error check in QuicStreamIdManager. 2020-03-31 dschinazi Parameterize QuicCryptoClientHandshakerTest by version Created with: roll-dep src/net/third_party/quiche/src R=bnc@chromium.org Change-Id: Iebf28bf21288f6bc1d19e882c86c633315085231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134687Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#755950}
-
Lei Zhang authored
Their usage was removed in https://crrev.com/706442. Change-Id: Ib8d01db98766737899826bcb1432461332f6201c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133268Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#755949}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55c991cc81ae..de6fa1ef2946 git log 55c991cc81ae..de6fa1ef2946 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 brandtr@webrtc.org Reland "Let WebRtcVideoChannel::ResetUnsignaledRecvStream delete all default streams." 2020-04-02 titovartem@google.com Move media configuration for PC level tests into separate class 2020-04-02 mbonadei@webrtc.org Replace std::string::find() == 0 with absl::StartsWith (part 2). Created with: gclient setdep -r src/third_party/webrtc@de6fa1ef2946 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I128329895e4150358236063a17fcdfc43e3182fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134707Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755948}
-
Ilya Nikolaevskiy authored
Bug: chromium:1060795,chromium:1066073,chromium:1066074,chromium:1066075,chromium:1066076,chromium:1066077,chromium:1066078,chromium:1066079,chromium:1066080,chromium:1066081,chromium:1066082,chromium:1066083,chromium:1066084,chromium:1066085,chromium:1066086 Change-Id: I598cb9202776de5976b28826e0f02fa4edef5af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128308Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#755947}
-
Sophie Chang authored
This allows us to better disambiguate whether we had attempted to fetch for the navigation at all. Currently, we could do something around host covered status but that does not provide the full picture. Bug: 1054649 Change-Id: Ie39d0e3e83fde149a8a6e40e8aacbcc033e57dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128087Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755946}
-
Chris Whelan authored
Bug: b/67907746 Test: cast_crash_storage_impl_fuchsia_unittest Change-Id: I7aa6f23cad265179db35720a7344709fe40bd4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120098 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755945}
-
Arthur Hemery authored
COOP was parsed for redirects already, but not properly enforced. This patch makes sure any redirect combination that would have led to a switch does put the final URL in a separate BrowsingInstance. Change-Id: Ia289cf661add09a8e86392c7c650219b90ac0a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132220Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#755944}
-
Manuel Rego Casasnovas authored
Computed style for outline-offset was not returning the proper value if "outline-style" was "none". This was due to a check in ComputedSyle::OutlineOffset() that this patch removes. This code could be there because this is needed for "outline-width" as specified in the spec [1], however there's nothing about this on the "outline-offset" property. This patch modifies outline-offset-computed.html, as it had some extra lines (similar to what's needed for "outline-width") to make it work in Chromium (and WebKit https://webkit.org/b/209913) due to this bug. [1] https://drafts.csswg.org/css-ui/#outline-props Bug: 1005372 Test: css/css-ui/parsing/outline-offset-computed.html Change-Id: Ief8d4fe22c462ec2bb493b20b1b22b8d0797e1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134133Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#755943}
-
Nico Weber authored
Suppress -Wunreachable-code-return warnings that can be fixed easily by rejiggering preprocessor conditions. No behavior change. Bug: chromium:1066980 Change-Id: I151bbd88ef39e18ae8f07c3e32e4b21de26520df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132780 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#755942}
-
Nate Fischer authored
No change to production logic. This adds a "--webview-verbose-logging" flag to WebView, intended to replace the "log verbosifier" app. Log verbosifier was designed to work on production Android images, where we couldn't specify an arbitrary commandline flag. However, Dev UI will support commandline flags even on production devices, so the log verbosifier is obsolete. This does not remove support for log verbosifier for the time being, although I intend to deprecate and remove support soon (I'll let M83 be a transition milestone). Bug: 988200 Test: Verify the flag is picked up by Dev UI and it works as expected Test: Verify log verbosifier app independently still works (tested on Q) Change-Id: I1e75c9c1fdfe09144a40d2717e2024272cc9264d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133274 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#755941}
-
David Dorwin authored
It is already included in the parent DEPS file. Change-Id: Iaf5d8c59cb50b17a2a4e229c894b8e7c3a07601c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131294 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755940}
-
Mila Green authored
Bug: 1060800 Change-Id: I7e28e1e57458d26577cc06413e35db921cd583de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134566Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755939}
-
Daniel Clark authored
The pre-FormControlsRefresh date picker considered the cell with 'highlight' to be the active cell with respect to ARIA, and it was the highlighted cell that moved around by arrow-key navigation. In the refreshed design, highlight is no longer managed in JS, and the cell marked as 'selected' in JS is the one that is moved around by arrow-key navigation and is therefore the one that should be considered focused by accessibility. However the management of aria-activedescendant and aria-selected was never migrated from highlight to selection. This change does this migration. For test coverage, the change re-enables DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen and modifies it to dump the full popup tree instead of stopping at the 'Today' button. The column header values are skipped so that the /blink subtest doesn't produce different results on different platforms (Windows uses Mo/Tu/We etc instead of M/T/W/etc for the day abbreviation localizations). date/week/month-picker-ax.html are updated to account for the extra MarkDirty events that are fired to to the fact that focus/selection is now being managed again for the calendar cells. month-picker-ax.html is moved to promise_test to match the format of the other two tests and changed to assert instead of timing out on failure. Bug: 1022920,1054901 Change-Id: Iaa98605582a12fcf44d87748ca3bc572518528fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111750 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#755938}
-
Ted Choc authored
BUG=702154 Change-Id: Ic5b338b9c4a59be0d777b38c6341d9ca293ba9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131152 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755937}
-
danakj authored
This component provides ShellMainDelegate, an implementation of ContentMainDelegate that creates the various Content Shell-based interfaces for each process. It can be asked to create web test versions of these interfaces also. This component will be able to see web_test components, while content_shell_lib will not need to anymore. (At least in the renderer so far.) This will allow us to 1) make content/shell/renderer/web_test into a separate component 2) merge test_runner into that same component (or vice versa?) without regressing separation by merging test_runner into content_shell_lib. The dependency graph would be like content_shell_app -> content_shell_lib content_shell_app -> web_test_renderer -> content_shell_lib R=avi@chromium.org Bug: 866140 Change-Id: I7f530851b60e478260d681b0c43b089d630a6b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132940Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755936}
-
Amy Huang authored
This is a reland of c00c874f Original change's description: > clang build.py: change LLVM_ENABLE_ZLIB from ON to FORCE_ON > > This uses the FORCE_ON option to enable zlib to ensure that clang > actually finds and uses zlib. Also moved this setting out of > base_cmake_args so that it is only used in the main clang build, > since there is another 32-bit build that can't use this zlib. > > Also changed to remove and re-download the zlib source on > every build. > > Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641 > Bug: 1061189 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753301} Bug: 1061189 Change-Id: If208eab801b1105814979134d0c75092c8c3f396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126970Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#755935}
-
Jochen Eisinger authored
Bug: 927509 Change-Id: Icc150445dd72857d9d85fa2939e77bd7b1718c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132399 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#755934}
-