- 24 Sep, 2019 40 commits
-
-
Colin Blundell authored
We are in the process of clarifying the use cases and usage model of FakeProfileOAuth2TokenService within the IdentityManager test infrastructure. This CL eliminates the FakePO2TS constructor that takes in a ProfileOAuth2TokenServiceDelegate, leaving only the one that internally creates a FakePO2TSDelegate. It turns out that there is no longer any usage of the constructor being eliminated here. Bug: 982751 Change-Id: If3dec3754887a62ef9564e50b64f0d8192907723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819313Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#699258}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bc646eee208f..f2690a15b706 git log bc646eee208f..f2690a15b706 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 nisse@webrtc.org Delete unused method SendSideBandwidthEstimation::UpdateReceiverBlock Created with: gclient setdep -r src/third_party/webrtc@f2690a15b706 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ied91b810c918099eb544df3668376fd8c11509be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699257}
-
David Roger authored
Until this CL, the Dice migration was blocked on the token migration. Now, if there are still pre-dice tokens when the dice migration happens, they are deleted. It has been more than a year since tokens are being migrated. There are still a few token services which were not migrated (most likely because they are corrupted or the encryption key has been lost). Bug: 1006669 Change-Id: Id4bf3e28c8386095ec98cc12cddbacb243f4f77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819310Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699256}
-
Vadym Doroshenko authored
This metric shows whether all password field values in a submitted password form came from JavaScript. This metric is useful for estimation ration of submissions that were facilitated by extensions. Change-Id: Id10152b9fc0f0402e6406fe4a578d21b065b552a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814017Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699255}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaRouter interface, and adapt unit tests. TBR=benwells@chromium.org Bug: 955171 Change-Id: I5290d977ce94e2be5efb00c8b5dd89bf74230b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813340 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699254}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome::mojom::ProfileImportObserver interface. Bug: 955171 Change-Id: I4a3bc9ed524a0962d1f87913f2dbeb27175bf425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816562Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#699253}
-
Jan Krcal authored
This CL adds support for fading out text of LabelButton using AnimatingLayoutManager. Concretely, when ShrinkDownThenClearText() gets called, the button reports a new desired size without it's label. The AnimatingLayoutManager can then resize the button using an animation to its newly desired size while the label is still (partially) visible. Once the animation is finished, the button clears its label. This CL directly makes use of this functionality for ToolbarButton. Bug: 1002160 Change-Id: Id2569d4c58497ccb3198ca70a01cc2d7eb270a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810977 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699252}
-
Charlie Reis authored
These have already been fixed in r697145. Bug: 998284 Change-Id: I53d4770246300cdd0c40716f67de23cf60566312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819643 Auto-Submit: Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699251}
-
Alex Clarke authored
This should really be a compositor task, and it's important it is once we start prioritizing loading and compositing tasks in the renderer till FCP (web_tests break otherwise due to unintentional task reordering). Bug: 971191 Change-Id: I39b0f7964c75a870c8c170e3236a6e3a281bd27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819437Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#699250}
-
Jan Krcal authored
This CL postpones hiding user email if it is hovered. The button gets hidden as soon as the mouse exits or clicks the button. Bug: 967317 Change-Id: Ibe85cd96e66881c188be33c77b9ffd1e9470d1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811238 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Background: All our app registry read/write access permissions are enforced by the compiler. We used `friend` declarations before. Introduce WebAppRegistrarMutable subtype for WebAppRegistrar. While WebAppRegistrar serves as read-only model, WebAppRegistrarMutable is a "view" which allows writable access for an owner which has WebAppRegistrarMutable pointer. WebAppSyncBridge is the only controller which has that writable access. Bug: 860583 Change-Id: I4623ce826d25f0c2bbf9ed685a932d7eb734bdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820497 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699248}
-
Kuo Jen Wei authored
Bug: 994258 Test: Test on device without portrait mode, the mode selector should not be scrollable. Change-Id: Ic8a154a705b4bb62dafb296d11a9a3dd92149820 Change-Id: Ie3a79185a266f87abdace599944fc883965b770b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818895 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#699247}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of resource.h from 3.50MB to 2.35MB. cors_error_status.h, memory_pressure_listener.h, and resource_error.h are included by resource.h directly or indirectly. The changes in these files contributes to the resource.h reduction. Bug: 242216 Change-Id: I41165e784b0c5150f109c10add6fa4ff5428a659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814579Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#699246}
-
Alexey Baskakov authored
Reuse sync WebAppSpecifics in web_applications code. This works much better than a comment with a requirement to keep protos/enums in sync. Bug: 860583 Change-Id: I8fc532c28ae8588608032cf751cc3ad44f26f31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818882Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#699245}
-
Yuichiro Hanada authored
As we found out in crrev.com/c/1774906, IMM instance or the active state of it can be stale in some condition. This CL is a workaround for the crash until we fix the root cause. Bug: 1000556 Change-Id: Ia1fb798d5308b752c5a30a0ac9c4fc172fe7f315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810878 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#699244}
-
Greg Thompson authored
This change adds the following four fields to feedback reports on Windows following an on-demand update check (and to chrome://system): - update_error_code: An int value in the GoogleUpdateErrorCode enum. - install_location: One of ("per-machine", "per-user", "unknown") indicating whether the browser is installed somewhere in the ordinary "all users" system location (e.g., "C:\Program Files (x86)\..."), the ordinary user-specific location (e.g., "C:\Users\USER\AppData\Local\..."), or some other unexpected location. - update_hresult: A Windows HRESULT (hex), provided by Google Update or COM, in case of error. - install_result_code: An int process exit code from the installer in case of error if the installer was executed. This is made possible by the introduction of UpdateState, which holds all state relating to an update check, and GetLastUpdateState(), which returns said state pertaining to the most recently completed update check. In support of this change, the Google Update update checker now uses base::Opional<int> (rather than a magic value of -1) for the installer process exit code to differentiate "none provided" from any specific value. Bug: 985209 Change-Id: Id49c65e40c0359aed767e0404afbf07030c20e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798345 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699243}
-
Jeevan Shikaram authored
This CL re-enables test that were disabled due to build breakages. Bug: 1003483 Change-Id: Ie20d5d788b5bea3615d0842148d5ebd7d0060e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809136Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#699242}
-
Alexey Baskakov authored
Inline CreateStore / OnStoreCreated methods. Bug: 860583 Change-Id: Ia3d8e0892fb8e2461be6233cad8f33f58f9d4ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816335Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e18bf0acc0be..410370705505 git log e18bf0acc0be..410370705505 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 dberris@chromium.org Pinpoint: Leverage cache for high-traffic entities Created with: gclient setdep -r src/third_party/catapult@410370705505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006888 Change-Id: I3c819204f425f0004743deacdfe3c0edd48d0c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820557Reviewed-by:
-
Xiaocheng Hu authored
This patch implements CSS clamp() as a combination of min() and max() according to how it's defined: https://www.w3.org/TR/css-values-4/#calc-notation Note: clamp() in 'sizes' attribute uses a different independent code path, which will be covered by a separate CL. Bug: 825895 Change-Id: Ifd3cdaf1f3e31e10594d95158c2c730f34689924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815850Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#699239}
-
Mark Cogan authored
Per comments on the CL to change the ownership of WebStateLists (crrev.com/c/1796358), there are a couple of nuances to behavior in TabModel that aren't currently covered by unit tests. First, multiple calls to -browserStateDestroyed must be safe. Since possible failure modes are DCHECKS or outright segfaults, the test just creates and populates a tab model, then calls -browserStateDestroyed twice. Second, empty sessions should be saved (meaning that when the user has no open tabs, restoring the session should not show any of the previously open tabs). The test here is also straightforward: force-save a non-empty session, close all of the tabs, force-save again, restore, and verify that there are no open tabs. Change-Id: I3b40d8fc6f60ca51bfaebeb704324a04d60bd7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819239Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#699238}
-
Mihai Sardarescu authored
This reverts commit 71e64b81. Reason for revert: This CL is only needed to be tested on canary and then merged to M77. CL https://chromium-review.googlesource.com/c/chromium/src/+/1819247 is the fix intended for M78+. Original change's description: > [iOS] Disable signed-in account view controller > > Disable the signed-in account view controller dialog. > This patch is to disable it for M-77 and M-78. The right fix will > come later with crbug.com/1006717 > > Bug: 1006744 > Change-Id: I537969bb221e165a7a0ca66d4324f8d87580916b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819304 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698946} TBR=msarda@chromium.org,justincohen@chromium.org,jlebel@chromium.org Change-Id: Ie6e9b97321b54d00b8ef3c2e600934e365fd9dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818528Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#699237}
-
Julie Jeongeun Kim authored
This CL converts ThreatReporterPtr and ThreatReporterRequest to new Mojo types using Remote, PendingRemote, PendingReceiver, Receiver, and ReceiverSet. Bug: 955171 Change-Id: I2bc837a87621763a7ee6604265296e63c0eef339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816200Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699236}
-
Alan Cutter authored
This test is flakily failing on Windows bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BookmarkBarNavigationTest.SecFetchSiteNoneFromNonEmptyTab TBR=mkwst@chromium.org Bug: 1006033 Change-Id: I72fa0c6baf009873850b7043d36d009bb6020e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818014Reviewed-by:
-
Robert Liao authored
BUG=1005568 Change-Id: I36dd422d65620ac945bd139b41afd274f2837f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820045 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#699234}
-
Robert Liao authored
BUG=1005568 Change-Id: Ibbf77ef3de28e836d85afd2f2a9a1fa87cce1b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820000 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Eugene But authored
This change is made because all subdirectories of ios/web/public represent features, while web_state subdirectory is class name. The move proposal was discussed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit Bug: 942244 Change-Id: Ia3c5cf1a6e0a0a58ba3f549e3619a6ada707d1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819355 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699232}
-
Ken Rockot authored
This is a reland of 749dcc3b PS1->PS4 shows the exclusive delta from the original patch, fixing a subtle lifetime issue in FileService. This turns out to have always been wrong: LevelDBServiceImpl can be destroyed before its created LevelDBDatabaseImpl objects have received all messages, and the service impl owns the shared message pipe for the associated database interfaces; thus messages can be dropped and data lost. This never mattered before because FileService instances effectively lived forever anyway. The fix here makes LevelDBServiceImpl lifetime independent of FileService lifetime, tying it instead to client lifetime. Original change's description: > Move File Service off Service Manager > > This is a first step towards eliminating the File Service and migrating > DOM Storage code into the Storage Service. > > File Service and its only clients (DOM storage objects) are moved off of > Service Manager APIs. LocalStorageContextMojo and > SessionStorageContextMojo are changed to own their own FileService > instance, now constructed directly over a directory path. > > No functional changes intended in this CL. > > Bug: 994911,977637 > Change-Id: I2ffd0bef670304a0dc3c103981139603521a14ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778801 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698487} NOPRESUBMIT=true Bug: 994911, 977637 Change-Id: I12658247e428f2e5eee32a2e3eabe3eb35381238 Tbr: avi@chromium.org Tbr: mek@chromium.org Tbr: rsesek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816582 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaController interface, and adapt unit tests. Bug: 955171 Change-Id: I59ab6af047fe6b87ae470e0379f7f607e12a427c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810998Reviewed-by:
-
Tomasz Moniuszko authored
Bug: 1006749 Change-Id: I74334514acd6fd195e6cc435e37e5b46731ea4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819306Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#699229}
-
Alan Cutter authored
Mark virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/update-bytecheck.https.html as timing out https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fomt-service-worker-startup%2Fexternal%2Fwpt%2Fservice-workers%2Fservice-worker%2Fupdate-bytecheck.https.html This test recently started timing out frequently on Windows 7. TBR=knollr@chromium.org Bug: 1002377 Change-Id: I5c54b1c0b683b214f11beaddd2259508dd71ba8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820405Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e712395b0e52..ca2ef4313b40 Created with: gclient setdep -r src-internal@ca2ef4313b40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I6d62654e2e88426b048b9ccb323a9906b3bcb9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699227}
-
Yuta Kitamura authored
Originally WindowAgent's constructor's comment suggested it should not be used, but nevertheless Document was using it. This CL updates the comment and adds information about when it should be used. Change-Id: Ia960af496bdea3fe7dbb0e07dc1f6a97cf64b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809035Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Auto-Submit: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#699226}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/017e8357..778af2fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d6e0ec38b34b1e956c861e77606313aa469d0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820443Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699225}
-
Jeevan Shikaram authored
This CL corrects a regression which hides the more settings and permission linkout. Bug: 979531 Change-Id: I468734a201836b23c1d7943f139ff9090af45390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820401Reviewed-by:
-
John Z Wu authored
This makes it easier to output debug menus. I had to change the private property into a method because C++ things do not seem to work well with valueForKey: Change-Id: I62b08be230b968449a6a002a1c7e62a4c0026a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816288Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#699223}
-
Jeevan Shikaram authored
This CL deletes the Google Play Store section and adds it's children into the new Apps settings section. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413184&signed_aid=VDO2a7j5Bu_Via8i0H_BzA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=413183&signed_aid=sQOsHwyPDGWKiaC2zZlgQQ==&inline=1 Bug: 1004583 Change-Id: If9d307de4240ab8246f2b7ebb61e38b2530f792a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815957 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699222}
-
Peter Kasting authored
Bug: 82078 Change-Id: Id6acded56ab6c6e4133a274875db985e963fcf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820539 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699221}
-
François Beaufort authored
This CL adds missing attribute error to GPUUncapturedErrorEvent. It was forgotten in http://crrev.com/1787504 Bug: 877147 Change-Id: Ia135b7b79a4215c0c90a4704516c3b70f3658072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814827 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#699220}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/984536bb45f4..e18bf0acc0be git log 984536bb45f4..e18bf0acc0be --date=short --no-merges --format='%ad %ae %s' 2019-09-24 dberris@chromium.org PinpointScheduler: A Validator Implementation 2019-09-24 dberris@chromium.org Pinpoint: Allow for partial job instance migration Created with: gclient setdep -r src/third_party/catapult@e18bf0acc0be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:988912,chromium:1006658 Change-Id: I6bc3f39f8d0124e31726b702551b7a6142468a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819851Reviewed-by:
-
