- 09 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88a5d76f5f62..214971471446 2020-09-09 jacktfranklin@chromium.org Expose the live directive from LitHtml 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie7af2d4c541d054337a72daa4e11c9530b120927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805365}
-
wutao authored
The preview photo is fetched and shown async, the img element on the settings page is broken for a while before the image is downloaded. This patch hides the img and shows it when the url is not empty. Bug: b/166816130 Test: added new js test Change-Id: I5ccc563dcc3f22c836a2fc35e7fa0e007ace846f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383262 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805364}
-
Frédéric Wang authored
An SVG foreignObject element currently always forces legacy layout [1]. Additionally, when such an element has visible overflow, DefinitelyNewFormattingContext returns a false negative, causing all the siblings of the SVG root to also fallback to legacy layout. However, SVG foreignObject elements always establish a new formatting context since they are treated as absolutely-positioned [2]. This CL fixes the bug by making DefinitelyNewFormattingContext always return true for an SVG foreignObject element. The fix is verified using a MathML test copied from integration-4.html, the one used for MathML-in-foreignObject support [1], with the assumption that MathML will never be implemented for legacy layout. Bug: 989920, 6606 [1] crbug.com/989916 [2] https://svgwg.org/svg2-draft/embedded.html#Placement Change-Id: I7f7cde90da728f1b1959728d39fed2e2070888f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400378Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#805363}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I34fb393ae9dd8b9baaa19ebd5078be90521e9d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401401Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805362}
-
Bo Liu authored
This reverts commit 33cd6ce1. Reason: Obtained crash reports from wild so no longer needed. Original description: > Add a DumpWithoutCrashing to header sender > > Add a DumpWithoutCrashing to the sender side of > URLLoaderFactory.CreateLoaderAndStart. > > Bug: 1028189 > Change-Id: I05fcf83ebe3248b4b67c60d0ecb5c176173ad976 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358478 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798660} Bug: 1028189 Bug: 1125081 Change-Id: I8729d0f68c9e7ede31e00e2a7ef9c0ac07dbd877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401218Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805361}
-
Shubham Aggarwal authored
This change consolidates the storage related methods in the WebContentSettingsClient interface into two new methods to prevent use of repeated logic in implementations. Implementations and usage sites have also been updated to use the new methods, RequestStorageAccess and RequestStorageAccessSync. Change-Id: If46b3d0ca7555b8db212b014580f0b5513bbe508 Bug: 1019415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353552 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#805360}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:11249650 Tbr: rmhasan@google.com Change-Id: I54ff4cc762cc377c12d3a6a7a73d506dffb50304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401598Reviewed-by:
-
Sunny Sachanandani authored
Bug: None Change-Id: I889d9ebbe9d8e5b33750bb1c12ae6121b14899bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398970Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#805358}
-
Chris Lu authored
Instead of relying on SceneState order calls, which cannot be guaranteed, a new AppState shouldShowDefaultBrowserPromo property is added to keep track of when a resumption of session is due to a cold start. A new DefaultBrowserSceneAgent class will listen to SceneActivationLevel and check the shouldShowDefaultBrowserPromo property to determine when to show the promo. Also, an iOS14 check is added to IsLikelyInterestedDefaultBrowserUser to ensure that only users on iOS14 see this promo. Bug: 1107489 Change-Id: I71c77a98e20644c620f4c4d3c60cb0b253931cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378710 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#805357}
-
Matt Jones authored
This patch removes the viewport type check for the TopToolbarOverlay in place of checking specific layouts. The format in this patch is much closer to what we want longer-term, especially with the deprecation of the ViewportMode concept. Bug: 1100332 Change-Id: Ief878a1c3b5b499cd411ab979d748cfd1477297a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350391 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805356}
-
Ben Pastene authored
The time has come. Bug: None Change-Id: Ied2bb8875c2451f72704a121c5cfcea601b85d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399433Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#805355}
-
Jack Franklin authored
Change-Id: I52239ca5c653e34c178a41bdb2d61c70c9183c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401043 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805354}
-
Michael Thiessen authored
When Chrome is the app firing the intent, don't record it as an external app launch. I also fix the case where we've added Chrome's trusted intent extras but not added Chrome's app id, which was previously counted in the UNKNOWN bucket. As far as I can tell though, only the search widget does this. Bug: b/167573777 Change-Id: I3be6321fa1c35f8860577a9d9fb771a40ca8ba19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398193Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805353}
-
ckitagawa authored
This CL fixes a few low-volume crashes in paint preview code. 1. PaintPreviewClient - a few instances where getting the URL for the renderer crashes due to it being invalid. I think this is only possible on dev builds, but worth fixing. 2. PlayerCompositorDelegate{Android} I believe |compositor_error_| might already be gone on rare occasion leading to a crash downstream. This CL was uploaded by git cl split. Change-Id: I1a775c9a076ea11c719936d8b7dd69fe54704eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401399Reviewed-by:Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805352}
-
Jan Krcal authored
Recently, all logic around profile avatars has been integrated into ProfileAttributesEntry::GetAvatarIcon() incl. new features such as colored default avatars. This CL updates the Windows-specific code to reflect these changes. In particular, it adds the only remaining Windows-specific feature into the generic GetAvatarIcon() function. Along with all other types of avatars (such as GAIA avatars), GetAvatarIcon() does not distinguish between low- and high-res avatars any more and only returns the high-res one. As a result, for the extremely rare case of old default avatars, the avatar badge for the small 48x48 icon is now based on the 2x bitmap that gets downscaled. Bug: 1122559 Change-Id: I4e8ee3817d6ccf5e2f755dfa86cd77e4169a5337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379726 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805351}
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I2cb2d00c6b2c0fd10f23f2f1a700ea9d081b2c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385638 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805350}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7310899f126..447e7a69ecdd 2020-09-09 hjd@google.com Merge "ui: Add docs link in record page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3c368de0dd4b735b4ec6cceb79b2380785bbd8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401301Reviewed-by:
-
Xida Chen authored
This CL changes AnimationEffect::LocalTime to return a base::Optional<double> instead of double, and so that we can remove a usage of blink::NullValue. Bug: 791086 Change-Id: I9908e70b5f5bb329b7fdf15d8d47e2f1973c6c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393071Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805348}
-
Shrek Shao authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1788138, these tests were enabled on Android. But flakes are seen on Nexus 9: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%209%29/28407 Following the similar pattern of skipping them as in: https://chromium-review.googlesource.com/c/chromium/src/+/1808584 https://chromium-review.googlesource.com/c/chromium/src/+/1628391 TBR=zmo@chromium.org Bug: 609629 Change-Id: Ibbdecd58265839c3bf8d2378a0eeba02f1356bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399824Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#805347}
-
Patrick Noland authored
Current CCToolbar uses a bare ImageButton instead of MenuButton. In the linked bugs, this causes us to fail to connect the button with the AppMenuButtonHelper and leaves the menu un-anchored. Rather than writing special logic to set the AppMenuButtonHelper for the bare image button, it seems cleaner to just use MenuButton on the CCToolbar and have it be safe/correct to use in that scenario (no update badge). Bug:1125048,1125075 Change-Id: I041a95467252d64af9559e40342c424645983e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399315 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805346}
-
Dylan Cutler authored
As dcheng@ pointed out in http://crrev.com/c/2377553 this pattern leads to inefficient machine code and should not be used here. Bug: None Change-Id: I12361f7bc8a6744c6c8ec5dda82bde4ac048dbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392705Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fdb64271aae6..b8b9262d7426 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC adithyas@google.com,mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: adithyas@google.com,mmoskvitin@google.com Change-Id: Ib421fd25652e2274bc6a76ea16a0d01bba6f5a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401302Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805344}
-
Oriol Brufau authored
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568 that inherited properties that apply to text can be set on ::marker and should affect the marker text. Therefore, this patch allows text-decoration-skip-ink, text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-position, -webkit-text-emphasis-style, and text-shadow in ::marker. text-underline-position is not allowed despite being inherited because it doesn't affect underlines specified by ancestor elements. And since text-decoration-line is not allowed, it would be pointless. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-text-decoration-skip-ink.html TEST=external/wpt/css/css-pseudo/marker-text-emphasis.html TEST=external/wpt/css/css-pseudo/marker-text-shadow.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html Some parsing tests fail because unprefixed text-emphasis hasn't been implemented. And some reftests fail in legacy because ::markers with 'content: normal' are not implemented using actual text. Change-Id: I3bd7287f0e8164a7fac0ed84dd4ec0af57a34f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396125 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#805343}
-
Aaron Colwell authored
This change is part of the effort to reduce site URL usage in various methods. SiteInfo contains the site URL and other information that will make it easier to improve security & process decisions going forward. Bug: 1085275 Change-Id: Ifb3ea7c02cf14cc33b23294e50a170188e6cb657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399124 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805342}
-
cfredric authored
Change-Id: Iabb1bdac97627239293f4077631ad0519876da56 Bug: 1126207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398944 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#805341}
-
Fredrik Söderqvist authored
These 'filters' don't have an explicit crop-rect so compute one explicitly by including it in the destination rect. Bug: 109224, 512453 Change-Id: Iba12987099d92c588159e1010abcfd1646382e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391134 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#805340}
-
Toby Huang authored
This new FamilyUserMetricsProvider will filter the Family Experiences team's metrics by categories of interest. The categories represent various combinations of supervised and K-12 EDU user types as primary and secondary accounts. Bug: 1103077 Change-Id: I96ee444b7847e06264ce2afab64dbf588e404a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317739 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805339}
-
Josh Nohle authored
The certificate manager observer for events from the contact manager. Destroy and recreate all private certificates if either 1) the user's contact list has changed since the last upload to the NearbyShare server, or 2) contacts are removed from the allowlist--relevant to selected-contacts visibility mode. This ensures that sharing can only happen with trusted contacts. Fixed: b/166113568, 1121320 Change-Id: I92ad994602003bbeea0bdc752b03965c11f1265e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377895 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805338}
-
Nate Chapin authored
Ensure orientation changes propagate to a grandchild even if the child's controller is not initialized When an orientation change occurs, the ScreenOrientationController of the local frame root propagates the orientation change event to subframes. However, if the frame doesn't have a ScreenOrientationController initialized, it skips that frame. However, it also incorrectly skips any children of that frame, so if a child does not a ScreenOrientationController, but one if its children does, that grandchild will not receive the orientation change event like it should. Do a full traverse of the frame tree, rather than a layer-by-layer one. Bug: 1121482 Test: ScreenOrientationControllerTest.OrientationChangePropagationToGrandchild Change-Id: If9c9e8ef9aa3ad2047aa97778dbfb503d1d827ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399008Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#805337}
-
David Bienvenu authored
Calls SetAppIdForWindow() in OverlayWindowViews::Create, using the appid of the web contents window that opened the Pip Window. This makes the Pip window get grouped with the window the Pip window was opened from on the Windows taskbar. Bug: 1116776 Change-Id: I23bb2cb8770c1778817a09139cb778f2b2e5549e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388274 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#805336}
-
ckitagawa authored
Record the FirstPaintBeforeTabLoad metric to include cases where the page has loaded before the compositor is has even started. Change-Id: I64423a3b153779bf429ac9644d8b9c71acbaed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401279Reviewed-by:
-
Roberto Moura authored
If we translate the tab strip and switch tabs, the tab strip and the toolbar will be repositioned. To prevent that, we take a snapshot of the tab strip and move it instead. Two methods were added to the view revealing vertical pan handler delegate protocol to allow this. One executed before the animation and one after. The method executed before is required because if we add a view (the snapshot) and set its frame (to match the tab strip's) inside an animation block, the frame will be misplaced in the beginning and will only be updated during the animation. - Create a TabStripContainerView class and change the type of the tab strip controller's view from UIView to TabStripContainerView. _ The class TabStripContainerView contains only one method, used to provide a snapshot of the tabStripView (the only subview of tab strip controller's view). Bug: 1094335 Change-Id: I09bca78f4099bd28a943976e8bc888b70cb4b8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339741 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805334}
-
Evan Stade authored
The failure was not caught by the CQ because there's no >=N coverage in the CQ, and the test is disabled for <N. Bug: none Change-Id: I3003ed59630b707314cbc23b882bb57ba3ac8add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398855Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805333}
-
Evan Stade authored
Bug: 1125860 Change-Id: I1aa892bad4b66a8518076244025f6fbafcf9b518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399403Reviewed-by:
-
arthursonzogni authored
The RenderFrameHostImpl::is_mhtml_document_ attribute is reset after same-document navigation, which is a bug found in: https://chromium-review.googlesource.com/c/chromium/src/+/2395777 This adds regression tests. The fix is easy and will come in follow-ups. Bug: 1126391 Change-Id: Ic5d166da4a73cda7e5fe9a04402cb0a813c9bf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401019Reviewed-by:
-
Aaron Colwell authored
Removing GetSoleProcessHostForURL() because all existing usage can be handled by GetSoleProcessHostForSite() and this will avoid recomputing the SiteInfo for the url. There are no user visible changes in behavior in this change. Bug: 1085275 Change-Id: I127d46e7a3f7217921e31eee57f1788b4d32ae63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399311Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805330}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599609504-6aed31ad43427a24d3f18572e204bc1984bf6c08.profdata to chrome-win64-master-1599630228-06e78b920e92149bcb86488690cdbb2bed08546f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9ff4f7e40864b14723f863ac1cd210598f15fbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400318Reviewed-by:
-
Oleh Lamzin authored
Use new method ServiceConnection::FlushForTesting instead of RunUntilIdle. Change-Id: If8b30b4b7a42206af83ae248a109590316e46a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398546Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805328}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81c6d6eeb4cf..1313d1aa7a18 2020-09-09 brianosman@google.com Make enum symbol tables standalone (no parent table) 2020-09-09 reed@google.com use pathbuilder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Id8ffa68648d3d0629b59ba890dea7973654810be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400887Reviewed-by:
-
David Jean authored
Bug: 1115961 Change-Id: I85f9a8b4e0589b3ede00f49df71762acf46e9978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400518 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805326}
-
